| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-19 | |||
| 08:49:59 | gibi | Kevin_Zheng: I'm +2 thanks for the effort | |
| 08:50:28 | gibi | stephenfin: Could you hit https://review.openstack.org/#/c/564092 again? Kevin_Zheng fixed your comments and it looks good to me | |
| 08:50:33 | Kevin_Zheng | gibi, my pleasure, thank you for the review | |
| 08:51:35 | vpc_ | gibi | |
| 08:51:36 | vpc_ | can i ask | |
| 08:51:37 | Kevin_Zheng | gibi, I would like to help on anything if needed | |
| 08:51:53 | gibi | vpc_: sure, go ahead | |
| 08:52:25 | vpc_ | how can i take a snapshot of an instance with 3 volumes attached on hit | |
| 08:53:17 | gibi | Kevin_Zheng: in Stein I would like to put some extra effort finishing the versioned notification transformation as in Rocky I did not make much progress but only couple of notification is missing | |
| 08:53:37 | gibi | Kevin_Zheng: your work is appriciated there | |
| 08:53:44 | Kevin_Zheng | sure | |
| 08:53:48 | Kevin_Zheng | I would love to | |
| 08:53:54 | gibi | Kevin_Zheng: cool, thanks | |
| 08:53:55 | vpc_ | gibi any thoughts? | |
| 08:54:31 | gibi | vpc_: do you need live snapshot or offline? | |
| 08:54:50 | vpc_ | live snapshot of instance | |
| 08:55:16 | vpc_ | i snapshot my instance but it not get all volume attached on it | |
| 08:57:20 | openstackgerrit | zhangyangyang proposed openstack/nova master: Remove os_compute_api:os-config-drive https://review.openstack.org/576435 | |
| 08:57:46 | gibi | vpc_: if you have 3 volumes then I guess you need to create 3 snapshots one for each | |
| 08:58:19 | gibi | vpc_: like calling this https://developer.openstack.org/api-ref/compute/#assisted-volume-snapshots-os-assisted-volume-snapshots 3 times | |
| 08:58:51 | gibi | vpc_: via cinder | |
| 08:59:21 | vpc_ | so i need 4 snapshot? | |
| 09:00:31 | gibi | vpc_: also look at https://docs.openstack.org/cinder/latest/admin/blockstorage-groups.html | |
| 09:01:12 | vpc_ | so this a volume snapshot? | |
| 09:01:22 | vpc_ | how about the instance itself? | |
| 09:01:26 | gibi | https://developer.openstack.org/api-ref/block-storage/v3/index.html#group-snapshots | |
| 09:02:28 | openstackgerrit | jichenjc proposed openstack/nova master: Mention server status in api-ref when rebuild https://review.openstack.org/576438 | |
| 09:02:43 | gibi | vpc_: you meant the root fs of the instance? | |
| 09:02:54 | vpc_ | yes sir | |
| 09:03:02 | vpc_ | like in AWS | |
| 09:03:11 | vpc_ | if you take a image of an instance | |
| 09:03:21 | vpc_ | all of its volume will be snapshot too | |
| 09:05:01 | gibi | vpc_: have you tried https://developer.openstack.org/api-ref/compute/#create-image-createimage-action ? | |
| 09:07:06 | vpc_ | yes i already create a snapshot on instance via horizon | |
| 09:42:45 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832 | |
| 09:42:46 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object https://review.openstack.org/573628 | |
| 09:42:47 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375 | |
| 09:42:48 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | |
| 09:42:49 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Change the anti-affinity Filter to adapt to new policy https://review.openstack.org/571166 | |
| 09:42:50 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | |
| 09:42:51 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | |
| 09:43:34 | openstackgerrit | jichenjc proposed openstack/nova master: Adjust log style and remove ocata support https://review.openstack.org/576462 | |
| 09:54:32 | openstackgerrit | Merged openstack/nova-specs master: Spec: Handling Reshaped Provider Trees https://review.openstack.org/572583 | |
| 10:30:13 | openstackgerrit | Merged openstack/nova master: Only run placement request filters when Placement will be called https://review.openstack.org/569969 | |
| 10:53:01 | openstackgerrit | Merged openstack/nova master: libvirt: remove unused get_ovs_interfaceid() https://review.openstack.org/572699 | |
| 11:21:34 | vpc_ | hi nova guys | |
| 11:39:11 | efried | ō/ | |
| 12:01:14 | openstackgerrit | Merged openstack/nova master: Add policy rule to block image-backed servers with 0 root disk flavor https://review.openstack.org/561284 | |
| 12:22:33 | openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | |
| 12:22:34 | openstackgerrit | Chris Dent proposed openstack/nova master: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | |
| 13:03:35 | mriedem | gibi: i answered your questions here https://review.openstack.org/#/c/556334/ - i don't think i have any (obvious to me) changes to make | |
| 13:18:08 | mriedem | sahid: thanks for your reviews on that live migration series of mine, replied in https://review.openstack.org/#/c/515423/ and https://review.openstack.org/#/c/551370/ - it is a bit hairy, i struggled a bit while writing this for what definitely needs to come over from the destination host to build the guest xml | |
| 13:19:15 | gibi | mriedem: here it is binding:host https://review.openstack.org/#/c/523604/18/nova/network/neutronv2/api.py@1223 but here it is binding:host_id https://review.openstack.org/#/c/556334/15/nova/network/neutronv2/api.py@2422 so I'm confused | |
| 13:21:32 | mriedem | gibi: so when we create the port binding, this is checking the host field in the request body https://review.openstack.org/#/c/414251/66/neutron/plugins/ml2/plugin.py@2044 | |
| 13:21:43 | mriedem | from neutron-lib, the field names are defined as: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/portbindings_extended.py#L58 | |
| 13:22:02 | mriedem | the binding:host_id is the field on the port resource, not the binding resource | |
| 13:22:20 | mriedem | when you set a port binding resource to active, it atomically updates the port's binding:host_id field | |
| 13:22:27 | mriedem | it's confusing that they are different, but that's the way it is | |
| 13:22:52 | mriedem | re: https://review.openstack.org/#/c/523604/18/nova/network/neutronv2/api.py@1223 | |
| 13:22:59 | gibi | Ahh I see now. the difference between the spec and the neutron code did not make this easier :) | |
| 13:23:12 | mriedem | yeah as i said in ^ the spec is outdated | |
| 13:23:16 | gibi | yeah | |
| 13:23:27 | mriedem | and the neutron ml2 plugin and port binding extended api reference doesn't yet have api ref docs | |
| 13:23:33 | mriedem | something i asked mlavalle about | |
| 13:24:28 | mriedem | note that if the binding resource field was 'host_id' rather than 'host' the live migration job would be failing at the top of the series | |
| 13:25:00 | mriedem | hmm, which it is now, /me looks | |
| 13:25:49 | mriedem | haven't seen this before http://logs.openstack.org/37/522537/29/check/nova-live-migration/08534a4/logs/screen-n-cpu.txt.gz?level=TRACE#_Jun_19_01_11_49_573713 | |
| 13:26:37 | mriedem | this might be something new in libvirt 4.0.0 using the queens UCA | |
| 13:26:43 | mriedem | which we weren't using last time i checked these job results | |
| 13:28:38 | gibi | having a tempest test at the top helps, thanks | |
| 13:29:47 | gibi | mriedem: regarding the rollback of multiple port activations. I don't know what can we do so let's keep it as is and try to fix it later when we see the real problem | |
| 13:30:08 | gibi | mriedem: I will try to get back to your neutron-new-port-binding-api series to re-review but it might not be today | |
| 13:30:48 | mriedem | gibi: sure, that's ok, thanks for what you've done so far | |
| 13:37:23 | gibi | mriedem: btw, Kevin_Zheng fixed up https://review.openstack.org/#/c/564092/ and I'm +2 so you can send it in | |
| 13:37:48 | mriedem | ok | |
| 13:40:01 | gibi | mriedem: I tried to reporduce bug 1777540 but I failed at https://bugs.launchpad.net/nova/+bug/1777157/comments/4 | |
| 13:40:03 | openstack | Launchpad bug 1777157 in OpenStack Compute (nova) "cold migration fails for ceph volume instances" [Undecided,New] | |
| 13:40:04 | openstack | bug 1777540 in OpenStack Compute (nova) ""IndexError: list index out of range" in ExceptionPayload.from_exception during resize failure" [Undecided,New] https://launchpad.net/bugs/1777540 | |
| 13:40:40 | gibi | mriedem: I don't know how can I hit code https://github.com/openstack/nova/blob/530c24596a74a6115f2e944176c46e4f3d199811/nova/compute/manager.py#L4079 | |
| 13:40:47 | gibi | mriedem: from the nova API | |
| 13:42:14 | gibi | mriedem: is short how can I trigger a migrate / resize that targets the same host and does not change the flavor of the instance | |
| 13:44:44 | mriedem | gibi: you could specify the host field when cold migrating? | |
| 13:45:00 | mriedem | https://developer.openstack.org/api-ref/compute/#migrate-server-migrate-action | |
| 13:45:29 | gibi | mriedem: I tried, I got {"badRequest": {"code": 400, "message": "Cannot migrate to the host where the server exists."}} | |
| 13:45:46 | mriedem | hmm, because https://github.com/openstack/nova/blob/530c24596a74a6115f2e944176c46e4f3d199811/nova/compute/api.py#L3366 | |
| 13:46:14 | mriedem | which is technically a behavior change since some drivers allow you to migrate to self https://github.com/openstack/nova/blob/530c24596a74a6115f2e944176c46e4f3d199811/nova/compute/manager.py#L4077 | |
| 13:46:21 | mriedem | thinking vmware | |
| 13:46:59 | openstackgerrit | Dan Smith proposed openstack/nova stable/queens: [Stable Only] Add amd-ssbd and amd-no-ssb CPU flags https://review.openstack.org/576270 | |
| 13:46:59 | mriedem | yeah vmware is the only driver that has supports_migrate_to_same_host=True | |
| 13:47:11 | mriedem | since the compute host is just managing a vcenter cluster of esxi hosts | |
| 13:47:50 | gibi | mriedem: it is added in Queens by https://review.openstack.org/#/c/408955/ | |
| 13:48:32 | mriedem | yeah i remember reviewing it :( | |
| 13:48:57 | gibi | mriedem: but the bug report says this issue was visible in queens so I don't get it how | |
| 13:49:10 | mriedem | so they weren't picking a host for the cold migrate, | |
| 13:49:15 | mriedem | maybe they only have 1 compute? | |
| 13:49:23 | gibi | then I get NoValidHost | |
| 13:49:38 | mriedem | or, maybe aggregates are setup in such a way that the same host is picked? | |
| 13:50:09 | mriedem | or you have 2 hosts and the other is full or disabled? | |
| 13:50:26 | gibi | OK, good ideas, let me dig | |
| 13:51:04 | mriedem | gibi: you also have to have allow_resize_to_same_host=True in nova.conf | |