Posted	Nick	Remark
#openstack-nova - 2018-06-12
17:51:11	mriedem	especially if it's not cached
17:51:16	openstackgerrit	Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262
17:51:36	mriedem	basically if you have a scope type set on a policy rule that gets used, and enable_scope=False (the default) then you get spammed with warnings
17:51:40	cdent	mriedem: yeah. you kinda wanna be able to say omg, I know
17:51:50	mriedem	probably needs to be a bug in oslo.policy
18:04:46	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
18:04:47	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269
18:04:48	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
18:10:49	mriedem	bpoulos: you moved https://review.openstack.org/#/c/479949/76..77/nova/compute/manager.py but didn't move the related unit test
18:13:46	mriedem	oh nvm i guess it's here https://review.openstack.org/#/c/561262/26/nova/tests/unit/compute/test_compute_mgr.py
18:17:20	mriedem	bpoulos: ok there is just 1 missing test in https://review.openstack.org/#/c/479949/ - i can add that if you like
18:22:38	bpoulos	mriedem: that would be great, thanks!
18:43:55	openstackgerrit	Simon Dodsley proposed openstack/nova master: Add enhanced KVM storage QoS quotas https://review.openstack.org/558530
18:45:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
18:45:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262
18:45:08	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
18:45:09	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269
18:45:10	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
19:13:23	openstackgerrit	Jay Pipes proposed openstack/nova master: add consumers generation field https://review.openstack.org/557958
19:13:24	openstackgerrit	Jay Pipes proposed openstack/nova master: placement: Allocation.consumer field https://review.openstack.org/565405
19:13:25	openstackgerrit	Jay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict() https://review.openstack.org/565407
19:13:26	openstackgerrit	Jay Pipes proposed openstack/nova master: Add a microversion for consumer generation support https://review.openstack.org/565604
19:13:27	openstackgerrit	Jay Pipes proposed openstack/nova master: Fix nits from change Id609789ef6b4a4c745550cde80dd49cabe03869a https://review.openstack.org/574324
19:13:44	jaypipes	mriedem: ^ rebased and merge-conflict-fixed.
19:16:28	mriedem	jaypipes: https://review.openstack.org/#/c/557958/29..30/nova/db/sqlalchemy/api_models.py
19:24:35	melwitt	mriedem: great, thanks for swapping the runway
19:28:14	openstackgerrit	Jay Pipes proposed openstack/nova master: add consumers generation field https://review.openstack.org/557958
19:28:15	openstackgerrit	Jay Pipes proposed openstack/nova master: placement: Allocation.consumer field https://review.openstack.org/565405
19:28:16	openstackgerrit	Jay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict() https://review.openstack.org/565407
19:28:17	openstackgerrit	Jay Pipes proposed openstack/nova master: Add a microversion for consumer generation support https://review.openstack.org/565604
19:28:18	openstackgerrit	Jay Pipes proposed openstack/nova master: Fix nits from change Id609789ef6b4a4c745550cde80dd49cabe03869a https://review.openstack.org/574324
19:28:20	jaypipes	mriedem: sorry about that. fixed.
19:53:14	openstackgerrit	Artom Lifshitz proposed openstack/nova master: DNM: Depends on intel-nfv-ci-tests to test NUMA LM https://review.openstack.org/574872
20:00:20	openstackgerrit	Merged openstack/nova master: Refactor libvirt get_memory_used_mb() https://review.openstack.org/571030
20:31:59	mriedem	dansmith: i'm assuming you could have cert validation setup on kernel and ramdisk images...?
20:32:12	mriedem	because this libvirt driver change isn't passing the trusted certs through in that case
20:32:19	mriedem	not sure if that was intentional
20:32:22	dansmith	mriedem: um
20:32:37	dansmith	mriedem: if you use that kind of image, each would have its own signature
20:32:40	mriedem	in general, i assume any image we download from glance could be signed and verified
20:32:50	dansmith	aren't we buried deep in the image code enough that we'd verify those like anything else/
20:33:16	mriedem	i think so https://review.openstack.org/#/c/561262/27/nova/virt/libvirt/driver.py@7432
20:33:28	mriedem	this is the trouble part that's missing passing through trusted_certs
20:34:20	dansmith	mriedem: you know I didn't write any of that code right?
20:34:49	mriedem	IT'S YOUR GD CODE NOW SMITH
20:34:59	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Add InstanceNUMATopology to LibvirtLiveMigrateData https://review.openstack.org/566398
20:35:00	openstackgerrit	Artom Lifshitz proposed openstack/nova master: libvirt live migration: fit NUMA topology on dest https://review.openstack.org/567242
20:35:01	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration https://review.openstack.org/566723
20:35:02	openstackgerrit	Artom Lifshitz proposed openstack/nova master: DNM: Depends on intel-nfv-ci-tests to test NUMA LM https://review.openstack.org/574872
20:35:05	mriedem	your prints are all over this
20:35:17	mriedem	it's 1/8 my baby now too
20:35:22	dansmith	I really have lost most of my context on it at this point
20:35:28	dansmith	I just split this off from the main patch for them
20:35:32	mriedem	i know
20:35:38	mriedem	and this change could be split into 2 now too
20:35:43	mriedem	virt changes and then compute manager changes
20:35:45	mriedem	but i'm not going to do that
20:37:05	dansmith	yeah, so I guess you're right, since they don't pass trusted_certs there,
20:37:18	dansmith	but if they did what you suggest (which I'm pretty sure I had suggested already) then they'd auto-verify
20:39:30	mriedem	yeah i moved the low-level calls to libvirt_utils.fetch_image to just use the in-scope instance variable and pass instance.trusted_certs rather than add a new parameter to the various _try_fetch_image* methods
20:39:37	mriedem	that's how i found this bug
20:45:12	mriedem	gdi, i can't really tell how to assert anything that is mocked out from ImageBackendFixture
20:50:52	efried	mriedem: example?
20:51:31	mriedem	don't have the energy
20:51:46	efried	mriedem: You mean from something like
20:51:46	efried	self.mock_create_ephemeral = \
20:51:46	efried	mock.create_autospec(driver.LibvirtDriver._create_ephemeral)
20:51:46	efried	self.useFixture(fixtures.MonkeyPatch(
20:51:46	efried	'nova.virt.libvirt.driver.LibvirtDriver._create_ephemeral',
20:51:46	efried	self.mock_create_ephemeral))
20:51:46	efried	you want to assert that the _create_ephemeral mock was called?
20:52:06	mriedem	more or less yes,
20:52:07	mriedem	was doing:
20:52:10	efried	mriedem: You have to make the fixture save off the actual mock
20:52:13	mriedem	img_backend_fixture = snaz
20:52:16	mriedem	...
20:52:29	mriedem	img_backend_fixture.mocked_thing.assert_called_once_with(...)
20:52:42	mriedem	and tried mocked_thing.return_value
20:53:02	mriedem	i thought the autospeced mock was being saved in those variables
20:53:09	efried	mriedem: So like:
20:53:10	efried	self.mock_create_ephemeral = \
20:53:10	efried	mock.create_autospec(driver.LibvirtDriver._create_ephemeral)
20:53:10	efried	fx = self.useFixture(fixtures.MonkeyPatch(
20:53:10	efried	'nova.virt.libvirt.driver.LibvirtDriver._create_ephemeral',
20:53:10	efried	self.mock_create_ephemeral))
20:53:10	efried	self.mriedem_mock = fx.mock
20:53:36	mriedem	ok, well...
20:53:43	mriedem	i'm past caring really
20:55:04	efried	mriedem: You're right, though, that create_autospec ought to be a mock you can assert on.
20:55:28	mriedem	i just hate the libvirt driver unit tests
20:55:31	mriedem	but that's not news
20:55:40	efried	mriedem: I've got +2s on the bottom nine patches in the neutron port binding series.
20:55:52	mriedem	hot diggity dog
20:56:00	mriedem	how many patches are there? 25?
20:56:12	efried	mriedem: I'm going to punt on the libvirt ones, at least unless someone begs.
20:56:25	efried	looks like 15
20:56:26	mriedem	https://review.openstack.org/#/q/topic:bp/neutron-new-port-binding-api+(status:open+OR+status:merged)
20:56:52	efried	yeah, those all show up in the series
20:57:08	mriedem	thanks for hitting those, even before it was in a runway
20:57:15	efried	yahyoubetcha.

Earlier   Later