Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-12
15:59:11 mriedem also, channel topic needs to be updated for current runways
15:59:19 mriedem dansmith: i think that's fine
15:59:24 stephenfin dansmith: Ah. Before I do something that will make you cry, any reason not to do that in __init__? https://github.com/openstack/nova/blob/master/nova/objects/diagnostics.py#L107
16:00:14 openstackgerrit Merged openstack/nova master: Extract part of PlacementFixture to placement https://review.openstack.org/568359
16:00:21 dansmith stephenfin: in general I'm very much opposed to it, yeah, because if you have half an object (think fields not lazy-loaded yet) and you always do that, you'll blow away things in the DB you would have otherwise left as-is
16:00:52 dansmith stephenfin: so it depends on the type of object.. if it's stored as a blob, then *might* be okay to do that, but it is then confusing for other people when they find examples like you linked
16:01:38 stephenfin dansmith: I figured (else this would be done by default). What's the best practice, in that case?
16:01:45 stephenfin Call 'obj_set_defaults()' every time I need to create a new object or don't use defaults, perhaps?
16:01:49 cdent oh this is fun: AssertionError: u'host3' == u'host3' in http://logs.openstack.org/08/574408/3/gate/nova-tox-functional/39c1a57/testr_results.html.gz
16:01:53 cdent wtf?
16:02:21 dansmith stephenfin: well, defaults were really introduced for something else kinda stupid, and honestly we probably shouldn't have left that in when we moved to oslo, but alas
16:02:46 dansmith stephenfin: if you want to do it in init and you're sure you're always going to be right, just throw a scary comment on it or something
16:02:47 gibi cdent: assertNotEqual :)
16:02:55 cdent yeah, got there
16:02:57 cdent eventually
16:03:06 dansmith stephenfin: or use it whenever you instantiate, or when you need them to be set
16:03:11 gibi cdent: I also saw this test fails infrequently locally
16:03:28 dansmith stephenfin: or, how about you call it in obj_load_attr() ? then, it'll set defaults if you touch something that isn't set
16:03:37 dansmith stephenfin: but still, scary comment I tink
16:04:59 stephenfin dansmith: I can do that. Cheers :)
16:05:02 openstackgerrit Eric Fried proposed openstack/nova master: Provide a direct interface to placement https://review.openstack.org/572576
16:05:11 sahid efried: i hink you made good point for the ut here
16:05:21 sahid https://review.openstack.org/#/c/571030/
16:05:55 openstackgerrit Merged openstack/nova master: placement: Use INNER JOIN for requied traits https://review.openstack.org/573113
16:06:04 mriedem cfriesen: that's a known issue on a bug you've already investigated
16:06:13 mriedem http://status.openstack.org/elastic-recheck/#1763181
16:06:24 efried sahid: Yeah, figured that wasn't enough to hold it up, I would fast-approve a fup to fix that if you're so inclined.
16:08:19 sahid efried: i'm not
16:08:24 efried :)
16:08:33 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add method to get cpu traits https://review.openstack.org/560317
16:09:32 cfriesen mriedem: sorry, you referring to the swap size thing?
16:09:44 mriedem cfriesen: no, the "wtf test failure" thing
16:10:05 mriedem oh oops
16:10:07 mriedem cdent: ....
16:10:10 mriedem sorry, too many c's
16:10:41 mriedem cfriesen: for the ceph swap size thing, i'd ask mnaser
16:10:50 mnaser hi
16:10:50 cfriesen no worries, I thought I had missed some context. :)
16:11:42 openstackgerrit Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
16:11:44 openstackgerrit Brianna Poulos proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262
16:11:44 openstackgerrit Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
16:11:45 openstackgerrit Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269
16:11:46 openstackgerrit Brianna Poulos proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
16:11:49 mnaser cfriesen, mriedem: we don't use swap (swap on ceph sounds rough) but do you have a bit more context or bug #?
16:12:19 mriedem mnaser:
16:12:20 mriedem (10:15:56 AM) cfriesen: is anyone aware of an issue where an RBD-backed swap disk is not restored to the initial size after a resize/revert? We're hitting this on Pike.
16:12:20 mriedem (10:16:47 AM) cfriesen: also, we're seeing a second issue where the guest has to manually re-run "mkswap" after a resize/confirm otherwise it still keeps using the old size of swap
16:12:36 cfriesen mnaser: haven't opened a bug yet, wanted to see if it was a known issue
16:12:54 mriedem mnaser: you use the rbd imagebackend don't you for ephemeral local disks?
16:12:58 mnaser mriedem: yes
16:13:05 mriedem how do you prevent users from attaching swap devices?
16:13:18 mnaser well, they could do it themselves by adding a volume
16:13:32 mriedem right, it's part of the block_device_mapping_v2 request when creating a server
16:13:32 mnaser i thought we're talking about the swap flavor attribute (that's a thing.. right?)
16:13:40 mriedem it's related
16:13:55 mriedem the swap bdm gets it's size from the swap value in the flavor
16:14:31 sahid efried: actually it would have been better to use a constant instead of 0, also since we have changed the method name it would have been better to refer a name with xen
16:14:58 cfriesen in the second case, I'm wondering whether we're copying/expanding the original ceph volume and not re-running mkswap on it, so the guest's on-disk data structures still show the "old" size
16:15:10 efried sahid: I can pull it out of the gate if you like.
16:15:41 mriedem https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1368
16:15:47 mnaser i think resize doesn't touch the underlying devices
16:15:50 mriedem i think you can create swap bdms with their own size not from the flavor
16:15:57 mriedem https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1375
16:16:06 mnaser same reason how resizing will result in a drive larger than the partiton
16:16:28 mriedem but if the flavor doesn't have swap set, then i guess that will always fail
16:16:29 sahid efried: what do you think? there are enough nits to hold the merge?
16:16:45 efried sahid: Would you have put a -1 on it for these issues?
16:17:14 dansmith efried: sahid I just commented on both
16:17:20 dansmith unsurprisingly, I think it's fine as-is
16:17:47 dansmith you're going to reset half the gate queue if you bump it out, FYI
16:18:09 sahid yes probably, for the constant and the test introduced that use nested
16:18:35 sahid but yes if the gate is already running i don't think any problem :)
16:18:53 zcorneli sahid: I can fix these as well within the next patch in the series.
16:18:53 sahid s/think/see
16:19:24 dansmith zcorneli: don't pollute your next patch with cleanups, do a separate patch from it
16:19:28 sahid zcorneli: that could be unrelated, but in a nother patch yes
16:19:32 cfriesen mnaser: isn't swap different since it can be wiped out during the resize and the guest is fine with that?
16:20:01 mnaser cfriesen: i'm assuming the code base doesn't actually touch anything if it's a resize
16:20:08 zcorneli dansmith: Ok, no worries
16:20:16 mnaser cfriesen: libvirt i assume?
16:22:28 cfriesen mnaser: yep
16:23:02 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1764883 https://review.openstack.org/562072
16:23:03 openstack bug 1764883 in OpenStack Compute (nova) "Evacuation fails if the source host returns while the migration is still in progress" [Undecided,In progress] https://launchpad.net/bugs/1764883 - Assigned to Lee Yarwood (lyarwood)
16:23:03 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Ensure pre-migrating instances are destroyed during init_host https://review.openstack.org/562284
16:23:09 mriedem is the libvirt driver the only one (really) that supports swap disks? because that's what the api-ref says:
16:23:10 mriedem "Specifies the guest server disk file system format, such as ext2, ext3, ext4, xfs or swap. This parameter affects only the libvirt virt driver."
16:25:20 mriedem maybe that just means the non-swap values are only used by the libvirt driver
16:25:40 dansmith or that libvirt is the only one that makes filesystems on disks
16:25:46 mnaser ^
16:25:58 dansmith does't mean you don't get a swap disk according to the flavor,
16:26:08 dansmith you just might have some-assembly-required sort of deal
16:26:35 mriedem ok, it
16:26:50 mriedem it's just that "This parameter affects only the libvirt virt driver." is confusing since you have to specify guest_format='swap' to get a swap bdm attached
16:26:59 mriedem along with some other bdm field incantations
16:27:04 mriedem that aren't documented in the api ref
16:32:41 mnaser https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8180-L8186
16:33:21 mnaser https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8235-L8241
16:33:38 mnaser so because it already exists with ceph, it probably doesnt touch it
16:34:12 mnaser (i think..)
16:34:55 tasker hey, good morning. I'm checking up on https://review.openstack.org/#/c/550865/ . is there something else needed before it can be merged? also, is this review a candidate for backport to Pike?

Earlier   Later