Posted	Nick	Remark
#openstack-nova - 2018-06-11
17:38:40	mriedem	my find/replace 1.27 -> 1.28 fu in the actual microversion change might have missed something
17:38:44	mriedem	but tests are happy
18:10:10	openstackgerrit	Dan Smith proposed openstack/nova stable/pike: Change consecutive build failure limit to a weigher https://review.openstack.org/573248
18:12:18	openstackgerrit	Curt Moore proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.openstack.org/574301
18:14:05	openstackgerrit	Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
18:14:06	openstackgerrit	Brianna Poulos proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262
18:14:07	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
18:14:08	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269
18:14:09	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
18:17:49	artom	In situations like this I really wish Python had static typing
18:18:28	artom	... or that OpenStack was written in Java ;)
18:18:29	mriedem	melwitt: reminder, you can release r-2 now https://launchpad.net/nova/+milestone/rocky-2
18:18:40	mriedem	based on https://review.openstack.org/#/c/573495/ it looks like it was june 8
18:30:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: xenapi: drop deprecated vif_driver config option https://review.openstack.org/567877
18:35:31	openstackgerrit	Curt Moore proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.openstack.org/574301
18:49:07	openstackgerrit	Merged openstack/nova stable/queens: Fix interpretation of max_attempts for scheduling alternates https://review.openstack.org/573254
18:55:21	mriedem	dansmith: i have beat your heart down on that patch as requested
18:56:36	dansmith	aye
18:57:28	melwitt	mriedem: what does it mean to release r-2 wrt to launchpad? oh, I see a "create release link"
18:58:15	mriedem	just paperwork
18:58:34	mriedem	but see the storyboard thread in the ML about why people care
18:59:21	melwitt	okay, I just didn't know to/how to do it. my bad
19:01:43	mriedem	artom: re https://review.openstack.org/#/c/572790/ i don't think we need your tempest patch
19:01:47	mriedem	i'm not sure why you created it
19:01:57	mriedem	because did you see that ^ depends on https://review.openstack.org/#/c/573025/ ?
19:02:12	artom	mriedem, we don't? I mean, to actually test the "positive" case where we refuse the swap
19:02:29	mriedem	you mean negative?
19:03:07	artom	mriedem, I genuinely have no idea :/
19:03:17	artom	mriedem, the case where we assertRaises(400)
19:03:18	mriedem	testing error conditions in tempest are called negative tests
19:03:18	artom	That one.
19:03:26	artom	OK, negative then :)
19:05:17	melwitt	mriedem: okay, done. thank you for letting me know about it https://launchpad.net/nova/+milestone/rocky-2
19:05:45	melwitt	I removed the rocky-2 milestone target from https://blueprints.launchpad.net/nova/+spec/preemptible-instances also
19:08:02	mriedem	artom: ok here is your 400 http://logs.openstack.org/09/573809/2/check/nova-multiattach/ebd4e2a/job-output.txt.gz#_2018-06-09_14_49_19_637410
19:08:18	mriedem	PUT http://104.130.136.141/compute/v2.1/servers/57ba4f52-8076-45e2-b6ac-14cf789b6926/os-volume_attachments/8361a693-e7c6-4a9b-8303-c303d5fbdad5
19:08:23	mriedem	Body: {"volumeAttachment": {"volumeId": "d9636fa2-78a3-468a-b56a-9e6e2d6f14f6"}}
19:08:48	artom	mriedem, yep, which is why I posted that patch
19:08:56	artom	mriedem, you don't have to merge it if you don't have to :)
19:09:07	artom	Although the cleanup failure is interesting
19:09:11	mriedem	i'm not QA core so i can't merge it..
19:09:28	artom	Either I'm really thick and doing something wrong, or refusing to swap a volume legit makes it undetachable
19:10:32	mriedem	where is the cleanup code that is waiting for the volume to be available after the swap failure,
19:10:41	mriedem	the code is doing the right thing, it leaves the old volume attached (in-use)
19:11:04	mriedem	the trace in the tempest failure doesn't make sense to me
19:11:14	artom	Same here, I can't understand it
19:11:31	artom	I tried printing the full stacktrace manually, but got just a bunch of test runner stuff
19:11:46	artom	So I can't even pinpoint where it's from - I *think* it's the cleanup phase
19:11:59	mriedem	i'm pretty sure it's the cleanups from attach_volume
19:12:09	mriedem	# On teardown detach the volume and wait for it to be available. This
19:12:09	mriedem	# is so we don't error out when trying to delete the volume during
19:12:09	mriedem	# teardown.
19:12:09	mriedem	self.addCleanup(waiters.wait_for_volume_resource_status,
19:12:09	mriedem	self.volumes_client, volume['id'], 'available')
19:12:09	mriedem	# Ignore 404s on detach in case the server is deleted or the volume
19:12:09	mriedem	# is already detached.
19:12:10	mriedem	self.addCleanup(self._detach_volume, server, volume)
19:12:27	mriedem	so, your test can't use that from the base class
19:12:59	mriedem	oh wait
19:13:03	mriedem	but it should be detaching the volume
19:13:03	mriedem	hmm
19:14:51	mriedem	looks like n-cpu is detaching it here http://logs.openstack.org/09/573809/2/check/nova-multiattach/ebd4e2a/logs/screen-n-cpu.txt.gz#_Jun_09_14_49_16_096647
19:17:13	mriedem	this shows the volume was available right when it failed http://logs.openstack.org/09/573809/2/check/nova-multiattach/ebd4e2a/job-output.txt.gz#_2018-06-09_15_07_12_120196
19:17:26	mriedem	[tempest.common.waiters] volume 8361a693-e7c6-4a9b-8303-c303d5fbdad5 reached available after waiting for 4.377925 seconds
19:18:04	artom	Whoa? But it waits for like a minute and a half?
19:19:04	mriedem	this is the detach request http://logs.openstack.org/09/573809/2/check/nova-multiattach/ebd4e2a/job-output.txt.gz#_2018-06-09_15_07_12_102448
19:19:09	mriedem	2018-06-09 14:49:15,860 5908 INFO [tempest.lib.common.rest_client] Request (TestMultiAttachVolumeSwap:_run_cleanups): 202 DELETE http://104.130.136.141/compute/v2.1/servers/57ba4f52-8076-45e2-b6ac-14cf789b6926/os-volume_attachments/8361a693-e7c6-4a9b-8303-c303d5fbdad5 0.301s
19:19:21	mriedem	2018-06-09 14:49:19,377 5908 INFO [tempest.common.waiters] volume 8361a693-e7c6-4a9b-8303-c303d5fbdad5 reached available after waiting for 4.377925 seconds
19:19:27	mriedem	took 4 seconds to detach it
19:21:28	mriedem	yeah i have no idea where that waiter is coming from
19:21:43	mriedem	besides just the attach_volume cleanup
19:22:25	artom	I'll try to dig into it more
19:22:44	artom	Not now though, don't want to context switch from NUMA LM
19:31:16	openstackgerrit	Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_util https://review.openstack.org/574403
19:31:17	openstackgerrit	Chris Dent proposed openstack/nova master: Do not use nova.test in placement.handlers.test_aggregate https://review.openstack.org/574404
19:31:18	openstackgerrit	Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_requestlog https://review.openstack.org/574405
19:31:19	openstackgerrit	Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_fault_wrap https://review.openstack.org/574406
19:31:20	openstackgerrit	Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_handler https://review.openstack.org/574407
19:31:21	openstackgerrit	Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_microversion https://review.openstack.org/574408
19:31:22	openstackgerrit	Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_deploy https://review.openstack.org/574409
19:33:08	openstackgerrit	Zack Cornelius proposed openstack/nova master: Refactor libvirt get_memory_used_mb() https://review.openstack.org/571030
19:33:09	openstackgerrit	Zack Cornelius proposed openstack/nova master: Implement file backed memory for instances in libvirt https://review.openstack.org/567876
19:41:48	mriedem	dansmith: is dash working for you?
19:42:01	dansmith	mriedem: not at the moment but it was a few minutes ago
19:42:14	dansmith	this happens when they have zuul down and it returns a {}
19:42:16	dansmith	so I assume that's it
19:42:32	mriedem	yeah looks like from infra chatter zuul is down
19:43:10	dansmith	"sweet"
19:45:47	openstackgerrit	Matt Riedemann proposed openstack/nova master: Keep attach_mode as top-level field in _translate_attachment_ref https://review.openstack.org/574413
20:17:33	openstackgerrit	Dan Smith proposed openstack/nova master: Use oslo.messaging per-call monitoring https://review.openstack.org/566696
21:09:10	mriedem	dansmith: did you forget to git add nova/conf/rpc.py?
21:09:16	dansmith	eff
21:09:30	mriedem	heh
21:09:40	openstackgerrit	Dan Smith proposed openstack/nova master: Use oslo.messaging per-call monitoring https://review.openstack.org/566696
21:13:05	mriedem	did you think about creating a new [rpc] group?
21:16:50	openstackgerrit	Julia Kreger proposed openstack/nova master: ironic: bugfix: ensure a host is set for volume connectors https://review.openstack.org/571982
21:27:06	dansmith	mriedem: I can't move rpc_response_timeout, so it didn't seem worth the trouble
21:27:09	dansmith	and potential confusion
21:27:50	openstackgerrit	Eric Fried proposed openstack/nova master: Direct Placement API: ksa Adapter https://review.openstack.org/574470
21:31:05	openstackgerrit	Eric Fried proposed openstack/nova master: Direct Placement API: ksa Adapter https://review.openstack.org/574470

Earlier   Later