Posted	Nick	Remark
#openstack-nova - 2018-06-06
16:42:18	bauzas	mriedem: *facepalms*
16:42:28	bauzas	I searched for the implementation
16:42:42	bauzas	but since they used a fucking wrong gerrit name, I was fcked
16:42:55	mriedem	i think on the dest, the driver just stores what the cluster and data store is, so the source has to find a compatible esxi host in the same cluster and datastore
16:43:10	mriedem	if it can't, then it's a failure
16:43:33	bauzas	note for myself : read the fscking launchpad whiteboard and don't assume people use gerrit correctly
16:44:13	mriedem	johnthetubaguy: you can drop the procedural -2 on this now https://review.openstack.org/#/c/270116/
16:45:16	bauzas	mriedem: yup, I just feel https://review.openstack.org/#/c/270116/10/nova/virt/vmwareapi/driver.py@277 needs to return the object they said
16:45:46	bauzas	but anyway, let's voice on the change
16:50:34	mriedem	bauzas: that's this https://review.openstack.org/#/c/270116/10/nova/virt/vmwareapi/driver.py@304
16:50:42	mriedem	it's the same object
16:51:12	mriedem	conductor calls check_can_live_migrate_destination to get migrate_data, passes it to live_migration, which passes it to pre_live_migration, which passes it bakc
16:51:13	mriedem	*back
16:51:17	mriedem	it's like the live migration hot potato
16:52:47	bauzas	yeah, it's just yet another way of doing the same check
16:53:38	dansmith	mriedem: melwitt: tssurya: assume we're having a cells meeting?
16:53:42	bauzas	if we were using the result of check_can_live_migrate_dest() on the compute by calling the source compute too before we run the migration, that would save us one roundtrip
16:56:18	openstackgerrit	Mathieu Gagné proposed openstack/nova-specs master: Use generic metadata term instead of config drive https://review.openstack.org/572837
16:58:18	tssurya	dansmith: I guess so ?
16:58:54	dansmith	let's do it just to say we did
17:15:41	openstackgerrit	Merged openstack/nova-specs master: Use generic metadata term instead of config drive https://review.openstack.org/572837
17:19:51	mgagne	got 3 nova-specs change merged in 1 day. more in 1 day than 2 whole years? /s =)
17:19:56	dansmith	heh
17:20:00	mriedem	lyarwood: btw, connection_info has access_mode but the volume attachment records in cinder have attach_mode
17:20:04	mriedem	so that's probably where i got it
17:20:20	mriedem	mgagne: you are now at your quota limit for nova specs
17:21:12	mgagne	haha, for the next 2 years, see you at OpenStack Xylophone
17:21:18	dansmith	heh
17:22:21	mriedem	openstack xenophobe coming to a denver conference center near you!
17:22:45	mriedem	lyarwood: so on https://review.openstack.org/#/c/552078/ i'm inclined to leave it attach_mode to mirror what's in the cinder api
17:23:00	mriedem	lyarwood: given that, i'm not sure if there is additional stuff you need for that spec
17:23:23	mriedem	i also realize i'm talking to a dev/null here and hopefully you'll come out of your FFU dungeon for awhile to reply
17:25:11	mgagne	mriedem: I got Queens up with CellsV1 so there is that. I didn't try to boot an instance but services were not complaining. Now working my way up from Mitaka to Queens.
17:25:44	mriedem	nice
17:25:49	mriedem	just cell0?
17:25:53	mriedem	or 1:1 cell mappings?
17:33:11	mgagne	cell0 since it's required and old setup with cells.json
17:35:25	openstackgerrit	Surya Seetharaman proposed openstack/nova-specs master: Handling a down cell https://review.openstack.org/557369
17:37:23	tssurya	mriedem, melwitt, dansmith: ^^
17:38:17	tssurya	jaypipes: whenever you have the time would appreciate your expert opinion on https://review.openstack.org/#/c/560042/
17:38:34	tssurya	thanks in advance
17:41:20	dansmith	jaypipes: yeah I cc'd you on the above a couple weeks ago looking for your comment from a db perspective, so would appreciate a read from you
17:45:17	openstackgerrit	Curt Moore proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.openstack.org/572805
17:46:04	jaypipes	dansmith, tssurya: k, will do a review.
17:55:25	openstackgerrit	Jan Gutter proposed openstack/nova-specs master: Spec to implement vRouter HW offloads https://review.openstack.org/567148
17:59:26	openstackgerrit	Jeremy Freudberg proposed openstack/nova master: DNM Revert "Use ksa session for cinder microversion check" https://review.openstack.org/572853
18:32:51	openstackgerrit	Merged openstack/nova master: Add granular placement policy rules for aggregates https://review.openstack.org/570621
18:56:30	jaypipes	dansmith, tssurya: k, reviewed. sorry for the delay on that.
18:56:48	tssurya	jaypipes: thanks,!
18:58:40	jaypipes	tssurya: np. mriedem's heal_allocations patch is a really good example of doing that batch processing stuff.
18:59:08	tssurya	absolutely! I will use similar logic then :)
18:59:45	jaypipes	tssurya: cool. just remember the key to that is to ensure you pass a sort_key consistently so you get a stable paging system.
19:00:08	mriedem	jaypipes: btw, i've got a +2 on heal_allocatoins now if you want to send it home
19:00:33	tssurya	jaypipes: ack
19:00:41	jaypipes	mriedem: well ahead of you :)
19:00:55	jaypipes	mriedem: it's already off to the sarlacc pits.
19:01:14	jaypipes	ok, now on to jangutter's spec.
19:02:06	jangutter	jaypipes: that's not the sarlacc pits, that's R'lyeh.
19:02:14	jaypipes	hehe
19:03:24	mriedem	just aim a litter higher
19:03:55	mriedem	dansmith: are you following all of this hot star wars action?
19:04:28	jaypipes	mriedem: really? I mean, I'm in Florida and was able to feel dansmith's eyeroll over here.
19:04:39	jaypipes	:)
19:05:13	dansmith	um yeah
19:05:18	jaypipes	hehe
19:05:19	dansmith	not a huge star wars fan
19:24:09	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Spec: Handling Reshaped Provider Trees https://review.openstack.org/572583
19:24:43	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Spec: Handling Reshaped Provider Trees https://review.openstack.org/572583
19:28:07	openstackgerrit	Doug Hellmann proposed openstack/osc-placement master: fix tox python3 overrides https://review.openstack.org/572917
19:28:17	openstackgerrit	Doug Hellmann proposed openstack/os-traits master: fix tox python3 overrides https://review.openstack.org/572921
19:28:20	openstackgerrit	Doug Hellmann proposed openstack/os-vif master: fix tox python3 overrides https://review.openstack.org/572922
19:30:09	mriedem	dansmith: want to flip to +W now https://review.openstack.org/#/c/567682/
19:31:05	dansmith	hell yes I do
19:31:20	mriedem	sayonara fping?!
19:32:11	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Spec: Handling Reshaped Provider Trees https://review.openstack.org/572583
19:32:19	mriedem	oolala
19:35:45	efried	mriedem: working on that requirement now - does it need to be removed from test-requirements?
19:36:43	mriedem	efried: you need to rebase
19:36:50	mriedem	the sphinx thing should go in doc/requirements.txt
19:37:40	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Spec: Handling Reshaped Provider Trees https://review.openstack.org/572583
19:37:59	efried	mriedem: Did the move ^. Rebase on what?
19:38:12	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Spec: Handling Reshaped Provider Trees https://review.openstack.org/572583
19:43:19	mriedem	efried: the PTI change merged yesterday
19:43:32	efried	mriedem: ack. I rebased. Thanks.
19:44:04	efried	mriedem: actually, looks like I got on top of it the first time, by a whisker. Anyway...
19:45:25	mriedem	le whew
19:45:56	mriedem	mdbooth: so did you ever report a nova bug?
19:46:01	mriedem	because i'm ready to push my fix
19:46:16	mriedem	nvm https://bugs.launchpad.net/nova/+bug/1775418
19:46:18	openstack	Launchpad bug 1775418 in OpenStack Compute (nova) "Swap volume of multiattached volume will corrupt data" [Undecided,New]
19:52:24	openstackgerrit	Matt Riedemann proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.openstack.org/572790
19:55:54	openstackgerrit	Merged openstack/nova master: Add granular policy rules for traits in placement https://review.openstack.org/570625
19:57:35	openstackgerrit	Matt Riedemann proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.openstack.org/572790
20:29:04	openstackgerrit	Surya Seetharaman proposed openstack/nova-specs master: Handling a down cell https://review.openstack.org/557369
20:32:16	openstackgerrit	Brianna Poulos proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262
20:32:17	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
20:32:18	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269
20:32:19	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
20:32:20	openstackgerrit	Merged openstack/nova master: Add nova-manage placement heal_allocations CLI https://review.openstack.org/565886
20:44:48	openstackgerrit	Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949

Earlier   Later