| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-04 | |||
| 07:23:51 | openstackgerrit | jichenjc proposed openstack/nova master: Enhance api-guide general info some updates https://review.openstack.org/561773 | |
| 07:27:25 | gibi | good mornin nova | |
| 07:27:40 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505 | |
| 07:33:25 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Only run placement request filters when Placement will be called https://review.openstack.org/569969 | |
| 07:38:50 | bauzas | gibi: good morning | |
| 07:54:43 | pvc | hi | |
| 07:54:47 | pvc | where should i add this | |
| 07:54:56 | pvc | sscheduler_default_filters = ..... ,PciPassthroughFilter | |
| 08:00:01 | gibi | pvc: to the nova.conf on the hosts where your nova-scheduler services are running | |
| 08:00:59 | pvc | im using kolla then i add that on [default] | |
| 08:02:42 | gibi | pvc: add it to the [scheduler] section | |
| 08:03:29 | pvc | self._waiter.wait(msg_id, timeout) File "/var/lib/kolla/venv/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 440, in wait message = self.waiters.get(msg_id, timeout=timeout) File "/var/lib/kolla/venv/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 328, in get 'to message ID %s' % msg_id) | |
| 08:04:04 | gibi | pvc: and please note that scheduler_default_filters are deprecated and renamed to enabled_filters as of https://review.openstack.org/#/c/349959/ | |
| 08:04:28 | pvc | this is my error | |
| 08:04:29 | pvc | - Fault Message Timed out waiting for a reply to message ID ad3febe91f124965a547ffe931d16e7e | |
| 08:05:04 | pvc | NoMatches: No 'nova.scheduler.driver' driver found, looking for 'nova.scheduler.filter_scheduler.FilterScheduler' | |
| 08:06:52 | pvc | this is my conf gibi http://paste.openstack.org/show/722636/ | |
| 08:07:29 | gibi | pvc: what nova version do you use? | |
| 08:07:43 | pvc | im using queens | |
| 08:10:50 | gibi | pvc: instead of scheduler_driver=nova.scheduler.filter_scheduler.FilterScheduler try scheduler_driver=filter_scheduler | |
| 08:11:36 | gibi | pvc: https://github.com/openstack/nova/blob/stable/queens/nova/conf/scheduler.py#L40 | |
| 08:16:14 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Change a validation in creating a server group https://review.openstack.org/546484 | |
| 08:16:20 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Change a validation in creating a server group https://review.openstack.org/546484 | |
| 08:48:53 | pvc | gibi updated http://paste.openstack.org/show/722639/ | |
| 08:52:29 | gibi | pvc: I think you dont need line:5 | |
| 08:52:45 | gibi | pvc: line:4 already makes the pci filter available | |
| 08:53:47 | gibi | pvc: line:7 needs to be in the [scheduler] section | |
| 08:56:09 | pvc | here gibi http://paste.openstack.org/show/722642/ | |
| 08:58:10 | pvc | okay now sir gibi? | |
| 08:59:06 | gibi | pvc: looks good to me now | |
| 08:59:46 | pvc | okay i'll reconfigure again. | |
| 08:59:51 | pvc | i just add it on the flavor | |
| 09:00:55 | pvc | --property pci_passthrough:alias='GTX:2' is that okay gibi | |
| 09:03:31 | gibi | pvc: you are transitioning to an area which I have less experties | |
| 09:04:03 | gibi | pvc: but it looks good | |
| 09:09:22 | pvc | gibi No valid host was found. There are not enough hosts available. | |
| 09:09:38 | pvc | gibi http://paste.openstack.org/show/722644/ | |
| 09:12:31 | gibi | pvc: try to check the scheduler log to see which filter removed your host as potential target for your vm | |
| 09:13:44 | kashyap | cfriesen: Responded on the review | |
| 09:14:58 | pvc | gibi Filter PciPassthroughFilter returned 0 hosts | |
| 09:21:38 | kashyap | mdbooth: Morning | |
| 09:21:52 | kashyap | mdbooth: Was trying to debug this only failure: http://logs.openstack.org/58/567258/4/check/openstack-tox-py35/727a7d4/testr_results.html.gz | |
| 09:22:02 | kashyap | (Context patch: https://review.openstack.org/#/c/567258/) | |
| 09:23:58 | mdbooth | kashyap: Looking | |
| 09:24:19 | kashyap | Thank you | |
| 09:24:41 | kashyap | mdbooth: So, it is blowing up here: nova/tests/unit/virt/test_virt_drivers.py --> test_live_migration() | |
| 09:25:13 | mdbooth | kashyap: Ah, this is syntactic | |
| 09:25:24 | mdbooth | Hopefully an easy one :) | |
| 09:25:33 | kashyap | Oh, really? | |
| 09:26:06 | kashyap | Please enlighten, /me is not feeling his best today | |
| 09:26:08 | mdbooth | kashyap: Those words normally precede a severe humbling | |
| 09:26:14 | mdbooth | So we'll see | |
| 09:26:44 | kashyap | mdbooth: If you want to apply the patch locally, here is a convenient: https://kashyapc.fedorapeople.org/0001-libvirt-Remove-usage-of-migrateToURI-2-APIs.patch | |
| 09:26:47 | gibi | pvc: then something is wrong with your pci setup | |
| 09:27:00 | kashyap | You can `git am` it, if you like. | |
| 09:27:58 | pvc | gibi on what side | |
| 09:28:08 | mdbooth | kashyap: git review -d is fine | |
| 09:28:10 | gibi | pvc: that is a good question :) | |
| 09:28:27 | kashyap | mdbooth: Yep, I find it a tad slower, though. But only a few seconds :-) | |
| 09:28:29 | pvc | i already enabled VT-d and VT-x | |
| 09:33:50 | openstackgerrit | Chen proposed openstack/nova master: Fix a typo https://review.openstack.org/572061 | |
| 09:37:42 | openstackgerrit | tianhui proposed openstack/nova master: Fix bug for hypervisors https://review.openstack.org/572063 | |
| 09:47:33 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505 | |
| 09:50:00 | jangutter | sahid: would you like me to build a lower-level unit test specifically for _set_config_VIFGeneric (re https://review.openstack.org/571461 )? I can do that. | |
| 09:57:56 | mdbooth | kashyap: Found it. | |
| 09:58:03 | mdbooth | kashyap: Ok, that was obtuse :) | |
| 09:58:11 | kashyap | mdbooth: I am still wading through PDB | |
| 09:58:27 | kashyap | Thanks for taking time to debug :-) | |
| 09:58:48 | kashyap | Right now I have debugger here: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7347 | |
| 10:02:21 | mdbooth | kashyap: Commented | |
| 10:02:28 | kashyap | Thanks! | |
| 10:03:02 | mdbooth | kashyap: I eventually resorted to grep :/ | |
| 10:03:18 | mdbooth | Python was hiding that mock extremely well. | |
| 10:03:44 | kashyap | :-) Still reading | |
| 10:03:47 | mdbooth | I couldn't even work it out from the debugger, even though I was almost 100% sure that guest.migrate was being mocked. | |
| 10:04:54 | kashyap | mdbooth: If you couldn't work it out...then I had little hope :P | |
| 10:10:47 | kashyap | mdbooth: So, this part was dodgy: | |
| 10:10:48 | kashyap | 135 self.stub_out('nova.virt.libvirt.guest.Guest.migrate', | |
| 10:10:48 | kashyap | 136 lambda self, destination, migrate_uri, params, flags, | |
| 10:10:51 | kashyap | 137 domain_xml, bandwidth: None) | |
| 10:11:11 | mdbooth | kashyap: Yep. You need to pop the domain_xml argument from that lambda. | |
| 10:11:30 | kashyap | Yep, now that I've removed it | |
| 10:11:47 | kashyap | Huh, "obtuse" was the apt word I was looking for. Thanks | |
| 10:11:59 | kashyap | I'll also see about the 'params' dict comments | |
| 10:12:45 | mdbooth | It was buried in an unrelated file in a function called by the setUp of a Grandparent class. | |
| 10:15:46 | mdbooth | Might do better to convert those few to Mock with an autospec | |
| 10:16:24 | mdbooth | I believe that will behave the same, but will automatically copy the argument signature of the function being mocked | |
| 10:16:55 | kashyap | mdbooth: Probably in separate change? | |
| 10:17:09 | mdbooth | Although tbh it smells that we're looking so deep inside the libvirt driver in that test anyway | |
| 10:17:15 | kashyap | (Prefer to avoid fixing everything in this one change) | |
| 10:17:30 | mdbooth | kashyap: Indeed. It would obviously have to be a preceding change, though. | |
| 10:18:25 | kashyap | mdbooth: Yeah, noted. Thanks, you saved my Monday morning | |
| 10:23:50 | kashyap | mdbooth: You went looking for 'domain_xml' via `grep`? | |
| 10:24:07 | mdbooth | kashyap: Yep :( | |
| 10:24:23 | mdbooth | kashyap: Was looking for mocks including domain_xml | |
| 10:24:40 | kashyap | I see | |
| 10:24:50 | mdbooth | I was pretty sure that migrate() was being mocked and I just couldn't find it. | |
| 10:25:41 | mdbooth | kashyap: Disappointingly brute force. | |
| 10:26:02 | kashyap | Yeah, I was stupefied. Embarassed that I didn't do the `grep` :-) | |
| 10:26:03 | sahid | jangutter: i think you can just add an assertion on the vif_name value | |