| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-29 | |||
| 07:07:31 | gibi | good morning nova | |
| 07:17:26 | openstackgerrit | Vishakha Agarwal proposed openstack/nova master: Re-using the code of os brick cinder https://review.openstack.org/565703 | |
| 07:32:00 | Multiple_ | https://review.openstack.org/#/c/563418/ | |
| 07:32:42 | Multiple_ | Please have a look at the review.. only a minor change of adding a retry decorator | |
| 08:05:33 | openstackgerrit | Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | |
| 08:41:33 | openstackgerrit | jichenjc proposed openstack/nova master: Remove unused function https://review.openstack.org/570865 | |
| 09:04:38 | lyarwood | stephenfin, mdbooth_, bauzas : https://review.openstack.org/#/c/569062/ - would you mind taking a look at this bugfix today if you have time? | |
| 09:04:52 | stephenfin | sure | |
| 09:38:07 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832 | |
| 09:38:08 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375 | |
| 09:52:06 | stephenfin | lyarwood: Did you say something about us planning to rework how volume drivers (or something to do with volumes?) are implemented in nova? | |
| 09:54:09 | stephenfin | lyarwood: In relation to https://review.openstack.org/#/c/482640/ | |
| 09:57:25 | lyarwood | stephenfin: yeah, I wasn't sure if this was going to be an imagebackend or volume driver, we don't want the former and this isn't so it's cool :) | |
| 09:57:42 | stephenfin | Ah, image backends. Gotcha | |
| 10:06:56 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/559032 | |
| 10:32:17 | lyarwood | kashyap: https://review.openstack.org/#/c/569442/ - can you close these backport out given https://review.openstack.org/#/c/570271/ has landed in stable? | |
| 10:32:39 | kashyap | lyarwood: I will; that fated forced thing | |
| 10:33:14 | kashyap | Done. | |
| 10:33:17 | lyarwood | kashyap: thanks | |
| 10:45:32 | openstackgerrit | zhuangzejian proposed openstack/nova master: Fix doc mistakes https://review.openstack.org/570894 | |
| 10:50:21 | stephenfin | bauzas: Can you send this docs patch on its way https://review.openstack.org/#/c/540887/ | |
| 11:05:25 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375 | |
| 11:17:07 | openstackgerrit | sean mooney proposed openstack/os-vif master: add noop plugin https://review.openstack.org/567924 | |
| 11:26:01 | openstackgerrit | Hamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640 | |
| 11:53:18 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | |
| 12:01:39 | openstackgerrit | Chen proposed openstack/nova master: Fix some inconsistencies in doc https://review.openstack.org/570407 | |
| 12:02:17 | openstackgerrit | Chen proposed openstack/nova master: Fix some inconsistencies in doc https://review.openstack.org/570407 | |
| 12:05:28 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1764883 https://review.openstack.org/562072 | |
| 12:05:29 | openstack | bug 1764883 in OpenStack Compute (nova) "Evacuation fails if the source host returns while the migration is still in progress" [Undecided,In progress] https://launchpad.net/bugs/1764883 - Assigned to Lee Yarwood (lyarwood) | |
| 12:05:30 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Ignore active evacuations during _init_instance https://review.openstack.org/562284 | |
| 12:38:58 | openstackgerrit | Merged openstack/nova stable/pike: Add ssbd and virt-ssbd flags to cpu_model_extra_flags whitelist https://review.openstack.org/570513 | |
| 12:39:04 | openstackgerrit | Merged openstack/nova stable/queens: Don't reschedule on RequestedVRamTooHigh errors https://review.openstack.org/568642 | |
| 12:46:44 | efried | ō/ | |
| 12:47:37 | gibi | efried: o/ | |
| 12:48:02 | gibi | efried: thankd for the comments on the bandwidth patch series, I'm going through those right now | |
| 12:48:17 | efried | cool | |
| 12:51:46 | openstackgerrit | Merged openstack/nova stable/queens: Add random sleep between retry calls to placement https://review.openstack.org/568218 | |
| 12:51:52 | openstackgerrit | Merged openstack/nova stable/queens: xenapi: handle InstanceNotFound in detach_interface() https://review.openstack.org/564468 | |
| 12:51:58 | openstackgerrit | Merged openstack/nova stable/queens: Improve performance when list instances with IP filter https://review.openstack.org/563972 | |
| 12:52:04 | openstackgerrit | Merged openstack/nova stable/queens: Add nova-status check for ironic flavor migration https://review.openstack.org/563250 | |
| 12:52:10 | openstackgerrit | Merged openstack/nova stable/queens: Log a warning and add nova-status check for old API service versions https://review.openstack.org/563251 | |
| 13:09:15 | efried | mriedem: What was [1] supposed to be here: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130768.html ? Maybe jaypipes' https://review.openstack.org/#/c/553597/ ? | |
| 13:25:38 | mriedem | known issue? | |
| 13:25:39 | mriedem | chmod: cannot access '/home/zuul/workspace/logs/reproduce.sh': No such file or directory | |
| 13:26:42 | sahid | mriedem: about the vftrusted feature, i think i have addressed all you comments | |
| 13:26:50 | sahid | did i missed something you want me to add? | |
| 13:35:39 | mriedem | sahid: i just need to go through it again | |
| 13:38:05 | sahid | mriedem: ok ok pefect so, i will wait for your feedback | |
| 13:38:20 | efried | mriedem: What was [1] supposed to be here: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130768.html ? Maybe jaypipes' https://review.openstack.org/#/c/553597/ ? | |
| 13:40:11 | sahid | efried, mriedem if I can ask.. I saw you on https://review.openstack.org/#/c/510897/ ...that patch just need a final ACK so the feature will be completed | |
| 13:41:15 | efried | sahid: That one is pretty far out of my wheelhouse, better to let mriedem be the +A (or get stephenfin to look again). | |
| 13:41:57 | mriedem | i'm currently trying to sort out the broken gate | |
| 13:43:00 | efried | priorities | |
| 13:43:56 | sahid | yep, that patch can continue to wait | |
| 13:55:13 | Kevin_Zheng | Hi, I have a silly question, I know the answer but I have to get an “official reply” from the community | |
| 13:56:59 | mriedem | efried: should have been https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#aggregates-in-placement for [1] | |
| 13:57:27 | efried | ack | |
| 13:58:34 | Kevin_Zheng | Our product provided a function -> output the list api reply as chart(like excel), somehow instances’ name with particular string could trigger functions like calculators etc, could nova do something about it? | |
| 13:59:48 | mriedem | Kevin_Zheng: no | |
| 14:00:30 | Kevin_Zheng | Why? | |
| 14:00:31 | mriedem | i don't think we'll add a blacklist to server names because people also put them into csv files | |
| 14:00:54 | openstackgerrit | Jay Pipes proposed openstack/nova master: mirror nova host aggregate members to placement https://review.openstack.org/553597 | |
| 14:03:31 | Kevin_Zheng | It will be impossible to cover all the special strings because there could be so many for different file formats? | |
| 14:04:07 | mriedem | Kevin_Zheng: for starters, "we need a change upstream to fix a problem in our downstream fork of the API" isn't justification for anything going upstream | |
| 14:04:41 | fishbone__ | hello all, I receive an error in the instance log when loading windows instances: pywintypes.com_error: (-2147352567, 'Exception occurred.', (0, 'Session', 'Access is denied. ', None, 0, -2147024891), None) any probable causes? | |
| 14:05:02 | efried | Kevin_Zheng: You could use a restrictive instance name template... | |
| 14:05:02 | mriedem | also, i thought openstackclient already handled converting output to csv format | |
| 14:05:35 | Kevin_Zheng | really? I don’t know that, I will check that | |
| 14:05:43 | mriedem | efried: that's not the display_name https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template | |
| 14:06:46 | mriedem | Kevin_Zheng: how was this implemented? the client gives a csv accept header in the request and gets csv rather than json in the response? | |
| 14:07:33 | Kevin_Zheng | mriedem: No, I think it is a function that can output the results to a file | |
| 14:07:47 | Kevin_Zheng | Like a button | |
| 14:08:40 | mriedem | umm | |
| 14:09:26 | Kevin_Zheng | They just ask if it is possible to add some rules for instance names | |
| 14:09:27 | mriedem | that doesn't make sense to me | |
| 14:11:14 | Kevin_Zheng | Yeah, thinking again, even if we check on the name, something else could also trigger the function, like description | |
| 14:11:26 | Kevin_Zheng | We will never check on those | |
| 14:11:34 | mriedem | openstackclient has a --format csv option, not sure why your users wouldn't just use that, rather than change the api | |
| 14:11:57 | mriedem | and if you did change the api to return a different response format, it should have been via an accept header | |
| 14:12:07 | mriedem | as far as i understand rest api / http rules | |
| 14:13:03 | Kevin_Zheng | I have to check the details tomorrow about how it is actually implemented | |
| 14:17:07 | Kevin_Zheng | mriedem_away: another thing I need your help, I want to discuss with you before updating the abort migration in queue patch, how should I deal with migrations with status in “preparing”? My idea was to wait it change to “running” or “error” as we can already deal with “running” migrations and could could probably ignore “error” migrations. So I added that loop. What do you suggest? | |
| 14:43:41 | bhagyashris | efried: Hi, Want to discuss regarding functional test case part for the patch https://review.openstack.org/#/c/560459/ . What I did was created new FakeLibvirtDriver in nova/virt/fake.py implement the updat_provider_tree() method same as in nova/virt/libvirt/driver.py and given that compute_driver = 'fake.FakeLibvirtDriver' in functional test case | |
| 14:44:40 | efried | bhagyashris: Okay, instead of duplicating the code, FakeLibvirtDriver should be a subclass of the real libvirt driver. | |
| 14:45:03 | efried | bhagyashris: otherwise, yes, that's the right approach. Were you able to get the test working with that setup? | |
| 14:48:06 | bhagyashris | efried: yes. and I have also tried on approach same as you suggested what i have did created the libvirt driver object in my FakeLibvirtDriver class and try to call the update_provider_tree() method using the libvirt object but i am getting error as File "nova/virt/fake.py", line 754, in __init__ super(FakeLibvirtDriver, self).__init__(virtapi, read_only) File "nova/virt/libvirt/driver.py | |
| 14:49:46 | bhagyashris | File "nova/virt/fake.py", line 754, in __init__ | |
| 14:49:48 | efried | bhagyashris: It sounds like you're trying to instantiate the driver as a separate instance attribute within your fake driver class. What you should do instead is have your fake driver class be a *subclass* of the real virt driver class. | |
| 14:50:41 | efried | class FakeLibvirtDriver(LibvirtDriver): | |
| 14:51:35 | efried | Then you don't have to override update_provider_tree - which you want to avoid anyway, since then changes to the original method won't automatically be reflected in your test. | |
| 14:52:47 | efried | bhagyashris: Take a look at nova.tests.unit.virt.libvirt.test_driver.HostStateTestCase.FakeConnection | |
| 15:06:52 | bhagyashris | efried: But anyway In that case as well i will need to implement the update_provider_tree() method in my FakeLibvirtDriver right? | |
| 15:07:34 | efried | bhagyashris: No. That's the whole point. You want to use the implementation from the superclass. | |
| 15:12:23 | bhagyashris | efried: ok. just inherit the LibvirtDriver class in my FakeLibvirtDriver and give this FakeLibvirtDriver as copute_driver in test case | |
| 15:12:37 | efried | bhagyashris: Correct. | |
| 15:13:07 | efried | bhagyashris: You may have to override certain other methods with stubs to get the "deploy" to work. | |
| 15:15:21 | bhagyashris | efried: ok thank you :) | |
| 15:15:28 | efried | bhagyashris: Good luck :) | |
| 15:16:05 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840 | |
| 15:16:06 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267 | |