| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-10 | |||
| 17:57:39 | openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | |
| 17:57:47 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Move create_tap_dev to the new utility module. https://review.openstack.org/557835 | |
| 17:57:48 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module. https://review.openstack.org/558487 | |
| 17:57:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add test_set_device_mtu_default back in https://review.openstack.org/567659 | |
| 17:58:50 | efried | mriedem: +2 all the way up. Don't know if you still feel good about approving the bottom one... | |
| 17:58:56 | mriedem | i feel great | |
| 17:59:23 | mriedem | you could also just fast approve https://review.openstack.org/#/c/567659/ | |
| 17:59:27 | mriedem | it's just adding a unit test back in | |
| 18:00:09 | efried | mriedem: done. | |
| 18:13:35 | clutchbeyers | This is a post-newton question: Does anyone know if we set availability_zone in spec_obj on vm provision if the user does not select an availability_zone? | |
| 18:14:23 | clutchbeyers | set in the db after launch* | |
| 18:28:45 | mriedem | clutchbeyers: i know that starting in pike we set the instance.availability_zone based on the compute host that was selected by the scheduler https://review.openstack.org/#/c/446053/ - not sure if that extends to the request spec | |
| 18:28:54 | mriedem | the request spec is really about what the user requested | |
| 18:29:08 | mriedem | so i don't think setting reqspec.az if the user didn't request one would be correct there | |
| 18:31:15 | melwitt | before that change, instance.availability_zone used to get set to the "default availability zone" if one wasn't requested at boot time | |
| 18:36:43 | mriedem | melwitt: i know, see https://bugs.launchpad.net/nova/+bug/1768876 | |
| 18:36:43 | openstack | Launchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged] | |
| 18:36:46 | efried | mriedem, melwitt: Do y'all have a problem if I fast-approve takashin's mox removal patches? They're test-only; if they pass zuul they clearly work; and I'd like to save other reviewers the pain of combing over these (they're pretty tedious). | |
| 18:37:35 | melwitt | efried: passing zuul is the easy part -- reviewing to ensure test coverage is not lost isn't. so I've not thought of them as easy, one person reviews | |
| 18:37:47 | melwitt | but that's just MHO | |
| 18:38:07 | efried | melwitt: roger that. YHO is what I was asking for. Will leave them for other cores to scrutinize. | |
| 18:39:00 | melwitt | mriedem: guh, another regression | |
| 18:40:18 | openstackgerrit | Merged openstack/nova master: Add CellMapping.get_by_project_id() query method https://review.openstack.org/509002 | |
| 18:47:02 | openstackgerrit | Dan Smith proposed openstack/nova master: Change the field type of InstanceMapping.instance_uuid https://review.openstack.org/567669 | |
| 18:51:42 | arvindn05 | mriedem: good call on checking for scheduling volume backed instances | |
| 18:52:06 | clutchbeyers | thanks for that explanation. we have a use-case where whatever az the scheduler chooses, we do not want a resize to migrate across az's. Sounds like the team has made the decision to keep that logic, and I support that. We can fork our own logic for that | |
| 18:52:33 | arvindn05 | for volume back instances the volume meta data is provided as image meta data. see https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1060 | |
| 18:53:08 | mriedem | clutchbeyers: if you look at my comments in https://bugs.launchpad.net/nova/+bug/1768876 - starting in pike you can't migrate across az's | |
| 18:53:08 | openstack | Launchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged] | |
| 18:53:15 | mriedem | which is actually a regression | |
| 18:53:16 | jmccarthy | mriedem: You about ? Trying to get 'test_cleanup_resize_not_same_host' to pass locally with tox, I don't really know this area - any hints how to resolve this conflict ? https://paste.fedoraproject.org/paste/ntZxhXGlWmzNiL--RZU~Ww | |
| 18:53:30 | mriedem | jmccarthy: see my backports? | |
| 18:53:40 | mriedem | https://review.openstack.org/#/q/Ib10081150e125961cba19cfa821bddfac4614408 | |
| 18:54:23 | jmccarthy | mriedem: Oh ! Ok cool lemme check that out | |
| 18:54:59 | mriedem | arvindn05: i could be wrong but i don't think that actually gets stored in the RequestSpec.image field | |
| 18:55:38 | jmccarthy | mreidem: Perfect - Thanks again ! Quite what to do there was giving me a headache lol | |
| 18:55:59 | arvindn05 | from what i saw...the volume meta data is treated exactly the same as image meta data,...the requestSpec.image has volume meta data in the case | |
| 18:56:36 | mriedem | arvindn05: i'm not so sure https://github.com/openstack/nova/commit/0a7427dc58eeb271646a962604106e0e84b870b6 | |
| 18:56:36 | arvindn05 | the only difference is that for volume backed instance the "id" field in the RequestSpec.image is not present... | |
| 18:56:40 | mriedem | but i don't know what you're seeing | |
| 18:56:54 | mriedem | oh that might be true | |
| 18:57:40 | arvindn05 | yup...the code there looks at the id field as well to determine...so looks like its consistent | |
| 18:57:45 | mriedem | oh i guess we use boot_meta here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L882 | |
| 18:58:28 | mriedem | https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L132 | |
| 18:58:30 | arvindn05 | now the only question is should we honor that metadata for volume boot? | |
| 18:59:42 | mriedem | idk | |
| 19:00:00 | arvindn05 | https://blueprints.launchpad.net/python-cinderclient/+spec/support-modify-volume-image-metadata an old blueprint discussion | |
| 19:00:10 | mriedem | i'm not sure how much precedent we have for honoring image meta during scheduling that comes from a volume | |
| 19:00:11 | arvindn05 | 20:32:54 <DuncanT> fmaldonado_: volume glance meta is for all of the same things glance properties are for | |
| 19:01:58 | arvindn05 | it seems that within the code, the volume meta data is treated exactly the same as image meta data...so i am leaning towards leaving it this way and adding few more unit and functional test cases | |
| 19:04:07 | clutchbeyers | mriedem: thats great to hear on the cross-az migration, we handle that in newton by use of the nova filters and extra specs that dont allow things to cross. But our specific use case is in the resize. If one spawns an instance without giving it an az, a resize will cold migrate (shutdown) and treat it like a new vm spin up and select another az with new flavors. Are you saying this behavior also does not allow for cross- | |
| 19:05:22 | mriedem | clutchbeyers: the change in pike would apply to any move operation through the scheduler, | |
| 19:05:32 | mriedem | so resize, live migrate, unshelve and evacuate | |
| 19:09:04 | clutchbeyers | mriedem: thank you for the clarification! | |
| 19:10:40 | mriedem | clutchbeyers: note that we could consider this a regression in pike. it's in your favor i guess, but depending on how we handle this bug we might change it back. | |
| 19:11:02 | mriedem | dansmith: maybe something we need to put in your forum session on cells... | |
| 19:13:08 | dansmith | mriedem: I'm not sure what you're saying is a regression | |
| 19:13:11 | dansmith | or what it has to do with cells | |
| 19:13:31 | dansmith | that you can't migrate across az boundaries/ | |
| 19:13:38 | mriedem | dansmith: https://bugs.launchpad.net/nova/+bug/1768876 | |
| 19:13:38 | openstack | Launchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged] | |
| 19:14:02 | clutchbeyers | mriedem: it my honest opinion, if a tenant does not specify an az on vm provision, then they arent too concnered about controlling their fault domain. So when they do decide to resize and it moves to another az, they theoretically shouldn't care | |
| 19:14:33 | clutchbeyers | But for those that specifically call out an az, they have a fault domain architecture in mind and wouldnt want to disrupt that | |
| 19:14:56 | dansmith | mriedem: okay, I think we talked about that in dublin, about potentially just forcing instance.az to whatever we chose if you didn't ask for one, keeping you in whatever az you happened to land in | |
| 19:15:26 | melwitt | I think that's what the original behavior was -- only allows migrating across AZ if none was selected deliberately | |
| 19:15:47 | dansmith | melwitt: you mean only keeps you in your az if you asked for one initially | |
| 19:15:53 | clutchbeyers | there is some assumptions being made there with how the tenant is designing their app/fault tolerance | |
| 19:16:07 | melwitt | dansmith: yeah | |
| 19:16:22 | dansmith | clutchbeyers: I totally agree that if you asked for one, you shouldn't be migrated out of it | |
| 19:17:18 | dansmith | I get that mriedem's metadata thing is a regression, | |
| 19:17:28 | dansmith | I'm missing what, if any, scheduler behavior regressed | |
| 19:17:29 | mriedem | dansmith: i don't remember talking about this specifically in dublin, | |
| 19:17:41 | mriedem | the only AZ thing I remember talking about wrt cells was the cross_az_attach volume upcall thing | |
| 19:18:06 | mriedem | dansmith: what i'm pointing out in this comment https://bugs.launchpad.net/nova/+bug/1768876/comments/4 | |
| 19:18:06 | openstack | Launchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged] | |
| 19:18:12 | dansmith | I'm pretty sure it was dublin, with bauzas and I | |
| 19:18:12 | mriedem | i need to test it still to confirm it is a regression | |
| 19:19:47 | dansmith | okay, I'm confused because I thought the second part of your comment (that an instance would be confined to whatever AZ it landed in) wasn't yet the case, but we considered doing that | |
| 19:20:01 | dansmith | in the dublin discussion where we were talking about how to handle instance.az when az wasn't requested | |
| 19:21:19 | mriedem | maybe we were talking about that in the context of volume cross_az_attach? | |
| 19:21:53 | dansmith | I dunno, I thought not, but I don't see it on the etherpad | |
| 19:22:08 | dansmith | I _know_ I've had a convo with bauzas about this in the not too distant past | |
| 19:22:22 | dansmith | maybe the az discussion there is merging together in my head | |
| 19:22:45 | mriedem | maybe related to the ops list thread on not allowing deleting/renaming an AZ that has instances in it? | |
| 19:23:09 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: always create consumer records https://review.openstack.org/567678 | |
| 19:23:17 | dansmith | this was face-to-face or face-to-screen | |
| 19:23:19 | dansmith | with bazuas | |
| 19:24:10 | dansmith | mriedem: what change in pike do you think is making us keep things in the same az? | |
| 19:24:30 | mriedem | https://review.openstack.org/#/c/446053/ | |
| 19:25:04 | dansmith | ah, yeah | |
| 19:25:13 | mriedem | if the instance.availability_zone was set based on CONF.default_availability_zone when the user didn't request one specifically, before that change, and that defaults to None, i believe that means the instance could freely move between AZs | |
| 19:25:33 | mriedem | anyway, i can write a simple functional test to try this once i get this 'remove fping' patch up | |
| 19:25:49 | dansmith | yeah, so, this is the change I was talking about, | |
| 19:25:59 | dansmith | which is probably when I was talking to bauzas about it (before writing this) | |
| 19:26:06 | dansmith | I just forgot that we had made it | |
| 19:26:42 | mriedem | heh, time flies :) | |
| 19:26:48 | dansmith | apparently | |
| 19:26:50 | mriedem | i don't think i was aware of this change either until yesterday | |
| 19:26:59 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove support for /os-fping REST API https://review.openstack.org/567682 | |
| 19:26:59 | melwitt | I just checked and the default is 'nova', not None. not sure if that makes a difference | |