Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-05-10
13:49:52 tssurya jaypipes: we use this as a marker for nova-manage map_instances
13:51:01 jaypipes stephenfin: k, thx for the commit ID. I'll look it up and see if I can understand the problem better.
13:51:03 stephenfin Oh, yeah, now I remember
13:51:33 stephenfin So we store a special string for InstanceMappingList.project_id
13:51:59 stephenfin and then for the UUID value, we store the list of the last InstanceMappingList that we processed
13:52:32 stephenfin but munged, so it won't conflict with that InstanceMappingList's UUID
13:52:36 dansmith I haven't read the thread,
13:52:53 dansmith but we can't change this unless you provide a migration path for people that might be in the middle of the process when they apply the patch
13:53:39 dansmith and if this is just because of the damn o.vo UUIDField warning (which I didn't want in the first place) I think it's not worth a change
13:55:05 mrf Hi,
13:55:27 mrf After a Resize i got Instance at Error with the next drop in nova-compute: InstanceNotFound: Instance 299fd82f-f081-4c81-8226-70d208f10a8f could not be found. any ideas?
14:05:10 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Explain how the marker works for instance-cell mapping https://review.openstack.org/567597
14:05:12 stephenfin gibi, dansmith: ^
14:08:28 mriedem bauzas: fyi in case you haven't seen this yet https://openstack-in-production.blogspot.com/2018/05/introducing-gpus-to-cern-cloud.html
14:08:58 bauzas mriedem: just discussed on twitter with tim
14:09:20 bauzas but thanks
14:13:10 openstackgerrit Eric Berglund proposed openstack/nova stable/queens: Stringify instance UUID https://review.openstack.org/567599
14:13:35 tetsuro jaypipes, efried: Could you have a look at https://review.openstack.org/#/c/567113/5, if you have time?
14:42:12 mriedem dansmith: question in https://review.openstack.org/#/c/509003/ about how the cell_mappings kwarg gets through to the DB API query method, i.e. why you need to do this https://review.openstack.org/#/c/509003/12/nova/tests/unit/api/openstack/fakes.py
14:42:18 mriedem otherwise the rest are nits which can be deal with in a follow up
14:42:22 mriedem *dealt
14:43:09 dansmith ack, will look in a bit
14:46:00 sean-k-mooney i have an interesting (annoying) issue with my teams openstack devcluster ... what does the value of the deleted column in the nova.instnaces table mean?
14:46:22 dansmith sean-k-mooney: deleted=id means the instance is deleted
14:46:28 dansmith deleted=0 means it's not
14:47:12 sean-k-mooney dansmith: thanks. i have an instance that shows up in opentack server list but cant be found when i do a openstack server delete or nova force-delete
14:47:36 sean-k-mooney dansmith: that was exactly what i was looking for ill see if that "deletes it"
14:47:41 dansmith maybe it's missing a mapping?
14:48:30 sean-k-mooney dansmith: or when my database crashed because the binary logs filled up the disk it currupted the entries...
14:48:36 dansmith or that :)
14:49:24 sean-k-mooney dansmith: it was mapped in the nova_api db. i tried deleteing it from there to see if it would be enough but it looks like i have to remove it from the cell0 db too or at least mark it as deleted
14:49:53 dansmith yeah, list will still find it without a mapping unless it's actually deleted
14:50:35 sean-k-mooney dansmith: its currently messsing with my nodepool deployment because it keeps trying to delete it and cant hence my db hacking
14:50:50 dansmith ack
14:51:02 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Migrate tempest-dsvm-multinode-live-migration job in-tree https://review.openstack.org/567612
14:55:31 jroll mriedem: fyi, https://review.openstack.org/567577
14:55:57 jroll thanks for pointing me at that bug, is not good
14:56:44 openstackgerrit Eric Berglund proposed openstack/nova stable/queens: Stringify instance UUID https://review.openstack.org/567599
14:57:11 mriedem jroll: ok, are there also going to need to be nova changes?
14:57:57 jroll mriedem: not in our driver, I'm not sure what you all do / need to do to shut down the connection on instance destroy
14:59:25 mriedem jroll: that reply is confusing
14:59:43 jroll lemme try again
14:59:47 tssurya mriedem: thanks for triaging https://bugs.launchpad.net/nova/+bug/1768876 , shall I go ahead with the migration tool then for populating the ones that are missing?
14:59:48 mriedem if there is nothing to do in the ironic driver, then i don't think there is anything to change in nova
14:59:59 mriedem tssurya: i was just going to ask you about that,
15:00:00 openstack Launchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged]
15:00:13 mriedem tssurya: it will require some thought, because i'm not sure what got put into instance.availability_zone before that change in pike,
15:00:32 mriedem i.e. is it None if the user doesn't specify an AZ when creating the instance? or does it default to 'nova'?
15:00:36 tssurya wasn't it None ?
15:00:54 jroll mriedem: the driver gives back some console URL, right? and nova's proxy thing connects to it? does that connection need to be closed or do we just let it die? if it needs to be closed, does nova do that already? (I guess this is outside the scope of the bug, but could be an improvement)
15:00:55 mriedem i'm not sure, but it will matter if we add an online data migration routine since we'll need to know which instances need to be migrated
15:01:18 tssurya mriedem: yea, I will try to dig more into the tree then
15:01:29 mriedem jroll: not sure, probably a good question for melwitt
15:02:02 jroll mriedem: ok, I'm sure it isn't urgent anyway. can mark that closes-bug instead if you like, but gonna wait for some reviews/CI results first
15:03:30 mriedem i'll mark invalid for nova,
15:03:35 mriedem and just point to the SB entry
15:04:22 jroll wfm
15:04:59 mriedem unrelated, but looks like issues in storyboard aren't found via google search?
15:05:13 jroll no clue
15:05:15 jroll that would be sad
15:05:21 mriedem like, trump level sad?
15:05:37 mriedem hash tag sad?!
15:06:09 jroll SAD!
15:09:27 artom MALA!
15:09:39 artom Make Launchpad Great Again!
15:09:43 melwitt jroll: the driver hands back a URL essentially that points at the console proxy. then the end user visits it and that initiates the connection to the proxy. AFAIK it's closed when the end user closes the console. I'm not aware that nova ever does anything to close it
15:10:02 melwitt I like launchpad fine, never understood to push for storyboard
15:10:18 jroll melwitt: ok cool, thanks
15:10:20 artom NIH?
15:10:24 mriedem melwitt: shhh
15:11:04 mriedem short answer on SB indexing in google is no
15:11:05 mriedem not yet
15:11:16 mriedem see -dev for details
15:13:35 melwitt mriedem: I didn't think we'd need a blueprint for this https://blueprints.launchpad.net/nova/+spec/add-documentation-rules-api-ref ?
15:15:13 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Migrate tempest-dsvm-multinode-live-migration job in-tree https://review.openstack.org/567617
15:15:14 mriedem melwitt: ha no
15:18:18 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Migrate tempest-dsvm-multinode-live-migration job in-tree https://review.openstack.org/567619
15:19:57 mriedem melwitt: just leave a comment that you don't need a blueprint to write contributor docs and mark the bp obsolete since that's as close to invalid as we get in launchpad
15:20:18 melwitt mriedem: k thanks
15:20:30 mriedem i also don't really want to review said contributor doc additions, but...
15:20:57 mriedem simply linking from the contributor docs to the api-ref wiki would be good enough IMO
15:24:11 melwitt okay, I'll suggest that on the bp
15:39:16 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: libvirt: check image type before removing snapshots in _cleanup_resize https://review.openstack.org/567623
15:39:51 mdbooth mriedem: Thanks for the review, btw. Working on addressing your comments, without embarking on another big cleanup.
15:40:34 mriedem mdbooth: np; i thought i had figured out why the compute manager test in the 3rd or 4th patch in the series was failing (due to the fake driver wanting legacy bdms) but that didn't fix it locally for me
15:41:26 mdbooth Yeah, I got to the bottom of that. It's an annoying testing artifact.
15:43:33 mdbooth The initializer pre-populates the dict subclass with a bunch of fields. This isn't required in the new class as it has only proxy fields, and can't be done for all proxied fields because is_volume is a property and isn't writable.
15:43:37 dansmith mriedem: that stub_instance thing is because of a failure, not because I was being overly thorough :)
15:43:49 mdbooth Anyway, I'll come up with something. Thanks again.
15:43:50 dansmith mriedem: I'll remove and run tests to highlight which one it was
15:44:30 dansmith I think it's probably fping or something, which mocks something with the stub_instance that would have shadowed the inner call we make with cell_mappings
15:44:31 mriedem dansmith: ok, as noted i didn't run all tests, just a sample, but anyway
15:44:38 dansmith mriedem: yup
15:45:12 mriedem dansmith: do you plan on doing a cleanup followup? otherwise i'm happy to.
15:45:15 mdbooth I suspect I'm going to end up with some test-only code in block_device.py, though, because the tests need some way to serialise a whole object for comparison, whereas runtime code just accesses fields by name.
15:45:16 mriedem since they're my nits
15:45:37 dansmith mriedem: I haven't looked at all your comments, but if there are legit ones I'll do it yeah
15:46:21 mriedem mdbooth: we shouldn't need test-only code in block_device.py. if we need special serialize code for those types of objects, surely we could house that in test utils separately
15:46:32 mriedem e.g. we have special comparison methods for versioned objects
15:46:55 mdbooth mriedem: It might come to that, but that's a bit of big cleanup I was hoping to avoid.

Earlier   Later