| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-09 | |||
| 14:31:13 | openstackgerrit | Chris Dent proposed openstack/nova master: VMware: Live migration of instances https://review.openstack.org/270116 | |
| 14:31:20 | efried | mdbooth: when in fact it is the prior | |
| 14:31:26 | efried | mdbooth: I don't care, just happened to notice. | |
| 14:31:36 | mdbooth | efried: Ah, I didn't reorder that patch | |
| 14:31:43 | mdbooth | I believe that's still correct. | |
| 14:31:51 | efried | okay | |
| 14:31:54 | efried | I didn't dig | |
| 14:34:16 | tssurya | dansmith: nah, we can skip :) I don't think belmiro is joining today | |
| 14:34:22 | dansmith | okay cool | |
| 14:36:50 | mriedem | efried: melwitt: mtreinish: f yeah e-r is commenting again https://review.openstack.org/#/c/567211/ | |
| 14:37:01 | efried | mriedem: woot | |
| 14:37:24 | efried | mriedem: what was the problem/solution? | |
| 14:38:09 | mriedem | efried: https://review.openstack.org/#/c/567058/ and https://review.openstack.org/#/c/567068/ | |
| 14:39:10 | efried | heh, so no CI for elastic recheck? | |
| 14:39:48 | mtreinish | mriedem: cool | |
| 14:40:14 | mriedem | efried: there is, but that part of the code is kind of tricky | |
| 14:40:33 | mriedem | the function takes a specific change, patchset, and build name/id, | |
| 14:40:37 | mriedem | and the logs are gone after 10 days | |
| 14:40:44 | mriedem | so not sure how you're going to reliably test for that | |
| 14:40:58 | mtreinish | efried: the ci there doesn't check the bot actually sending messages. (it's complex) Mostly we validate the individual pieces work and that the queries are valid (although that looks like it's failing) | |
| 14:41:15 | reshift | Hi, does the nova python client have any methods to search servers for a metadata key or value? | |
| 14:41:33 | openstackgerrit | Eric Fried proposed openstack/nova master: [doc] Add soft_deleted flag https://review.openstack.org/562897 | |
| 14:42:33 | mriedem | reshift: the REST API doesn't support that so i don't think the client does either | |
| 14:43:07 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add InstanceNUMATopology to LibvirtLiveMigrateData https://review.openstack.org/566398 | |
| 14:43:08 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Service version check for NUMA live migration https://review.openstack.org/566723 | |
| 14:43:09 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: NUMA-aware live migration https://review.openstack.org/567242 | |
| 14:43:17 | reshift | ok, thanks | |
| 14:43:25 | mriedem | reshift: see https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L301 | |
| 14:43:40 | mriedem | there is https://developer.openstack.org/api-ref/compute/#server-metadata-servers-metadata but (1) you'd need to hit that for all servers and (2) it doesn't have filter params | |
| 14:44:07 | reshift | I think I might try using tags instead | |
| 14:44:28 | mriedem | reshift: i was just going to say, you can filter servers on tags | |
| 14:44:31 | mriedem | if that works for you | |
| 14:53:15 | efried | mdbooth: I don't see how convert_all_volumes filters down to only volumes. | |
| 14:53:39 | efried | rather, how it filters anything. | |
| 14:56:29 | mdbooth | efried: Those functions are weird | |
| 14:57:45 | openstackgerrit | Michael Bayer proposed openstack/nova master: Add connection_parameters to list of items copied from database https://review.openstack.org/567248 | |
| 14:57:56 | mdbooth | efried: So, it's a concatenation of volume, snapshot, image, and blank, all of which are volume types | |
| 14:58:46 | mdbooth | efried: Each of those functions individually works by calling <class>._transform on everything in the list, and those of the wrong type raise an error | |
| 14:58:59 | mdbooth | It's obtuse, but the result is that they're all volumes. | |
| 14:59:31 | efried | mdbooth: Noted. The obtuseness, and the cheapness of the is_volume check, would have me preferring to leave it in even if redundant. | |
| 14:59:54 | mdbooth | efried: The *implementation* is obtuse, however the intent is very clear | |
| 15:00:07 | mdbooth | It's called 'convert_all_volumes', and it returns only volumes | |
| 15:00:55 | mdbooth | In my view, the is_volume test adds confusion, because it sets an expectation that the input might be something other than volumes | |
| 15:01:23 | mdbooth | I'd rename 'bdms' to 'volumes' | |
| 15:01:47 | efried | esberglu: If you're following this, it'd be your action ^ | |
| 15:03:45 | mdbooth | I wonder, however, if it's possible to have a volume bdm with no connection_info. I guess you'd have that at least briefly before attach? | |
| 15:05:37 | zzzeek | jaypipes melwitt hurry i need you to drop everything and attend to my personal nova issue | |
| 15:13:44 | openstackgerrit | Merged openstack/python-novaclient master: Fix the incorrect cirros default password https://review.openstack.org/567170 | |
| 15:15:01 | jaypipes | zzzeek: how may I assist you, fine sir? | |
| 15:16:41 | zzzeek | jaypipes: more "I added an option to oslo.db" pain: https://review.openstack.org/#/c/567248/ | |
| 15:17:19 | zzzeek | jaypipes: i want to put up the backports for this | |
| 15:18:48 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Skip ServerActionsTestJSON.test_rebuild_server for cells v1 job https://review.openstack.org/567256 | |
| 15:22:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Simplify instance name generation https://review.openstack.org/516573 | |
| 15:22:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove '_apply_instance_name_template' https://review.openstack.org/567257 | |
| 15:23:25 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI2() API https://review.openstack.org/567258 | |
| 15:24:45 | kashyap | mdbooth: ^ You might be interested in the above change. As I've see you fiddle with migration parameters of libvirt migrate API :-) | |
| 15:24:52 | kashyap | No urgency at all. This can wait. | |
| 15:25:19 | kashyap | s/see/seen/ | |
| 15:30:42 | mriedem | stephenfin: why do we need this? https://review.openstack.org/#/c/567257/ - looks like you're just taking a separate method and munging it back into where it's called from | |
| 15:30:58 | mriedem | well, not where it's called from, but close | |
| 15:31:19 | stephenfin | It makes the follow up way easier to parse, in my mind at least https://review.openstack.org/#/c/516573/ | |
| 15:31:44 | stephenfin | (follow up to https://review.openstack.org/#/c/499612/) | |
| 15:33:25 | openstackgerrit | Dan Smith proposed openstack/nova master: Add CellMapping.get_by_project_id() query method https://review.openstack.org/509002 | |
| 15:33:26 | openstackgerrit | Dan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells https://review.openstack.org/509003 | |
| 15:34:08 | mriedem | stephenfin: left some comments, the commit message clearly needs more context | |
| 15:34:23 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Skip placement on rebuild in same host https://review.openstack.org/561015 | |
| 15:42:50 | openstackgerrit | Merged openstack/nova stable/queens: Fix dropped check for boot_index 0 in _validate_bdm https://review.openstack.org/564461 | |
| 15:43:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove '_apply_instance_name_template' https://review.openstack.org/567257 | |
| 15:43:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Simplify instance name generation https://review.openstack.org/516573 | |
| 15:52:24 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: add resource_requests field to RequestSpec https://review.openstack.org/567267 | |
| 15:52:25 | stephenfin | Anyone have any idea why this change could be causing Tempest to fail? https://review.openstack.org/#/c/564444/ http://logs.openstack.org/44/564444/2/check/tempest-full/762ada1/testr_results.html.gz | |
| 15:52:25 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: transfer port.resource_request to the scheduler https://review.openstack.org/567268 | |
| 15:53:56 | stephenfin | The only functional thing I've changed is that we now fetch physnet information for any network IDs we passed in network requests - not just port IDs. Can't reproduce locally though :/ | |
| 15:55:10 | openstackgerrit | Artom Lifshitz proposed openstack/nova stable/pike: log stale allocations as WARNING instead of DEBUG https://review.openstack.org/567271 | |
| 15:55:56 | openstackgerrit | Artom Lifshitz proposed openstack/nova stable/queens: log stale allocations as WARNING instead of DEBUG https://review.openstack.org/567273 | |
| 15:56:45 | openstackgerrit | Artom Lifshitz proposed openstack/nova stable/pike: log stale allocations as WARNING instead of DEBUG https://review.openstack.org/567271 | |
| 15:57:22 | gibi | stephenfin: now you include the meta network 'auto' to the query http://logs.openstack.org/44/564444/2/check/tempest-full/762ada1/controller/logs/screen-n-api.txt.gz?level=ERROR#_May_07_16_24_34_423219 | |
| 15:59:15 | stephenfin | gibi: Dang it. Thanks! I've been trying to suss that all day and couldn't find the required log 😅 | |
| 15:59:22 | lbragstad | jaypipes: re: the scope type patches for nova, i reworked the ksm (gating) and the oslo.context patches (still in review) - hopefully they're a bit more clear from a consuming service perspective | |
| 15:59:30 | lbragstad | oslo.context patch - https://review.openstack.org/#/c/530509/ | |
| 16:00:02 | mdbooth | dansmith: I think the explanation you requested is better in a class docstring rather than the commit message. That ok with you? | |
| 16:00:18 | mdbooth | Means we can find it later without git spelunking. | |
| 16:00:47 | dansmith | sure | |
| 16:01:30 | mriedem | stephenfin: the NetworkRequest(List) has helper methods to determine if it's an auto-allocate request | |
| 16:05:07 | artom | mriedem, to be honest I just mechanically did the backport since our downstream bug was against 12 (https://bugzilla.redhat.com/show_bug.cgi?id=1572836 FWIW) | |
| 16:05:07 | openstackgerrit | Merged openstack/nova master: Followup for multiple member_of qparams support https://review.openstack.org/567209 | |
| 16:05:07 | openstack | bugzilla.redhat.com bug 1572836 in openstack-nova "nova-compute should log messages about stale resource allocations at warning priority" [Medium,Post] - Assigned to alifshit | |
| 16:05:50 | mriedem | artom: see my comments when i merged the change on master | |
| 16:06:18 | mriedem | artom: queens and rocky shouldn't be hitting that code so warning is ok, and we can't rely on ocata/pike computes to heal the allocations, | |
| 16:06:41 | mriedem | but that gets fuzzy when you're in pike and could have ocata computes, and we also fixed a bunch of places post-pike GA that didn't cleanup allocations on failure, | |
| 16:06:51 | mriedem | so from that bz, it's possible they hit one of those places that are now fixed | |
| 16:07:27 | artom | mriedem, dammit, I was hoping I wouldn't have to use my brain for this one ;) | |
| 16:07:36 | mriedem | defer your brain to dansmith | |
| 16:07:41 | mriedem | he knows that code well | |
| 16:08:53 | artom | I... I can't tell if you're serious or just messing with Dan :/ | |
| 16:11:38 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Do not use SameHostFilter in API sample tests https://review.openstack.org/563037 | |
| 16:12:45 | mriedem | artom: i'm phoning a friend | |
| 16:13:00 | dansmith | mriedem: I think warning on pike is reasonable, and I think that's where we hit it downstream.. they didn't realize things had gotten legit out of sync because they had debug off | |
| 16:13:23 | dansmith | when they turned debug on, we realized some instances had allocations on three computes because of legit leaks | |
| 16:13:53 | mriedem | was this pike 16.0.0 GA? | |