Posted	Nick	Remark
#openstack-nova - 2018-05-08
20:13:50	arvindn05	if the image meta data for a volume is just the image attributes rather than any of the standard fields of ImageMetaProps then again the test may not make sense
20:15:41	mriedem	the volume's volume_image_metadata is a copy of the image metadata from the image or snapshot used to create the volume
20:16:15	mriedem	so if we ever wanted/needed to actually filter volume-backed instances based on image metadata, we can totally do that by getting the image meta via the volume_image_metadata, we just don't do that today
20:17:13	mriedem	http://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/flows/manager/create_volume.py#n559
20:19:06	arvindn05	so if i have an image with trait:foo, then for a volume based on that image the meta data would look like below
20:19:06	arvindn05	"volume_image_metadata": {
20:19:06	arvindn05	"image_id": "b48c53e1-9a96-4a5a-a630-2e74ec54ddcc",
20:19:06	arvindn05	"trait:foo" "required"
20:19:06	arvindn05	....
20:19:06	arvindn05	},
20:19:29	arvindn05	or would the trait:foo field be missing and looked up when the image is loaded with the ID
20:19:58	mriedem	arvindn05: maybe you should fire up a devstack and test this out for yourself
20:20:45	arvindn05	if its the above with trait:foo being part of volume_image_metadata then i would need to add to CinderFixtureNewAttachFlow else i can do your suggestion of updating the image directly
20:21:36	mriedem	https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1409 is not attempting to be an exhaustive list of what goes into volume_image_metadata for the cinder fixture
20:21:47	arvindn05	mriedem: havent worked with cinder before...so trying to cover the bases...will update my devstack to have cinder and try out as well
20:23:42	arvindn05	yea...if you knew off the top of the head if volume_image_metadata enumerates all ImageMetaProps(if defined on the image) that would help me get a headstart with the test
20:37:29	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Fix the policy argument in server-group-create https://review.openstack.org/564699
20:55:13	openstackgerrit	karim proposed openstack/nova master: Pushing image traits to ironic node https://review.openstack.org/565620
20:58:38	openstackgerrit	Eric Fried proposed openstack/nova master: Use .. deprecated:: theme for deprecations https://review.openstack.org/565822
21:05:54	mriedem	melwitt: i don't know if this is a bug fix or a feature or what https://review.openstack.org/#/c/564193/
21:06:34	openstackgerrit	Merged openstack/nova master: Bump pypowervm minimum to 1.1.15 https://review.openstack.org/564276
21:08:18	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration https://review.openstack.org/566723
21:08:48	melwitt	mriedem: yeah, looks like a driver parity thing. not sure if it's a feature either, not an expert on what image meta props really are
21:10:55	mriedem	yeah it's adding support for hw_video_ram to the vmware driver
21:11:00	mriedem	so not a bug
21:11:23	mriedem	the commit message totally makes it sound like it's fixing something, but it's not
21:11:31	mriedem	"fix this new thing that i'm adding"
21:12:01	melwitt	yeah, agreed. good doc finds in your comment
21:13:41	melwitt	we usually do blueprints for driver parity things but this is indeed a lot smaller than most of the parity things we usually see. kind of more along the lines of adding the aarch64 support stuff maybe?
21:16:06	melwitt	so maybe don't need a blueprint but do need release note and doc update at a minimum
21:17:08	mriedem	yeah i don't think we need a blueprint either
21:17:10	mriedem	just reno and doc updates
21:17:56	melwitt	++
21:18:38	melwitt	looks like the doc update would be in glance though
21:18:51	mriedem	for the image properties one yeah,
21:18:58	mriedem	but we should also document the flavor extra spec in our docs
21:19:23	melwitt	yeah -- just not sure it has to fall on their change though, since it's currently undocumented even for the libvirt driver
21:20:03	mriedem	melwitt: ok, i'll do them a solid and push a patch below theirs that adds the flavor extra spec doc, and they can then update it
21:20:33	melwitt	sounds super
21:32:47	openstackgerrit	Merged openstack/nova master: Remove stale pip-missing-reqs tox test https://review.openstack.org/565535
21:40:55	openstackgerrit	Matt Riedemann proposed openstack/nova master: doc: Don't confuse CPU pinning/NUMA as Hyper-V only https://review.openstack.org/561949
21:40:56	mriedem	stephenfin: we need to get -W working in the docs builds again ^
21:50:59	openstackgerrit	Matt Riedemann proposed openstack/nova master: Use .. deprecated:: theme for deprecations https://review.openstack.org/565822
21:51:01	openstackgerrit	Merged openstack/nova master: placement: Object changes for granular https://review.openstack.org/564351
21:51:26	sean-k-mooney	mriedem: huh when did they make that a config option on the host instead of using the there custom extra spec option
21:51:58	mriedem	sean-k-mooney: context?
21:52:10	sean-k-mooney	hyperv numa affinity
21:52:24	mriedem	that's a question for claudiu
21:52:25	mriedem	or git blame
21:53:21	sean-k-mooney	hyperv used (like 4/5 releases ago) have a addtion hw:somting extra spec that allowed you to set the numa affinity of the guest memory
21:54:24	sean-k-mooney	i went looking for it simi recently but could not find it so i assumed it was removed but i guest its now a host config option
21:55:22	mriedem	dansmith: i left comments in https://review.openstack.org/#/c/509002/ but didn't want to -1
21:57:07	sean-k-mooney	mriedem: ah it was hw:numa_mempolicy=preferred|strict http://git.openstack.org/cgit/openstack/nova-specs/tree/specs/liberty/approved/hyper-v-vnuma-enable.rst#n78
22:01:10	sean-k-mooney	ah it looks like they did not complete the spec until ocata and that extra spec got lost along the way. that is a shame i wanted to add that to the libvirt driver at some point.
22:04:19	dansmith	mriedem: ack, thanks
22:09:58	arvindn05	mriedem: FYI tested with image backed volume the image meta data needs to be part of the volume_image_metadata...so will need to modify the fixture..will write the funtional test with that in mind :)
22:09:58	arvindn05	"volume_image_metadata": {
22:09:58	arvindn05	"image_id": "39f216fd-ebba-4a6a-b741-c83cd02a00ec",
22:09:58	arvindn05	"trait:CUSTOM_TRUSTED": "required",
22:09:58	arvindn05	...
22:09:59	arvindn05	}
22:17:03	openstackgerrit	Matt Riedemann proposed openstack/nova master: vmware:Validation video ram against the max video ram allowed. https://review.openstack.org/564193
22:17:04	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add docs for hw_video:ram_max_mb flavor extra spec https://review.openstack.org/567070
22:29:08	openstackgerrit	Merged openstack/osc-placement master: RP delete inventories (v1.5) https://review.openstack.org/514642
22:38:36	melwitt	mriedem: I dunno if you saw my reply yesterday about the stable releases. I was thinking maybe we just do the releases after we get the regression fixes we know about in? what was your thought on it? do you think we should go ahead and flush the stable review queues too?
23:09:21	openstackgerrit	Merged openstack/nova master: Handle PortNotFoundClient exception when getting ports https://review.openstack.org/565183
23:12:16	melwitt	interesting, this old experimental queue job failing because it wants to install the liberty cloud archive which isn't supported on xenial http://logs.openstack.org/37/554437/18/experimental/legacy-tempest-dsvm-nova-libvirt-kvm-apr/e50a428/logs/devstacklog.txt.gz#_2018-05-08_22_58_11_828
23:18:54	openstackgerrit	Merged openstack/python-novaclient master: Fix the policy argument in server-group-create https://review.openstack.org/564699
23:47:36	openstackgerrit	Merged openstack/nova master: placement: Granular GET /allocation_candidates https://review.openstack.org/517757
23:47:44	openstackgerrit	Merged openstack/nova master: doc: Don't confuse CPU pinning/NUMA as Hyper-V only https://review.openstack.org/561949
23:47:52	openstackgerrit	Merged openstack/nova master: Use .. deprecated:: theme for deprecations https://review.openstack.org/565822
23:58:39	mriedem	melwitt: didn't see it, but these are the regressions i had in mind: https://review.openstack.org/#/c/564461/ https://review.openstack.org/#/c/566367/ https://review.openstack.org/#/c/563213/
#openstack-nova - 2018-05-09
00:08:13	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration https://review.openstack.org/566723
00:38:00	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration https://review.openstack.org/566723
00:52:27	openstackgerrit	fupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment https://review.openstack.org/565181
01:18:44	openstackgerrit	Artom Lifshitz proposed openstack/nova master: WIP: Service version check for NUMA live migration https://review.openstack.org/566723
01:22:47	openstackgerrit	Merged openstack/nova master: Convert fping API to processutils.execute() https://review.openstack.org/564144
02:35:14	takashin
02:44:21	openstackgerrit	fupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment https://review.openstack.org/565181
04:11:02	openstackgerrit	Merged openstack/nova master: Add docs for hw_video:ram_max_mb flavor extra spec https://review.openstack.org/567070
04:44:55	openstackgerrit	Jake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows https://review.openstack.org/556751
04:46:32	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Return nested providers in get_by_request https://review.openstack.org/567113
04:50:10	openstackgerrit	Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
04:50:11	openstackgerrit	Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
04:50:12	openstackgerrit	Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
04:51:41	openstackgerrit	Merged openstack/nova master: log stale allocations as WARNING instead of DEBUG https://review.openstack.org/564964
04:54:36	openstackgerrit	Michael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module. https://review.openstack.org/557552
04:54:37	openstackgerrit	Michael Still proposed openstack/nova master: Move create_tap_dev to the new utility module. https://review.openstack.org/557835
04:54:39	openstackgerrit	Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module. https://review.openstack.org/558487
04:57:56	openstackgerrit	Merged openstack/nova master: Convert xenapi's xvp console to processutils. https://review.openstack.org/564145
05:04:35	openstackgerrit	Takahito Hirose proposed openstack/python-novaclient master: api_version decorator becomes an error in Python 3.5.0. https://review.openstack.org/564702
05:56:48	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Return nested providers in get_by_request https://review.openstack.org/567113
07:01:43	openstackgerrit	Merged openstack/nova master: Remove IronicHostManager and baremetal scheduling options https://review.openstack.org/565805
07:23:54	openstackgerrit	fupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment https://review.openstack.org/565181
07:52:17	openstackgerrit	sahid proposed openstack/nova master: compute: introduce cpu_shared_set option https://review.openstack.org/561912
07:52:18	openstackgerrit	sahid proposed openstack/nova master: libvirt: always pass emulator threads policy https://review.openstack.org/561913
07:52:19	openstackgerrit	sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set https://review.openstack.org/510897
08:20:03	openstackgerrit	Jan Gutter proposed openstack/nova master: Add plumbing for Contrail/Tungsten Fabric offloads https://review.openstack.org/567147
08:22:15	openstackgerrit	Jan Gutter proposed openstack/nova-specs master: Spec to implement vRouter HW offloads https://review.openstack.org/567148
08:26:50	stephenfin	jaypipes: By mechanisms, I was referring to the various ways of a network can be configured and segmented, either L2 or L3. Local means connectivity is only on a single host https://gist.github.com/bonclay7/458b353f997e05db374d

Earlier   Later