Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-05-08
14:24:25 kashyap Which should log this: https://review.openstack.org/#/c/565242/5/nova/virt/libvirt/driver.py@4799
14:24:45 kashyap artom: Yep, digging...Thx for the (non-null) pointer
14:24:48 jroll kashyap: if there's other warn calls happening, you could also do mock_warn.assert_has_calls([mock.call('Monitoring...')])
14:25:22 artom kashyap, I'm thinking something else called LOG.warning somewhere along that test's execution
14:25:38 kashyap jroll: I don't think it's other warn calls, because I was calling it with a specific warning message
14:25:46 artom If those were legit calls, you can adjust your tests to only assert on the call you care about
14:25:46 kashyap jroll: But let me try your trick.
14:25:52 jroll kashyap: what artom said :)
14:25:55 artom If they weren't legit, you fix your code :)
14:26:14 jroll ++
14:26:25 kashyap Thx for the comments, folks
14:27:06 artom Btw, asserting on *log messages* is horrible testing practive
14:27:08 artom *practice
14:27:20 artom I know Nova is side-effect land, so we don't have much choice
14:27:38 artom But in an ideal world, we'd be asserting stuff on output, given a certain input
14:27:44 kashyap artom: I was actually asked to do it. I firt did the self.assertTrue(mock_warn.called)
14:28:17 kashyap And the libvirt driver at least doesn't do a lot of those. Only 3 or so of them -- asserting on log message.
14:28:39 artom kashyap, yeah, I fully understand the reality of what we're working on
14:28:39 kashyap And if it's any consolation, this warning will be removed in the next release.
14:34:18 openstackgerrit Merged openstack/nova master: Changing scheduler sync event from INFO to DEBUG https://review.openstack.org/566392
14:58:31 jmccarthy mriedem: Thanks again for the help, this experimental review did the trick for me https://review.openstack.org/#/c/566367
15:05:22 mriedem jmccarthy: np, thanks for verifying it
15:06:28 kashyap jroll: Your trick tells me my assertion was not even in the call list. ("not all found in call list").
15:06:52 jroll interesting
15:21:23 mriedem jmccarthy: just tested mel's suggestion in there, i'll get that patch updated later today
15:22:37 jmccarthy mriedem: Ah ok cool - I can give that a whirl also to confirm (but probably not till later)
15:46:33 openstackgerrit Eric Fried proposed openstack/nova master: Use query_parameters in granular gabbit https://review.openstack.org/566927
15:48:54 openstackgerrit Aditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin https://review.openstack.org/534371
15:52:06 stephenfin jaypipes, bauzas, sean-k-mooney: Fancy taking another swing at https://review.openstack.org/#/c/541290/ today?
15:53:32 jaypipes stephenfin: ack, will do. sorry, was swamped with other stuff yesterday and didn't get to that.
15:54:04 stephenfin no worries :) /me is going through bandwidth-resource-provider again atm
15:55:43 openstackgerrit Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269
16:01:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001
16:01:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548
16:01:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604
16:01:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170
16:01:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947
16:01:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333
16:01:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334
16:01:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423
16:01:51 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370
16:01:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager https://review.openstack.org/551371
16:01:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870
16:01:54 openstackgerrit Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537
16:01:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Add VIFMigrateData.get_dest_vif https://review.openstack.org/566931
16:01:56 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: factor out pre_live_migration plug_vifs call https://review.openstack.org/566932
16:01:57 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: use dest host port bindings during pre_live_migration https://review.openstack.org/566933
16:07:06 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370
16:07:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager https://review.openstack.org/551371
16:07:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870
16:07:10 openstackgerrit Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537
16:07:56 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: test live_migration_wait_for_vif_plug=True https://review.openstack.org/558006
16:35:51 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove 'NUMATopologyLimits.obj_from_db_obj' https://review.openstack.org/537412
16:35:52 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_to_dict' functions https://review.openstack.org/537413
16:35:53 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.openstack.org/537414
16:36:19 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: check image type before removing snapshots in _cleanup_resize https://review.openstack.org/566367
16:36:20 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: remove old rbd snapshot removal error handling https://review.openstack.org/566369
16:37:52 openstackgerrit Artom Lifshitz proposed openstack/nova master: Add InstanceNUMATopology to LibvirtLiveMigrateData https://review.openstack.org/566398
16:37:53 openstackgerrit Artom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration https://review.openstack.org/566723
16:54:37 openstackgerrit Eric Fried proposed openstack/nova master: placement: Granular GET /allocation_candidates https://review.openstack.org/517757
17:01:16 openstackgerrit Merged openstack/nova master: libvirt: Fix misleading debug msg "Instance is running" https://review.openstack.org/565234
17:11:18 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Use oslo.messaging per-call monitoring https://review.openstack.org/566696
17:30:34 openstackgerrit Merged openstack/nova-specs master: Network bandwidth resource provider https://review.openstack.org/502306
17:30:57 gibi \o/ ^^
17:37:34 efried mriedem: In ocata and/or pike, in a bfv situation, is/was there a bug where the scheduler would require the host to have localdisk inventory in the amount requested by the flavor, even though it wasn't ultimately allocated/consumed?
17:57:02 mriedem efried: https://bugs.launchpad.net/nova/+bug/1469179 ?
17:57:02 openstack Launchpad bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,In progress] - Assigned to Dan Smith (danms)
18:23:50 efried Thanks mriedem
18:44:11 dansmith tssurya: have you looked over this yet? https://review.openstack.org/#/c/509003/
18:44:39 dansmith mriedem: melwitt: do you both agree that having a config flag for gating that ^ vs. just hitting all cells is a good idea?
18:44:42 tssurya dansmith: oops, not yet, will review now
18:44:53 dansmith tssurya: okay I want to make sure it will work for you
18:47:27 mriedem umm,
18:47:48 mriedem since most people aren't >1 cell yet, that adds an extra db hit to every GET /servers operation right?
18:50:50 dansmith yeah, which is why I think it probably needs a config knob
18:51:01 dansmith it should be a huge benefit to cern, but not most people
18:51:31 tssurya dansmith: this works for us since we have a lot of cells, but I think from a developer perspective we wouldn't want to retrieve the mappings every time , so I vote for a config option -> same logic in us doing refresh handler for disable cells to maintain the cache.
18:52:37 dansmith aye
19:00:02 jaypipes dansmith: my thought was that such an option could easily be added if it becomes an issue later.
19:01:59 mriedem dansmith: well, you could create 1000 fake instances and compare the average time to list them either way and see if the extra join is a noticeable impact
19:02:17 dansmith mriedem: extra join?
19:02:26 mriedem instance mappings -> cell mappings
19:02:34 jaypipes mriedem: it's not a join. just an extra query against instance_mappings IIRC
19:02:35 mriedem the upfront extra join to filter cell mappings based on project_id
19:02:38 dansmith it's a whole extra hit, not just a join
19:02:57 mriedem the "new extra db kerfuffle"
19:03:57 dansmith I prefer to just make it default to continue using the cache, and let people like cern opt into this behavior
19:09:00 melwitt mriedem: sweet, thanks for closing out the bp
19:10:29 jaypipes stephenfin: still around?
19:11:52 jaypipes stephenfin: what precisely do you mean by "mechanisms" in "Like provider networks, tenant networks can use one of five mechanisms: *flat*, *VLAN*, *local*, *VXLAN*, or *GRE*."? In particular, what is "local mechanism"?
19:12:55 melwitt dansmith: config option sounds okay ... the only bad side is, yet-another-config-option. and I'm thinking how can we group cells-related options, CONF.cells is already taken by cells v1
19:13:23 jaypipes melwitt: CONF.cern? ;)
19:13:25 mriedem CONF.api.something
19:13:35 melwitt heh
19:13:38 mriedem CONF.api.multicell_project_per_cell
19:13:42 tssurya jaypipes: :P
19:13:51 jaypipes tssurya: :)
19:15:36 mriedem fortunately we already have a project_id index in the instance_mappings table
19:17:04 mriedem this unblocks osc-placement if someone wants to give the +W https://review.openstack.org/#/c/565694/
19:19:02 jaypipes mriedem: done

Earlier   Later