| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-07 | |||
| 15:03:41 | dansmith | jaypipes: yeah | |
| 15:04:11 | dansmith | I was saying that I think we'd be a lot better off if we just did that.. have a config value of "if_no_user_id_then_use_this=$uuid" | |
| 15:04:11 | jaypipes | dansmith: guess I just didn't want to go through a forced data migration. | |
| 15:04:14 | dansmith | well, | |
| 15:04:35 | dansmith | if you did, we could have FKs and not have to conditionally handle "if there is a consumer, else..." anywhere else in the code | |
| 15:06:22 | melwitt | mnaser: just updated the devstack patch, fyi | |
| 15:06:23 | efried | the tradeoff being that we would have to have "if user/project is $dummy then don't display it" | |
| 15:06:30 | efried | etc | |
| 15:06:34 | jaypipes | dansmith: there's only a single place we do that in my code series. | |
| 15:06:37 | dansmith | efried: you must have that anyway | |
| 15:06:59 | dansmith | efried: in case someone creates an allocation with a new one and then displays it with an old one | |
| 15:07:01 | efried | right, just sayin you're not really saving anything. | |
| 15:07:24 | efried | sorry, 'tradeoff' isn't the right word. | |
| 15:07:25 | dansmith | jaypipes: but anyone that uses the api has to have that code as well yeah? | |
| 15:07:57 | dansmith | jaypipes: because if the allocation was created with an older one, then the newer microversion has to show something different and every consumer has to handle that | |
| 15:08:14 | dansmith | which I know they do today, I'm just saying I think this was done wrong from the beginning and we should correct it | |
| 15:08:36 | jaypipes | dansmith: so instead of switching on project_id == None, they would need to switch on project_id == <sentinel>? | |
| 15:08:37 | dansmith | having the ambiguity on both ends makes this more complicated | |
| 15:08:52 | dansmith | jaypipes: they being the api consumer? | |
| 15:09:07 | jaypipes | dansmith: yes | |
| 15:09:34 | dansmith | I'm not sure why they would be "switching" on that value at all | |
| 15:09:37 | jaypipes | dansmith: I thought project == None was as good a representation as any | |
| 15:10:16 | jaypipes | dansmith: lemme back up and make sure I understand your concern | |
| 15:10:42 | dansmith | an api consumer doesn't list allocations looking for those without a project, or looking for those with a project, right? they'd be listing them and counting things, collated by project, or something like that I think | |
| 15:10:51 | dansmith | and they have to handle the null-ness of that field as a special value | |
| 15:11:16 | jaypipes | dansmith: the only place in my code series that has any "logic" about whether a consumer record exists is line 227 here: https://review.openstack.org/#/c/565405/5/nova/api/openstack/placement/handlers/allocation.py | |
| 15:11:19 | dansmith | when I explained this to you last week you said "yes exactly" so I'm just confused :) | |
| 15:11:21 | mriedem | o/ | |
| 15:11:37 | dansmith | jaypipes: yeah I get that | |
| 15:11:40 | mriedem | anyone talk about this gate failure yet? http://status.openstack.org/elastic-recheck/#1769286 | |
| 15:11:58 | dansmith | mriedem: melwitt is on it I think | |
| 15:12:03 | mriedem | great | |
| 15:12:06 | dansmith | mriedem: came from her patches I think | |
| 15:12:14 | mriedem | it did, not sure how though | |
| 15:12:16 | mriedem | unless it's timing | |
| 15:12:37 | jaypipes | dansmith: an API caller just asks for allocations for a consumer UUID or allocations for a resource provider UUID | |
| 15:12:45 | melwitt | mriedem: it's that the console proxy config needs to be per cell instead of global for the TLS settings to get picked up | |
| 15:12:54 | melwitt | and devstack doesn't gate on nova-next | |
| 15:13:04 | dansmith | jaypipes: yep | |
| 15:13:13 | mriedem | melwitt: this isn't 100% failure though is it? | |
| 15:13:22 | melwitt | I don't understand why it doesn't fail on all patches though, for example this one, the vnc proxy log just ... stops http://logs.openstack.org/67/566367/1/check/nova-next/48ce9d6/logs/screen-n-novnc-cell1.txt.gz | |
| 15:13:44 | melwitt | no, it's not 100%, see the above example ^ | |
| 15:14:22 | melwitt | mriedem: this is the devstack patch I've proposed https://review.openstack.org/566446 it passed nova-next earlier but I updated it to remove repetition. if I did that right, it should still pass nova-next | |
| 15:25:38 | mriedem | melwitt: nova-next runs in the devstack experimental queue if you want to test changes on devstack itself | |
| 15:25:41 | mriedem | but yeah it's not gating | |
| 15:26:30 | melwitt | yeah, I realized that while working on the fix. I've been running it through the experimental queue to test the fix | |
| 15:27:23 | mriedem | ack. i'm in st paul today and just got online so getting caught up. | |
| 15:28:58 | melwitt | k | |
| 15:29:43 | mriedem | bauzas: lyarwood: would be good to get this in and released https://review.openstack.org/#/c/566164/ | |
| 15:40:19 | kashyap | mriedem: Holiday in the UK / IE | |
| 15:40:28 | kashyap | Probably France too | |
| 15:40:48 | mriedem | alright | |
| 15:42:02 | kashyap | (Not in France) | |
| 15:42:30 | kashyap | mriedem: BTW, thanks for the careful review here: https://review.openstack.org/#/c/565242/4/nova/virt/libvirt/driver.py@a4798 | |
| 15:43:00 | kashyap | mriedem: Even I wrote "After second thoughts", I think hard-failing at Compute start up sounds cleaner | |
| 15:44:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add NUMANetworkTopology object https://review.openstack.org/564439 | |
| 15:44:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440 | |
| 15:44:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.networks field https://review.openstack.org/564441 | |
| 15:44:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add NetworkRequest.physnet, tunnelled https://review.openstack.org/564442 | |
| 15:44:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Unchain _get_phynet_info from _get_port_vnic_info https://review.openstack.org/564443 | |
| 15:44:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Add 'populate_networks' to network API https://review.openstack.org/564444 | |
| 15:45:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Add '_get_network_tunnel_status' https://review.openstack.org/564445 | |
| 15:45:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Add network_requests to instance_extra https://review.openstack.org/564446 | |
| 15:45:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add Instance.network_requests https://review.openstack.org/564447 | |
| 15:45:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Start accounting for network requests https://review.openstack.org/564448 | |
| 15:45:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: rt: Start utilizing Instance.network_requests https://review.openstack.org/564449 | |
| 15:45:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add RequestSpec.requested_networks https://review.openstack.org/564450 | |
| 15:45:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary default parameter https://review.openstack.org/564451 | |
| 15:45:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Start utilizing network_requests https://review.openstack.org/564452 | |
| 15:45:35 | mriedem | kashyap: time to get dansmith to arbitrate | |
| 15:46:05 | kashyap | mriedem: Hehe, thought so. FWIW, I checked with a "real Operator" (runs OpenStack in Fedora Infra) | |
| 15:46:20 | kashyap | mriedem: And he agrees with your suggestion | |
| 15:53:43 | dansmith | mriedem: kashyap: commented | |
| 15:53:47 | kashyap | Completely unrelated thing about English: mriedem once corrected on a commit message: "we told it was" --> "we said [...]". I can't explain _why_ but his correction of s/told/said indeed "sounds" correct. | |
| 15:53:59 | kashyap | dansmith: Thanks; /me wears prickle-safe suit and heads to Gerrit | |
| 15:55:15 | kashyap | Oh, nothing prickly there this time. | |
| 15:56:28 | kashyap | dansmith: Okido; we're all on the same page on where it should fail. | |
| 15:56:50 | kashyap | dansmith: But I'm not even sure if a deprecation cycle is required, when all along the feature was a misfeature | |
| 15:57:23 | kashyap | But I see what you mean, though: "something valid until that point suddenly disappearing is not nice" | |
| 15:57:41 | dansmith | kashyap: I don't think the deprecation people care about that, they care about not breaking configs without a warning | |
| 15:58:05 | kashyap | Yeah, reasonable point. | |
| 15:58:32 | kashyap | But the "deprecation people" might agree in this case? | |
| 16:04:07 | dansmith | kashyap: mriedem is all the "deprecation people" we need on this | |
| 16:04:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove get_config_vhostuser https://review.openstack.org/565471 | |
| 16:04:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: MIN_LIBVIRT_VHOSTUSER_MQ https://review.openstack.org/565472 | |
| 16:04:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_PF_WITH_NO_VFS_CAP_VERSION https://review.openstack.org/565517 | |
| 16:08:58 | mriedem | kashyap: if we aren't going to do a deprecation cycle with a warning if people are using those deprecated options, then we can't just make the service fail to start, | |
| 16:09:08 | mriedem | so i was wrong about the hard-fail on startup | |
| 16:09:29 | mriedem | consider you're rolling from queens to rocky and nova-compute doesn't startup because of something you were using in config which never had a warning in queens | |
| 16:09:59 | mriedem | we could say, "release notes bra!" but that doesn't make people less pissed off | |
| 16:10:39 | mriedem | so you can (a) (1) deprecate in rocky and (2) hard-fail in stein or (b) just do what you have now - don't hard-fail on start but don't honor the options either | |
| 16:11:08 | dansmith | kashyap: exhibit a ^ | |
| 16:18:15 | melwitt | fwiw, I agree with mriedem on that | |
| 16:20:48 | finucannot | whoops | |
| 16:21:14 | efried | thanks for all the reviews stephenfin | |
| 16:21:36 | stephenfin | efried: No problem. I've been lagging there the last few weeks | |
| 16:35:14 | openstackgerrit | Merged openstack/nova master: Fix typos in Host aggregates documentation https://review.openstack.org/566591 | |
| 18:17:30 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Use oslo.messaging per-call heartbeating https://review.openstack.org/566696 | |
| 18:53:51 | openstackgerrit | Jay Pipes proposed openstack/nova master: add consumer.generation/create missing consumers https://review.openstack.org/557958 | |
| 18:53:52 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add Project, User and Consumer objects https://review.openstack.org/565403 | |