| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-03 | |||
| 10:59:57 | gibi | kashyap: done :) | |
| 11:05:49 | kashyap | Thanks! | |
| 11:07:42 | kashyap | gibi: I can't really figure why this is the only one that is failing: https://review.openstack.org/#/c/564012/ | |
| 11:07:52 | kashyap | (Where you did the 'recheck') | |
| 11:07:59 | moshele | stephenfin: hi can you review this pike backport https://review.openstack.org/#/c/563501/? | |
| 11:08:20 | gibi | kashyap: based on the fail tempest test case names it feels unrelated to me | |
| 11:08:37 | gibi | kashyap: if the recheck fails with similar result then we have to dig | |
| 11:08:38 | kashyap | Indeed. Anyway, let's see if the new 'recheck' helps | |
| 11:09:10 | kashyap | Anyway, I have other irons in the fire...So onto them | |
| 11:21:15 | openstackgerrit | Merged openstack/nova master: Include only required fields in ironic node cache https://review.openstack.org/539508 | |
| 11:46:33 | jaypipes | stephenfin: answered your query on the query on https://review.openstack.org/#/c/561315 :) | |
| 12:28:09 | openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources https://review.openstack.org/565841 | |
| 12:28:34 | jroll | dtantsur: fyi, rebased ^ on vdrok's stuff with a depends-on for the scheduler changes instead | |
| 12:31:36 | dtantsur | thanks! | |
| 12:32:17 | stephenfin | jaypipes: Makes sense. Mind addressing these two comments and I can ack https://review.openstack.org/#/c/561315/15/nova/api/openstack/placement/util.py@533 https://review.openstack.org/#/c/561315/15/nova/api/openstack/placement/handlers/resource_provider.py@200 | |
| 12:33:05 | stephenfin | bauzas, gibi: Easy doc win here, if you fancy taking a look https://review.openstack.org/#/c/540888/ | |
| 12:33:16 | gibi | stephenfin: looking | |
| 12:47:01 | gibi | stephenfin: you missed one link :) https://review.openstack.org/#/c/540888/3/api-guide/source/server_concepts.rst@895 | |
| 12:47:11 | gibi | stephenfin: fix it quickly and I'm +2 | |
| 13:02:47 | openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | |
| 13:02:58 | jaypipes | stephenfin: righty-o. all done ^ | |
| 13:11:38 | openstackgerrit | Merged openstack/nova master: trivial: Fix file permissions https://review.openstack.org/566014 | |
| 13:35:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Start using openstackdoctheme's extlink extension https://review.openstack.org/540888 | |
| 13:35:24 | stephenfin | gibi: There were actually a few more. Think I've addressed everything that uses a versioned URL now | |
| 13:36:28 | gibi | stephenfin: thanks, looking | |
| 13:37:05 | sahid | stephenfin: can you look at this serie https://review.openstack.org/#/c/561912/9, jaypipes already +2ed most of the patches | |
| 13:37:14 | stephenfin | sahid: Can do | |
| 13:37:54 | gibi | stephenfin: is the new link at https://review.openstack.org/#/c/540888/3..4/doc/source/admin/manage-the-cloud.rst@25 more general than the original was? | |
| 13:38:42 | stephenfin | gibi: Possibly. I couldn't find an equivalent for the former | |
| 13:38:54 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: trivial: Fix file permissions https://review.openstack.org/566064 | |
| 13:39:02 | gibi | stephenfin: ahh so the original was a dead link already | |
| 13:39:09 | gibi | stephenfin: then it is OK for me | |
| 13:39:13 | stephenfin | Yup. A couple of them were | |
| 13:39:29 | gibi | stephenfin: then this fix is better than I thought :) | |
| 13:39:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove [scheduler]/host_manager config option https://review.openstack.org/565806 | |
| 13:52:12 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-manage placement heal_allocations CLI https://review.openstack.org/565886 | |
| 13:52:17 | gibi | stephenfin: why do we need this ref? https://review.openstack.org/#/c/540888/3..4/nova/api/openstack/compute/rest_api_version_history.rst@761 | |
| 13:53:58 | stephenfin | gibi: for this https://review.openstack.org/#/c/540888/3..4/doc/source/admin/manage-volumes.rst@37 | |
| 13:54:05 | mriedem | johnthetubaguy: want to re-approve this? https://review.openstack.org/#/c/524027/ had to rebase | |
| 13:54:16 | gibi | stephenfin: cool, thanks | |
| 13:54:44 | johnthetubaguy | mriedem: sorry missed that one, done | |
| 13:55:58 | melwitt | nova meeting in 5 minutes | |
| 13:56:37 | mriedem | johnthetubaguy: thanks | |
| 13:57:09 | mriedem | johnthetubaguy: it's also your mandatory weekly bugging for https://review.openstack.org/#/c/552078 | |
| 13:59:22 | johnthetubaguy | mriedem: so I managed to loose track of what we are doing with specs re freeze, although this one should get approved eiher way | |
| 13:59:43 | mriedem | johnthetubaguy: spec freeze is r-2 | |
| 13:59:45 | mriedem | june 7 i think | |
| 14:00:51 | johnthetubaguy | mriedem: ah, I had in my head r-1 for some reason | |
| 14:01:00 | mriedem | it usually is the 1st milestone, | |
| 14:01:08 | mriedem | but because of runways we decided to move out the spec freeze | |
| 14:01:14 | johnthetubaguy | yeah, makes good sense | |
| 14:01:34 | johnthetubaguy | I am just out of the loop (again), too many stupid hospital trips, but thankfully that is all done now! | |
| 14:01:56 | Shilpa | stephenfin: hi, did you gone through http://paste.openstack.org/show/720231/, is it okay to discuss now? | |
| 14:02:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | |
| 14:02:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update layout docs for running console proxies https://review.openstack.org/557489 | |
| 14:02:51 | mriedem | johnthetubaguy: hopefully everything is ok, didn't know that was happening | |
| 14:02:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate the nova-consoleauth service https://review.openstack.org/565367 | |
| 14:03:46 | mriedem | stephenfin: rebased and fixed up https://review.openstack.org/#/c/565367/ - should be happy now | |
| 14:03:52 | johnthetubaguy | mriedem: no worries, not really mentioned it, wasn't too bit a deal, just took time I didn't have! | |
| 14:04:03 | kashyap | Because when I just wanted to ping on something, Matt was already on it & addressed what needs addressing. | |
| 14:04:11 | kashyap | (Not the first time it happened, though...) | |
| 14:04:13 | mriedem | johnthetubaguy: babies are just so gd needy! | |
| 14:05:01 | mriedem | kashyap: the right stuff? https://www.youtube.com/watch?v=tbIEwIwYz-c | |
| 14:05:24 | efried | without clicking, /me assumes nkotb video. | |
| 14:05:50 | kashyap | Haha | |
| 14:05:57 | johnthetubaguy | mriedem: its true | |
| 14:06:23 | kashyap | mriedem: Didn't know of this vintage song; thanks for the education. | |
| 14:08:18 | kashyap | efried: You know your guess was right. | |
| 14:09:09 | kashyap | As it's closer to me | |
| 14:11:25 | mriedem | tssurya: question in https://bugs.launchpad.net/nova/+bug/1767303 for you | |
| 14:11:25 | openstack | Launchpad bug 1767303 in OpenStack Compute (nova) "Scheduler connects to all cells DBs to gather compute nodes info" [Undecided,New] - Assigned to Surya Seetharaman (tssurya) | |
| 14:12:33 | mriedem | tssurya: maybe you just want to propose a backport of https://review.openstack.org/#/c/539617/ for queens? | |
| 14:14:17 | bauzas | stephenfin: do we really need RsT for a docstring ? https://review.openstack.org/#/c/564214/2/nova/conf/devices.py | |
| 14:15:04 | stephenfin | bauzas: It's not a docstring. That's help text that's parsed by oslo_config.sphinext to generate this | |
| 14:15:15 | stephenfin | https://docs.openstack.org/nova/queens/configuration/config.html | |
| 14:15:16 | bauzas | shit | |
| 14:15:27 | bauzas | because yes, it's a docstring | |
| 14:15:34 | bauzas | it's just we use the docstring elsewhere | |
| 14:15:52 | stephenfin | I think our definition of docstring differs :) | |
| 14:16:05 | bauzas | IMHO, help text is for nova.conf | |
| 14:16:10 | bauzas | but meh | |
| 14:16:18 | stephenfin | Um, that is nova.conf? | |
| 14:16:23 | bauzas | a *python* docstring | |
| 14:16:30 | bauzas | 3 brackets | |
| 14:16:38 | bauzas | that's what I call "docstring" | |
| 14:16:47 | edleafe | bauzas: that's just a string | |
| 14:16:50 | stephenfin | That's a mult-line string | |
| 14:16:52 | stephenfin | Yeah | |
| 14:17:07 | edleafe | A docstring is the comment that follows the method definition | |
| 14:17:12 | stephenfin | https://www.python.org/dev/peps/pep-0257/#id15 | |
| 14:18:27 | bauzas | well, if you should name something because of its usage, I disagree | |
| 14:18:30 | bauzas | but meh | |
| 14:18:56 | bauzas | :p | |
| 14:19:05 | edleafe | bauzas: for example: | |
| 14:19:06 | edleafe | def some_method(): | |
| 14:19:06 | edleafe | "this is a docstring" | |
| 14:19:06 | edleafe | return True | |
| 14:19:19 | edleafe | Doesn't need triple quotes | |
| 14:19:25 | edleafe | unless it's multi-line | |
| 14:19:52 | bauzas | I should write my own language | |