| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-02 | |||
| 09:03:22 | kashyap | As the main change got merged while I was asleep | |
| 09:03:28 | kashyap | So you're right on time | |
| 09:03:33 | kashyap | Thanks! | |
| 09:03:43 | lyarwood | kashyap: huh, maybe you just said they'd be coming soon then :) | |
| 09:03:51 | lyarwood | kashyap: and ack, I'll get to them today | |
| 09:04:36 | kashyap | lyarwood: Thanks; you'll see the changes needing reviews here: https://review.openstack.org/#/q/topic:bug/1750829+(status:open+OR+status:merged) | |
| 09:07:32 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041 | |
| 09:39:20 | sahid | jaypipes: if you have a moment, I have a fix here, it's about how we compute memory we could be in situation where guests get oomkilled | |
| 09:39:25 | sahid | https://review.openstack.org/#/c/532168/ | |
| 09:48:33 | openstackgerrit | Michael Still proposed openstack/nova master: Convert fping API to processutils.execute() https://review.openstack.org/564144 | |
| 09:48:34 | openstackgerrit | Michael Still proposed openstack/nova master: Convert xenapi's xvp console to processutils. https://review.openstack.org/564145 | |
| 09:48:36 | openstackgerrit | Michael Still proposed openstack/nova master: Convert certificate generation to processutils. https://review.openstack.org/564146 | |
| 10:15:21 | openstackgerrit | sahid proposed openstack/nova master: compute: introduce cpu_shared_set option https://review.openstack.org/561912 | |
| 10:15:22 | openstackgerrit | sahid proposed openstack/nova master: libvirt: always pass emulator threads policy https://review.openstack.org/561913 | |
| 10:15:23 | openstackgerrit | sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set https://review.openstack.org/510897 | |
| 10:35:21 | openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | |
| 10:35:22 | openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | |
| 10:35:23 | openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | |
| 10:37:41 | openstackgerrit | Michael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module. https://review.openstack.org/557552 | |
| 10:37:42 | openstackgerrit | Michael Still proposed openstack/nova master: Move create_tap_dev to the new utility module. https://review.openstack.org/557835 | |
| 10:37:43 | openstackgerrit | Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module. https://review.openstack.org/558487 | |
| 10:58:06 | openstackgerrit | Balazs Gibizer proposed openstack/osc-placement master: Fix error message in test assert https://review.openstack.org/565694 | |
| 11:09:56 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Make association_refresh configurable https://review.openstack.org/565526 | |
| 11:11:05 | jbernard | melwitt: re the patch (yesterday, rbd busy snapshots), it's a valid rbd state, but tempest does not tolerate it | |
| 11:11:11 | moshele | stephenfin: hi can you review the pike backport https://review.openstack.org/#/c/563501/ ? | |
| 11:12:22 | jbernard | melwitt: the order of operations during teardown is non-deterministic | |
| 11:13:11 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: ironic: Report resources as reserved when needed https://review.openstack.org/517921 | |
| 11:17:32 | openstackgerrit | Vishakha Agarwal proposed openstack/nova master: Re-using the code of os brick cinder https://review.openstack.org/565703 | |
| 11:24:28 | kashyap | melwitt: When you're back, mriedem is right about that extraCPU flags blueprint: a future patch needs to add the ability to remove specific CPU flags. | |
| 11:30:41 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop BAD_LIBVIRT_CPU_POLICY_VERSIONS https://review.openstack.org/564012 | |
| 11:30:42 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_REALTIME_VERSION https://review.openstack.org/565707 | |
| 11:33:32 | kashyap | stephenfin: sahid: ^ On the last commit above (on REALTIME), can you double-confirm what I wrote in the commit message? (I.e. no tests need to cleaned-up.) | |
| 11:35:44 | kashyap | (Also the one before it, 'CPU_POLICY' one, lost +W due to rebase.) | |
| 11:55:25 | openstackgerrit | Michael Still proposed openstack/nova master: Convert configdrive to use processutils. https://review.openstack.org/565723 | |
| 11:55:27 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_QEMU_POSTCOPY_VERSION https://review.openstack.org/565724 | |
| 12:10:42 | openstackgerrit | Martin Midolesov proposed openstack/nova master: vmware:Validation video ram against the max video ram allowed. https://review.openstack.org/564193 | |
| 12:13:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Placement: any traits in allocation_candidate query https://review.openstack.org/565730 | |
| 12:39:22 | stephenfin | kashyap: Can do | |
| 12:45:01 | jmccarthy | Hmm anyone try cold migrate an instance (cinder/lvm backed) with master ? I'm not sure what is the story - but I have this /var/lib/nova/instances/<id>/disk.info left behind on the source host afterwards (after resize verify) and I think it shouldn't be ? | |
| 12:48:24 | kashyap | stephenfin: Gracias | |
| 12:52:55 | jmccarthy | Seems like it's related to this, which is fixed .. https://bugs.launchpad.net/nova/+bug/1666831 - where can one check whether tests for this bug are currently passing ? | |
| 12:52:55 | openstack | Launchpad bug 1666831 in OpenStack Compute (nova) ocata "Nova recreates instance directory after migration/resize" [Low,Fix committed] - Assigned to Lee Yarwood (lyarwood) | |
| 12:54:41 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries https://review.openstack.org/558045 | |
| 12:54:42 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480 | |
| 12:54:43 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories https://review.openstack.org/559554 | |
| 12:54:44 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support nested allocation candidates in placement https://review.openstack.org/565487 | |
| 13:04:30 | mriedem | stephenfin: i know it's past it's runway slot now, but the console objects series from mel is ready to go i think if you have some time to go through it, i know you've been through the earlier patches in the series so you have some context: https://review.openstack.org/#/q/topic:bp/convert-consoles-to-objects+status:open | |
| 13:05:37 | stephenfin | mriedem: Sure, I'd be happy to | |
| 13:06:24 | mriedem | thanks | |
| 13:06:41 | mriedem | kashyap: is there going to be more to https://blueprints.launchpad.net/nova/+spec/libvirt-cpu-model-extra-flags ? | |
| 13:06:47 | mriedem | or is the bp complete? | |
| 13:06:54 | kashyap | mriedem: Your comment on Friday was right | |
| 13:06:57 | kashyap | mriedem: There is the one last item | |
| 13:07:05 | kashyap | That you quoted to Mel on IRC | |
| 13:07:15 | mriedem | kashyap: even though the last patch says "(A future Nova patch will also allow ability to remove CPU flags.)" | |
| 13:07:17 | kashyap | mriedem: We need ability to remove flags as well. That's one more item | |
| 13:07:19 | kashyap | Indeed | |
| 13:07:24 | mriedem | ok | |
| 13:07:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Placement: Support mixing required traits with any traits https://review.openstack.org/565741 | |
| 13:08:19 | kashyap | mriedem: If you are wondering why we need that. Here is one case I wrote up: | |
| 13:08:22 | kashyap | You might ask: "Why would you want to remove a CPU flag though?" One | |
| 13:08:24 | kashyap | scenario for that is: An Operator wants to generate a baseline CPU | |
| 13:08:27 | kashyap | config. And a certain CPU flag is causing performance issue or other | |
| 13:08:29 | kashyap | nuisance, and if the Operator isolated the problem to _that_ specific | |
| 13:08:32 | kashyap | CPU flag, then she may want to remove the flag. | |
| 13:09:05 | kashyap | mriedem: And thanks for shepherding through the minor nits and merging! | |
| 13:10:48 | gibi | mriedem: hi! regarding having one bp with two specs. Jay asked me to split the spec. Does it automatically means I have to have two bp? | |
| 13:12:09 | mriedem | yes | |
| 13:12:24 | gibi | mriedem: OK, then I will file a separate bp too | |
| 13:16:08 | kashyap | mriedem: When you get a minute, I have a different topic, which needs a opinion. It's quick: | |
| 13:16:18 | kashyap | It's about this: https://review.openstack.org/#/c/565242/ -- libvirt: Remove support for Intel CMT `perf` events | |
| 13:16:53 | kashyap | mriedem: At PTG, we agreed (based on info at that time) to log a warning when Nova's `enabled_perf_events` config is used that it is deprecated, and remove it later | |
| 13:17:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Placement: support mixing required traits with any traits https://review.openstack.org/565741 | |
| 13:17:15 | gibi | mriedem: fixed ^^ | |
| 13:17:22 | kashyap | mriedem: However ... upon closer code inspection, we cannot deprecate the config itself, as there are *other* `perf` events besides Intel's CMT events. | |
| 13:17:43 | stephenfin | mriedem, kashyap: I've just left a +1 on this because I think we should take the opportunity to clarify things a little while we're here https://review.openstack.org/#/c/565724/1 | |
| 13:17:46 | kashyap | So here comes my change: What i am proposing is to _remove_ the support for those three Intel CMT events, which is encoded in a dict | |
| 13:17:55 | stephenfin | However, it's not totally related so I can bump to a +2 if you disagree | |
| 13:17:57 | kashyap | (And retain the config itself) | |
| 13:18:12 | kashyap | stephenfin: Let me take a quick look | |
| 13:20:06 | kashyap | stephenfin: Your point is right about it not being clear; but it's a separate change. | |
| 13:20:12 | kashyap | stephenfin: However, | |
| 13:20:52 | kashyap | stephenfin: ... your nit to clean-up _is_post_copy_available() is reasonable, and I should make it in this change. | |
| 13:21:11 | kashyap | It's not a functional change, but just making it like the one below. | |
| 13:22:42 | kashyap | (Even the test change, it still is maybe reasonable to adjust in the current patch.) | |
| 13:22:54 | kashyap | (On a call; will look once done.) | |
| 13:24:03 | mriedem | kashyap: i don't know why PERF_EVENTS_CPU_FLAG_MAPPING are special; you should also probably ask alex_xu about this since he helped work on this getting in | |
| 13:24:24 | kashyap | mriedem: Yep, I actually meant to "Cc" alex_xu on the comment above. | |
| 13:24:46 | kashyap | mriedem: The original config `enabled_perf_events` was added to monitor the flags noted in the CPU_FLAG_MAPPING | |
| 13:24:57 | kashyap | That dict has the three `perf` events for Intel CMT | |
| 13:25:19 | dansmith | kashyap: I know, I just don't think it's worth it.. just MHO | |
| 13:25:38 | kashyap | The way I'm proposing is: (a) remove the broken-by-design Intel CMT (PERF_EVENTS_CPU_FLAG_MAPPING); (b) retain support for other events for `enabled_perf_events` | |
| 13:26:20 | kashyap | dansmith: Hmm, it is a strict improvment, and is correcting a misleading lie that can impact instance boot | |
| 13:26:24 | kashyap | Seems all the worth to me | |
| 13:26:28 | kashyap | Anyway, the backports are done | |
| 13:26:31 | kashyap | And they all pass too | |
| 13:27:10 | kashyap | (It's just a couple of simple lines, FWIW) | |
| 13:27:35 | kashyap | But otherwise, in general I agree with you that minor things shouldn't be backported all the way back like that. | |
| 13:37:04 | bauzas | folks, for those who don't know yet what I call the French May-hem, we're entering a month where a lot of French folks are out | |
| 13:37:23 | dansmith | bauzas: so may is different how then? | |