Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-26
15:20:43 cdent if you have access to modify inventories, you have access to breaking the whole thing
15:39:47 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: Configure multiple vGPU types https://review.openstack.org/564214
15:39:48 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: mdevs returning parent and vendor PCI info https://review.openstack.org/562304
15:39:49 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Get inventories per pGPU https://review.openstack.org/564215
15:46:00 dansmith mriedem: ugh, I think we have a race for service version checking somewhere in unit tests
15:46:03 dansmith a bad mock or something
15:46:13 dansmith I dunno why it's showing up in this patch
15:51:43 mriedem cdent: you don't have to give access to modify inventories
15:51:53 mriedem you can give read-only access to non-admins for things like listing providers and showing inventory
15:51:59 mriedem and leave POST and PUT to admin
15:52:16 cdent mriedem: I believe the ask was to be able to control allocation ratios, but maybe I'm not remembering right
15:53:06 wolverineav sahid: stephenfin - just trying to move the conversation here for faster convergence. if you're both online here. there's 2 open queries. (1) get_config_ivs() being removed. i'm not sure where its called or used. (2) #try os-vif codepath works or not - this is true and verified.
15:55:00 stephenfin wolverineav: It's being called here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L653-L654
15:55:25 sahid wolverineav: you have to convert this function to be something like _set_config_VIF
15:55:28 stephenfin (Yes, that _is_ really non-obvious and I plan to fix it in the future)
15:56:14 sahid so when osvif object is going to be generate, nova will call it based on the vif type
15:56:21 sahid that to configure domain xml
15:56:43 sahid os-vif never configure domain xml
15:56:50 sahid it's nova responsbility
15:56:52 stephenfin wolverineav: Yeah, what sahid said. The path it will be taking is from [1] to [2]
15:56:56 stephenfin [1] https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L648
15:57:08 stephenfin [2] https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L616-L622
15:57:36 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: Showing some strange behavior https://review.openstack.org/564541
15:58:08 stephenfin wolverineav, sahid: We should probably document this once in os-vif we're done. It's certainly a little confusing
16:00:48 sahid stephenfin: yes it is
16:04:57 wolverineav sahid: stephenfin - got it. so the get_config_* methods i should just simply remove, since they're for legacy path. that fixes (1). and for (2) - i installed the os-vif-bigswitch plugin locally and did some regression to bring up a VM. so that satisfies (2). makes sense?
16:05:22 wolverineav i mean get_config_ivs related methods to be removed.
16:05:43 stephenfin wolverineav: I think you need to remove the get_config_ivs methods and, if necessary, add some '_set_config_ivs' functions
16:06:03 stephenfin Assuming you need to modify the libvirt XML for those interfaces
16:06:10 stephenfin If not, you're good
16:06:12 stephenfin I think :)
16:07:33 wolverineav stephenfin: ah. i'm fairly certain we don't. i'll confirm in a bit.
16:07:44 wolverineav thanks sahid stephenfin!
16:07:52 stephenfin wolverineav: Anytime!
16:18:38 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: General policy sample file for placement https://review.openstack.org/524425
17:36:52 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Showing some strange behavior https://review.openstack.org/564541
18:43:27 melwitt mriedem: do we know if anyone is working on a spec amendment for https://review.openstack.org/#/q/topic:bp/nova-validate-certificates ?
18:44:28 cdent nice blog post mriedem
18:45:32 openstackgerrit Jay Pipes proposed openstack/nova master: placement: resource requests for nested providers https://review.openstack.org/554529
18:48:27 dansmith melwitt: yeah I think she said someone was
18:48:29 mriedem melwitt: i don't, i asked about it last week
18:48:31 dansmith peter?
18:48:34 mriedem oh right
18:48:38 mriedem cdent: oh did they post it?
18:48:56 cdent mriedem: showed up in my planet feed
18:48:59 openstackgerrit Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315
18:49:07 melwitt dansmith: okay, thanks. I thought I had read something like but second guessed it
18:57:41 melwitt esberglu: I'm going to move your blueprint out of the runway for now since the series is on hold while the CI is worked on. I'll put it at the front of the queue if we expect the CI to be adjusted soon
19:02:06 esberglu melwitt: ack. Working on the CI pipeline now. I'm hoping to get the scenario testing up early next week, but depends on what kind of roadblocks I hit
19:04:17 melwitt esberglu: k, sounds good. keep us posted
19:09:15 melwitt naichuans: hi, your blueprint https://blueprints.launchpad.net/nova/+spec/xenapi-image-handler-option-improvement has been added to a review runway. I know you have been active on the patch series already but please let us know if now is not a good time to quickly iterate on the series
19:09:56 melwitt jianghuaw_: ^
19:09:58 openstackgerrit Eric Fried proposed openstack/nova master: Base test module/class for functional placement db https://review.openstack.org/564590
19:11:12 mriedem channel topic needs to be updated
19:12:34 melwitt I was thinking I can probably remove "Add host/hostId to instance action events API" too since it's all approved but maybe should wait until merge
19:13:25 mriedem that still needs the novaclient change
19:13:45 melwitt okay, so keep it until novaclient done
19:14:12 melwitt thanks
19:14:23 mriedem i think so, i assume yikun_ can crank out the novaclient change in the next day
19:14:30 mriedem if takashin doesn't beat him to it
19:14:47 melwitt yeah, that's cool. I wasn't sure if the novaclient thing was going to be off-runway but makes sense to be in-runway
19:15:04 mriedem like off broadway?
19:15:11 melwitt yes exactly like that
19:15:17 mriedem fwiw i always waited to complete a bp when the novaclient changes were done
19:15:30 mriedem helped remind me to pester people to do them
19:15:49 melwitt makes sense
19:21:27 openstackgerrit Eric Fried proposed openstack/nova master: Base test module/class for functional placement db https://review.openstack.org/564590
19:21:28 openstackgerrit Eric Fried proposed openstack/nova master: Use test_base symbols directly https://review.openstack.org/564592
20:15:06 Sundar Hi edleafe
20:15:18 mordred efried: I just pushed up an update to https://review.openstack.org/#/c/564299/ that should make it work - and also the previous patch has been updated with a co-authored-by for you :)
20:16:08 efried mordred: I already +1'd the latter. Thanks for that.
20:16:18 mordred \o/
20:16:58 mordred efried: thanks, btw, for your excellent tests of the version normalization code - theymade adding testing here much easier
20:17:12 efried oh, good.
20:17:13 openstackgerrit Dan Smith proposed openstack/nova master: Make service all-cells min version helper use scatter-gather https://review.openstack.org/539590
20:17:14 openstackgerrit Dan Smith proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/539617
20:18:34 jaypipes stephenfin: fyi, finally getting around to reviewing the numa-aware-vswitches spec again.
20:30:27 efried mordred: Reviewed
20:33:05 mordred efried: thank you sir
20:36:46 edleafe Sundar: hi - was away from my desk for a bit
20:38:56 Sundar edlefe, NP. Thanks for reaching out
20:39:01 Sundar *edleafe
20:39:43 Sundar I am trying to understand why nested Resource Provider support is not usable for Cyborg in Rocky. I understand it is incomplete. But could you give me some details or pointers?
20:41:06 edleafe Sundar: here's the current work for getting NRPs in allocation candidates: https://review.openstack.org/#/q/topic:bp/nested-resource-providers-allocation-candidates+(status:open+OR+status:merged)
20:42:01 openstackgerrit Merged openstack/nova master: Handle deprecation of inspect.getargspec https://review.openstack.org/530777
20:42:09 openstackgerrit Merged openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145
20:43:10 edleafe Sundar: so until that series is complete, we can't really begin to use it
20:47:19 Sundar edleafe: It seems to me that https://review.openstack.org/#/c/554529/ is the key one. Others relate to nested+shared RPs etc., which may not be of immediate relevance to Cyborg. Does that sound right?
20:47:28 melwitt takashin: hi, have you seen this ML thread about your blueprint bp/list-show-all-server-migration-types http://lists.openstack.org/pipermail/openstack-dev/2018-April/129736.html ? your response would be appreciated
20:48:32 edleafe Sundar: it's difficult to say which will impact Cyborg.
20:49:05 edleafe Sundar: is 1400 UTC a good time for you? We have the scheduler subteam meeting then
20:49:13 edleafe Sundar: on Mondays
20:50:15 melwitt nova meeting in 10 minutes
20:50:30 Sundar edleafe: Sure, I can make it at 7 am PDT Monday (I am in SF Bay Area).
20:50:46 takashin melwitt: Yes.
20:51:19 Sundar edleafe: Also, this series does not seem to address nested RPs + granular resource requests. Where is that tracked?
20:53:10 edleafe Sundar: hmmm... efried, are you around?
20:53:24 melwitt takashin: okay, cool. if you could send a response to the mailing list, it would be helpful
20:53:31 edleafe Sundar: https://wiki.openstack.org/wiki/Meetings/NovaScheduler
20:53:48 takashin melwitt: okay.

Earlier   Later