| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-26 | |||
| 11:40:56 | kashyap | (You know what it is.) | |
| 11:41:02 | mriedem | testes | |
| 11:41:11 | kashyap | Indeed, :D | |
| 11:41:54 | efried | We *could* patch mox3 -- to use mock. | |
| 11:42:11 | efried | surely somebody's done that somewhere. | |
| 11:42:13 | mriedem | it looks like it's usage is best effort and optional | |
| 11:42:25 | mriedem | for inspect.getargspec | |
| 11:42:41 | mriedem | so easy thing would just be adding an "if six.PY3: raise ValueError()" | |
| 11:42:57 | mriedem | anywho, the warnings filter is low priority now | |
| 11:43:20 | efried | Yeah, totally. But leaving the patch open is goodness. And we can revisit it when mox is all gone. | |
| 11:43:38 | efried | takashin has been doing a good job there. | |
| 11:44:32 | kashyap | mriedem: Morning, meta comment: on your remark here, if you say: "I insist", I'll close it as you prefer. I'm normally mindful of it, but in this instance I'd prefer to track it via LP bug too: https://bugs.launchpad.net/nova/+bug/1766208 | |
| 11:44:32 | openstack | Launchpad bug 1766208 in OpenStack Compute (nova) "Lift the restriction on choices for `cpu_model_extra_flags` config attribute" [Undecided,In progress] - Assigned to Kashyap Chamarthy (kashyapc) | |
| 11:44:50 | kashyap | See my last comment, before you say the phrase :-) | |
| 11:45:17 | kashyap | And thanks for the actual substantial review, though! _That_ appreciate the most | |
| 11:45:34 | mriedem | kashyap: i insist | |
| 11:46:13 | kashyap | Heh, okay; moooooooving on. | |
| 11:51:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle deprecation of inspect.getargspec https://review.openstack.org/530777 | |
| 11:54:18 | mriedem | kashyap: i think you can throw https://review.openstack.org/#/c/563926/ into runways | |
| 11:54:25 | mriedem | pickings in the queue are starting to get slim | |
| 11:54:30 | mriedem | for non-blocked things | |
| 11:55:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a warnings filter for inspect.getargspec usage https://review.openstack.org/564343 | |
| 11:59:27 | kashyap | mriedem: Hi, will click in a min; making some quick late lunch | |
| 12:00:07 | kashyap | mriedem: Do you have a (non-null) pointer as to how I can "throw it into a runway"? If you have to look up too, disregard; I'll get to it | |
| 12:00:34 | efried | kashyap: https://etherpad.openstack.org/p/nova-runways-rocky | |
| 12:00:50 | efried | kashyap: Add it at the bottom of the queue (L89) | |
| 12:01:56 | kashyap | Gracias | |
| 12:02:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove explicit instance.info_cache.delete() https://review.openstack.org/563689 | |
| 12:03:32 | kashyap | Done | |
| 12:03:35 | kashyap | Thanks, Eric! | |
| 12:05:01 | efried | yahyoubetcha | |
| 12:15:22 | kashyap | Has anyone here tinkered with modifying the 'post-config' for Nova here: http://git.openstack.org/cgit/openstack-dev/devstack/tree/.zuul.yaml#n281 | |
| 12:17:15 | mriedem | sean-k-mooney[m]: i think https://review.openstack.org/#/c/551370/ is ready for your review. i've confirmed via the live migration CI run in the patch at the top of the series that enables this code that it's hitting _update_vif_xml correctly and linked the logs inline | |
| 12:17:32 | mriedem | sean-k-mooney[m]: however, note the TODO i have in here https://review.openstack.org/#/c/551370/19/nova/virt/libvirt/migration.py@252 | |
| 12:17:36 | mriedem | about vif type changing | |
| 12:18:01 | mriedem | remember we talked about whether we could just ignore the original source_vif and just get a new vif config based on the destination vif to generate the new xml *except* for the pci address? | |
| 12:18:22 | mriedem | the problem with that is, the source_vif contains the 'network' info in the vif, which is what we need for things like source bridge and target dev | |
| 12:18:36 | mriedem | so can we even have vif type changes for a vif on the same network? | |
| 12:19:54 | mriedem | sean-k-mooney[m]: what i really need is a 2-node deployment where i've got ovs on one node and linuxbridge on another, and live migrate between them, but getting that setup would probably take me awhile - i'm not sure how easily devstack can be configured to tell the subnode to use linuxbridge when the controller is configured for ovs (but doesn't neutron server by default support ML2 ovs and LB agents?) | |
| 12:28:18 | openstackgerrit | Matthew Booth proposed openstack/nova master: Simplify BDM boot index checking https://review.openstack.org/564480 | |
| 12:28:25 | kashyap | mriedem: Re-thinking on your comment here on the confusion of `diff`s: https://review.openstack.org/#/c/563926/3/nova/tests/unit/virt/libvirt/test_driver.py@6418 | |
| 12:28:49 | kashyap | mriedem: I added it in the existing way because it keeps all the *_custom* tests together | |
| 12:29:10 | mdbooth | mriedem: ^^^ it was a simple bug. Refactor remains worth it imho, as the old code is mind-bendingly obtuse. | |
| 12:29:51 | kashyap | So someone reading the test along will feel less "cognitive load" if I don't randomly add the new '_multiple_extra_flags' test _after_ '_host_model_with_extra_flags' | |
| 12:31:50 | mriedem | mdbooth: ack | |
| 12:33:06 | kashyap | mriedem: Disregard me until the new iteration passes tests; I still have rearranging to do. | |
| 12:39:28 | openstackgerrit | Martin Midolesov proposed openstack/nova master: Validating video ram against the max video ram allowed https://review.openstack.org/564193 | |
| 12:51:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | |
| 12:51:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | |
| 12:51:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | |
| 12:51:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | |
| 12:51:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 12:51:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | |
| 13:18:04 | Tahvok | Hey guys! Is it possible to request a release for ocata branch? | |
| 13:18:24 | mriedem | Tahvok: i think that's already up | |
| 13:18:35 | mriedem | https://review.openstack.org/#/c/564044/ | |
| 13:19:40 | Tahvok | Oh, nice! I was waiting for some fix to be realesed for a couple of months now :) | |
| 13:19:44 | Tahvok | Thanks! | |
| 13:21:14 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Lift the restriction of choices for `cpu_model_extra_flags` https://review.openstack.org/563926 | |
| 13:26:20 | mordred | mriedem, jaypipes: how hard/expensive would it be to return a total count of objects for paginated collections? | |
| 13:27:32 | mordred | (just got a question about being able to get a count of items without having to loop over the iterator in the sdk - but we can't do it because pagination... thought I'd check to see how insane it would be to get that added | |
| 13:29:30 | cdent | mordred: you're after a 'total' bit of metadata? | |
| 13:30:07 | mordred | cdent: yah. atleast, maybe I'm after a total bit of metadata | |
| 13:30:42 | mordred | cdent: I'm honestly not sure how muchit's a thing I want - but cost of implementation probably impacts how much I want it :) | |
| 13:31:15 | cdent | I know how that can be. I'm afrait that I'm not familiar with the pagination handling in nova's api, so can't provide any quick and dirty guess | |
| 13:34:03 | jaypipes | mordred: it would be a total refactoring of the pagination system. | |
| 13:34:19 | mordred | jaypipes: awesome.then I don't want it | |
| 13:34:23 | jaypipes | ha | |
| 13:36:36 | openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming https://review.openstack.org/486475 | |
| 13:36:37 | openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: document change for supporting image handler https://review.openstack.org/563077 | |
| 13:37:31 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | |
| 13:38:09 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Support inherit api samples in ApiSampleTestBase https://review.openstack.org/562547 | |
| 13:46:11 | openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: document change for supporting image handler https://review.openstack.org/563077 | |
| 13:51:45 | mriedem | right we don't return a total in the links response today, | |
| 13:51:56 | mriedem | and...we also limit the responses by default to 1000 | |
| 13:52:09 | mriedem | so based on that, the total we give might not be the actual total number of that resource in the db | |
| 13:52:22 | mriedem | well, you can pass in limit | |
| 13:56:02 | openstackgerrit | Merged openstack/nova master: ServerActionsSampleJsonTest refactor https://review.openstack.org/561819 | |
| 13:58:56 | openstackgerrit | Merged openstack/nova stable/queens: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564454 | |
| 14:13:34 | mriedem | kashyap: some small things to cleanup in https://review.openstack.org/#/q/topic:bump_min_libvirt_and_qemu+status:open | |
| 14:13:48 | kashyap | mriedem: Will look | |
| 14:14:17 | kashyap | mriedem: On that other patch of `cpu_model_extra_flags` -- while context is fresh, a functional change comment: | |
| 14:14:52 | kashyap | mriedem: I was just talking to QEMU / libvirt folks, and I was reminded that allowing / removing extra flags even for 'host-passthrough' mode makes sense. Why? An example: | |
| 14:15:23 | kashyap | (a) An Operator might want to explicitly disable nested virt for a Nova guest; then they can remove 'vmx' CPU flag | |
| 14:16:22 | kashyap | (b) QEMU may disable some features unless you explicitly ask for them (like: "invtsc" CPU flag) -- in that case it makes sense to explicitly specify the flag | |
| 14:16:29 | kashyap | I'll add a note in the code for a future patch. | |
| 14:16:55 | kashyap | Or after some thinking ... I might add it in the current patch. Haven't decided yet | |
| 14:17:06 | openstackgerrit | Eric Fried proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | |
| 14:17:50 | efried | mriedem: This should be a quick +A (trivial changes since your prior +2) ^ | |
| 14:19:16 | mriedem | kashyap: if you're going to drop the model restrictions when dropping the choices restriction, it'd be best to do that in the same change so you're not having to dump multiple feature release notes on people for the same config option | |
| 14:19:41 | mriedem | i will have to take your word on the host-passthrough thing | |
| 14:20:11 | kashyap | Yeah, exactly -- I too don't like find it appealing to make the feature release notes muddly | |
| 14:20:19 | openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | |
| 14:20:53 | kashyap | mriedem: You don't have to; I can provide a minimal functional test case you can try yourself on a linux laptop | |
| 14:21:06 | kashyap | With bare QEMU. That demonstrates it. | |
| 14:22:51 | kashyap | mriedem: Sorry about this one: https://review.openstack.org/#/c/564013/3/nova/virt/libvirt/driver.py | |
| 14:22:59 | openstackgerrit | Dan Smith proposed openstack/nova master: Make service all-cells min version helper use scatter-gather https://review.openstack.org/539590 | |
| 14:23:00 | openstackgerrit | Dan Smith proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/539617 | |
| 14:23:05 | kashyap | mriedem: Mixed up versions there; it's for Stein | |
| 14:23:13 | dansmith | mriedem: ^ | |