| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-23 | |||
| 13:48:17 | openstackgerrit | Dan Smith proposed openstack/nova master: DNM: Test virtio queue sizes https://review.openstack.org/563626 | |
| 13:48:23 | dansmith | sahid: ^ | |
| 13:49:06 | sahid | dansmith: oh... smart :) | |
| 13:49:47 | cdent | scheduler meeting #openstack-meeting-alt in ten minutes | |
| 13:49:53 | bauzas | hkominos: well, not sure I understant your question, you're asking if Nova should provide an empty pci slot anyway? | |
| 13:50:35 | kashyap | As a second pair of eyes to MattR, can anyone else be able to take a look at this: https://review.openstack.org/#/c/558783/ | |
| 13:53:35 | hkominos | bauzas:yes | |
| 13:54:13 | hkominos | bauzas:I think it does provide one anyway but I need one more. | |
| 13:54:23 | bauzas | hkominos: well, I don't know why, so you should ask for that by a blueprint | |
| 13:54:28 | tssurya | dansmith: if I want to populate a newly added column (say queued_for_delete), based on existing data from another column (say instances.deleted), what is the best way of doing this ? -> migration tool (seems to be the usual way in the past) ? or is there a way to do this while adding the new column ? | |
| 13:55:01 | dansmith | tssurya: doing it while adding the column should not be done because it can lock the table and be a problem for pre-applying schema | |
| 13:55:17 | dansmith | tssurya: if you can, the best way is on loading/saving the object out of the db | |
| 13:55:48 | dansmith | tssurya: so in _from_db_obj or something like that, set the field on the loaded object so it will be saved later, optionally saving it right then if you need it to be saved immediately | |
| 13:55:59 | tssurya | dansmith: oh okay, yep will go that way then | |
| 13:56:15 | dansmith | tssurya: example: https://github.com/openstack/nova/blob/master/nova/objects/service.py#L259-L264 | |
| 13:56:22 | dansmith | that was how we generated uuids on the service objects | |
| 13:56:57 | tssurya | dansmith: thanks | |
| 13:57:19 | tssurya | I will use this approach | |
| 14:04:19 | sean-k-mooney | sahid: the nfv cis are corntolled by internal repos in intel. you wont be able to change the test setup. you will however be able to hardcode the use of a queue lenght in nova in a DNM patch and get the same effect | |
| 14:05:59 | stephenfin | bauzas: All comments addressed here. Fancy hitting it again? https://review.openstack.org/#/c/379525/ | |
| 14:06:20 | bauzas | stephenfin: yup, I can sneak peek on it | |
| 14:06:42 | sean-k-mooney | sahid: we might be able to change the setup via a patch to networking-ovs-dpdk to add a local.sh or late running section to the devstack pluging to alter the flavors used by the ci but i would need to look into that. | |
| 14:08:45 | sahid | sean-k-mooney: ok thanks | |
| 14:09:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add policy rule to block image-backed servers with 0 root disk flavor https://review.openstack.org/561284 | |
| 14:14:04 | kashyap | Can anyone remind me what is the way to recheck this job: 'legacy-tempest-dsvm-multinode-live-migration' | |
| 14:17:11 | kashyap | Seems like I'm hitting a problem that is related to the CI env: http://logs.openstack.org/12/562312/4/check/legacy-tempest-dsvm-multinode-live-migration/88f1334/job-output.txt.gz | |
| 14:26:14 | mriedem | kashyap: you can't recheck specific jobs | |
| 14:26:22 | mriedem | you just leave a 'recheck' comment | |
| 14:26:58 | kashyap | mriedem: Yeah, that I'm aware. Just thought I'd check if I can avoid a "full blown recheck" | |
| 14:27:16 | kashyap | (To be mindful to not cause needless CI churn.) | |
| 14:27:58 | mriedem | mnaser: i got https://review.openstack.org/#/c/561284/ updated to use a policy rule instead of a config option, this is the thing to disable booting from a 0 root disk flavor if you're not doing bfv | |
| 14:29:31 | openstackgerrit | Merged openstack/nova master: libvirt: Add a debug log entry before / after invoking migrate() https://review.openstack.org/563550 | |
| 14:29:38 | openstackgerrit | Merged openstack/nova master: Mention that users need noVNC >= 0.6 https://review.openstack.org/562847 | |
| 14:30:30 | kashyap | mriedem: When you have time this week: Zuul blessed this, and I've addressed your remarks: https://review.openstack.org/#/c/558783/ (libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky") | |
| 14:33:37 | mriedem | was just looking at it | |
| 14:39:34 | kashyap | Thanks. | |
| 14:40:02 | kashyap | stephenfin: efried: Thanks for the quick review (commit: 880f628)! | |
| 14:40:20 | efried | kashyap: yahyoubetcha. Easy one. | |
| 14:41:19 | kashyap | efried: More context on that is - before that commit, it was incredibly difficult to tell if that migrate() method has run or not | |
| 14:41:31 | efried | I get it. | |
| 14:42:23 | efried | kashyap: Mainly, I get credit for a libvirt review I can point to so people don't accuse me of being PowerVM/IBM-centric. | |
| 14:42:25 | kashyap | Although there's a comment snuck in to Eventlet schedule a new thread, but that's too subtle | |
| 14:42:33 | kashyap | efried: Hehe | |
| 14:43:01 | efried | kashyap: I'm counting on major brownie points from this series: https://review.openstack.org/560444 | |
| 14:43:02 | kashyap | efried: Don't worry, I'll send more your way; mechanical clean up of constants :P | |
| 14:43:20 | mnaser | mriedem: nice patch, is there a way we can track things like "things to do for next release" ? | |
| 14:43:24 | kashyap | Until you might get sick of it :P (Once Matt merges the earlier MIN_ bump) | |
| 14:43:51 | mriedem | mnaser: we don't have anything formal for that besides the TODOs in the code | |
| 14:45:14 | mnaser | i see | |
| 14:45:44 | kashyap | efried: Interesting. Have to still educate myself on that (ProviderTree stuff) | |
| 14:46:36 | efried | kashyap: Let me know if you want help there. We wrote a nice contributor doc - maybe since you claim to be fresh, you could scan it and let me know if it gives you what you need... | |
| 14:46:46 | kashyap | efried: I don't claim to be fresh :P | |
| 14:47:14 | kashyap | efried: But yeah, got a URL to that doc? | |
| 14:47:29 | efried | kashyap: working on that (I pretty much suck at searching the docs) | |
| 14:47:45 | kashyap | Aah, I see. The past tense word "wrote" made me think it's already in tree | |
| 14:48:31 | efried | kashyap: It is. | |
| 14:48:37 | efried | kashyap: Mahbad, it's a reference doc: https://docs.openstack.org/nova/latest/reference/update-provider-tree.html | |
| 14:49:17 | efried | kashyap: So yeah, in recompense for that two-line review, you get to read my doc and give me feedback. | |
| 14:49:25 | efried | kashyap: No mistake, you got the raw end of that deal. | |
| 14:50:28 | kashyap | efried: Hehe, oh on the first look, I appreciate the structure & detail. This needs a bit of concentration to read cover-to-cover; queued it. | |
| 14:50:57 | efried | kashyap: thanks in advance | |
| 14:51:59 | kashyap | efried: A quick question -- do you also do "hypervisor stuff" with PowerVM / IBM (z)? | |
| 14:52:44 | kashyap | (This bit: https://www-03.ibm.com/systems/power/software/linux/powerkvm/) | |
| 14:52:46 | efried | kashyap: I know nothing from z. | |
| 14:52:57 | efried | kashyap: And PowerKVM != PowerVM. I know nothing about the former. | |
| 14:53:53 | efried | kashyap: And depending what you mean by "hypervisor" - I get kinda close. I at least have first-order contact with people who do the nuts and bolts. | |
| 14:54:02 | kashyap | Oops, sorry for the mix-up | |
| 14:54:10 | kashyap | (Nod) | |
| 14:54:10 | efried | Yeah, I'm sorry too. | |
| 14:54:23 | efried | It didn't need to be that confusing. | |
| 14:54:28 | efried | But you know branding/marketing folk. | |
| 14:54:42 | kashyap | Hehe, totally | |
| 14:54:55 | kashyap | efried: The KVM author still regrets the name of it, I hear... | |
| 14:55:20 | kashyap | https://en.wikipedia.org/wiki/KVM_switch vs. https://en.wikipedia.org/wiki/Kernel-based_Virtual_Machine | |
| 14:57:11 | efried | gibi, mriedem: FYI: https://review.openstack.org/#/c/561724/ | |
| 14:59:26 | kashyap | mriedem: Hmm, you gave +2, but you noted a whitespace nit & the needless comment. Respinning to remove the needless cruft. | |
| 15:02:44 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | |
| 15:02:45 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Drop MIN_LIBVIRT_SET_ADMIN_PASSWD https://review.openstack.org/562312 | |
| 15:05:07 | efried | gibi: That last low-priority bug with the abandoned patches - I didn't look deeply, but does that qualify as low-hanging fruit? | |
| 15:07:45 | kashyap | Remind me again, if I update the commit message, will I "lose" the +2? | |
| 15:08:49 | kashyap | (Only one spurious comma this time, though) | |
| 15:09:19 | stephenfin | kashyap: You will, yup | |
| 15:09:37 | kashyap | Okay, I'll leave it as is, not worth to bother reviewers about it | |
| 15:09:38 | stephenfin | If it's not a bigger issue, you're usually better of just leaving it unless someone else comments on that or something else | |
| 15:09:53 | stephenfin | (If it was a bigger issue, you wouldn't have got the +2) | |
| 15:09:54 | kashyap | Yeah, it's not an issue all, only OCD. | |
| 15:10:58 | kashyap | stephenfin: Okido; sorry for the bait, but since you like clean-up patches, you might be the second +2er: https://review.openstack.org/#/c/558783/ | |
| 15:11:38 | sahid | dansmith: the intel ci just finished, that looks to be OK | |
| 15:16:10 | stephenfin | kashyap: Ooh, for sure | |
| 15:16:16 | bauzas | stephenfin: jaypipes: dansmith: efried: FWIW, given all the convos we had about https://review.openstack.org/#/c/557065/2/specs/rocky/approved/vgpu-rocky.rst, I'm about to write a patch that'd show some dynamic group usage | |
| 15:16:22 | kashyap | Gracias | |
| 15:16:25 | stephenfin | bauzas: I've it done | |
| 15:16:40 | bauzas | stephenfin: where ? I could do the same | |
| 15:16:41 | stephenfin | :) | |
| 15:16:45 | stephenfin | sec | |
| 15:16:58 | stephenfin | bauzas: https://github.com/stephenfin/nova/commit/58b53e888feb146123087f2e3f54f677f1fdccdc | |
| 15:16:58 | bauzas | or make it generic | |
| 15:17:33 | stephenfin | (I haven't pushed it to Gerrit yet because it's not end-to-end tested and I don't want to swamp the CI as I iterate) | |
| 15:17:34 | dansmith | sahid: yep, cool | |
| 15:18:20 | bauzas | stephenfin: I'm not sure we should dynamicall add the groups in nova/config | |