Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-20
10:19:14 kashyap Saw that. artom -- it's not my patch's problem, is it
10:19:20 artom Doesn't look related to your patch
10:19:28 kashyap Phew, thanks for looking
10:19:43 kashyap I'm just going a little mental at looking all the non-Zuul CI stuff that's failing
10:19:52 artom I mean, I know fsck all about zvm
10:19:54 kashyap And ending up at the conclusion that it's unrelated to what I'm doing
10:20:01 kashyap :D
10:20:03 artom But that looks like our "can't connect to libvirt" error message
10:23:02 openstackgerrit Tovin Seven proposed openstack/python-novaclient master: Trivial: Update pypi url to new url https://review.openstack.org/563060
10:23:18 kashyap Oh
10:28:10 openstackgerrit Merged openstack/nova stable/ocata: Handle spawning error on unshelving https://review.openstack.org/548622
10:29:04 openstackgerrit Merged openstack/nova stable/ocata: Increase cpu time for image conversion https://review.openstack.org/562145
10:38:40 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: deprecate the config for image handler class path https://review.openstack.org/497201
10:38:41 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming https://review.openstack.org/486475
10:42:24 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: WIP: complex policy https://review.openstack.org/553776
11:06:50 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: document change for supporting image handler https://review.openstack.org/563077
11:29:00 openstackgerrit Chris Dent proposed openstack/nova master: Fix link in placement contributor doc https://review.openstack.org/563086
11:29:19 cdent stephenfin, fried_rice : trival doc fix ^
11:29:28 fried_rice ...
11:30:59 fried_rice cdent: Either that should have failed sphinx build previously, or there's a dummy target in the doc somewhere
11:31:09 fried_rice ...but I can't find the latter; and clearly the former didn't happen
11:31:12 fried_rice So /me confused.
11:31:14 cdent yeah, I dunno
11:31:45 cdent I figured I would just fix it
11:32:23 cdent fried_rice: might have been before warnings were made errors?
11:32:51 fried_rice That's been a while, and this was recent.
11:33:03 fried_rice Maybe warnings-as-errors is only in place for the placement docs?
11:35:10 fried_rice indeed 'unknown target name' before this fix.
11:35:16 fried_rice (in my IDE)
11:35:18 fried_rice building...
11:37:06 cdent which IDE do you use fried_rice ?
11:37:11 fried_rice pycharm
11:37:41 fried_rice fyi, openstack has licenses for the pro edition
11:38:05 fried_rice though tbh I haven't noticed much of a difference. (I probably just don't use the features that are enabled in pro)
11:40:51 cdent I'm old and inelastic enough that the I want to carry on using vim until I die. I was surveying out of curiosity, not seeking
11:42:34 cdent "that the I want" don't know what I was trying to say there
11:44:05 fried_rice cdent: Do you have a bunch of customizations and stuff in your vim?
11:44:13 fried_rice Anything python-specific beyond syntax coloring?
11:45:07 openstackgerrit Surya Seetharaman proposed openstack/nova master: Delete orphaned RS and IM records of archived instances https://review.openstack.org/560042
11:45:43 openstackgerrit Nguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build https://review.openstack.org/551802
11:46:15 cdent no, not really. I'm not much of a customizer. And if it wasn't there already in a sort of semi-automatic fashion, I'd not turn on the syntax coloring. The main things I care about are auto-indent and paren matching. And since nova uses such a bad indent style, I'm not getting much help from my editor on that front (I could fix my editor to behave better, but haven't got around to it)
11:49:10 fried_rice cdent: I love vim just fine, but IDE ability to jump from a symbol to its definition, find all usages of a method, jump directly to method overrides, search for symbols by (wildcarded) name, see class/method/attribute overview trees, etc. -- all pretty serious productivity boosters for me.
11:49:28 cdent tags
11:50:01 fried_rice There was a time I used to be able to do interactive debugging, but it didn't (used to) work in the nova project, and I haven't tried it recently or tried to fix it.
11:50:24 fried_rice Do you tag the whole project?
11:50:47 cdent fried_rice: do you ever wonder or worry if IDE superpowers can result in code that is harder for other people to read/maintain?
11:51:08 cdent when I use them, yes, but I frequently don't
11:51:14 cdent because I don't need/want to
11:51:51 fried_rice cdent: You mean because I'd be less inclined to write new stuff in sensible locations because I know I can always navigate by hotkey?
11:52:37 cdent not just that, not just about navigation, and not really anything in particular: more just "do you think about that?"
11:52:41 fried_rice Given formatting restrictions (which pycharm also validates on the fly) I'm not sure what other pitfalls there might be.
11:52:52 cdent me neither, just noodling
11:53:11 fried_rice And given our review process, I would expect people to gripe if stuff was in the wrong place.
11:53:38 cdent Yeah, I'm not really thinking about issue of where code is
11:53:55 cdent More about the actual code itself: how it is written, how it is structured internally to itself
11:54:23 fried_rice Mm. No, I don't feel like I would do any of that differently in a primitive editor.
11:54:56 fried_rice If code generation were a thing, I could see that being an issue (though I would also expect that to get filtered by reviewers)
11:55:19 fried_rice So like, if this was Java, and I was using "generate a bean" or whatever.
11:56:07 fried_rice But - whether because I just don't know about / use the code generation features, or they don't exist, or they wouldn't apply to the kind of dev we do in openstack, or whatever - I don't use any code gen tools in my IDE.
11:56:59 fried_rice btw, I tried quick-building that doc and apparently my venv wasn't set up, so I'm going through tox.... and the venv is *still* installing deps.
11:57:22 fried_rice Which says to me that we're installing the wrong set of deps for building docs.
11:58:04 fried_rice I think stephenfin has some patches that clean some of that up. But I think they just consolidate some of the venvs. Not sure whether docs was folded into one of the others.
11:58:37 cdent the gate now builds docs outside of the 'docs' venv that can be used locally
11:59:00 cdent but yes, the deps are probably wrong. probalby building nova deps, not docs deps
12:04:38 openstackgerrit sahid proposed openstack/nova master: libvirt: don't set interface backend for vhostuser https://review.openstack.org/562708
12:04:39 openstackgerrit sahid proposed openstack/nova master: libvirt: fix wrong driver name for vhostuser interface https://review.openstack.org/561562
12:04:40 openstackgerrit sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997
12:06:27 sahid giblet: i added a test i hope it's what you were looking for
12:11:15 frickler melwitt: gah, if you had created a bug for https://review.openstack.org/561370 it might have saved me searching half a day to come to the same result. but then maybe not, so no hard feelings ;)
12:11:55 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: WIP: complex policy https://review.openstack.org/553776
12:12:19 openstackgerrit sahid proposed openstack/nova master: libvirt: fix wrong driver name for vhostuser interface https://review.openstack.org/561562
12:12:20 openstackgerrit sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997
12:12:51 neha_alhat stephenfin: Hi
12:16:08 bauzas folks, I'm half-around
12:16:22 bauzas my wife is in ER, so I'll help her
12:17:07 fried_rice bauzas: Hope everything is okay
12:17:14 neha_alhat stephenfin: Actually I want to know why these two conf parameters regrading live migration are made mutable in[1]. [1]:https://review.openstack.org/#/c/319203/
12:19:47 bauzas fried_rice: hope so
12:22:08 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: WIP: complex policy https://review.openstack.org/553776
12:27:42 stephenfin fried_rice: Yeah, I need to pick those up again and rebase them
12:28:03 stephenfin Especially now, given the whole "move everything to python3" initiative
12:28:04 stephenfin Also
12:28:31 finucannot neha_alhat: What do you mean?
12:28:54 openstackgerrit Jens Harbott (frickler) proposed openstack/nova master: DNM: Test devstack + ceph plugin patches https://review.openstack.org/563097
12:28:56 fried_rice finucannot: Do you happen to know offhand why a doc containing a `link`_ with a missing _`target` would have passed sphinx build?
12:29:13 fried_rice Is that warning not fatal in the nova repo?
12:29:24 fried_rice I thought it was, but maybe I'm thinking of the nova-specs repo
12:29:45 finucannot fried_rice: I bet it fails locally https://review.openstack.org/#/c/559348/
12:30:32 fried_rice oh, I remember seeing that patch.
12:30:51 neha_alhat finucannot: why only these parameters are marked mutable=True? why not others? Is there any criteria to make conf parameters as mutable?
12:31:00 finucannot fried_rice: Yeah, ima go bug infra guys and see if we can get some movement on it
12:31:05 fried_rice finucannot: But so the answer is that the gate won't fail on those for now?
12:31:23 finucannot fried_rice: Correct, and there's nothing we can do to override that
12:31:32 finucannot Save a custom extension or something
12:32:41 finucannot neha_alhat: Things are generally mutable if you it's something that you feel you'd want to change at runtime (and actually can without breaking stuff)
12:32:49 finucannot I guess this was one of those things
12:33:12 finucannot neha_alhat: tbh, I don't have the full context and the commit message is poor so I can't really say what the authors intention was
12:33:31 finucannot This is why one should always write mdbooth-level commit messages :)
12:35:10 fried_rice finucannot: I'm +2ing cdent's https://review.openstack.org/#/c/563086/ - after having checked the rendered doc because apparently I can't rely on sphinx for this one...
12:35:46 finucannot fried_rice: I've +Wd it

Earlier   Later