| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-19 | |||
| 16:29:04 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | |
| 16:29:20 | openstackgerrit | zhangyangyang proposed openstack/nova master: Deprecate auth_uri option https://review.openstack.org/562537 | |
| 16:30:17 | cfriesen | mriedem: melwitt: Do we want to address bug 1764556? If so, is there a better option than changing the online data migration in Pike to add UUIDs to deleted services? | |
| 16:30:17 | openstack | bug 1764556 in OpenStack Compute (nova) queens ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,Confirmed] https://launchpad.net/bugs/1764556 | |
| 16:30:56 | cfriesen | it does require a pretty specific set of actions to reproduce | |
| 16:31:24 | efried | lyarwood: That does seem to be the only possible culprit. Haven't figured out how/why yet, though. | |
| 16:31:38 | efried | lyarwood: Can we propose a revert and see if it fixes? | |
| 16:33:18 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: Revert "Proper error handling by _ensure_resource_provider" https://review.openstack.org/562739 | |
| 16:33:26 | lyarwood | efried: ^ sure, there you go | |
| 16:33:31 | efried | lyarwood: ack | |
| 16:33:46 | mriedem | does that cause CI failures or just ugly logs? | |
| 16:33:55 | mriedem | because https://review.openstack.org/#/c/525309/ itself didn't fail CI | |
| 16:33:56 | lyarwood | efried: and thanks, that was a guess given the change history tbh | |
| 16:34:15 | mriedem | cfriesen: we usually want to fix bugs | |
| 16:34:39 | efried | lyarwood: Right, I'm not basing my opinion on anything deeper at the moment. | |
| 16:35:24 | lyarwood | mriedem: that last check run was in 2017 | |
| 16:35:37 | mriedem | lyarwood: it ran through the gate yesterday though | |
| 16:35:39 | lyarwood | mriedem: so maybe this change and another are causing this? | |
| 16:36:06 | lyarwood | mriedem: ah yeah true sorry | |
| 16:36:11 | mriedem | https://review.openstack.org/#/q/openstack/nova+status:merged+branch:stable/ocata | |
| 16:40:04 | cfriesen | mriedem: just thought I'd check given the specific sequence of events needed. I appreciate the time you spent getting the functional test going. | |
| 16:40:55 | efried | jeez, how far back could we go? Are we sure that same exception trace isn't showing up everywhere? | |
| 16:41:02 | openstackgerrit | Merged openstack/python-novaclient stable/pike: Use generic user for both zuul v2 and v3 https://review.openstack.org/562500 | |
| 16:42:35 | mriedem | it's not in http://logs.openstack.org/09/525309/1/gate/legacy-tempest-dsvm-neutron-full/ddcc396/logs/screen-n-cpu.txt.gz which was from the gate run | |
| 16:43:51 | mriedem | i don't see anything else remotely close to that same code though in here https://github.com/openstack/nova/commits/stable/ocata | |
| 16:46:35 | melwitt | cfriesen: I agree we need to fix it, just not sure how yet | |
| 16:48:22 | cfriesen | I think tweaking the online data migration for services would prevent the one scenario we know about. the question is whether we need something to deal with clouds that have already upgraded to pike | |
| 16:54:06 | melwitt | yeah. not sure | |
| 17:08:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | |
| 17:08:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Leave a hint when populate_schema fails https://review.openstack.org/562757 | |
| 17:20:17 | cfriesen | mriedem: for "Add request_id to instance action notifications", why are we bumping the version for nova / doc/notification_samples/common_payloads/InstanceActionPayload.json (and other similar ones where the version is the only change)? | |
| 17:21:20 | efried | cfriesen: base class? | |
| 17:22:02 | efried | cfriesen: Sorry, to explain that comment: The request ID is being added in a base class, so all derived classes need to bump. | |
| 17:24:41 | openstackgerrit | melanie witt proposed openstack/nova stable/ocata: Stop globally caching host states in scheduler HostManager https://review.openstack.org/539013 | |
| 17:28:02 | cfriesen | efried: okay, that makes sense. I missed the implications of the logical reference to InstancePayload.json in InstanceActionPayload.json | |
| 17:29:22 | melwitt | looks like the next PTG is gonna be at HOOOOONNNNNNKKKKKK again | |
| 17:31:00 | cfriesen | they must have gotten a really good deal there | |
| 17:31:49 | jaypipes | melwitt: and double the price. | |
| 17:32:01 | melwitt | that too | |
| 17:32:37 | mriedem | remember, if your room is loud, make sure the window is closed | |
| 17:32:46 | edleafe | The Foundation doesn't think that developer productivity is worth spending money on | |
| 17:33:01 | jaypipes | apparently the train honking situation has been fixed. | |
| 17:33:31 | mriedem | "All aboard! Next stop Denver!" is pretty funny though | |
| 17:33:38 | jaypipes | indeed. | |
| 17:37:55 | mriedem | well this doesn't look good http://grafana.openstack.org/dashboard/db/zuul-status?panelId=19&fullscreen | |
| 17:38:46 | efried | if you say so | |
| 17:38:59 | mriedem | is the total drop out normal? maybe it is. | |
| 17:39:02 | melwitt | what does taht mean | |
| 17:39:13 | mriedem | i've just been noticing that stuff is sitting in the queue for awhile | |
| 17:39:36 | mriedem | i'm watching lee's revert on ocata | |
| 17:41:51 | melwitt | yeah, online vs accepting. I would have thought online means "has the ability to accept" so the drop means things no longer being accepted. but why | |
| 17:42:45 | efried | Oh, I would have thought 0 means "we're all busy doing stuff right now" and the worrisome part would be when the line is all the way at the top ("there's nothing in the gate at the moment" - which does that ever happen, ever??) | |
| 17:48:50 | melwitt | asking in -infra. inquiring minds want to know | |
| 17:57:44 | efried | dansmith: Not sure if you've been following the ML thread, but you're one likely to have a strong opinion, so can I pester you for the second nod? https://review.openstack.org/#/c/562687/ | |
| 17:58:36 | dansmith | efried: honestly I'm a little worn out on that stuff | |
| 17:59:36 | efried | dansmith: Aren't we all | |
| 18:10:00 | mriedem | arvindn05: done https://review.openstack.org/#/c/560718/ | |
| 18:11:31 | openstackgerrit | Merged openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925 | |
| 18:17:52 | melwitt | this looks like something we might want to get in before novaclient release https://review.openstack.org/#/c/424256 | |
| 18:19:12 | melwitt | not sure if all the concerns from the -1 got answered, but it was updated this morning | |
| 18:33:31 | melwitt | mriedem: wanna double check this osc-placement release patch pls? https://review.openstack.org/#/c/56278 | |
| 18:35:41 | mriedem | melwitt: wrong patch | |
| 18:35:47 | mriedem | https://review.openstack.org/#/c/562787/ | |
| 18:35:54 | mriedem | RIP hartsocks | |
| 18:36:07 | melwitt | aw | |
| 18:36:29 | melwitt | I failed at copy-pate | |
| 18:36:32 | melwitt | *paste | |
| 18:36:34 | melwitt | and typing | |
| 18:37:54 | melwitt | efried, jaypipes: did y'all want to get these two things in before os-traits release today? https://review.openstack.org/546713 and https://review.openstack.org/553277 | |
| 18:38:21 | melwitt | or is it cool to just go ahead | |
| 18:38:56 | efried | It looks like we want gibi to sign off on the former | |
| 18:43:48 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: [CLI] Fix token auth type https://review.openstack.org/424256 | |
| 18:44:01 | mriedem | melwitt: +2 on ^ | |
| 18:44:23 | melwitt | ack | |
| 18:47:18 | jaypipes | melwitt: can't merge https://review.openstack.org/#/c/546713/ until mriedem signs off in. The proposed supports_recreate capability would be changed to supports_evacuate by mdbooth's patch. | |
| 18:47:48 | mriedem | there is no supports_recreate capability in that os-traits patch | |
| 18:47:49 | jaypipes | melwitt: never mind... I forgot I didn't put supports_recreate in there. | |
| 18:48:39 | jaypipes | melwitt: either way, since I proposed the patch, someone else needs to +2. | |
| 18:49:17 | jaypipes | melwitt: as for the CPU max display heads one, I'm already +2 on it. | |
| 18:49:21 | jaypipes | GPU... | |
| 18:49:56 | melwitt | yeah, I mean, were those two things important for the release today or are they fine to wait till a future release | |
| 18:50:27 | jaypipes | melwitt: I wouldn't mind having them merged. | |
| 18:50:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Move some tests into nova.tests.unit.notifications.objects.test_instance https://review.openstack.org/562793 | |
| 18:55:46 | mriedem | jroll: does https://bugs.launchpad.net/nova/+bug/1765334 sound familiar to you as something we might have fixed already outside of https://review.openstack.org/#/c/518294/ ? | |
| 18:55:47 | openstack | Launchpad bug 1765334 in OpenStack Compute (nova) "Ironic resource class may not be put into inventory in Pike" [Undecided,New] | |
| 18:55:51 | mriedem | johnthetubaguy_: ^ | |
| 19:02:41 | mriedem | looks like https://github.com/openstack/nova/commit/9ed692bf8c84e0a702536101cd6cb084d33e1c26#diff-6243ddf138dd43ec84fc716722531cb8 | |
| 19:06:19 | jroll | mriedem: sounds like 518294 might need a backport to pike? | |
| 19:07:12 | mriedem | eh, idk | |
| 19:07:23 | jroll | mriedem: or it's a race against the resource tracker | |
| 19:07:36 | melwitt | mriedem: novaclient release patch https://review.openstack.org/#/c/562804 | |
| 19:07:45 | mriedem | https://review.openstack.org/#/c/518294/ is specifically about resource inventory that's not in the compute node, only placement | |
| 19:08:00 | jroll | ah | |
| 19:08:04 | mriedem | in the case of this ironic bug on pike, it's a custom resource class that gets proxied into the node later | |
| 19:08:27 | mriedem | so rather than create the ironic node with a custom resource class, they create the node, then add the resource class, and that doesn't get reported, via nova (RT) into placement | |
| 19:08:55 | jroll | mriedem: don't think it's the commit you linked, though, that one is about nodes with instances, the bug is before an instance is places | |
| 19:08:56 | mriedem | because nova doesn't think that custom resource classes are something worth reporting for inventory i guess, unless a *known* inventory class changes, like VCPU, MEMORY_MB and DISK_GB | |
| 19:09:20 | mriedem | ah yeah | |
| 19:09:36 | mriedem | that's what i asked in the bug, is the node deployed or not which might make it different from dtantsur|pto's patch | |
| 19:09:52 | mriedem | "1. Always reporting the custom resource class for deployed nodes, if present." | |