| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-19 | |||
| 12:20:26 | mriedem | an appropriate follow up for this is probably putting a helper method on the RequestContext itself to tell if it's a real user request | |
| 12:21:00 | mriedem | we have RequestContext.is_user_context but that returns False if is_admin is True | |
| 12:21:50 | gibi | mriedem: I think the appropriate follow up is to merge https://review.openstack.org/#/c/524306 which means we have a proper request_id for periodic tasks as well and therefore we can remove the check from the payload generation | |
| 12:22:55 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: only increment disk address unit for scsi devices https://review.openstack.org/561613 | |
| 12:23:03 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748 | |
| 12:23:52 | openstackgerrit | sahid proposed openstack/nova master: compute: introduce cpu_shared_set option https://review.openstack.org/561912 | |
| 12:23:53 | openstackgerrit | sahid proposed openstack/nova master: libvirt: always pass emulator threads policy https://review.openstack.org/561913 | |
| 12:23:54 | openstackgerrit | sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set https://review.openstack.org/510897 | |
| 12:23:55 | openstackgerrit | sahid proposed openstack/nova master: libvirt: update emulator threads docstring https://review.openstack.org/562565 | |
| 12:24:23 | openstackgerrit | Merged openstack/nova stable/queens: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560142 | |
| 12:24:31 | openstackgerrit | Merged openstack/nova stable/queens: Don't persist RequestSpec.retry https://review.openstack.org/560143 | |
| 12:25:30 | openstackgerrit | sahid proposed openstack/nova master: compute: introduce cpu_shared_set option https://review.openstack.org/561912 | |
| 12:25:31 | openstackgerrit | sahid proposed openstack/nova master: libvirt: always pass emulator threads policy https://review.openstack.org/561913 | |
| 12:25:32 | openstackgerrit | sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set https://review.openstack.org/510897 | |
| 12:25:33 | openstackgerrit | sahid proposed openstack/nova master: libvirt: update emulator threads docstring https://review.openstack.org/562565 | |
| 12:26:47 | openstackgerrit | Merged openstack/nova stable/queens: List instances performace optimization https://review.openstack.org/561715 | |
| 12:28:05 | kashyap | mriedem: Morning, I think this is ready for some review: https://review.openstack.org/#/c/558783/ -- libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" | |
| 12:28:16 | kashyap | mriedem: I'd like to build other compat code clean-up patches based on the above | |
| 12:28:32 | kashyap | Which is the bulk of the change | |
| 12:30:19 | kashyap | (Also my eyes are a bit hazy after arriving at that patch iterating a couple of weeks. A fresh pair of eyes taking a look at it would be nice.) | |
| 12:31:33 | mriedem | kashyap: i can put it in a tab for now | |
| 12:31:59 | kashyap | Merci. Some look at it and comments will give me a bit more push to fix whatever stuff reviewers might find. | |
| 12:33:45 | lyarwood | mriedem: ack will do | |
| 12:33:48 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748 | |
| 12:34:08 | openstackgerrit | sahid proposed openstack/nova-specs master: fix blueprint related to the spec overhead-pin-set https://review.openstack.org/561916 | |
| 12:40:00 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | |
| 12:44:36 | openstackgerrit | Merged openstack/nova stable/queens: Document how to disable notifications https://review.openstack.org/561954 | |
| 12:44:44 | openstackgerrit | Merged openstack/nova stable/queens: libvirt: Report the allocated size of preallocated file based disks https://review.openstack.org/562074 | |
| 12:45:58 | sahid | mriedem: about your comment on the trusted tag we are going to erase, i let a comment in the review | |
| 12:46:02 | sahid | https://review.openstack.org/#/c/562565/ | |
| 12:46:31 | sahid | i think there are some condition where that could be an issue | |
| 12:52:49 | mriedem | sahid: wrong patch? | |
| 12:57:47 | sahid | mriedem: yep sorry https://review.openstack.org/#/c/458820/ | |
| 13:08:00 | openstackgerrit | Matthew Booth proposed openstack/nova master: Rename recreate to evacuate in driver signatures https://review.openstack.org/560900 | |
| 13:12:46 | openstackgerrit | Lei Zhang proposed openstack/nova master: Improve check capacity sql https://review.openstack.org/561862 | |
| 13:20:09 | maciejjozefczyk | Guys, maybe you remember any problem related to metadata-agent and cloud-init during openstack upgrade? I heard about bugs like cleaning of instance ssh service keys during upgrades but I'm not able to track any details. | |
| 13:25:45 | mriedem | sahid: replied | |
| 13:25:57 | mriedem | cdent: i guess we already had a postgresql job in nova's experimental queue | |
| 13:26:00 | mriedem | but that doesn't help you | |
| 13:27:52 | cdent | mriedem: yeah, looks like both jay and eric are happy to merge my fix without test proof | |
| 13:28:11 | cdent | which would require a functional environment running pg or a new tempest test | |
| 13:28:42 | cdent | I explored doing a functional pg environment locally but it quickly fell apart for reasons I couldn't care to figure out (at least not last night) | |
| 13:29:21 | sahid | mriedem: ok so you may have right, i thought about that hard-reboot thing but it seems i'm wrong i will build that env and re-put my head in that whole serie | |
| 13:29:50 | jaypipes | what did I mess up now? | |
| 13:32:01 | cdent | jaypipes: you're safe this time | |
| 13:32:05 | openstackgerrit | Chris Dent proposed openstack/nova master: Add root and parent provider uuid to group by clause https://review.openstack.org/562379 | |
| 13:38:34 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Skip placement on rebuild in same host https://review.openstack.org/561015 | |
| 13:54:17 | mriedem | cdent: as in functional tests in-tree? you have to have the pg env setup, there is a script for it | |
| 13:54:43 | mriedem | nova/tools/test-setup.sh | |
| 13:54:53 | mriedem | sets up the openstack_citest creds for mysql and pg | |
| 13:55:45 | bauzas | efried: jaypipes: thanks for providing the explanations about granular groups | |
| 13:56:01 | bauzas | efried: jaypipes: fine with me about defaulting 400 if you don't provide the qparam | |
| 13:56:17 | bauzas | mriedem: I guess you running the meeting ? | |
| 13:56:20 | bauzas | or gibi? | |
| 13:56:34 | efried | bauzas: ack. Does the "global" any|isolate option give you enough control to do what you need to do for NUMA? | |
| 13:56:44 | bauzas | efried: I think so yeah | |
| 13:56:56 | gibi | bauzas: I talked to melwitt yesterday and she said she will run it today | |
| 13:56:58 | efried | bauzas: It seems like it should: user who doesn't care about topo uses `any`; user who does care uses `isolate` | |
| 13:56:58 | bauzas | efried: I provided two qpery parameters | |
| 13:57:00 | jaypipes | efried: should be any|isolate|same, right? | |
| 13:57:09 | bauzas | efried: one would be the one you discussed | |
| 13:57:18 | melwitt | nova meeting in 3 minutes | |
| 13:57:20 | efried | jaypipes: If you want two granular groups to go into the same provider, you should combine them into a single numbered group. | |
| 13:57:21 | bauzas | efried: the second was 'in_tree' | |
| 13:57:37 | bauzas | efried: so I think it answers one of two | |
| 13:57:40 | efried | bauzas: We need to discuss that one further. | |
| 13:57:41 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/557930 | |
| 13:58:08 | cdent | mriedem: how do the functional tests become aware of that stuff? as in how does the new database string get connected to the code? that's the part I was struggling to make go. (simply overrdingn the default db connection string fell on its face) | |
| 13:58:15 | bauzas | efried: jaypipes: fine if I'm discussing that qpuery param by my own spec ? | |
| 13:58:26 | bauzas | efried: jaypipes: I tihnk we don't need a separate one | |
| 13:58:28 | efried | bauzas: As I stated somewhere or other, we can't use the keyword "in_tree" because that already has implications for GET /resource_providers to return *all* the providers in the same tree as the specified RP. | |
| 13:58:49 | bauzas | efried: I don't remember which exact param name I used but got it | |
| 13:58:53 | mriedem | cdent: i've always been confused by the framework for this, but you'd have to figure out how TestNovaMigrationsPostgreSQL works | |
| 13:58:55 | efried | bauzas: Also, it's not sufficient to say "same subtree" in any form, because we need an indication of where that subtree "starts". | |
| 13:59:09 | bauzas | efried: mmm k | |
| 13:59:10 | mriedem | the oslo.db opportunistic tests only run if a given backend is configured | |
| 13:59:27 | efried | bauzas: I did explain this further in one of the ML notes, but it was kinda buried. Let me find it... | |
| 13:59:31 | cdent | mriedem: i'll see if I can wrap my brain around that while vagueing out during the meeting | |
| 14:01:27 | cdent | wooph, some serious magic going on here | |
| 14:02:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Suggest when to propose notification changes https://review.openstack.org/562265 | |
| 14:03:07 | efried | bauzas: this one, scroll about 3/4 of the way down: http://lists.openstack.org/pipermail/openstack-dev/2018-April/129511.html | |
| 14:03:34 | Nisha_Agarwal | hi, I have stable pike setup where i was trying nova boot for ironic nodes. It always give "OrphanedObjectError" as soon as it spawns the thread for deploy. This happens due to the context getting set to None at some point. After debugging we found context is set to None here https://github.com/openstack/nova/blob/stable/pike/nova/objects/instance.py#L824 | |
| 14:03:49 | bauzas | efried: sorry, was probably not enough caffeinated | |
| 14:03:54 | bauzas | or my French | |
| 14:04:09 | bauzas | -ETOOMUCHWORDS | |
| 14:04:10 | Nisha_Agarwal | When i just comment out this line ironic deploy goes through successfully, | |
| 14:04:32 | Nisha_Agarwal | i tried on two Pike setups, i see this behaviour consistently | |
| 14:04:33 | efried | Dis-moi si tu veux que je l'explique en français :) | |
| 14:05:53 | Nisha_Agarwal | should i go ahead and raise bug against nova? | |
| 14:07:29 | Nisha_Agarwal | mriedem, ^^^^ | |
| 14:15:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add request_id to instance action notifications https://review.openstack.org/553288 | |
| 14:15:59 | sahid | dansmith: arg... unsupported configuration: Unknown interface <driver name='vhost-user'> | |
| 14:16:38 | mriedem | Nisha_Agarwal: do you have the latest fixes for pike? | |
| 14:16:58 | Nisha_Agarwal | mriedem, yes | |
| 14:17:03 | sahid | it's not really like libvirt ignores the driver name... only way to make it working is to avoid passing name attribute | |
| 14:17:25 | dansmith | sahid: that's really unfortunate... I guess I should push to see more real testing... | |
| 14:17:32 | Nisha_Agarwal | i have pulled all the patches for stable/pike | |
| 14:17:50 | sahid | dansmith: nothing is merged | |
| 14:18:17 | dansmith | sahid: I know, I mean before +2ing.. I expected you were testing these other configs locally before review | |
| 14:18:30 | sahid | i expected to have that env with DPDK ready before the final +2+W | |