Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-18
03:39:54 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Send out notification when instance metadata updated https://review.openstack.org/558140
03:48:02 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
03:54:36 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming https://review.openstack.org/486475
04:56:55 openstackgerrit Merged openstack/nova master: Remove placement config check https://review.openstack.org/558089
05:29:34 openstackgerrit jichenjc proposed openstack/nova master: Fix docs for confirmResize action https://review.openstack.org/562062
08:13:51 openstackgerrit sahid proposed openstack/nova master: compute: introduce cpu_shared_set option https://review.openstack.org/561912
08:13:52 openstackgerrit sahid proposed openstack/nova master: libvirt: always pass emulator threads policy https://review.openstack.org/561913
08:13:53 openstackgerrit sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set https://review.openstack.org/510897
08:20:18 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466
08:21:32 openstackgerrit Florian Haas proposed openstack/nova stable/ocata: Increase cpu time for image conversion https://review.openstack.org/562145
09:01:01 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288
09:04:54 openstackgerrit jichenjc proposed openstack/nova-specs master: Add additional information for z/VM spec. https://review.openstack.org/562154
09:05:33 openstackgerrit jichenjc proposed openstack/nova master: mv generate_glance_url to get_image_endpoint_url https://review.openstack.org/511400
09:06:20 openstackgerrit jichenjc proposed openstack/nova-specs master: Add additional information for z/VM spec. https://review.openstack.org/562154
09:13:14 openstackgerrit jichenjc proposed openstack/nova-specs master: Add additional information for z/VM spec. https://review.openstack.org/562154
09:15:16 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
09:27:33 openstackgerrit jichenjc proposed openstack/nova-specs master: Add additional information for z/VM spec. https://review.openstack.org/562154
09:57:39 openstackgerrit sahid proposed openstack/nova master: compute: introduce cpu_shared_set option https://review.openstack.org/561912
09:57:40 openstackgerrit sahid proposed openstack/nova master: libvirt: always pass emulator threads policy https://review.openstack.org/561913
09:57:41 openstackgerrit sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set https://review.openstack.org/510897
10:05:23 stephenfin bauzas: Could you take a look at https://review.openstack.org/#/c/379525 today?
10:05:38 bauzas stephenfin: ack
10:13:51 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783
10:13:52 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_{LIBVIRT_KVM,QEMU}_S390_VERSION https://review.openstack.org/560363
10:13:53 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_KVM_PPC64_VERSION https://review.openstack.org/560364
10:13:54 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_VIRTUOZZO_VERSION https://review.openstack.org/560365
10:26:08 openstackgerrit Florian Haas proposed openstack/nova stable/ocata: Increase cpu time for image conversion https://review.openstack.org/562145
10:31:31 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
10:32:37 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832
10:32:38 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: WIP: complex policy https://review.openstack.org/553776
10:34:15 kashyap lyarwood: Is this Ocata (trivial) backport still acceptable under stable branch policies -- https://review.openstack.org/#/c/562145/
10:36:26 kashyap It should be accepted & solves a real problem.
10:42:50 kashyap efried: Fixed the tests. I went with:
10:42:50 kashyap @mock.patch.object(nova.virt.libvirt.migration,
10:42:51 kashyap 'get_updated_guest_xml', return_value='')
10:43:03 kashyap Line 9179: https://review.openstack.org/#/c/558783/9/nova/tests/unit/virt/libvirt/test_driver.py
10:43:32 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
10:47:55 fghaas lyarwood: I proposed the backport that kashyap just mentioned; I'm here if you need additional info on how exactly we bumped into this in Ocata
10:49:16 lyarwood sorry just on a call, I'll catch up in ~50mins
10:49:56 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
10:50:02 fghaas lyarwood: no rush at all, just wanted to let you know — will be here for several hours
11:05:44 jaypipes naichuans, jianghuaw_: still around?
11:31:13 jaypipes sahid: reviewing the cpu_shared_set patches again now.
11:36:38 jaypipes sahid: +2 on all.
11:40:51 sahid jaypipes: whaa thanks, i did not expected you to be so active on it :)
11:42:13 jaypipes sahid: let's "git r done" ;)
12:24:57 efried kashyap: Good deal man.
12:29:24 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: WIP: complex policy https://review.openstack.org/553776
12:38:52 naichuans jaypipes: Hi, Jay, I'm still here
12:48:15 openstackgerrit Balazs Gibizer proposed openstack/nova-specs master: Suggest when to propose notification changes https://review.openstack.org/562265
12:49:21 jaypipes naichuans: hi! so my primary concern is that the virt driver will be adding and removing resource provider records based on a "blip" of some device turning on and off.
12:49:35 kashyap efried: Still ~14 more clean-ups to do. Since this time the (libvirt / QEMU) version increment been a larger jump (because we didn't bump in "Queens"), need to clean up a lot more constants & compat code.
12:53:00 naichuans jaypipes: understood :) we decide to skip removing rp operation, and keep adding.We can't get allocation information in update_provider_tree. So it is difficult to check if the GPU is used by a VM or not. I remove the unavailable rps removing code. If nova schedule to a unavailable rp, then would be a failure and re-schedule
12:53:46 naichuans jaypipes: Any suggestion?
12:59:33 bauzas jaypipes: naichuans: I think we agreed to ask operators to not modify the config opt if so
13:00:04 bauzas at least because it would trample the compute service to understand how many vGPUs are used
13:00:36 bauzas if you want to modify that opt, destroy all your instances using vGPUs IMHO
13:01:12 naichuans Ah, if operators don't modify the config files, then the issue should not happen~
13:01:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix docs for confirmResize action https://review.openstack.org/562062
13:04:50 openstackgerrit Nguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build https://review.openstack.org/551802
13:05:12 naichuans jaypipes: bauzas: done?
13:05:26 bauzas done by what?
13:06:04 naichuans I mean we will assume operators would not change config opts?
13:09:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix docs for confirmResize action https://review.openstack.org/562062
13:34:59 Shilpa stephenfin: hi
13:35:25 Shilpa stephenfin: changes https://review.openstack.org/#/c/550172/3/ not working, any further inputs to resolve this?
13:44:37 jaypipes naichuans, bauzas: sorry, I really don't understand what you mean by config opts and operators.
13:45:28 bauzas I mean that enabled_vgpu_types shouldn't be modified
13:45:54 bhagyashris efried; Hi,
13:46:02 efried bhagyashris: Hello
13:46:12 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924
13:46:22 efried bhagyashris: It looked like you were getting ready to talk to me yesterday, and then... didn't.
13:47:23 jaypipes bauzas: that's not what we've been discussing, though. we've been discussing removing resource providers that temporarily become "unavailable" due to maintenance or down state, etc. And I have been telling naichuans and jianghuaw_ that it would be best to not auto-remove those resource providers based on some transient state.
13:47:39 bhagyashris efried: Regarding the patches https://review.openstack.org/#/c/560444/ , https://review.openstack.org/#/c/560459/2 I have fixed the unit test case part. so should i need to write the functional test as well?
13:48:12 efried bhagyashris: I think that would be nice, certainly.
13:48:23 efried bhagyashris: A functional test that behaves exactly like your live setup did.
13:48:49 naichuans jaypipes: like jianghua's comment, we mean modify the nova.conf to change supported vgpu types
13:49:08 efried bhagyashris: I would even say you should submit that functional test in its own patch, *before* the above changes, demonstrating that it produces the *wrong* result; and then with the above patches, flip it over to demonstrate the *right* result.
13:49:26 efried bhagyashris: Also, if we don't already have a LP bug open for this, we should do that.
13:49:45 efried dammit bauzas, I was in the middle of reviewing that!
13:49:54 Kevin_Zheng gibi efried , Hi thanks for the reviews, I’m totally fine with adding req Id also to update notifications, I will do it tomorrow, could you guys also check https://review.openstack.org/#/c/560748 it make update notification tests using common sample, so if it got merged I don’t have to rebase ;)
13:50:05 bauzas efried: thank Zuul
13:50:10 efried sigh
13:50:34 bauzas just a doc -1 because I was missing 2 blank lines
13:50:37 efried Kevin_Zheng: I don't know if adding req IDs to those other objects is appropriate - gibi what do you think?
13:50:39 bhagyashris efried: yes and there is test for update_provider_tree in nova/tests/functional/test_servers.py so accordingly i will need to add fuctional test write
13:50:44 jaypipes naichuans: and what happens if there are allocations on a pGPU that you end up removing from the enabled_vgpu_types CONF?
13:50:54 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1764883 https://review.openstack.org/562072
13:50:54 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP compute: Ignore active evacuations during _init_instance https://review.openstack.org/562284
13:50:54 openstack bug 1764883 in OpenStack Compute (nova) "Evacuation fails if the source host returns while the migration is still in progress" [Undecided,New] https://launchpad.net/bugs/1764883
13:51:13 bauzas jaypipes: I'm fine with your point too
13:51:43 efried bhagyashris: Yes. I don't know where libvirt-specific functional tests live, but that would be the idea.
13:51:51 jaypipes naichuans: at a bare minimum, I'd like to see some handling of a failed delete of a resource provider due to, say, an allocation existing against that provider.
13:52:40 efried bhagyashris: But I'm saying, also a functional test that hits the specific scenario you demonstrated - where the sharing provider was ignored before the fix (the DISK_GB shows up in the compute node RP) but is observed after the fix (shows up in the sharing provider).
13:52:59 naichuans jaypipes: will check it and add the error handling
13:53:10 Kevin_Zheng efried: gibi replied in the patch, he thought it is better to add it for InstanceUpdatePayload but not in status update
13:56:19 bhagyashris efried: ok, any idea or is there any reference that the test written for libvirt
13:56:58 efried bhagyashris: I have no idea. I know nothing about libvirt :)
13:57:06 efried bhagyashris: I thought *you* were the expert there :P
13:57:20 efried Maybe kashyap knows...

Earlier   Later