Earlier  
Posted Nick Remark
#openstack-nova - 2018-04-17
10:42:27 sahid matt had some questions, i tried to reply but perhaps you want to give more details
10:42:31 kashyap stephenfin: I spent 2 hours fixing two tests. I'm slow as molasses with this stuff
10:42:34 kashyap Thanks
10:43:18 stephenfin bauzas: Did I hear something about us deprecating AggregateCoreFilter ?
10:43:40 bauzas stephenfin: hola, sorry saw your late ping
10:43:46 bauzas stephenfin: but I was running :p
10:43:54 stephenfin bauzas: All good :)
10:44:10 bauzas stephenfin: the aggregate filters ? well, it's a long story :)
10:45:11 bauzas stephenfin: AFAIK, the aggregate filters aren't deprecated *yet*
10:45:27 bauzas but there was a discussion about providing that feature by the Placement API
10:47:40 stephenfin bauzas: OK, so not gone yet. I'll tackle this issue another way so
10:49:15 openstackgerrit Martin Midolesov proposed openstack/nova master: [vmwareapi] Expose cpu model on homogeneous cluster; Reformating code; https://review.openstack.org/561901
10:53:39 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145
10:58:16 openstackgerrit Merged openstack/nova stable/queens: Skip placement on rebuild in same host https://review.openstack.org/561014
11:21:17 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
11:23:55 mdbooth lyarwood: Done
11:25:04 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Improve performance when list instances with IP filter https://review.openstack.org/539469
11:27:05 lyarwood mdbooth: thanks
11:27:24 mdbooth lyarwood: Took me a while to re-load the context :)
11:27:52 openstackgerrit Martin Midolesov proposed openstack/nova master: [vmwareapi] Expose cpu model on homogeneous cluster; Refactoring code; https://review.openstack.org/561588
11:28:33 lyarwood mdbooth: yeah, I did come across https://bugs.launchpad.net/nova/+bug/1510328 from danpb btw, might try and follow up with that once this lands
11:28:33 openstack Launchpad bug 1510328 in OpenStack Compute (nova) "Nova pre-allocation of qcow2 is flawed" [Low,Confirmed]
11:29:26 mdbooth lyarwood: IIRC that's a pita to do without refactoring the imagebackend.
11:29:54 lyarwood mdbooth: oh joy, well maybe not then
11:30:32 mdbooth lyarwood: Look into it, though. I'm pretty jaded about most of that code, so I may not be looking at it fresh.
11:32:22 openstackgerrit Lee Yarwood proposed openstack/nova stable/ocata: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/519950
11:36:31 openstackgerrit Hamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640
11:40:01 openstackgerrit sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_share_set https://review.openstack.org/510897
11:40:02 openstackgerrit sahid proposed openstack/nova master: compute: introduce cpu_share_set https://review.openstack.org/561912
11:40:03 openstackgerrit sahid proposed openstack/nova master: libvirt: pass emulator threads policy insteadwhether it's isolated https://review.openstack.org/561913
11:41:09 sahid jaypipes: I have introduce the cpu_share_set by this serie ^ you might be interested. I tryed to limit the scope to my spec and I expect you to update the option for usage of cpu-resource spec
11:45:25 openstackgerrit sahid proposed openstack/nova-specs master: fix blueprint related to the spec https://review.openstack.org/561916
11:55:32 kashyap mdbooth: Following up from our yesterday's discussion, I fixed the tests
11:55:46 kashyap mdbooth: And I had to use Mock, I'm afraid. The tests were already broken / failing
11:56:02 kashyap mdbooth: You can see in this small commit message: https://kashyapc.fedorapeople.org/0001-tests-unit-Fix-test_live_migration_update_graphics_x.patch
11:59:11 jaypipes sahid: rock on, thank you sir :)
12:19:17 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748
12:21:08 openstackgerrit Sylvain Bauza proposed openstack/nova stable/queens: ironic: Get correct inventory for deployed node https://review.openstack.org/561923
12:21:54 jaypipes jianghuaw_: still up?
12:23:43 openstackgerrit Sylvain Bauza proposed openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925
12:26:25 bauzas stable cores, looks like we break some TripleO CI, and we need https://review.openstack.org/#/q/I6717ce19f6005c8ebb7af75437a72876c5a53f34 to be accepted for helping them
12:26:48 bauzas free beers offered
12:28:44 openstackgerrit Sylvain Bauza proposed openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925
12:38:44 openstackgerrit Merged openstack/nova stable/pike: Fix wrapping of neutron forbidden error https://review.openstack.org/560087
12:41:30 lyarwood bauzas: free beer you say?
12:41:53 bauzas yup, free as in 'I pay'
12:42:05 bauzas Vancouver is in 1 month
12:42:25 bauzas and even if I have a gold fish mind, I will still remember :)
12:42:39 mdbooth lyarwood: As long as you meet in person at a specific bar in France, location to be revealed no more than 1 hour in advance.
12:43:26 bauzas well, if in France, no beer
12:43:33 bauzas Chartreuse instead
12:44:15 mdbooth bauzas: I've never had that...
12:44:53 bauzas again, https://en.wikipedia.org/wiki/Chartreuse_(liqueur)
12:45:51 mdbooth bauzas: Next time I'm in France :)
12:46:18 bauzas mdbooth: didn't you tried the Génépi last time you were there ?
12:47:15 mdbooth bauzas: Not that I specifically recall, although there were drinks I drank without necessarily knowing what they were :)
12:47:25 bauzas that's sad
12:47:36 bauzas you just had half the experience
12:47:46 bauzas skiing is one thing
12:48:00 bauzas after-skiing is another thing
12:48:39 mdbooth Apres-ski for me is mostly food and bed :(
12:48:58 openstackgerrit Merged openstack/nova stable/queens: only increment disk address unit for scsi devices https://review.openstack.org/561196
12:49:49 bauzas mdbooth: tss tss, no excuse
12:49:53 stephenfin bauzas: Alternatively, go to 🇦🇹 where the beer is plentiful and the <something decidedly PC about the opposite sex>
12:50:07 bauzas I do ski with 70-yr old people
12:50:32 bauzas actally, skiing on Fridays out of vacation periods make you consider young on the slopes...
12:50:54 mdbooth bauzas: They've all been skiing since they were 2, though
12:51:25 bauzas nah
12:51:46 bauzas some decided to retire in the mountains
12:51:57 bauzas like new-age monks
12:52:27 bauzas one good way of praying : take a 60% slope
12:53:15 openstackgerrit Artom Lifshitz proposed openstack/nova master: Add skip_latest_microversion decorator https://review.openstack.org/433585
12:53:16 openstackgerrit Artom Lifshitz proposed openstack/nova master: Run api sample tests against 2.latest https://review.openstack.org/430352
12:57:36 openstackgerrit Konstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861
13:04:41 mriedem gibi: question in https://review.openstack.org/#/c/460625/
13:10:15 kosamara mriedem I fixed the nitpicks and created a blueprint
13:12:55 Shilpa stephenfin: hi
13:13:11 stephenfin Shilpa: o/
13:13:33 Shilpa stephenfin: i was going through temst failure logs for https://review.openstack.org/#/c/550172
13:14:12 Shilpa stephenfin: Also checked at http://codesearch.openstack.org/?q=vnc_auto.html&i=nope&files=&repos=
13:14:49 Shilpa stephenfin: here there are multiple projects referring novncproxy_base_url
13:15:04 openstackgerrit Stephen Finucane proposed openstack/nova master: Add CPUWeigher https://review.openstack.org/379525
13:15:40 Shilpa stephenfin: do we need to inform respective projects to modify the same, or what action we need to take here?
13:15:46 gibi mriedem: the versioned notification works based on the values of the Aggregate ovo so if we want to send the update.start notification with the already updated data then we have to update the Aggregate ovo before the start notification. But that would mean the start notification is sent _after_ the actual update so it is not a start notification any more
13:16:12 gibi mriedem: a bit of chicken and egg
13:17:12 stephenfin Shilpa: We probably do, yes. However, why does that affect the Tempest job?
13:17:15 mriedem gibi: well, or add a 'new_metadata' field to the aggregate payload, something like that
13:17:21 Shilpa stephenfin: is because of any refrence we are missing and cauing temst failure for https://review.openstack.org/#/c/550172?
13:17:23 mriedem or 'metadata_updates'
13:18:46 mriedem gibi: granted, the legacy notification is a bit dumb in that it sends the start notification with the updates but it also sends the end notification with the same updates, but not the full aggregate meta, so the legacy notification is also arguably incomplete
13:19:20 mriedem since i don't know how these are consumed, i don't want to rathole on it too much and that's why i didn't -1
13:19:43 Shilpa stephenfin: i am still finding root cause of tempst failure, and it was failed for for patch set 1 too, but missing logs there since got over written because of patch set 2
13:19:44 mriedem if the consumer wants/needs to know the delta, i guess they can diff the metadata from the start/end notifications
13:20:13 stephenfin Shilpa: That configuration value definitely works if you test manually?
13:20:47 stephenfin Shilpa: Hmm, looks like we're not passing the token correctly http://logs.openstack.org/72/550172/2/check/tempest-full/f6945b6/controller/logs/screen-n-novnc.txt.gz
13:22:12 gibi mriedem: I would go for the solution where any update.start notification sends information about the state _before_ the update and the update.end sends the new state in the payload. In some cases we deviated from that and added the diff directly to the payload instance.update old_task_sate new_task_state but there we don't have start and end notification to use
13:22:17 Shilpa stephenfin: i have checked these logs and here seems token value is empty
13:24:23 Shilpa stephenfin: from where we can confirm, vnc 1.0.0 get downloaded successfully? i checked http://logs.openstack.org/72/550172/2/check/tempest-full/f6945b6/job-output.json.gz, but how once can confirm downloading of latest VNC version is successful?
13:24:55 mriedem gibi: yeah, +W
13:25:21 gibi mriedem: I think the proposed versioned aggregate.update_metadata is a good start. If somebody needs the explicity diff in the payload we can add that later

Earlier   Later