| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-12 | |||
| 16:36:53 | mriedem | if not, don't worry about it | |
| 16:38:43 | cfriesen | mriedem: If we wanted to backport "proper" handling of encrypted volumes in the error case it could be done in a separate patch, I don't think the ordering really matters. For now I'll rework the backport to go off the stable/queens one. | |
| 16:39:21 | mriedem | i think the encrypted volume stuff only needed to change because of the behavior change in _disconnect_volume for luks native encryption | |
| 16:39:24 | mriedem | which we're not going to backport | |
| 16:41:45 | cfriesen | mriedem: well...with my fix if we hit exception.DeviceNotFound we'll continue on without every calling encryptor.detach_volume() | |
| 16:44:01 | cfriesen | mriedem: so I was wondering if we should move the call to ncryptor.detach_volume() down right above the call to self._disconnect_volume(), but I didn't know enough about that code to know if that was okay. | |
| 16:44:27 | cfriesen | it *seems* analogous to what happens in the newer code, but I could be missing something | |
| 16:45:10 | mriedem | i defer to lyarwood | |
| 16:50:01 | openstackgerrit | Chris Friesen proposed openstack/nova stable/pike: libvirt: disconnect volume from host during detach https://review.openstack.org/560690 | |
| 16:50:18 | melwitt | cfriesen: see the earlier version of the patch from before the encryption-related refactor https://review.openstack.org/#/c/515008/9/nova/virt/libvirt/driver.py | |
| 16:53:31 | efried | melwitt: Care to have a look at https://review.openstack.org/#/c/553475/ ? Then we can put update_provider_tree to bed. | |
| 16:53:46 | efried | melwitt: Should be an easy on. | |
| 16:53:48 | efried | one | |
| 16:54:36 | melwitt | sure | |
| 16:55:23 | cfriesen | melwitt: perfect, that's exactly what I was thinking about doing | |
| 17:08:38 | efried | mikal: What's your feel on deferring the requirements issue out of the zvm driver series? | |
| 17:09:09 | openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Numbered request groups use different providers https://review.openstack.org/560974 | |
| 17:10:14 | mriedem | efried: like we did in the powervm series? :) | |
| 17:10:45 | efried | mriedem: Sure. I.e. nobody cared enough to pursue it, so it dropped. That's as it should be, if nobody cares enough to pursue it. | |
| 17:11:01 | mriedem | i was also going to mention in that ML thread, btw, that if we did get pedantic about requirements, os-brick would also fall into that camp since only the libvirt and hyperv driver use it | |
| 17:11:38 | efried | mriedem: The ML thread is making it clearer with every note that this is a bigger issue than we can/should expect to solve in the zvm driver series. | |
| 17:13:10 | openstackgerrit | Chris Friesen proposed openstack/nova stable/pike: libvirt: disconnect volume from host during detach https://review.openstack.org/560690 | |
| 17:13:22 | openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | |
| 17:13:53 | mriedem | i haven't read the latest | |
| 17:14:16 | mriedem | i know what we'll do, | |
| 17:14:18 | mriedem | i'll run for TC, | |
| 17:14:28 | mriedem | and then push through that all projects must define optional requirements in [extras] | |
| 17:14:31 | mriedem | as a community wide goal | |
| 17:14:38 | dansmith | mriedem: os-brick isn't really environment specific as much though | |
| 17:14:55 | dansmith | well, maybe that's not true, I guess it runs linux commands | |
| 17:15:07 | mriedem | dansmith: this zvm lib dep isn't conditional on arch right? | |
| 17:15:08 | dansmith | but, it seems less confusingly installed than my linux machine with powervm and zvm stuff both installed | |
| 17:15:35 | dansmith | mriedem: arch or platform? | |
| 17:15:53 | dansmith | mriedem: I assume you run nova in linux land on z, so not platform | |
| 17:16:12 | dansmith | and maybe not even on an s390x if it's like an HMC | |
| 17:16:13 | mriedem | i assume this zvm driver runs on a linux host, and then calls REST APIs to some zvm hypervisor | |
| 17:16:17 | dansmith | yeah | |
| 17:16:24 | mriedem | like powervm | |
| 17:16:30 | dansmith | linux for sure, but might even be on x86 | |
| 17:16:35 | mriedem | yeah totes | |
| 17:16:43 | mriedem | doesn't need to be linux on s390x | |
| 17:16:48 | mriedem | that would be dumb | |
| 17:16:59 | dansmith | yeah, the arch thing isn't the concern as much as it's a lib for a hypervisor I don't need | |
| 17:17:12 | mriedem | sure, but the point is, we are all over the board | |
| 17:17:16 | dansmith | brick is kinda the same-ish, although it's not as weird I think | |
| 17:17:19 | dansmith | yes, definitely | |
| 17:17:31 | mriedem | os-xenapi is also in requirements.txt | |
| 17:17:43 | mriedem | taskflow is also only used by powervm but in requiments.txt | |
| 17:17:52 | dansmith | I think that for people who get government audits for every line of installed code, it'd be a harder sell than os-brick being there but not used | |
| 17:17:55 | dansmith | but just a guess | |
| 17:18:10 | mriedem | you know what i miss? COOs | |
| 17:18:18 | dansmith | I'd be happy using this as an opportunity to get right with the loahd on here | |
| 17:18:25 | dansmith | mriedem: really? that's funny, I don't miss them at all | |
| 17:18:33 | mriedem | i was being sarcastic | |
| 17:18:38 | dansmith | WAT | |
| 17:18:40 | dansmith | I had no idea | |
| 17:18:41 | mriedem | but your audit comment got me reminiscing | |
| 17:18:45 | dansmith | I know :) | |
| 17:18:52 | mriedem | and now this https://www.youtube.com/watch?v=CZ_3G4xqSDQ | |
| 17:19:17 | mriedem | looking at those guys reminds me i need to schedule a haircut | |
| 17:21:12 | mriedem | alright wtf was i doing now | |
| 17:24:02 | mriedem | efried: i have replied for great posterity | |
| 17:24:13 | efried | mriedem: thanks | |
| 17:25:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001 | |
| 17:25:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | |
| 17:25:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | |
| 17:25:18 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | |
| 17:25:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | |
| 17:25:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | |
| 17:25:21 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | |
| 17:25:22 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | |
| 17:25:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | |
| 17:25:24 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | |
| 17:25:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 17:25:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | |
| 17:27:26 | mriedem | arvindn05: if you're just asking questions in a patch ( https://review.openstack.org/#/c/546357/ ) you don't need to -1 | |
| 17:47:24 | arvindn05_ | mriedem: thanks...will keep in mind. | |
| 17:48:38 | mriedem | arvindn05_: i put some comments in your spec amendment, thanks for starting that https://review.openstack.org/#/c/560718/1 | |
| 17:49:02 | mriedem | jaypipes: dansmith: efried: ^ that's going to require some placement love | |
| 17:49:47 | dansmith | ugh | |
| 17:49:52 | mriedem | f yeah, rebuild | |
| 17:52:04 | mriedem | if we can request resources=VCPU:0 and in_tree=<compute node uuid> then i think we'd be ok | |
| 17:53:10 | efried | mriedem: I think jaypipes wanted to deal with that by using the GET /resource_providers API instead of GET /a_c. (I disagreed; I think ?in_tree in GET /a_c is a fine idea) | |
| 17:53:32 | dansmith | but asking for zero resources seems weird | |
| 17:53:36 | mriedem | actually if we added in_tree to GET /allocation_candidates, just make resources optional in the same microversion | |
| 17:54:03 | mriedem | so GET /allocation_candidates?in_tree=1234&required=CUSTOM_NEW_IMAGE_TRAIT | |
| 17:55:37 | dansmith | that also seems a little weird to me | |
| 17:55:59 | mriedem | because we aren't going to actually allocate anything? | |
| 17:56:19 | dansmith | well, not that we aren't going to allocate anything really | |
| 17:56:27 | dansmith | just that we're asking a weird question there | |
| 17:56:37 | mriedem | ok, well, some options | |
| 17:57:03 | mriedem | this doesn't seem like an impossibly hard issue though | |
| 18:00:31 | dansmith | not to validate it no, just weird to do it that way is all | |
| 18:13:02 | dansmith | mriedem: why can't we just GET /rp/$uuid and look at the traits? | |
| 18:23:10 | mriedem | we could | |
| 18:23:31 | mriedem | in fact, | |
| 18:23:37 | arvindn05_ | mriedem: that was the suggestion in the bp | |
| 18:23:39 | arvindn05_ | :) | |
| 18:23:49 | mriedem | GET /resource_providers?in_tree=<node uuid>&required=<traits> | |
| 18:24:16 | mriedem | arvindn05_: if you mean, "For the above issue, the scheduler can request traits of current host and try | |