Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-11
05:25:24 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
05:40:44 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
05:48:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in test_neutron_security_groups.py https://review.openstack.org/560267
05:49:29 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466
06:03:40 openstackgerrit Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078
06:03:41 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605
06:03:42 openstackgerrit Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
06:03:43 openstackgerrit Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
06:03:44 openstackgerrit Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
06:04:40 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
06:07:37 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466
06:18:01 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772
06:57:55 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
07:12:33 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
07:13:21 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159
07:18:53 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925
07:19:24 openstackgerrit Bence Romsics proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675
07:19:25 openstackgerrit Bence Romsics proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043
07:19:26 openstackgerrit Bence Romsics proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326
07:27:49 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296
07:38:26 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299
07:44:06 takashin mriedem: Are you around?
07:44:39 takashin mriedem: Could you look https://bugs.launchpad.net/nova/+bug/1762941 ?
07:44:40 openstack Launchpad bug 1762941 in OpenStack Compute (nova) "testtools.matchers._impl.MismatchError: 'completed' != u'running' in test_bug_1718512.TestRequestSpecRetryReschedule.test_resize_with_reschedule_then_live_migrate" [Undecided,New]
08:06:02 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299
08:28:24 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
08:28:43 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296
08:28:59 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
08:34:53 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299
08:39:06 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: RP list: member_of and resources parameters (v1.3, v1.4) https://review.openstack.org/511183
08:39:07 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: RP delete inventories (v1.5) https://review.openstack.org/514642
08:39:08 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: CLI for traits (v1.6) https://review.openstack.org/514643
08:39:09 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: Resource class set (v1.7) https://review.openstack.org/514644
08:39:10 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646
08:39:11 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647
08:39:12 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819
08:39:13 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: Transactionally update allocations (v1.13) https://review.openstack.org/546674
08:39:14 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675
08:39:15 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043
08:39:16 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326
08:52:50 openstackgerrit Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317
09:06:21 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
09:06:22 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
09:06:23 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240
09:06:24 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340
09:06:25 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344
09:19:28 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296
09:38:33 kashyap mdbooth: Hi, would you happen to have a minute to debug a unit test failure that's driving me nuts?
09:39:02 kashyap mdbooth: That's the one: http://paste.openstack.org/show/718887/
09:39:11 mdbooth kashyap: Not this morning I'm afraid
09:39:18 kashyap mdbooth: Ah, no problem.
09:43:14 mdbooth kashyap: Without any kind of in depth look, and assuming you're just seeing teeth-gnashing weirdness, I suggest either:
09:43:22 mdbooth * You're not mocking what you think you're mocking
09:43:58 mdbooth * self._host.has_min_version returns something disgustingly pythonic with obtuse notions of true and false
09:45:12 kashyap mdbooth: I think it's the former; the "mock" thing.
09:45:47 kashyap I ran through PDB, and both: libvirt_driver.MIN_VIRTUOZZO_VERSION (from the test) and the MIN_VIRTUOZZO_VERSION from driver.py print the same version
09:47:41 kashyap Anyway; thanks for the look.
09:48:56 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159
09:49:35 mdbooth kashyap: You're mocking driver._conn btw
09:49:44 mdbooth But the test uses driver._host
09:49:47 mdbooth s/test/code/
09:51:42 mdbooth kashyap: Unfortunately your problem is vastly more interesting than what I'm actually supposed to be doing.
09:51:57 kashyap :-)
09:52:56 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299
09:53:57 mdbooth kashyap: Don't assume that the previous unit test was correct. It may have worked only by coincidence. This isn't uncommon.
09:54:13 kashyap This doesn't fly either:
09:54:14 kashyap + with mock.patch.object(driver.init_host, 'getVersion') \
09:54:14 kashyap + as mock_getver:
09:54:31 kashyap mdbooth: Sigh, yeah, I recall johnthetubaguy saying our MIN_VERSIONS testing has been a "joke"
09:54:32 mdbooth driver.init_host is a function
09:54:42 mdbooth That doesn't really make sense
09:55:36 mdbooth If you look at Host.has_min_version
09:56:09 mdbooth See that _version_check gets version from conn.getLibVersion
09:56:18 kashyap Aah, I remove that:
09:56:21 mdbooth Where conn is returned by Host.get_connection()
09:58:25 mdbooth You need the return value of Host.get_connection() to return an object whose getLibVersion() method returns your test value
09:58:38 mdbooth You can do that with Mock
09:59:07 mdbooth I wonder if you can also do it with FakeVirtAPI
09:59:11 kashyap (Hmm, yeah: host.has_min_version --> _version_check --> getLibVersion)
09:59:39 kashyap mdbooth: Yeah, if we can do it with the FakeVirtAPI, shouldn't I go that route, instead?
10:00:36 mdbooth It looks like you can just mock fakelibvirt.FAKE_LIBVIRT_VERSION
10:00:41 mdbooth And it will do what you want
10:00:51 kashyap mdbooth: NOte that we'd like to check: MIN_VIRTUOZZO_VERSION is OK.
10:00:56 kashyap But thanks for the walk through
10:01:24 kashyap Hey, this is also "work", but yeah, "someone else's work", though :P
10:01:26 mdbooth ^^^ is how to change the value it's testing against
10:02:01 kashyap mdbooth: Noted; will play a bit more and see where I arrive
10:08:57 openstackgerrit Chen Hanxiao proposed openstack/nova master: trivial: fix a comment typo https://review.openstack.org/560349
10:11:28 openstackgerrit Stephen Finucane proposed openstack/os-vif master: Add lower-constraints job https://review.openstack.org/556056
10:32:14 kashyap mdbooth: Thanks for the idea! It seemed to have worked.
10:44:47 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451
10:50:02 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783
10:50:03 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_{LIBVIRT_KVM,QEMU}_S390_VERSION https://review.openstack.org/560363
10:50:04 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_KVM_PPC64_VERSION https://review.openstack.org/560364
10:50:05 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_VIRTUOZZO_VERSION https://review.openstack.org/560365
11:10:13 openstackgerrit Merged openstack/nova master: make metadata doc up to date https://review.openstack.org/559613
11:10:25 openstackgerrit Merged openstack/nova master: Log a more useful error when neutron isn't configured https://review.openstack.org/559111
11:10:42 openstackgerrit Merged openstack/nova master: doc: add a link in the install guides about configuring neutron https://review.openstack.org/559115
11:11:00 openstackgerrit Merged openstack/nova master: Log a more useful error when cinder auth isn't configured https://review.openstack.org/559399
11:11:11 openstackgerrit Merged openstack/nova master: Move test_report_client out of placement namespace https://review.openstack.org/558911

Earlier   Later