Posted	Nick	Remark
#openstack-nova - 2018-04-10
20:02:20	dansmith	the deal is the instance didn't let go of the volume, so there's really nothing else to do other than shut it down, or tell the instance to get over itself
20:02:46	cfriesen_	dansmith: fair enough. you mentioned an instance action, where would that get logged?
20:02:56	dansmith	in instance actions
20:04:15	cfriesen_	I mean where in the detach volume exception path would we report the failure to detach as an instance action?
20:04:33	dansmith	I'm not positive we do, I'm just saying I think we would
20:04:39	dansmith	I can look, but so can you :)
20:05:03	cfriesen_	yep..was hoping you knew off the top of your head. Looking.
20:07:11	dansmith	nope
20:08:39	dansmith	ah yeah,
20:08:53	dansmith	cfriesen_: @wrap_instance_event on compute manager detach_volume
20:08:57	cfriesen_	dansmith: looks like ComputeManager.detach_volume() has wrap_instance_fault and wrap_instance_event decorators
20:09:01	dansmith	I think that decorator ends up with it
20:09:01	dansmith	yeah
20:09:34	efried	dansmith: You wanna finish up the paperwork on the bp here https://blueprints.launchpad.net/nova/+spec/add-consumer-generation
20:09:50	cfriesen_	dansmith: So heat should maybe poll those for updates as well as looking for the state change on the volume?
20:10:29	dansmith	efried: I hate paperwork
20:10:44	dansmith	cfriesen_: I'm guessin' that'd be smart :)
20:11:21	efried	dansmith: :*
20:12:07	cfriesen_	time to go check the captured database logs and see if the appropriate info was there.
20:18:11	openstackgerrit	Merged openstack/nova stable/queens: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559700
20:18:51	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559702
20:24:26	openstackgerrit	Surya Seetharaman proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920
20:29:41	openstackgerrit	Merged openstack/nova master: Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171
20:30:13	openstackgerrit	Merged openstack/nova master: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/505771
20:31:56	cfriesen_	dansmith: I see relevent entries in "instance_actions_events" and "instance_faults", but I don't know of any API to get either of those. Would the fault entry show up when doing a GET
20:31:57	cfriesen_	GET
20:31:59	cfriesen_	/servers/{server_id}
20:32:06	cfriesen_	whoops, paste error
20:32:07	dansmith	cfriesen_: the instance actions api
20:32:15	mriedem	GET /os-instance-actions
20:32:23	mriedem	the fault is stored on the server
20:32:35	mriedem	https://developer.openstack.org/api-ref/compute/#servers-actions-servers-os-instance-actions
20:32:40	dansmith	cfriesen_: https://developer.openstack.org/api-ref/compute/#list-actions-for-server
20:32:43	dansmith	yeah
20:32:44	mriedem	https://developer.openstack.org/api-guide/compute/faults.html
20:32:56	mriedem	^ might be stale
20:33:02	mriedem	most things in the compute api guide are old
20:33:45	mriedem	e.g. https://developer.openstack.org/api-guide/compute/faults.html#instance-faults
20:33:50	mriedem	"However, there is currently no API to retrieve this information."
20:33:52	mriedem	that's totally bogus
20:34:19	mriedem	GET /server/{id} has a 'fault' key in the response
20:34:20	mriedem	"A fault object. Only displayed in the failed response. Default keys are code, created, and message (response code, created time, and message respectively). In addition, the key details (stack trace) is available if you have the administrator privilege."
20:38:21	cfriesen_	thanks, looks like heat should be able to get the necessary info
20:38:59	openstackgerrit	Merged openstack/nova master: Don't persist RequestSpec.retry https://review.openstack.org/559447
20:39:30	openstackgerrit	Matt Riedemann proposed openstack/nova stable/queens: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560142
20:39:31	openstackgerrit	Matt Riedemann proposed openstack/nova stable/queens: Don't persist RequestSpec.retry https://review.openstack.org/560143
20:44:32	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560145
20:44:33	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: Don't persist RequestSpec.retry https://review.openstack.org/560146
21:10:10	openstackgerrit	Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
21:10:11	openstackgerrit	Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
21:15:15	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560145
21:15:16	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: Don't persist RequestSpec.retry https://review.openstack.org/560146
21:16:16	jackie-truong	I have a patch that adds documentation for the certificate validation feature. Should that be linked with the current nova-validate-certificates patches? I'll still include the bp link in the commit message
21:17:02	cfriesen_	mriedem: dansmith: have you ever seen anything like this? http://paste.openstack.org/show/718865/ It seems like we ask nova to detach, but libvirt doesn't recognize the device.
21:17:39	mriedem	yes
21:17:46	mriedem	cfriesen_: you should be talking to lyarwood and melwitt
21:17:51	cfriesen_	cool, will do
21:17:54	mriedem	they've been in the bowels of that code a few times
21:17:57	openstackgerrit	Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
21:18:30	mriedem	cfriesen_: which branch are you on? do you have all the latest fixes?
21:19:05	cfriesen_	this would be Pike, I'd have to check if it was totally up to date
21:19:59	cfriesen_	gotta run, parent-teacher interview
21:20:52	openstackgerrit	Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
21:20:53	openstackgerrit	Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
21:20:54	openstackgerrit	Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
21:22:57	mriedem	cfriesen_away: i was thinking of https://review.openstack.org/#/c/488545/ but that's in pike GA
21:41:25	openstackgerrit	Matt Riedemann proposed openstack/nova stable/ocata: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560162
21:53:33	openstackgerrit	Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300
21:59:06	arvindn05	dansmith: can you please review the changes made per your suggestions? https://review.openstack.org/#/c/557795/ - Update ImageMetaProp object to expose traits
22:04:05	openstackgerrit	Ed Leafe proposed openstack/nova master: Add a microversion for consumer generation https://review.openstack.org/558958
22:15:04	openstackgerrit	Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242
22:15:05	openstackgerrit	Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078
22:15:06	openstackgerrit	Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605
22:15:07	openstackgerrit	Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
22:15:08	openstackgerrit	Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
22:15:09	openstackgerrit	Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
22:23:04	openstackgerrit	Matt Riedemann proposed openstack/nova stable/ocata: Don't persist RequestSpec.retry https://review.openstack.org/560167
22:55:34	openstackgerrit	Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242
22:55:35	openstackgerrit	Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078
22:55:36	openstackgerrit	Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605
22:55:37	openstackgerrit	Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
22:55:38	openstackgerrit	Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
22:55:39	openstackgerrit	Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
23:17:56	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Add history behind nullable project_id and user_id https://review.openstack.org/560174
23:18:17	efried	dansmith, edleafe, jaypipes: ^^
23:19:23	efried	mikal: +2!
23:19:44	efried	mikal: Thanks for putting up with me.
23:20:37	openstackgerrit	Ed Leafe proposed openstack/nova master: Add handlers for consumer_generation https://review.openstack.org/557959
23:20:40	openstackgerrit	Ed Leafe proposed openstack/nova master: Add a microversion for consumer generation https://review.openstack.org/558958
23:21:02	edleafe	efried: ^^ answered *some* of your concerns. The remainder can be discussed tomorrow.
23:21:15	efried	edleafe: Roger that. I gotta bail.
23:34:14	openstackgerrit	Matt Riedemann proposed openstack/nova master: doc: cleanup docs about instance faults https://review.openstack.org/560178
23:34:25	mriedem	cfriesen_away: ^ that one is for you
23:48:00	openstackgerrit	Matt Riedemann proposed openstack/nova master: doc: cleanup docs about instance faults https://review.openstack.org/560178
23:49:31	mriedem	alex_xu: gmann: Kevin_Zheng: ^ I just realized that we don't have 'fault' as a server blacklisted query parameter or sort key
23:49:50	mriedem	but it is a joined table
23:50:37	mriedem	looking at https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L298
23:51:04	Kevin_Zheng	mriedem: got it, will check it the first thing when got to office
23:54:50	openstack	Launchpad bug 1762870 in OpenStack Compute (nova) "server fault is not blacklisted for filtering/sorting" [Medium,Triaged]
23:54:50	mriedem	https://bugs.launchpad.net/nova/+bug/1762870

Earlier   Later