Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-10
16:05:15 mriedem or if that's already the rule they have in place
16:14:46 mriedem lee bugged out, but i might have a fix on the cinder side
16:14:51 smcginnis mriedem: I think we can't due to things like migration.
16:14:52 mriedem glory hallelujah
16:15:13 mriedem smcginnis: i'll poke you with the patch when it's up, and i'll hope lee can apply and see if it solves his issue
16:15:25 smcginnis mriedem: OK, sounds like a plan.
16:19:31 openstackgerrit Lee Yarwood proposed openstack/nova master: rbd: flatten images when creating/unshelving an instance https://review.openstack.org/457886
16:21:25 melwitt mriedem: thanks for adding the neutron stuff to the forum ideas etherpad
16:21:32 mriedem np
16:22:37 mriedem lyarwood: does that also fix bug 1732428?
16:22:37 openstack bug 1732428 in OpenStack Compute (nova) "Unshelving a VM breaks instance metadata when using qcow2 backed images" [Medium,In progress] https://launchpad.net/bugs/1732428 - Assigned to Matt Riedemann (mriedem)
16:24:18 lyarwood mriedem: no, flatten is specific to the rbd imagebackend
16:24:49 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688
16:26:16 jgriffith lyarwood: I added a note to https://bugs.launchpad.net/cinder/+bug/1762687
16:26:16 openstack Launchpad bug 1762687 in Cinder "Concurrent requests to attach the same non-multiattach volume to multiple instances can succeed" [High,New]
16:26:28 lyarwood thanks ./me looks
16:26:33 jgriffith I think the race is the condition check in _reserve_volume on the cidner side
16:26:37 jgriffith mriedem: ^^
16:27:23 mriedem jgriffith: just about got something here
16:27:46 jgriffith mriedem: oh... so I guess that means I was wrong?
16:27:55 mriedem haven't read the comment yet,
16:27:58 mriedem just fixing tests
16:28:01 jgriffith Oh... LOL
16:28:12 jgriffith mriedem: so what you're saying is "there's a chance" :)
16:28:22 smcginnis :)
16:28:28 jgriffith if this were slack I'd insert stupid gif here
16:30:12 smcginnis I think that's the whole reason why folks like slack over irc. :)
16:31:11 melwitt dansmith: this is the patch we talked briefly about on friday at the ptg about flattening rbd images if not CONF.use_cow_images. I had asked the room if there was any usefulness in someone configuring that way and you had said some people would to get better performance https://review.openstack.org/#/c/457886
16:31:20 mriedem lyarwood: can you test this out? https://review.openstack.org/560074
16:31:27 lyarwood mriedem: sure can
16:33:17 mriedem dansmith: melwitt: just fyi, i'll be out for a few hours this afternoon
16:33:56 melwitt k
16:33:57 dansmith melwitt: okay, was there more to that question?
16:36:18 melwitt dansmith: lyarwood rebased it a little while ago and it reminded me that I had been meaning to ask if you could review it. I added the bit about using the CONF.use_cow_images config option as a toggle for flattening
16:36:28 dansmith okay
16:40:59 lyarwood mriedem: that appears to be enough but I'm just spamming requests from the cli again
16:43:23 mriedem lyarwood: ok i'm updating it per jgriffith's comment
16:43:59 jgriffith lyarwood: so just the refresh was enough?
16:44:17 lyarwood mriedem: that's a different issue though right? That's allowing concurrent attach requests for multiattach volumes that are reserved?
16:44:34 jgriffith lyarwood: if so that's great, and we can consider that if adding reserve to the status check has consequences (I still think it might)
16:46:19 lyarwood jgriffith: yeah as above I can't see how adding reserved helps with this non-multiattach race tbh
16:46:50 lyarwood jgriffith: we only expect available or downloading in that case right?
16:46:57 mriedem yeah
16:47:17 jgriffith lyarwood: yes
16:47:20 mriedem and yes i think adding 'reserved' would only be for racing to attach the same multiattach volume to separate instances
16:47:29 jgriffith mriedem: +1
16:47:31 lyarwood kk
16:47:37 lyarwood just checking, thanks
16:47:42 mriedem so if just the volume refresh fixes it, then i could remove the 'reserved' part of this patch, and that can be done later if it's a problem
16:52:56 lyarwood mriedem: yup I'd drop it for now tbh but it's really up to the cinder folks
16:53:41 mriedem lyarwood: if it fixes your issue for non-multiattach volumes then i'm happy to simplify the patch
16:53:52 mriedem i need some time to write a test anyway
17:08:59 cfriesen_ mriedem: did you ever get any further with https://bugs.launchpad.net/nova/+bug/1696125 ? I think we're seeing it too, though it showed up in the guise of a stalled heat stack deletion.
17:08:59 openstack Launchpad bug 1696125 in OpenStack Compute (nova) "Detach interface failed - timeout waiting to detach tap device in linuxbridge job (pike)" [High,In progress] - Assigned to Matt Riedemann (mriedem)
17:11:24 openstackgerrit Sam Yaple proposed openstack/nova stable/pike: Fix wrapping of neutron forbidden error https://review.openstack.org/560087
17:11:40 openstackgerrit Sam Yaple proposed openstack/nova stable/ocata: Fix wrapping of neutron forbidden error https://review.openstack.org/560088
17:12:04 cfriesen_ mriedem: and we're not using linuxbridge
17:16:13 mriedem cfriesen_: no, slipped out of mind since we're not hitting it in the gate anymore
17:17:26 mriedem SamYaple: you have to first backport that to stable/queens
17:17:33 mriedem oh wait
17:17:37 SamYaple mriedem: its in stable queens
17:17:38 SamYaple i checked
17:17:42 mriedem yeah :)
17:17:43 mriedem nvm
17:20:22 SamYaple yea it got me too. its just a 5 month old branch, when queens was still master
17:20:28 SamYaple 5 month old patch*
17:21:02 kashyap dansmith: Just read the scroll. Thanks for the explanation
17:21:56 kashyap dansmith: And yes, I did realize I had to remove 'test.nested'. Just didn't commit to it in the paste-bin. /me tinkers a bit
17:26:29 openstackgerrit Eric Fried proposed openstack/nova master: Test case: ResourceClass.normalize_name with ß https://review.openstack.org/560092
17:26:29 openstackgerrit Eric Fried proposed openstack/nova master: Make ResourceClass.normalize_name handle sharp S https://review.openstack.org/560093
17:30:14 melwitt efried: how did you find that? ^
17:30:29 efried melwitt: Nice one, right?
17:30:37 melwitt yeah o.O
17:30:52 efried I actually found it while working on https://review.openstack.org/#/c/556628/ which I'm now going to abandon (because reasons I'm posting here is a minute)
17:31:43 efried (but mostly because jaypipes is right)
17:33:12 mriedem we might have a new dbdeadlock http://logs.openstack.org/14/554314/1/gate/tempest-full-py3/1aa1216/controller/logs/screen-n-cpu.txt.gz?level=TRACE#_Apr_10_13_49_39_294710
17:38:12 artom (null)
18:01:25 openstackgerrit Eric Fried proposed openstack/os-traits master: normalize_name helper https://review.openstack.org/560107
18:15:11 openstackgerrit Ed Leafe proposed openstack/nova-specs master: Add Generation to Consumers https://review.openstack.org/556971
18:17:44 edleafe dansmith: ^^ Addressed your comments
18:18:31 efried edleafe: Thanks, that lgtm
18:22:16 simondodsley anyone help with https://review.openstack.org/#/c/558530 that breaks pep8 with a C901 'LibvirtConfigGuestDisk.format_dom' is too complex (40) error? My Python skills are not up to re-coding that module with confidence
18:22:23 openstackgerrit Jimmy McCrory proposed openstack/nova master: Pass user context detaching volume on exceptions https://review.openstack.org/560115
18:22:31 openstackgerrit Eric Fried proposed openstack/os-traits master: normalize_name helper https://review.openstack.org/560107
18:22:32 dansmith efried: well, I still wanted more detail on the userid history thing, but I guess I'm the only one
18:23:22 efried dansmith: Oh, yeah, edleafe did you want to address that?
18:23:45 efried I would volunteer to write it up, but I'm not 100% sure I understand it well enough to articulate it.
18:25:35 melwitt simondodsley: I think that just means the code you added pushed the format_dom method length over the limit for "complexity". so you just need to break some of the code in format_dom into a private helper method and call it from format_dom
18:28:13 simondodsley melwitt: Yeah - I get what the error is, but the whole section of that module is repeating if statements. I'm not sure I want to modify code that I didn't add for my first attempt at messing with core Nova code :)
18:32:42 edleafe dansmith: I didn't work on the user_id changes, so my knowledge of the whys and wherefores is limited
18:33:17 melwitt simondodsley: oh, I see. I think what I would do is add a refactor patch to stack under your patch that adds a method like "iotune = self._get_iotune()" and puts all of the iotune.append stuff in there. then your additions would go in _get_iotune
18:34:02 efried edleafe: Is http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-04-10.log.html#t2018-04-10T15:24:58 roughly correct to your understanding?
18:34:42 melwitt that said, it looks like you need some review on your spec https://review.openstack.org/#/c/340168 (I will take a look)
18:35:11 openstackgerrit Merged openstack/nova-specs master: Add Generation to Consumers https://review.openstack.org/556971
18:36:04 edleafe efried: yeah, that's pretty much it
18:36:23 efried I can have a crack at an edit.
18:36:40 efried Because when dansmith is happy, everyone's happy.
18:37:02 efried Or maybe it's the inverse.
18:37:14 edleafe efried: wasn't there some discussion about trying to backfill those values, using the consumer_uuid to find the project/user for that VM
18:37:30 efried oh, sheesh, I don't remember any of that.

Earlier   Later