Posted	Nick	Remark
#openstack-nova - 2018-04-10
01:41:50	openstackgerrit	jichenjc proposed openstack/nova master: make metadata doc up to date https://review.openstack.org/559613
01:50:45	openstackgerrit	Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242
01:50:46	openstackgerrit	Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078
01:50:46	openstackgerrit	Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605
01:50:47	openstackgerrit	Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
01:50:47	openstackgerrit	Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
01:50:48	openstackgerrit	Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
02:03:14	naichuans	Hi, efried: do we have the scheduler of to get NRP working through GET /allocation_candidates?
02:05:34	alex_xu	kashyap: yea, I think it supports boarder option, but at least for our team, we only use cmt
02:08:57	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in test_virt_drivers.py https://review.openstack.org/559878
02:16:20	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (1) https://review.openstack.org/558704
03:43:22	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159
03:51:25	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (2) https://review.openstack.org/558993
03:53:19	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (3) https://review.openstack.org/559258
04:00:15	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159
05:39:27	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451
06:03:41	openstackgerrit	jichenjc proposed openstack/nova master: remove ec2 in service and cmd https://review.openstack.org/556778
06:03:41	openstackgerrit	jichenjc proposed openstack/nova master: remove ec2 object definitions https://review.openstack.org/557150
06:03:42	openstackgerrit	jichenjc proposed openstack/nova master: remove ec2 db functions https://review.openstack.org/557572
06:25:16	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772
06:45:09	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451
06:54:10	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
07:13:34	openstackgerrit	Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466
07:14:21	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171
07:14:21	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783
07:22:13	kashyap	zigo: If you want to re-ACK this -- https://review.openstack.org/#/c/558171/
07:26:30	bauzas	good morning nova
08:45:48	openstackgerrit	Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242
08:45:49	openstackgerrit	Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078
08:45:49	openstackgerrit	Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605
08:45:50	openstackgerrit	Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
08:45:50	openstackgerrit	Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
08:45:51	openstackgerrit	Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
08:46:17	zigo	kashyap: I did it but there are still ci failures.
08:50:33	kashyap	zigo: Let me look; this shouldn't certainly cause CI failures
08:51:22	kashyap	Hmm, I see "IBM PowerKVM CI" failing
09:14:29	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451
09:28:56	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
09:53:59	openstackgerrit	Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262
10:05:05	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
10:25:41	Tahvok	Should horizon respect the live migration when host aggregates are enabled? Because when I live migrate an instance, it still gives me an option to choose to live migrate an instance to a host not part of the host aggregate
10:46:35	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
10:52:00	openstackgerrit	Petersingh Anburaj proposed openstack/nova master: Making consistent used of GiB and MiB in Doc https://review.openstack.org/559985
11:05:06	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/559987
12:19:28	openstackgerrit	Yikun Jiang (Kero) proposed openstack/osc-placement master: Initialize 'result' variable in functional.base https://review.openstack.org/560004
12:28:31	efried	naichuans: No, not yet. Keep an eye on blueprint nested-resource-providers-allocation-candidates
12:28:31	efried	spec: https://review.openstack.org/#/c/556873/
12:28:31	efried	code: https://review.openstack.org/#/q/topic:bp/nested-resource-providers-allocation-candidates+(status:open+OR+status:merged)
12:49:11	efried	claudiub: Does autospec work for method signatures?
12:51:50	efried	yes, yes it does.
12:53:06	claudiub	sorry, I didn't see it in time. :)
12:53:15	claudiub	and yes, it does, that was the whole point of it. :)
12:54:37	claudiub	efried: although arguably there is still one case in which it doesn't get applied, one case I've missed in the original implementation: https://review.openstack.org/#/c/557923/
12:54:39	efried	claudiub: Knew it worked that way for objects, wasn't sure about methods.
12:56:24	claudiub	efried: also, keep in mind that this has a +2, so it might merge soon. Hopefully it won't affect nova_powervm: https://review.openstack.org/#/c/470775/
12:57:26	efried	claudiub: If you have a moment, I'm hitting a place where the autospec doesn't seem to be working as expected...
12:57:34	claudiub	sure, what's up
12:57:41	efried	looking at this patch: https://review.openstack.org/#/c/552242/
12:58:04	efried	Look at the signature of e2fsck here https://review.openstack.org/#/c/552242/12/nova/privsep/fs.py
12:58:16	efried	accepts (image, flags='-fp')
12:58:51	claudiub	sure
12:58:52	efried	Then look at the first usage here: https://review.openstack.org/#/c/552242/12/nova/virt/xenapi/vm_utils.py
12:59:03	efried	note extra kwarg check_exit_code
12:59:26	efried	So I thinks to myself, I thinks, "Okay, let's autospec here: https://review.openstack.org/#/c/552242/12/nova/tests/unit/virt/xenapi/test_vm_utils.py"
12:59:39	efried	...but when I do that, the test still passes.
13:00:05	efried	i.e. the autospec doesn't seem to be catching that extra kwarg.
13:00:55	claudiub	i might be blind, but where are you autospecing it?
13:00:56	efried	It's probably me being blind.
13:01:11	efried	@mock.patch('...', autospec=True)
13:01:21	efried	is that a legit way to do that?
13:02:02	claudiub	i might be really blind as a bat then. but yeah, there's a reason why it passes
13:03:41	claudiub	or, wait, that only aplies to object methods. hm. anyways, there is an issue with mock.patch autospec, which i've addressed in oslotest. what happened was that mock.patch's autospec didn't consume the self / cls argument of object / class methods
13:04:08	efried	I remember that issue. But in this case there are no classes involved, are there?
13:04:09	claudiub	it should be the case now, since it's just a function.
13:04:44	efried	it's possible my venv has an old oslotest, lemme check...
13:04:57	claudiub	can you check if the mock.patch autospec works as expected with this patch on top? https://review.openstack.org/#/c/470775/
13:04:59	efried	finucannot: you around this week?
13:05:16	efried	claudiub: okay.
13:05:27	finucannot	efried: Yes, but I'm focused on getting the numa-aware-vswitch PoC out the door
13:05:41	stephenfin	oops
13:05:50	claudiub	that patch basically enforces the oslotest's mock.patch behaviour.
13:07:52	mriedem	jianghuaw_: does the citrix xenserver CI have any multinode job to test live migration for this series? https://review.openstack.org/#/c/489451/
13:15:21	efried	claudiub: Okay, first I upgraded oslotest in my venv (3.2.0 => 3.4.1). Then I patched in https://review.openstack.org/#/c/557923/ (which presumably also means I'm getting as-yet-unreleased oslotest whatever). Then I merged in https://review.openstack.org/#/c/470775/ with the patch in question.
13:15:28	efried	claudiub: None of this yielded the expected failure.
13:16:09	claudiub	interesting
13:16:21	claudiub	i'll take a look today as well
13:16:44	claudiub	but later on, I have a meeting soon, so I have to prepare for that. :)
13:17:01	claudiub	but thanks for catching it. :)
13:18:18	madhaviy	mriedem: I am checking fix proposed for LP bug https://bugs.launchpad.net/nova/+bug/1698010, by stephenfin , is there any other way to avoid using dhcp_domain from nova.conf during config_drive metadata creation
13:18:18	openstack	Launchpad bug 1698010 in OpenStack Compute (nova) "neutron-based instances should not use the nova-network 'dhcp_domain' option" [High,In progress] - Assigned to Stephen Finucane (stephenfinucane)
13:19:08	efried	claudiub: Ahcrap, I think I know what's happening.
13:19:28	efried	The method in question is decorated with a thing that accepts *a, **k
13:19:56	claudiub	oh, I see.
13:20:13	claudiub	interesting. :)
13:20:25	efried	sure would be nice to be able to get around that somehow. But that sounds like black magic to me.
13:21:01	claudiub	also, just an fyi, there are still a few other cases in which autospec is not working properly, for example sqlalchemy tends to have decorators which inject arguments in to the call. can't really autospec that. :)
13:22:40	claudiub	well, autospecs are almost useless for methods which have *args / **kwargs
13:23:08	claudiub	not entirely, but still.
13:26:59	mriedem	madhaviy: i don't remember the details of that, but i do remember that the proposed patch wasn't going to work per garyk's comments. i also seem to remember an openstack-dev ML thread about this, but don't recall those details either. i would have to go back and dig into all of this and load it up into my head, which i'm not going to do right now (busy with other stuff), so unless you can summarize it's going to have to wait.
13:29:10	mriedem	i don't see any links to ML discussion in the patches though

Earlier   Later