| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-09 | |||
| 18:20:31 | esberglu | All the other conf related stuff is in upgrade, but I haven't found any adding new group, just moving existing groups | |
| 18:20:42 | esberglu | Feature seems more accurate to me | |
| 18:24:13 | openstackgerrit | Merged openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238 | |
| 18:27:06 | mriedem | esberglu: let me check to see what this is actually doing | |
| 18:28:33 | esberglu | mriedem: Allows a user to specify how much of a physical proc to assign each vCPU | |
| 18:29:40 | mriedem | yeah, don't worry, i've got the fine toothed comb out now | |
| 18:33:36 | openstackgerrit | Merged openstack/nova master: Avoid dumping stack on BuildAbortException https://review.openstack.org/559751 | |
| 18:34:00 | mriedem | esberglu: comments inline | |
| 18:35:27 | mriedem | esberglu: what's with the flavor extra spec mention? | |
| 18:35:35 | mriedem | is that something yet to be added? | |
| 18:40:14 | esberglu | mriedem: Added that flavor extra spec mention after comments from edmondsw | |
| 18:40:56 | edmondsw | what commit? | |
| 18:41:21 | esberglu | edmondsw: https://review.openstack.org/#/c/554688/3/nova/conf/powervm.py@30 | |
| 18:42:45 | mriedem | i'm ok with blaming things on edmondsw | |
| 18:42:51 | edmondsw | works for me :) | |
| 18:43:24 | edmondsw | yeah, we shouldn't mention that if it's only an OOT thing | |
| 18:43:38 | mriedem | i don't even see it in the out of tree driver | |
| 18:43:39 | edmondsw | I didn't realize that was only OOT | |
| 18:43:47 | edmondsw | looking... | |
| 18:44:00 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Log a warning and add nova-status check for old API service versions https://review.openstack.org/557506 | |
| 18:44:10 | mriedem | https://github.com/openstack/nova-powervm/search?utf8=%E2%9C%93&q=proc_unit_factor&type= | |
| 18:44:55 | zzzeek_ | jaypipes edleafe I can look later, though Im not sure SQLite even supports ALTER TABLE for a server default if that's your target DB | |
| 18:44:56 | mriedem | i found https://github.com/openstack/nova-powervm/commit/4bad1ec1654b757c70100fbcc6f51505719d79d9 - and this setting is in the pypowervm lib | |
| 18:45:36 | esberglu | proc_units_factor not proc_unit_factor | |
| 18:45:51 | zzzeek_ | jaypipes edleafe oh but if this is nova / sqlalchemy-migrate then that's another wrinkle | |
| 18:46:01 | edleafe | zzzeek_: it's in one of the functional tests | |
| 18:46:08 | edmondsw | mriedem esberglu misnamed: https://github.com/openstack/nova-powervm/blob/1dc302b7198ad749dc14cc69cf8f2e45e929d132/nova_powervm/virt/powervm/vm.py#L248-L250 | |
| 18:46:26 | zzzeek_ | edleafe: add me to the review and ill try to look later | |
| 18:46:50 | edleafe | zzzeek_: k - thanks | |
| 18:46:59 | mriedem | edmondsw: esberglu: ok, so... | |
| 18:47:09 | mriedem | you're upstreaming a thing from the out of tree driver, | |
| 18:47:10 | edmondsw | and those are in nova as well as nova-powervm | |
| 18:47:13 | edmondsw | no | |
| 18:47:15 | mriedem | for a flavor extra spec that's not part of the same series | |
| 18:47:22 | edmondsw | is is already in nova | |
| 18:47:41 | mriedem | ok powervm:proc_units is in nova yeah i see | |
| 18:47:52 | mriedem | ok can we unclusterfudge the commit message on this along with the config option help and such? | |
| 18:47:59 | edmondsw | https://github.com/openstack/nova/blob/master/nova/virt/powervm/vm.py#L379-L381 | |
| 18:48:16 | edmondsw | yeah, we'll get the right extraspec(s) mentioned | |
| 18:48:22 | edmondsw | good catch, tx | |
| 18:48:25 | mriedem | the default matches what's in the out of tree driver, | |
| 18:48:30 | mriedem | but not what you'd get today with the in-tree driver | |
| 18:48:36 | mriedem | i don't know how you want to resolve that | |
| 18:48:42 | mriedem | i'm inclined to not care about the out of tree default | |
| 18:48:42 | edmondsw | mriedem that's part of the reason for this change | |
| 18:49:03 | edmondsw | the default in the nova driver was not great... and we definitely want it to be consistent | |
| 18:49:43 | edmondsw | it was always meant to be 0.1 by default | |
| 18:49:59 | mriedem | why not change the default in the library? | |
| 18:51:19 | edmondsw | mriedem because pypowervm is used by folks, whereas the powervm driver in nova isn't yet | |
| 18:51:54 | mriedem | if folks are using the out of tree driver, they are getting the out of tree default config opt value, not what's in the library | |
| 18:51:55 | mriedem | yeah? | |
| 18:52:00 | mriedem | but lowly in-tree driver is | |
| 18:52:51 | edmondsw | I mean folks are using pypowervm directly, not only via the oot driver | |
| 18:53:02 | mriedem | folks == powervm? | |
| 18:53:05 | mriedem | *powervc | |
| 18:53:19 | edmondsw | not powervc... it uses nova-powervm | |
| 18:53:20 | edmondsw | but others | |
| 18:53:26 | mriedem | oVirt on Power | |
| 18:53:27 | mriedem | got it :) | |
| 18:53:38 | edmondsw | non-OpenStack folks | |
| 18:54:21 | edmondsw | basically, this is a goof, we release changing the default in nova is lousy, but it was just the best solution in this case | |
| 18:54:29 | edmondsw | s/release/realize/ | |
| 18:54:31 | mriedem | ok, so you don't want to change the default in the library, i get it. then esberglu it's an upgrade release note, not feature | |
| 18:54:43 | edmondsw | yep | |
| 18:55:42 | mriedem | well, it's honestly probably both | |
| 18:56:00 | mriedem | both a new option (feature) and an upgrade since the default for that new option changes the default | |
| 18:56:05 | mriedem | on an existing extra spec | |
| 18:56:23 | mriedem | just do both in a single reno file | |
| 18:56:36 | esberglu | mriedem: Sounds good | |
| 18:56:57 | esberglu | edmondsw: tx for the help, I didn't have as much context, just wanted to fix CI :) | |
| 18:58:04 | edmondsw | anytime :) | |
| 19:11:20 | mriedem | huh, it probably surprises no one that when we shelve offload a server, we null out the host but not it's AZ value | |
| 19:12:47 | mriedem | this is the time where cfriesen_ is supposed to ask if anyone uses shelve | |
| 19:16:29 | mriedem | jmlowe_: hey i'm trying to recreate https://bugs.launchpad.net/nova/+bug/1759924/ on a single node devstack system | |
| 19:16:29 | openstack | Launchpad bug 1759924 in OpenStack Compute (nova) "Port device owner isn't updated with new host availability zone during unshelve" [Medium,Triaged] - Assigned to Matt Riedemann (mriedem) | |
| 19:16:52 | mriedem | jmlowe_: and things are find until i shelve, rename the az from az1 to az2, and then try to unshelve the instance | |
| 19:17:02 | mriedem | it blows up because the AZ filter is looking for az1 which is now gone | |
| 19:17:08 | jmlowe_ | yes | |
| 19:17:29 | mriedem | oh in yours you unshelved to a different az/host | |
| 19:17:31 | jmlowe_ | unshelve will put it anywhere if the original spec doesn't have an az | |
| 19:17:44 | jmlowe_ | correct | |
| 19:17:55 | mriedem | oh yeah, i created this instance with az1 specifically, so it's in the request spec, yeah i'll fix that and retry | |
| 19:18:35 | mriedem | this kind of seems like a bug of it's own, but not sure what we'd do about it | |
| 19:19:05 | mriedem | we'd have to update any shelved instances in an az if we rename that az | |
| 19:20:33 | jmlowe_ | if nothing else, where ever an instance is unshelved it needs to update the device_owner because it is there and that is truth | |
| 19:20:50 | mriedem | jmlowe_: yeah i'm trying to get to that part | |
| 19:21:03 | mriedem | jmlowe_: while you've got az renames on the brain, maybe you'd like to reply to http://lists.openstack.org/pipermail/openstack-operators/2018-March/015029.html with your thoughts | |
| 19:22:06 | jmlowe_ | oh, I effectively did that by putting all my computes into rackwise az | |
| 19:22:28 | jmlowe_ | to get migration to work again I wound up editing the specs | |
| 19:22:47 | mriedem | i bet updating json blobs in the db is super fun | |
| 19:28:50 | mriedem | jmlowe_: ack confirmed http://paste.openstack.org/show/718769/ | |
| 19:36:08 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | |
| 19:36:52 | jmlowe_ | mriedem: it was all the fun you might imagine it to be and then some | |
| 19:38:32 | jmlowe_ | if you could never change the az name because you could never change the spec then az's really become a nightmare for operators and should be avoided at all costs, probably not what people really want | |
| 19:45:38 | mriedem | jmlowe_: what if, for starters, as mentioned in that ML thread, we just didn't allow az renames while there were (alive) instances in those AZs? | |
| 19:45:49 | mriedem | so operators can't shoot themselves in the foot that way? | |
| 19:49:35 | jmlowe_ | Lets say you start with the default "nova", specs wind up with nova in it, how to you create any AZ if you didn't plan on it from the beginning? Do you have to get this right before any people start using your cloud and make sure your guesses never having run a cloud before were correct for all time? | |
| 19:49:55 | mriedem | is nova put into the request spec? | |
| 19:50:21 | mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L895 | |
| 19:50:35 | mriedem | 'nova' shouldn't be in the request spec unless the user specifically requested --availability-zone nova | |