Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-09
01:06:00 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159
01:37:46 openstackgerrit jichenjc proposed openstack/nova master: Avoid live migrate to same host https://review.openstack.org/542689
01:38:02 openstackgerrit jichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception https://review.openstack.org/541152
02:10:02 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145
02:44:18 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
02:46:00 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159
02:55:04 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/openstack/compute/test_hosts.py https://review.openstack.org/559266
02:56:43 openstackgerrit jichenjc proposed openstack/nova master: make metadata doc up to date https://review.openstack.org/559613
04:24:32 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates https://review.openstack.org/556514
04:24:32 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480
04:24:33 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories https://review.openstack.org/559554
04:24:33 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Consult the dictionary for root provider ids https://review.openstack.org/559555
06:12:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (1) https://review.openstack.org/558704
06:22:58 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Improve getting nested providers with capacity https://review.openstack.org/559638
06:28:15 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (2) https://review.openstack.org/558993
06:28:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (3) https://review.openstack.org/559258
06:47:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in test_user_data.py https://review.openstack.org/559264
06:58:25 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/*/test_instance_actions.py https://review.openstack.org/559269
07:09:04 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix the request context in ServiceFixture https://review.openstack.org/558160
07:09:42 openstackgerrit Takashi NATSUME proposed openstack/nova master: Replace mox stubs with stub_out in test_extended_volumes.py https://review.openstack.org/558685
07:29:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/*/test_server_password.py https://review.openstack.org/559649
07:41:32 openstackgerrit Roman Dobosz proposed openstack/nova master: Added weight for aggregate soft (anti) affinity. https://review.openstack.org/556762
07:41:33 openstackgerrit Roman Dobosz proposed openstack/nova master: Add nodes to group hosts to be checked against aggregation https://review.openstack.org/559651
07:57:30 bauzas good morning Stackers
08:08:28 tssurya good morning bauzas
08:11:29 openstackgerrit Zhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722
08:12:51 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
08:24:02 tetsuro good morning
08:40:47 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159
08:47:20 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
08:47:21 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
08:47:21 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240
08:47:22 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340
08:47:22 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344
08:57:52 lyarwood Morning all - https://review.openstack.org/#/c/544238/ +2'd by Matt last week, any additional core reviews would be appreciated.
09:00:41 Sasikiran Hi All, Is there any steps to recover a vm in error state ("Unexpected vif_type=baremetal", "code": 500, "details": " File \"/usr/lib/python2.7/dist-packages/nova/compute/manager.py\", line 375, in decorated_function )
09:25:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/*/test_server_metadata.py https://review.openstack.org/559673
09:38:21 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
09:58:13 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783
09:58:13 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: [RFC] Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171
10:38:55 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242
10:38:56 openstackgerrit Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078
10:38:56 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605
10:38:57 openstackgerrit Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
10:38:57 openstackgerrit Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
10:38:58 openstackgerrit Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
10:53:01 openstackgerrit Kashyap Chamarthy proposed openstack/nova stable/queens: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559700
10:53:28 openstackgerrit Kashyap Chamarthy proposed openstack/nova stable/pike: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559702
11:00:33 kashyap johnthetubaguy: As agreed on the list, bumped the NEXT_MIN versions to whats on Debian Stretch: https://review.openstack.org/558783
11:46:47 openstackgerrit Merged openstack/nova master: conf: Remove 'db_driver' config opt https://review.openstack.org/508487
12:41:04 openstackgerrit sahid proposed openstack/nova master: network: update pci request spec to handle trusted tags https://review.openstack.org/458820
12:41:04 openstackgerrit sahid proposed openstack/nova master: libvirt: configure trust mode for vfs https://review.openstack.org/458514
12:44:24 openstackgerrit Merged openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set https://review.openstack.org/511188
12:51:23 efried lyarwood: I theeeenk there's a bug in your test cases.
12:52:54 ktibi Hi nova, Anyone have already see this issue : when I add a second NIC on my instance, instance hang on reboot, just after random: crng init done :/
12:55:50 lyarwood efried: do I need to reset the mock_get_encryption mock?
12:56:36 efried lyarwood: I'm commenting it up. But 1) .side_effects isn't a thing (it's spelled .side_effect); and 2) when you have .side_effect set, .return_value is ignored.
12:56:58 efried lyarwood: I confirmed by removing those two .side_effects lines (the test still passes)
12:57:09 lyarwood gah, nice catch
12:59:34 efried lyarwood: Okay, commented. Care to fix the formatting since you're respinning anyway? :)
13:01:11 lyarwood efried: sure if you could elaborate a little on why the current style is an issue
13:01:41 efried lyarwood: What I would do is set the side_effect to [{}, {}] and make sure you *don't* raise.
13:02:06 lyarwood efried: right, sorry I was asking about L1553 in driver.py
13:02:14 efried lyarwood: Oh, because a) backslashes are icky, and b) having the second line of the condition at the same indent level as the interior of the condition is icky.
13:02:31 efried For the latter, we have a pep rule... disabled in the nova project. (Couldn't tell you why)
13:02:57 lyarwood efried: kk, right I didn't know there was a pep rule for that, I'll sort that out now as well.
13:03:01 lyarwood efried: thanks :)
13:03:05 efried lyarwood: Thank you
13:13:41 openstackgerrit Merged openstack/nova-specs master: Fix typos in NUMA-aware live migration https://review.openstack.org/558842
13:18:52 sean-k-mooney o/
13:19:02 sean-k-mooney finucannot: are you about?
13:20:58 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238
13:21:30 lyarwood efried: ^ sorry was interrupted, the [{}, {}] case is tested by all of the other swap_volume tests FWIW
13:21:39 lyarwood efried: but I can add it if you really want it in there
13:22:10 efried lyarwood: I figured it was; it would just be a way to make sure your mocks are doing the right thing.
13:22:25 efried lyarwood: Not necessary to add it here.
13:22:59 efried lyarwood: Just sayin, if it had been in there, with .side_effects, it wouldn't have worked as expected, and after some head scratching, you would have found the other bug that everybody missed :)
13:24:50 tblakes mriedem: Does https://review.openstack.org/#/c/555812/ still require the patch you suggested? The review comments at https://review.openstack.org/#/c/559169/ seem to indicate not. If it doesn't require the patch, is https://review.openstack.org/#/c/559158/ then ready to be cherry-picked in to stable/queens?
13:25:11 lyarwood efried: yeah true, I'd need to move this into a seperate method to make testing a little easier, otherwise I'll end up mocking all of swap_volume again.
13:25:34 efried lyarwood: Yeah, I figured that was probably the case. It's fine this way.
13:29:06 efried lyarwood: +2 (with some optional formatting nits)
13:30:30 kholkina Hi! Could you please explain why free_ram_mb + memory_mb_used != memory_mb? How does it calculated?
13:31:02 kholkina I mean values in 'nova hypervisor-show'
13:31:20 lyarwood efried: thanks, can't say I agree with the nit but if others also call it out I'll respin :)
13:32:03 lyarwood urgh sorry that's not good
13:32:03 efried lyarwood: Yeah, I'm sure there's a reason we've got those peps switched off - it must be because the ptb don't care.
13:33:29 efried lyarwood: FYI, this excerpt from tox.ini explains to some extent:
13:33:29 efried # Most of the whitespace related rules (E12* and E131) are excluded
13:33:29 efried # because while they are often useful guidelines, strict adherence to
13:33:29 efried # them ends up causing some really odd code formatting and forced
13:33:29 efried # extra line breaks. Updating code to enforce these will be a hard sell.
13:34:07 efried If I may paraphrase: "Follow these rules unless it results in really odd code formatting or forced extra line breaks"
13:34:24 efried ...which is of course difficult without OCD reviewers (or being OCD yourself)
13:34:32 efried ...which is why the peps exist.
13:41:35 efried mikal: yt?
13:42:13 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238
13:42:14 mriedem tblakes: if jgwentworth says she can't reproduce the problem on master then i guess it's not an issue, especially if we can't recreate with a test
13:44:10 efried mriedem: Quick re-approval for lyarwood: https://review.openstack.org/#/c/544238/
13:44:29 tblakes mriedem: Thanks! I'll abandon https://review.openstack.org/#/c/559169/ and recheck https://review.openstack.org/#/c/559158/.
13:45:21 openstackgerrit Raoul Hidalgo Charman proposed openstack/nova master: Expose shutdown retry interval as config setting https://review.openstack.org/552483

Earlier   Later