Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-04
16:38:19 lbragstad https://review.openstack.org/#/c/523973/ consists of the latest changes
16:38:28 melwitt lbragstad: great, thanks for the heads up
16:39:05 lbragstad melwitt: no problem - let me know if you still want to go through the scope_types thing, too (cc mriedem)
16:45:58 johnthetubaguy lbragstad: I keep meaning to hit that one too
16:50:38 mriedem dansmith: on the heels of this wait_for_instance_event thing, i'm probably going to need a handle to the registered events so that i can cancel them, related to the TODO here https://review.openstack.org/#/c/558001/1/nova/compute/manager.py@6100
16:51:04 mriedem i.e. i need to start waiting before calling the dest compute which returns a flag telling me if i should in fact be waiting
16:51:15 mriedem if dest says it doesn't care, then i need not wait
16:51:50 dansmith um, I'm not sure I understand
16:52:06 mriedem this is the thing where the source waits for vif plugged events,
16:52:13 mriedem pre_live_migration on the dest host does the vif plugging,
16:52:14 mriedem source is waiting
16:52:20 dansmith as long as you do your call to the remote side within the "with wait_for_events.." then whatever
16:52:28 dansmith oh so you don't hang exiting the with?
16:52:30 mriedem the change adds a config option to enable this, because we know some backends in neutron won't send the event unless the port host binding changes
16:52:57 mriedem well, the dest could set the flag saying don't wait, because it's using opendaylight or something
16:53:08 mriedem so then we want the source to not wait the 5 minutes and then die
16:53:21 dansmith right, but you've already entered the context manager at the point at which you realize the destination says not to wait yeah?
16:53:31 mriedem right, not yet in this patch, but that's the TODO
16:53:35 dansmith yeah,
16:53:36 mriedem to avoid a race window
16:54:05 mriedem as mentioned in the commit message, we could arguably say that we assume computes in the same cell to be using the same networking backend and just apply the config from the source host
16:54:08 dansmith so you can just raise in there and catch it outside the context manager.. something like "raise BelayThatOrderCapN()"
16:54:27 dansmith I don't think you need anything more complicated than that
16:55:18 mriedem raise from within the wait_for_instance_event context?
16:55:23 dansmith yeah
16:56:00 mriedem wouldn't that call the error_callback registered with the event?
16:56:34 dansmith not if you don't have one, which you don't right? but either way, handle it in the error_callback if you want
16:57:10 dansmith er, no
16:57:18 dansmith actually if you raise yourself then it doesn't call error_callback even
16:57:23 dansmith that's only if the event fails
16:57:29 dansmith so just raise
16:58:41 mriedem yeah, flow control might get a bit wonky in this code, will have to deal with that
16:59:25 mriedem with the rpc change to the migrate data object we can't backport this either, but it's been such a latent issue maybe it's not something we really care about backporting anyway
16:59:39 dansmith I dunno, you're already catching exceptions around the context manager, so I would think it's just a catch/log/ignore and fall through sort of deal
17:00:09 dansmith oh, well, I guess you need to do that inside maybe
17:00:10 dansmith anyway
17:00:17 dansmith easier that building a cancel mechanism I think
17:00:24 dansmith *than
17:00:46 mriedem yeah i can also refactor our the existing meat if necessary for the part that actually calls the driver to transfer the guest
17:00:55 mriedem these live migration methods tend to get overly complicated
17:01:00 dansmith aye
17:01:01 mriedem *out
17:11:40 openstackgerrit Matt Riedemann proposed openstack/nova master: DRY up test_rollback_live_migration_set_migration_status https://review.openstack.org/555489
17:11:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Avoid unnecessary port update during live migration https://review.openstack.org/556332
17:11:41 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001
17:11:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548
17:11:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604
17:11:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423
17:11:43 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370
17:11:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170
17:11:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947
17:11:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334
17:11:45 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371
17:11:45 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870
17:11:46 openstackgerrit Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537
17:12:06 openstackgerrit Merged openstack/nova master: trivial: Fix nits in code comments https://review.openstack.org/558133
17:12:23 openstackgerrit Merged openstack/nova master: Complement tests in allocation candidates https://review.openstack.org/558135
17:12:24 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: test live_migration_wait_for_vif_plug=True https://review.openstack.org/558006
17:12:50 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: test live_migration_wait_for_vif_plug=True https://review.openstack.org/558006
17:15:01 lbragstad johnthetubaguy: ++ yeah - it'd be awesome to get your input there
17:22:50 openstackgerrit Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
17:22:51 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
18:22:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Noauth should also use request_id from compute_req_id.py https://review.openstack.org/555266
18:22:32 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688
18:23:27 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688
18:31:01 sean-k-mooney dansmith: o/ do you have a minute to weigh in on unit test for the nic feature based schulding change set?
18:31:24 dansmith sean-k-mooney: I dunno, ask and then I'll answer :)
18:32:19 sean-k-mooney dansmith: alot of the test changes look like this https://review.openstack.org/#/c/449257/59/nova/tests/unit/compute/test_resource_tracker.py swapping from dicts to objects. if i do the lazy load change you requested the dict form would still work because we would have two fields.
18:33:12 sean-k-mooney dansmith: i dont want to duplicate all the test but im wondering should i migrate all the tests as i had done before to the object form or keep the dict form
18:33:50 openstackgerrit Merged openstack/nova master: Fix typos in release notes https://review.openstack.org/554175
18:34:03 openstackgerrit Merged openstack/nova master: Remove unnecessary code encoding specification https://review.openstack.org/557903
18:34:06 dansmith sean-k-mooney: well, what you have there doesn't really test anything other than kwarg dispatch of the init of that object,
18:34:12 dansmith which shouldn't be **dict, IMHO
18:34:12 openstackgerrit Merged openstack/nova master: Move pypowervm requirement to 1.1.12 https://review.openstack.org/558254
18:34:21 openstackgerrit Merged openstack/nova master: Remove a outdated warning https://review.openstack.org/557898
18:34:49 dansmith sean-k-mooney: on the field change,
18:34:54 sean-k-mooney well the ** was because i originally used sed for the conversion
18:35:00 dansmith uh huh :)
18:35:32 dansmith you need to add this as a spec_obj field, and yes, I would expect to see at least a test that uses the old dict-y spec field with the rest of the code
18:36:07 sean-k-mooney im going to get rid of the ** but im just wonding if i should get rid of all uses of spec=[{}] and move them to spec_objs=[objects]
18:36:10 dansmith I would expect to make all the existing tests use the object, and add one more new test that just makes sure something basic still works if you only have the dict field set
18:36:17 cdent sean-k-mooney, jaypipes (and dansmith and cfriesen_ you probably know this too): On jay's spec about cpu resource tracking ( https://review.openstack.org/#/c/555081/ ) the existing situation is that any given host can only be shared or dedicated, but not mixed? Is that just an OpenStack/Nova limitation, or is it also a limitation in libvirt/KVM?
18:36:34 dansmith sean-k-mooney: yeah, except for the new test to validate the old dict path
18:36:51 dansmith cdent: just nova AFAIK
18:37:24 sean-k-mooney dansmith: ok ill convert them all to use objects like i had started and then add in test just for the old path thanks.
18:37:32 dansmith sean-k-mooney: yup
18:37:38 cdent so if we get nova sorted (via jay's ideas) we'll need to cook some code in the virtdriver, but not deeper in the stack? cool.
18:38:30 sean-k-mooney cdent: am nova will happliy allow a mixed host but it is not preventing the shared cpus from stomping over the pinned ones today. so we use host aggregates to seperate them
18:39:02 cdent sean-k-mooney: ah, okah, thanks
18:39:36 dansmith right, thatg
18:41:11 melwitt bhagyashris: I have a question about your spec on deleteBackups. my assumption has been that you have users that are currently using rotation '0' to purge backups as a side effect. is that correct?
18:41:59 melwitt *using rotation '0' to the createBackup API
19:07:10 mriedem anyone know the tl;dr on the 'a plan to stop syncing requirements into projects' thread?
19:07:20 mriedem sounds like requirements.txt changes are now all done manually?
19:08:48 dansmith from the oslo room ptg,
19:09:14 dansmith I think they were saying that they would only sync (or manually sync) requirements when the minimum was being raised past what the project has listed
19:09:20 dansmith instead of just always syncing always
19:09:45 sean-k-mooney mriedem: i get why we might want to do this to prevent raising minimums higher then needed but i think we are also losing that auto blacklisting of specific versions e.g. x>1.0,x!=1.1
19:09:48 dansmith so that things like swift can continue supporting the older versions of some libraries they have because of workarounds or lack of actual requirements for the newer one
19:10:23 mriedem i just see that it's throwing people off e.g. https://review.openstack.org/#/c/554679/

Earlier   Later