Posted	Nick	Remark
#openstack-nova - 2018-04-02
21:35:58	arvindn05	yup...but they do handle empty dict...in case of an empty dict, they do not initialize the fields
21:36:14	arvindn05	the if condition there is handling the empty dict case
21:37:29	dansmith	arvindn05: none of this matters since you shouldn't be setting that from from_dict() anyway, per my comment
21:37:58	dansmith	er, wait wait, maybe I'm confused
21:38:07	arvindn05	dansmith: yup...i got that...can we discuss the comment?
21:39:18	arvindn05	http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/glance-image-traits.html#proposed-change
21:40:36	arvindn05	we are adding attributes like below to the image dict to support filtering based on traits expressed in images
21:40:36	arvindn05	trait:HW_CPU_X86_AVX2=required
21:40:36	arvindn05	trait:CUSTOM_TRUSTED_HOST=required
21:40:53	dansmith	arvindn05: yeah I know that part
21:42:22	dansmith	okay, sorry I had this all tangled in my head
21:42:48	dansmith	I was thinking this was the path in for the legacy dict, but this is actually the path in for image meta itself, which calls the name mapping stuff inside here
21:42:52	arvindn05	no problem...sorry i just threw it over the wall
21:45:45	arvindn05	yes...i think. the methods parses all the properties expressed in the image meta data(as a key:value strings) both legacy and non-legacy and creates the ImageMetaProps out of it
21:46:24	dansmith	arvindn05: replying to try to clean up my mess, hang on
21:52:03	dansmith	arvindn05: see if that makes sense
21:52:27	arvindn05	thx..looking at it now
21:52:28	dansmith	something he said about none-ness sent me down the wrong path in thinking what this was about
21:55:23	arvindn05	got it...makes sense
21:55:56	arvindn05	dansmith: thanks...will make the update
21:56:06	dansmith	ack
22:27:45	openstackgerrit	Eric Fried proposed openstack/nova master: Remove deprecated [placement] opts https://review.openstack.org/557086
22:39:08	openstackgerrit	Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795
22:40:43	openstackgerrit	Eric Berglund proposed openstack/nova master: WIP: PowerVM: Cold Migrate & Resize https://review.openstack.org/553583
22:46:41	openstackgerrit	Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795
#openstack-nova - 2018-04-03
00:26:02	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Fix validation for command arguments https://review.openstack.org/558324
00:43:49	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Fix AttributeError in getting a resource ID https://review.openstack.org/558328
01:31:58	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
01:33:11	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
01:48:00	openstackgerrit	Merged openstack/nova master: doc: Upgrade placement first https://review.openstack.org/556631
01:48:09	openstackgerrit	Merged openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821
02:20:41	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix the request context in ServiceFixture https://review.openstack.org/558160
03:38:38	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145
05:07:31	openstackgerrit	Naichuan Sun proposed openstack/nova master: (WIP)xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
05:16:25	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
05:18:58	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
05:24:18	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
05:24:51	openstackgerrit	Naichuan Sun proposed openstack/nova master: (WIP)xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
05:25:45	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
05:25:46	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
05:27:20	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240
05:27:30	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340
05:27:45	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344
05:34:58	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Replace GB with GiB https://review.openstack.org/558364
05:36:22	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Replace GB with GiB https://review.openstack.org/558364
05:36:48	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
07:08:24	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: trivial: Fix nits in code comments https://review.openstack.org/558133
07:08:25	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Complement tests in allocation candidates https://review.openstack.org/558135
07:11:08	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772
07:27:08	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
07:28:29	openstackgerrit	Fan Zhang proposed openstack/nova master: [Trivial]Add missing blank space in conf description https://review.openstack.org/558414
08:02:59	tetsuro	@efied(fried_bunny), jaypipes, edleafe, alex_xu_ : I read through the IRC log in Monday and evacuated https://review.openstack.org/558133 , and https://review.openstack.org/558135 from the “anchor” branch since they can be merged now.
08:03:21	tetsuro	But I think exposing unrequested resources in prov_sum is necessary change for NRP cases, too, if we are going to expose all the NRPs in the tree.
08:03:37	tetsuro	Without this change, how do NRPs that don’t have requested resources appear in prov_sum? Are we going to expose them without resource information?
08:04:12	tetsuro	Could you tell me why we need all the NRPs in the tree? If there aren’t specific and concrete usecase so far, I even don’t think we have to support that all NRP in prov_sum since the design depends on the usecase.
08:04:27	tetsuro	I’m also asking the same question in https://review.openstack.org/#/c/556873/.
08:10:25	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] api-ref: Fix parameters https://review.openstack.org/558142
08:29:54	bauzas	good morning Novaers
08:35:30	fanzhang	oh hi bauzas, sorry to bother. I accidentally found this trivial bug, https://review.openstack.org/#/c/558414/, should I add CI manually to reviewer or just wait? Kind a new to post patch to nova. :)
08:36:25	bauzas	fanzhang: in general, we try to avoid small nit fixes like this one
08:37:28	fanzhang	bauzas yeah, I do think it's not appropriate.
08:37:44	bauzas	fanzhang: to answer your original question, that change is in the queue http://zuul.openstack.org/
08:38:04	bauzas	I can see it there in the check pipeline
08:38:29	bauzas	so you just need to wait until all the jobs are done so that you'd get a Zuul review
08:39:43	bauzas	fanzhang: you can have some docs in https://docs.openstack.org/infra/manual/developers.html#automated-testing
08:40:47	fanzhang	bauzas oh, cool. Thanks. I see there are lots of CI jobs in nova. But we only have a few in trove. I thought maybe nova is not the same as trove. :)
08:41:09	kashyap	alex_xu_: Thanks for reviewing this! https://review.openstack.org/#/c/534384/
08:42:28	fanzhang	bauzas as for the nit fix above, should I abandon it or ?
08:47:05	fanzhang	I noticed there was one trivial fix like above, see https://review.openstack.org/#/c/558183/ . So anything I should do you can just help point it out, thanks :) I do want to know how nova team try to avoid small nit fixes.
08:51:31	johnthetubaguy	fanzhang: we have a list of "trival bug fixes" on this etherpad: https://etherpad.openstack.org/p/rocky-nova-priorities-tracking
08:58:51	fanzhang	johnthetubaguy thanks, looks great :)
08:59:28	kashyap	Is this the magic incantation to "recheck" Citrix XenServer CI? -- 'xenserver: recheck'
09:01:19	kashyap	johnthetubaguy: Meanwhile; this is ready, also has a +2: https://review.openstack.org/#/c/534384/22
09:01:43	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
09:08:10	openstackgerrit	Merged openstack/nova master: Fix a missing white space in exception message https://review.openstack.org/558183
09:10:49	openstackgerrit	Merged openstack/os-vif stable/pike: ovs: do not delete port if already exists https://review.openstack.org/550080
09:17:11	johnthetubaguy	kashyap: ah, good call out, will take another peak at that ASAP
09:41:02	kashyap	Splendid!
09:43:21	kashyap	johnthetubaguy: Oh, darn, so it is the spacing that is causing the output to be all mangled? -- https://review.openstack.org/#/c/534384/22/nova/conf/libvirt.py@546
09:43:24	kashyap	Good catch!
09:45:19	kashyap	johnthetubaguy: Any suggestion to fix that? As it stands, indentation doesn't render
09:45:22	kashyap	stephenfin: You about?
09:45:31	stephenfin	kashyap: I am
09:45:44	kashyap	stephenfin: When you are: I wonder if you have any tricks to get this right: https://review.openstack.org/#/c/534384/22/nova/conf/libvirt.py@546
09:46:00	kashyap	See the rendering, the indentation is gone, and the config is highlighted: http://logs.openstack.org/84/534384/22/check/build-openstack-sphinx-docs/016a796/html/configuration/config.html
09:46:05	johnthetubaguy	kashyap: some of it used to, got standup right now, so distracted
09:46:25	kashyap	stephenfin: `grep` for the the string: "This allows specifying granular CPU feature flags when specifying" to arrive at the right place in the HTML
09:46:28	johnthetubaguy	kashyap: hmm, looks like what I had working is totally broken again
09:46:41	stephenfin	kashyap: It's a bug in oslo_config.sphinxext https://review.openstack.org/#/q/status:open+project:openstack/oslo.config+branch:master+topic:bug/1755783
09:46:55	johnthetubaguy	"* ..." and "\n" used to render OK, but its a bit broken right now
09:47:13	kashyap	stephenfin: Ah, interesting
09:47:45	stephenfin	kashyap: ...which should be fixed soon as those patches are merged. This is the one you care about https://review.openstack.org/553860
09:47:58	kashyap	stephenfin: So I'll add a pointer to your patch series (thanks!). I don't need to make any changes yet, do I?
09:48:11	stephenfin	kashyap: Once that is merged though, there are a couple of things that still need changing. I'll comment now
09:49:55	kashyap	stephenfin: Ah, thank you. I'll subscribe to that 'oslo_config' patch series
09:51:42	kashyap	stephenfin: Hmm, hope that'd be stable branches backports compatible; because I'll be backporting that change to two branches
09:52:01	kashyap	(As it's addressing an important guest perf regression)
09:52:08	stephenfin	kashyap: You're just going to lose some of the docs formatting there, I'm afraid
09:52:18	stephenfin	It'll still render but poorly
09:52:40	kashyap	stephenfin: For backports, you mean?

Earlier   Later