Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-03-28
21:39:53 mikal mriedem: sure, if you want. You've been saying its a low priority the whole time though. You can't have it both ways.
21:39:56 mriedem b/c of the nova-net stuff
21:40:22 mriedem what do i want both ways?
21:40:31 mriedem my point is,
21:40:42 mriedem i don't think you should do more privsep stuff for nova-net specific things when we're going to drop nova-net,
21:40:44 mikal Either you want privsep or you don't. I don't really care either way any more.
21:40:56 mriedem and if that means the privsep conversion isn't done at the end of your current runway, i think that's ok
21:41:26 mriedem also, i'm not the only person here
21:41:30 mikal I've said all along that privsep wouldn't be done at the end of the runway. The last couple of patches which need nova-net to go can just sit around until someone removes nova-net.
21:46:59 efried This seems simple to me. The scope of the runway is the privsep series up to but not including the patches that require nova-net removal. Runways don't have to encompass an entire blueprint. That was something we talked about early on, but later relaxed our stance on.
21:59:39 melwitt agreed, privsep up until the nova-net requiring ones can be done as part of the runway and that's it
22:07:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration https://review.openstack.org/527541
22:10:14 openstackgerrit Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628
22:14:51 mriedem efried: maybe you'd like to rev https://review.openstack.org/#/c/546813/ ?
22:14:57 mriedem i'm itching to +2 that
22:15:06 efried mriedem: sec...
22:16:42 melwitt mikal: earlier today we were talking about metadata API versioning because of a spec review where the proposal wants to change the network_data.json format in a new version. dansmith said new versions can be only additive and that was news to me and mgagne. is that also your understanding? we see this code comment by you above the version list https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L60
22:17:21 melwitt and I'm not aware of any other documentation about the versioning
22:17:23 esberglu mriedem: efried: Sorry I've been caught up in some other stuff. Was planning on hitting that either tonight or 1st thing in the am
22:17:52 efried esberglu: I can punch it rn if you like.
22:19:11 mikal melwitt: I don't think we've ever done a non-additive change, but I'd have to check. The scheme is inherited from ec2, so I guess what they've done might also matter. Mostly this comes down to looking at the cloud-init implementation and seeing how it would handle the data changing.
22:20:19 esberglu efried: If you want to go for it. I'm trying to finish out a bunch system upgrades today
22:21:19 mriedem Kevin_Zheng: just a small change to add to https://review.openstack.org/#/c/536722/ about older computes
22:21:22 mriedem then i'll be +2 again
22:21:37 melwitt mikal: yeah, I think you're right that we haven't done a non-additive change. ack on having to look at cloud-init. although there might be other things consuming the API that might not handle a compat change even if cloud-init does
22:22:04 mikal melwitt: very true. You can totally write a shell script to parse metadata, that's the whole idea.
22:22:14 mikal melwitt: the original cloud-init was in fact a shell script.
22:25:59 mgagne melwitt, mikal: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html
22:26:06 mgagne "The earlier versions are available to you in case you have scripts that rely on the structure and information present in a previous version."
22:26:47 mgagne my understanding of this statement is that newer versions can remove information or change structure in non-backward compatible ways
22:29:01 efried mriedem: Does that reno need to say anything beyond "The PowerVM driver now supports hot plugging/unplugging of network interfaces." ?
22:29:39 mriedem efried: nope
22:29:44 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: Network interface attach/detach https://review.openstack.org/546813
22:29:46 efried mriedem: ight. ^
22:29:57 mriedem thanks
22:29:59 efried My daughter cooked me a steak. I'm out.
22:30:09 esberglu efried: tx
22:30:26 melwitt mgagne: I interpret it the same way. so, the source material for this API was intended to be able to change things between versions and break compat. it will be interesting to see how cloud-init is written and whether it would be insulated to such an API change. (and that's aside from all of the other things people may have written to consume the metadata API)
22:30:55 mikal cloud-init has heavy contributions from amazon, so we're probably ok then
22:31:14 mikal Although the openstack implementation in cloud-init probably doesn't get much love from amazon
22:31:25 melwitt yeah, that's my concern
22:31:28 mikal I do think asking someone to check cloud-init as part of the spec review is reasonable
22:31:39 mgagne melwitt: supported versions are hardcoded: https://git.launchpad.net/cloud-init/tree/cloudinit/sources/helpers/openstack.py?h=ubuntu/xenial#n44
22:32:09 mikal LOL, they're quite far behind.
22:32:35 mikal Unless xenial is shipping an old version?
22:32:36 mgagne that's for xenial, should check for latest
22:32:55 mgagne but it supports network_data.json so I'm happy =)
22:33:41 mgagne same for latest version it seems: https://git.launchpad.net/cloud-init/tree/cloudinit/sources/helpers/openstack.py?h=ubuntu/devel#n44
22:33:42 mikal https://github.com/cloud-init/cloud-init/blob/master/cloudinit/sources/helpers/openstack.py
22:33:46 mikal Trunk is just as far behind
22:34:08 mikal I guess maybe they expect us to be keeping that stuff up to date
22:34:18 mikal That means no vendordata v2 for anyone in cloud-init land for example
22:34:23 mgagne up to date => support older versions ?
22:34:34 mgagne if nobody asks ¯\_(ツ)_/¯
22:34:56 mgagne had to ask for network_data.json and contribute, wasn't easy
22:37:54 dansmith mikal: melwitt mgagne: we've not done non-additive changes in the past, and I don't really see any reason to make that change here.. we can totally do it additive-ly
22:38:20 dansmith we could re-audit all that stuff and make those checks more explicit about version spans (i.e start doing a thing in X, stop doing it in Y) but I don't see the point
22:38:46 dansmith yes, anything consuming latest is playing with fire, but.. shell scripts
22:39:05 mgagne dansmith: sure, just want to make sure we don't force ourselves to abide ourselves to some non-written rules which happens to have no reasons to exist
22:39:54 mgagne I updated spec to keep backward compat
22:43:25 melwitt yeah, ip_address and ip_addresses would be redundant but maybe that's not that big of a deal
22:43:45 melwitt or, ip_address would be redundant
22:52:30 openstackgerrit Michael Still proposed openstack/nova master: Start untangling network utilities. https://review.openstack.org/557542
22:52:31 openstackgerrit Michael Still proposed openstack/nova master: Move two more generic network utilities to a move obvious place. https://review.openstack.org/557543
22:52:42 mikal melwitt: ^--- that's the sort of untangling I was talking about
22:53:54 melwitt ah, okay. thanks for getting that started
22:54:36 mikal melwitt: some of that makes it more apparently that there is some privsep to do in nova.network, event if nova-net is nuked from orbit
22:54:44 mikal melwitt: which wasn't as obvious before
22:55:22 melwitt mikal: so that means, some privsep work is needed to support the utils that are not really part of nova-net?
22:55:51 mikal melwitt: yes, as we split out the bits of nova-net that we need post nova-net, we will find things that need to be privsep'ed
22:56:04 mikal melwitt: none of them look hard to do, but the previous assumption was that all of nova-net was just getting deleted
22:56:07 mikal melwitt: which is not true
22:56:15 melwitt mikal: understood
22:56:43 mikal melwitt: so, these ones got the remove-nova-network bp tag, but could have had the privsep one if we'd wanted to, they're all tangled up together
22:57:04 mikal I don't think you can tag two blueprints. Maybe you can?
22:57:44 melwitt I think you can, but from what I can tell, they make more sense under nova-net removal being that they're decoupling things that need to remain after removing nova-net
22:57:52 mikal Yeah
22:58:04 mikal I also don't care how they're tagged as long as they get reviewed one day
22:58:12 melwitt that work would have to be done anyway to remove nova-net, even without privsep
22:58:16 mikal I'mma just going to keep rebasing them and smashing the gate until someone gives in and reviews them
22:58:18 melwitt yeah, same
22:58:46 mikal Given we're up to 13 interrelated patches so far, and that list will grow
22:58:57 openstackgerrit Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990
22:58:57 openstackgerrit Dan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value https://review.openstack.org/555851
22:58:58 openstackgerrit Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728
22:58:58 openstackgerrit Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002
22:58:59 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement https://review.openstack.org/557490
22:58:59 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282
#openstack-nova - 2018-03-29
00:40:36 openstackgerrit Michael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module. https://review.openstack.org/557552
01:21:54 Spaz-Home Annnnd weekend over
01:29:57 openstackgerrit Jake Yip proposed openstack/nova master: Add --before option to db archive_deleted_rows https://review.openstack.org/556751
01:37:10 openstackgerrit Zhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722
01:37:11 openstackgerrit Merged openstack/nova stable/queens: Change compute mgr placement check to region_name https://review.openstack.org/555901
01:47:42 openstackgerrit jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150
02:14:58 openstackgerrit jichenjc proposed openstack/nova master: WIP: remove ec2 in service and cmd https://review.openstack.org/556778
02:14:59 openstackgerrit jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150
02:14:59 openstackgerrit jichenjc proposed openstack/nova master: WIP: remove db ec2 https://review.openstack.org/557572
02:56:23 openstackgerrit jichenjc proposed openstack/nova master: Move update_task_state out of try/except https://review.openstack.org/557152
03:00:50 openstackgerrit Jianle He proposed openstack/nova-specs master: Back up volume-backed-instance https://review.openstack.org/530214
03:01:22 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Fix endpoint URI /allocation_requests https://review.openstack.org/557580

Earlier   Later