| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-26 | |||
| 18:32:26 | melwitt | tssurya: but when I was thinking about it later, if we have queued_for_delete (from your spec) that was the main missing piece preventing us from being able to count instances in the instance_mappings table. the other piece is user_id | |
| 18:33:21 | melwitt | the "queued_for_delete" column was controversial in the past, but now that it's not, it opens that door again | |
| 18:33:38 | tssurya | melwitt: yea I agree, I guess I will go ahead with the queued_for_delete and will leave out the user_id for a separate spec and we (you) can battle out adding the "type" with the placement guys later | |
| 18:33:50 | melwitt | user_id I think is not controversial because we already have project_id, I'm actually not sure why we didn't add user_id too | |
| 18:34:27 | tssurya | melwitt: the reason I was asking for the user_id is because I could do these two in the same spec if you want like dansmith said its one migration | |
| 18:34:48 | melwitt | tssurya: sounds good | |
| 18:35:15 | melwitt | tssurya: yeah, I agree with him that it can be one migration, just two specs where each problem being solved for down cells is described in detail separately | |
| 18:35:23 | melwitt | just so it's easier to organize | |
| 18:36:30 | tssurya | melwitt: cool, I was waiting to get your opinion too, so I will do it in two specs, one for nova-list/service-list when a cell is down, second for quotas when a cell goes down, however I won't touch any from placement | |
| 18:36:39 | tssurya | calculations since you already have a spec | |
| 18:37:45 | melwitt | tssurya: okay, won't that mean we would have three specs then? I was thinking I would just roll the "add user_id column" stuff into the spec I have https://review.openstack.org/#/c/509042 | |
| 18:38:23 | melwitt | and then also add reference to your spec where it depends on your queued_for_delete column | |
| 18:38:35 | tssurya | melwitt: oh yes that's fine with me | |
| 18:38:54 | tssurya | melwitt: so I will do one single spec with queued_for_delete, | |
| 18:39:06 | tssurya | melwitt: sounds good ? | |
| 18:39:11 | melwitt | tssurya: yep sounds good | |
| 18:39:30 | tssurya | melwitt: thank you | |
| 18:40:37 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | |
| 18:52:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | |
| 18:52:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | |
| 18:52:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | |
| 18:52:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value https://review.openstack.org/555851 | |
| 18:52:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | |
| 18:52:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | |
| 18:52:14 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | |
| 19:16:00 | imacdonn | mriedem or toabctl : either of you around ? | |
| 19:19:47 | imacdonn | mriedem toabctl In case you show up while I'm at lunch:) Regarding https://github.com/openstack/nova/commit/3a3b0f09db318faf1a1ea711a73bb365cab8b233 - I think we have the same issue with the "image" service, if glance.api_servers is not configured (which is recommended) | |
| 19:21:54 | imacdonn | efried: your name is on this too :) https://github.com/openstack/nova/blob/master/nova/image/glance.py#L114-L116 | |
| 19:23:03 | mriedem | imacdonn: 'image' is already in that list https://github.com/openstack/nova/commit/3a3b0f09db318faf1a1ea711a73bb365cab8b233#diff-c83f1fae2a677ed29036e293dd0e63caR121 | |
| 19:23:09 | efried | yeah, what he said. | |
| 19:23:19 | mriedem | devstack doesn't set glance.api_servers either | |
| 19:23:47 | imacdonn | oh yeah, I'm blind | |
| 19:23:53 | imacdonn | I wonder why I'm getting this, then... | |
| 19:24:23 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] File "/usr/lib/python2.7/site-packages/nova/image/glance.py", line 126, in get_api_servers | |
| 19:24:23 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] endpoint = utils.get_endpoint(ksa_adap) | |
| 19:24:23 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] File "/usr/lib/python2.7/site-packages/nova/utils.py", line 1373, in get_endpoint | |
| 19:24:23 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] "interfaces: %s" % interfaces) | |
| 19:24:27 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] EndpointNotFound: Could not find requested endpoint for any of the following interfaces: ['internal', 'public'] | |
| 19:24:41 | mriedem | i probably know why | |
| 19:24:54 | mriedem | https://review.openstack.org/#/c/554703/ | |
| 19:25:32 | imacdonn | 4 days ago, eh? that seems plausible | |
| 19:26:57 | imacdonn | will have to see if I'm doing something "the old way" ... removed the api_servers option to try to be current :) | |
| 19:27:59 | imacdonn | I guess maybe it's the code, not me ... not using versioned notifications | |
| 19:31:44 | mriedem | this isn't about versioned notifications | |
| 19:31:56 | mriedem | it's about notifications sent during periodic tasks where we don't have a token | |
| 19:32:26 | imacdonn | You comment says "there isn't much the operator can do about it outside of (1) switching entirely to versioned notifications, which not many people are using yet if at all, or ...." | |
| 19:32:27 | openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | |
| 19:32:32 | efried | cdent: For nosey parkers ^ | |
| 19:39:35 | openstackgerrit | melanie witt proposed openstack/nova master: Migrate tempest-dsvm-multinode-live-migration job in-tree https://review.openstack.org/555945 | |
| 19:42:29 | openstackgerrit | Eric Fried proposed openstack/nova master: doc: Upgrade placement first https://review.openstack.org/556631 | |
| 19:42:40 | efried | mriedem, jaypipes, dansmith, sean-k-mooney cdent edleafe ^ | |
| 19:57:06 | openstackgerrit | Eric Fried proposed openstack/nova master: Get rid of 406 paths in report client https://review.openstack.org/556633 | |
| 19:57:17 | efried | mriedem, jaypipes, dansmith, sean-k-mooney cdent edleafe and ^ | |
| 19:57:27 | efried | dev ML note coming soon | |
| 19:57:56 | cdent | efried is a stack not a queue | |
| 19:58:26 | efried | cdent: Too true, much to my dismay. | |
| 19:58:48 | cdent | takes all kinds | |
| 20:02:48 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | |
| 20:02:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | |
| 20:02:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | |
| 20:02:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | |
| 20:02:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | |
| 20:02:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | |
| 20:02:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | |
| 20:02:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | |
| 20:02:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 20:02:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | |
| 20:05:09 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement stable/queens: Migrate legacy-osc-placement-dsvm-functional job in-tree https://review.openstack.org/556635 | |
| 20:09:48 | mriedem | esberglu: why is tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON.test_create_list_show_delete_interfaces_by_network_port[id-73fe8f02-590d-4bf1-b184-e9ca81065051,network] skipped in https://review.openstack.org/#/c/546813/ ? | |
| 20:15:32 | openstackgerrit | Merged openstack/nova master: Standardize '_get_XXX_constraint' functions https://review.openstack.org/385071 | |
| 20:23:40 | cfriesen | Suppose I have a stopped instance. I then restart nova-compute. It appears that _init_instance() will call self.driver.plug_vifs() unconditionally. Is this expected/necessary? Won't we call plug_vifs from the power_on() code anyways? | |
| 20:36:31 | openstackgerrit | Merged openstack/nova master: tox: Fix indentation https://review.openstack.org/556543 | |
| 20:38:15 | esberglu | mriedem: We're working on a solution to that. Right now to attach interfaces we need to wait for the RMC connection to become active for the instance | |
| 20:38:32 | esberglu | Which takes a really long time (like 10 minutes) | |
| 20:39:01 | esberglu | We're trying to get something going in our CI that will pre-spawn the instances so that they are ready by the time tempest gets to that test | |
| 20:41:59 | mriedem | esberglu: ok then you just have some small things to update in that patch and i'll be +2 on it | |
| 20:43:06 | esberglu | mriedem: ack. Thanks for the review | |
| 20:47:36 | efried | mriedem: D'oh, I totally shoulda thought to send that mail to the ops list. Thanks for forwarding. | |
| 20:59:19 | imacdonn | mriedem efried Another stupid question.... for things like neutron, placement, etc., is it reasonable to assume that if I don't need to override them, the keystone stuff from [keystone_authtoken] (auth_url, auth_type, etc.) should apply? It seems somewhat inconsistent .. e.g. it seems to work for cinder, but not for neutron | |
| 21:00:30 | efried | imacdonn: Some services operate under admin context, some user context, some both depending on the code path. | |
| 21:01:53 | efried | imacdonn: ...uuhhhh, and that's apparently all I've got to say on that. | |
| 21:02:07 | efried | imacdonn: I was composing more stuff to say and realized I really don't know how it works. | |
| 21:02:15 | efried | I would have to go do some digging. | |
| 21:02:19 | imacdonn | efried: heh, OK ... thinking through this ... does it mean that cinder is working because it's reusing the user's auth token ? | |
| 21:02:47 | efried | I think sdague probably has this in his head without sleuthing. | |
| 21:03:59 | sdague | imacdonn: it is working because it uses the user's token | |
| 21:04:18 | imacdonn | sdague: right ... that makes sense .. thanks | |
| 21:04:29 | sdague | the prefered model is the user auths to the first service or keystone, and then that token gets used for the users through the whole flow | |
| 21:04:58 | sdague | which ensures that if there is a bug in the code, the user permissions restrict how much damage they can do | |
| 21:05:53 | imacdonn | sdague: Understood. It makes sense now. | |
| 21:10:07 | openstackgerrit | Eric Fried proposed openstack/nova master: doc: Upgrade placement first https://review.openstack.org/556631 | |
| 21:22:12 | cfriesen | does anyone know why we call driver.plug_vifs() in _init_instance() for a stopped instance? | |
| 21:22:19 | cfriesen | looks like that code has been there forever | |
| 21:23:03 | cfriesen | I'm wondering if it's a lowest-common-denominator virt driver thing | |
| 21:23:08 | kashyap | cfriesen: melwitt: dansmith: Since I'm awake, thinking a bit more on https://review.openstack.org/#/c/534384/15/nova/virt/libvirt/driver.py: While I agree that failing at Nova start up is better it seems better to hard-fail _at_ instance start up, much like we do for 'mode' and 'model'? | |
| 21:23:33 | kashyap | If you see we're actually hard-failing for 'custom' and 'mode' just in the driver.py file | |
| 21:24:05 | cfriesen | kashyap: arguably we should hard-fail those at nova-compute startup too. | |
| 21:24:08 | kashyap | IMHO, it just is consistent (for better or worse) to raise exception.Invalid()fail for the closely related 'extra_flags' too. | |
| 21:24:13 | kashyap | cfriesen: Yes, exactly! | |
| 21:24:20 | kashyap | cfriesen: But that's a surgery for different day | |