Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-03-20
21:45:13 mriedem efried: np, thanks for the quick review
21:47:36 mriedem hongbin: yikun: Kevin_Zheng: easy bug https://bugs.launchpad.net/nova/+bug/1757273
21:47:38 openstack Launchpad bug 1757273 in OpenStack Compute (nova) "nova-compute fails to start even if [placement]/region_name is set" [Medium,Triaged]
21:53:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove RequestContext.instance_lock_checked https://review.openstack.org/554378
22:29:37 mriedem i wonder if anyone that uses DVR also uses shared ephemeral storage (rbd imagebackend) and live migration (HP cloud anyone?)
22:29:53 mriedem because i'm pretty sure we don't cleanup on failed live migration properly in that case
22:30:26 mriedem https://github.com/openstack/nova/blob/3fd863d8bf2fa1fc09acd08d976689462cffd2e3/nova/compute/manager.py#L6506 will also cleanup some stuff we put in the port's binding profile for DVR during live migration,
22:30:42 mriedem but if do_cleanup is False, which it is if you're using shared ephemeral storage, then we don't clean that up
22:40:59 efried mriedem: Are you talking specifically libvirt?
22:41:35 efried Cause that sounds like something we either support already or will support shortly in PowerVM (out of tree).
22:41:58 mriedem for shared local disk?
22:42:14 mriedem https://github.com/openstack/nova/blob/3fd863d8bf2fa1fc09acd08d976689462cffd2e3/nova/compute/manager.py#L6185
22:42:39 mriedem looks like that is also checked for xen and hyperv
22:43:33 mriedem anyway, https://github.com/openstack/nova/blob/3fd863d8bf2fa1fc09acd08d976689462cffd2e3/nova/compute/manager.py#L6524 is totally doing more than just cleaning up local disk created on the dest host for non-shared storage
22:43:39 mriedem it's also cleaning up network stuff on the dest host
22:45:09 mriedem added back in mitaka https://review.openstack.org/#/c/227897/
22:45:18 mriedem oh nvm, that was the error handling
22:47:24 mriedem wow added long ago https://review.openstack.org/#/c/4646/
22:47:35 mriedem essex
22:48:20 efried Gotta run
23:27:11 openstackgerrit Michael Still proposed openstack/nova master: Move configurable mkfs to privsep. https://review.openstack.org/551921
23:27:12 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi xenstore_read's to privsep. https://review.openstack.org/552241
23:27:14 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242
23:27:14 openstackgerrit Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078
23:27:15 openstackgerrit Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
23:27:15 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605
23:27:23 openstackgerrit Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
23:27:25 openstackgerrit Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
23:59:36 openstackgerrit melanie witt proposed openstack/nova master: Remove useless run_periodic_tasks call in ClientRouter https://review.openstack.org/554381
#openstack-nova - 2018-03-21
00:23:38 mriedem alex_xu_: gmann_: there is a question in here about API validation outside of the json schema, would be nice to get your input https://review.openstack.org/#/c/546925/
00:49:31 gmann_ mriedem: sure, ll check
01:08:31 Kevin_Zheng mriedem got it
01:38:17 mriedem johnthetubaguy: thanks for the review on https://review.openstack.org/#/c/520248/ - i didn't see the -1 until now; as for the script thing where someone starts using an IP before the server is ready, we don't show the server address while it's building
01:38:54 mriedem because of this fun guy https://github.com/openstack/nova/blob/3fd863d8bf2fa1fc09acd08d976689462cffd2e3/nova/conf/api.py#L264
01:39:40 mriedem gmann_: btw, i think you can remove that option now, it's been over 3 months
01:39:42 mriedem ^
01:47:57 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add [placement]/region_name to compute manager placement config check https://review.openstack.org/554759
01:56:42 yikun mriedem, sorry, I misunderstand your means to have to use the schema to validate per-policy rule. : )
01:56:43 yikun so, you mean it's just a code validation after schema validation, right?
01:57:11 mriedem yikun: yes, since we can't define a mapping in the json schema document
01:57:26 mriedem not that i know of anyway, without some custom schema code
01:59:21 yikun ok, got it. :)
02:06:31 mriedem but alex_xu_ might have other ideas
02:06:40 mriedem anyway, time for me to stop working, ttyl
02:39:14 openstackgerrit Julia Kreger proposed openstack/nova master: WIP: Add microversion to ironic client wrapper call https://review.openstack.org/554762
02:48:56 vivsoni_ if we have two compute node, compute1 & compute2
02:49:13 vivsoni_ and if we create nova instance1 from compute1
02:49:31 vivsoni_ then is that instance1 visible from compute2 as well
02:49:32 vivsoni_ ?
02:50:16 vivsoni_ i mean when i execute 'nova list' command from compute2, will that instance1 will be listed ?
03:12:37 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925
03:14:59 yikun mriedem, :), thanks, have a good rest.
03:17:09 yikun and alex_xu_ any other idea about it, : ) Cloud you give me some advice about how to validate? https://review.openstack.org/#/c/546925/
04:16:24 diga jaypipes: Hi
04:17:36 diga jaypipes: I have assigned https://bugs.launchpad.net/nova/+bug/1751692 bug to me from the shared list
04:17:37 openstack Launchpad bug 1751692 in OpenStack Compute (nova) "os_region_name an unnecessary required option for placement " [Low,Triaged] - Assigned to Digambar (digambarpatil15)
04:36:21 openstackgerrit Michael Still proposed openstack/nova master: Remove duplicative implementation of temporary directories. https://review.openstack.org/554791
04:36:22 openstackgerrit Michael Still proposed openstack/nova master: Use a pythonic delete. https://review.openstack.org/554792
04:36:22 openstackgerrit Michael Still proposed openstack/nova master: Use a pythonic delete, with a retry. https://review.openstack.org/554793
05:43:32 gmann_ yikun: i think we can do using json schema with power of oneOf/anyOf. i wrote my comments on patch
05:44:02 gmann_ yikun: oneOf might be good here as at a time only 1 policy can exist
06:15:16 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772
06:30:17 openstackgerrit jichenjc proposed openstack/nova master: mv generate_glance_url to get_image_endpoint_url https://review.openstack.org/511400
06:32:03 openstackgerrit jichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception https://review.openstack.org/541152
06:32:52 yikun gmann_, Thanks, cool, ``oneOf`` is like a powerful enum, and we can use it in here.
06:32:59 yikun gmann_, and for the things about policy name, I just think it's ok to me to change ``policy`` to ``name``, and do some convert in api to transfer this ``name`` to the ``policy`` in db.
06:34:43 openstackgerrit jichenjc proposed openstack/nova master: Move placement test cases from db to placement https://review.openstack.org/553149
06:38:45 yikun gmann_, actually, the 'name/type' also as a alternative name for policy, as I mentioned, in PS2:
06:38:45 yikun https://review.openstack.org/#/c/546925/2/specs/rocky/approved/allow-specifying-limit-for-affrinity-group.rst@49
06:39:00 yikun But I thought it seems we need keep consist between api and db, so, in current PS, I use the 2 times policy which look like a bit redundant.
06:55:41 openstackgerrit zhufl proposed openstack/nova master: Fix api-ref: nova image-meta is deprecated from 2.39 https://review.openstack.org/554813
06:59:08 openstackgerrit jichenjc proposed openstack/nova master: Remove quota reserve/commit/rollback https://review.openstack.org/521470
07:07:47 openstackgerrit jichenjc proposed openstack/nova master: deprecate fping_path config option https://review.openstack.org/526602
07:53:56 openstackgerrit jichenjc proposed openstack/nova master: Add more functional test for placement.usage https://review.openstack.org/513264
07:59:19 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
08:05:37 gmann_ yikun: i see, just respond. changing to name looks ok to me.
08:06:22 gmann_ yikun: i will give try to test the schema in parallel but tomorrow as it is holiday in japan so not allowed to work much due to wife order :)
08:07:26 openstackgerrit jichenjc proposed openstack/nova master: Remove translate and a TODO https://review.openstack.org/554827
08:08:04 yikun ha, really thanks, and I also try it now, but it seems doesn't work, I'm trying to find the reason.
08:08:10 yikun gmann_,
08:08:13 yikun ^
08:08:36 gmann_ ohk, sure
08:24:17 yikun gmann_, good msg, it works.
08:24:21 yikun it didn't work well before, the reason is a typo in "s/aditionalProperties/additionalProperties",
08:24:29 yikun sorry, I just copy from your comment and didn't find this tiny typo.
08:24:32 yikun and my result paste here:
08:24:37 yikun http://paste.openstack.org/show/707232/
08:26:45 gmann_ yikun: ahhh, thanks that's my bad finger when editing on vim :) good to hear that worked
08:29:03 yikun gmann_, lol, I will update specs later, and have a good holiday. : )
08:29:39 gmann_ yikun: thanks, ll review that once you push new version.
08:33:13 openstackgerrit Merged openstack/nova stable/ocata: Fix joins in instance_get_all_by_host https://review.openstack.org/511682
09:12:02 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925
09:37:26 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
09:37:26 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
09:37:27 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240
09:37:27 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340
09:37:28 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344
09:41:03 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
09:41:04 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240
09:41:04 openstackgerrit jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340

Earlier   Later