| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-20 | |||
| 19:45:30 | mriedem | it's not like we return links to volumes and ports in the notification either | |
| 19:45:38 | mriedem | sean-k-mooney: i agree | |
| 19:45:42 | melwitt | yeah, the only other thing I can think of for fixing the periodic task is if we could somehow seed periodic tasks with the service catalog instead of the empty get_admin_context() one, but I don't know what would be involved there | |
| 19:46:10 | melwitt | I guess it anyway won't be able to get any info from glance even if it had the catalog, it would just fail later, right? | |
| 19:46:34 | mriedem | the notification path here isn't actually doing a GET to glance | |
| 19:46:47 | efried | Yeah, I'm not worried about that bit at all. | |
| 19:46:49 | mriedem | it's getting the service catalog from keystone via ksa | |
| 19:46:53 | melwitt | meaning, it won't do that even if it has the catalog? | |
| 19:46:54 | mriedem | but w/o a token | |
| 19:47:05 | melwitt | okay | |
| 19:47:27 | mriedem | so for now, the easiest thing to do probably do is in this notification code, handle EndpointNotFound and just set the image_ref_url to the image id | |
| 19:47:36 | efried | are context hashable? | |
| 19:47:45 | mriedem | they are serializable | |
| 19:47:46 | dansmith | edleafe: hmm, so member_of with multiple aggregates is doing an "or" of all the ones you pass, right? is that what we really want? | |
| 19:47:51 | openstackgerrit | Merged openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631 | |
| 19:47:54 | efried | so probably | |
| 19:48:00 | mriedem | efried: i'd rather not do crazy cache shit with contexts | |
| 19:48:02 | openstackgerrit | Merged openstack/nova master: api-ref: add a note in DELETE /os-services about deleting computes https://review.openstack.org/553598 | |
| 19:48:14 | mriedem | we already have some craziness with contexts and periodics today pulling off the local thread storage | |
| 19:48:22 | mriedem | which totally effs with request id log tracing | |
| 19:48:23 | efried | mriedem: I was just going to experiment, cool yer jets. | |
| 19:48:33 | mriedem | i will not cool my jets or hold my horses | |
| 19:48:51 | melwitt | slow your roll | |
| 19:48:57 | mriedem | this is the part that blows up https://github.com/openstack/nova/blob/master/nova/notifications/base.py#L397 | |
| 19:48:58 | openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | |
| 19:49:54 | sean-k-mooney | mriedem: is instance.image_ref the image id? | |
| 19:51:18 | melwitt | gdi I tried to set the importance at the same time as mriedem and set it differently. will set it back | |
| 19:53:34 | openstackgerrit | Eric Young proposed openstack/nova master: Support extending attached ScaleIO volumes https://review.openstack.org/554679 | |
| 19:54:17 | mriedem | sean-k-mooney: yes | |
| 19:54:28 | melwitt | mriedem, efried: are one of you going to propose the patch or shall I? | |
| 19:54:38 | mriedem | i can push a patch | |
| 19:54:43 | melwitt | k | |
| 19:54:44 | mriedem | if LP would not timeout on me | |
| 19:55:15 | openstackgerrit | Michael Still proposed openstack/nova master: Move configurable mkfs to privsep. https://review.openstack.org/551921 | |
| 19:55:15 | openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi xenstore_read's to privsep. https://review.openstack.org/552241 | |
| 19:55:16 | openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242 | |
| 19:55:16 | openstackgerrit | Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078 | |
| 19:55:17 | openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605 | |
| 19:55:17 | openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | |
| 19:55:18 | openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | |
| 19:55:18 | openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | |
| 19:56:35 | sean-k-mooney | mriedem: one other tought. you said if you get an endpoint not found you would set image_ref_url to the image id. any reason to not always use the image id? | |
| 19:57:01 | mriedem | sean-k-mooney: i said above, it changes the api | |
| 19:57:10 | mriedem | in this case, meh | |
| 19:57:18 | mriedem | we can change the payload for the versioned notifications later, | |
| 19:57:22 | mriedem | but this also goes in the legacy notifications | |
| 19:57:24 | jaypipes | guh, this day turned into a giant disaster. | |
| 19:57:38 | sean-k-mooney | mriedem: yes but we could have a microverion for that no? oh this is an unversioned notification | |
| 19:57:39 | mriedem | jaypipes: i have a photo that might make your day better | |
| 19:57:43 | efried | jaypipes: Sokay, I still haven't gotten through those two patches yet. | |
| 19:57:56 | jaypipes | efried: no worries, duder. today's pretty much a goner for me. | |
| 19:58:17 | sean-k-mooney | jaypipes: how did the dentist go. | |
| 19:58:20 | jaypipes | efried: suffice to say it involves me cleaning up a giant pile of dog shit in the back of my car in the rain. | |
| 19:58:29 | jaypipes | efried: ^ not related to the dentist | |
| 19:58:36 | mriedem | but at least your teeth are clean | |
| 19:58:37 | efried | jaypipes: Geez, you try to do something nice for the dog... | |
| 19:58:51 | jaypipes | indeed. | |
| 19:58:53 | mriedem | unless there was...splatter | |
| 19:59:21 | sean-k-mooney | mriedem: ew, let hop not for jaypipes sake | |
| 19:59:24 | efried | jaypipes: You want a quick feeling of satisfaction, https://review.openstack.org/#/c/545111/ ought to be eligible for quick-approve :) | |
| 19:59:29 | sean-k-mooney | *hope | |
| 19:59:55 | mriedem | efried: i'll take a look again at that after this | |
| 19:59:57 | jaypipes | my dogs have become a nested provider tree with inventory of DOG_SHIT_KG | |
| 20:00:07 | efried | rofl | |
| 20:00:08 | mriedem | CUSTOM_DOG_SHIT_KG? | |
| 20:00:11 | tssurya | lol | |
| 20:00:14 | jaypipes | yes, sorry. | |
| 20:00:19 | jaypipes | well corrected, mriedem | |
| 20:00:22 | mriedem | :) | |
| 20:00:31 | sean-k-mooney | mriedem: i dont know me might want to standarise it | |
| 20:01:03 | jaypipes | sean-k-mooney: os-dog-poop? | |
| 20:01:26 | jaypipes | though that's a big specific. os-poop would be more generic and future proof. | |
| 20:01:27 | efried | Well, we already have os-brick | |
| 20:01:35 | jaypipes | well played efried | |
| 20:01:39 | sean-k-mooney | jaypipes: you know im surprised you have not come up with an os-pug yet | |
| 20:03:16 | jaypipes | sean-k-mooney: Provider Usage Group. | |
| 20:03:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't log a warning for InstanceNotFound with deleted VIFs https://review.openstack.org/554591 | |
| 20:07:34 | dansmith | jaypipes: loaded question for you in here: https://review.openstack.org/#/c/544694/2/specs/rocky/approved/alloc-candidates-member-of.rst | |
| 20:07:40 | mriedem | efried: edmondsw: question inline about evacuate https://review.openstack.org/#/c/545111/ | |
| 20:10:03 | edmondsw | mriedem looking | |
| 20:10:36 | mriedem | also, | |
| 20:10:53 | mriedem | at some point, we should not have powervm specs for 'implement random feature parity stuff in our driver', | |
| 20:11:04 | mriedem | just do what other virt drivers do and have specless feature parity blueprints per feature in questoin | |
| 20:11:34 | sean-k-mooney | mriedem: for https://review.openstack.org/554591 are the network-vif-deleted event generated by neutron port being deleted as part of instance deleteion or are they neutron vif unplugged events form the ports being removed from ovs? | |
| 20:11:40 | efried | mriedem: That would be lovely. Are we at that point yet? | |
| 20:11:52 | mriedem | efried: i'm ok with that if melwitt is | |
| 20:12:17 | mriedem | sean-k-mooney: the former | |
| 20:12:29 | melwitt | mriedem, efried: sounds fine to me | |
| 20:12:52 | efried | Cool beans. edmondsw esberglu ^. | |
| 20:12:52 | sean-k-mooney | mriedem: ok then ya that makes sense to me. i just was not sure where the event was comming from | |
| 20:13:26 | efried | mriedem, melwitt: But for this release, since we're already here, use the bp/spec that's proposed, yah? | |
| 20:13:39 | mriedem | shrug, i personally don't care for the wishlist | |
| 20:13:53 | mriedem | because it just seems really random | |
| 20:13:55 | melwitt | is the proposed spec all just feature parity stuff? | |
| 20:14:05 | mriedem | and i see adding support for hot plugging vifs was added after PS3 | |
| 20:14:05 | efried | melwitt: yes | |
| 20:14:05 | edmondsw | I'm happy to abandon this and start using specless blueprints this release | |
| 20:14:13 | efried | ++ | |
| 20:14:31 | mriedem | there are no actual design details in the spec, so it's not really useful imo | |
| 20:14:34 | sean-k-mooney | mriedem: so just to follow on from that, does that mean if i delete a neutron port that is bound to an instance that automatically results in a notifcation to nova to call detach interface on the virt driver? | |