| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-20 | |||
| 15:18:26 | dansmith | there are several still that have a method and just pass | |
| 15:18:39 | dansmith | are those converted and "removed" or are those things we just don't do anything for? | |
| 15:19:02 | mriedem | can you give an example? | |
| 15:19:04 | stephenfin | For example? | |
| 15:19:17 | dansmith | def plug_802qbg(self, instance, vif): | |
| 15:19:17 | dansmith | pass | |
| 15:19:23 | stephenfin | I went through and removed some others ones a while back. IIRC, everything else was still needed. See commit 1b872996d08b01a1b8a1e82d13d6d7b06bc3aa01 | |
| 15:19:40 | mriedem | ok that's in nova.virt.libvirt.vif | |
| 15:19:54 | dansmith | I was probably reading ivs and ovs and just assumed we had orphaned all this code, but if we're removing them as we can, that's cool | |
| 15:19:55 | dansmith | mriedem: right | |
| 15:20:14 | mriedem | i guess there is no plug for 802qbg but there is a get_config method for it | |
| 15:20:57 | stephenfin | Hmm, I'm not sure about that one. We do getattr magic somewhere in there so it's tricky to figure out what's called and what's dead | |
| 15:21:13 | mriedem | 2.1 is changed to 21 | |
| 15:21:15 | mriedem | so it becomes 802qbg | |
| 15:21:25 | mriedem | the os-vif conversion code looks for _nova_to_osvif_vif_802_1qbg | |
| 15:21:31 | mriedem | because the vif type is "802.1qbg" | |
| 15:23:09 | stephenfin | Which raised NotImplemented? | |
| 15:23:14 | stephenfin | *raises | |
| 15:23:16 | mriedem | yes | |
| 15:23:34 | mriedem | i don't know why we don't have to plug/unplug those, but we have to get the config apparently for the guest | |
| 15:24:21 | mriedem | um https://github.com/openstack/os-vif/blob/master/os_vif/objects/vif.py#L263 | |
| 15:24:25 | mriedem | https://github.com/openstack/os-vif/blob/master/os_vif/objects/vif.py#L277 | |
| 15:24:30 | mriedem | seems we could convert two right there | |
| 15:25:00 | dansmith | the reason I'm asking is around removing our linux_net module | |
| 15:25:05 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/537897 | |
| 15:25:05 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | |
| 15:25:06 | openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | |
| 15:25:06 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | |
| 15:25:18 | dansmith | it's really hard to tell if/when it's used right now | |
| 15:26:30 | stephenfin | this is for nova-network deletion, I assume? | |
| 15:27:53 | dansmith | not really, although that's part of it.. the linux_net module uses a lot of config in conf/network that we can't remove when we nuke nova-net | |
| 15:31:24 | dansmith | mriedem: are you cool with backporting this? https://review.openstack.org/#/c/552691/ | |
| 15:33:37 | mriedem | sure | |
| 15:37:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't log a warning for InstanceNotFound with deleted VIFs https://review.openstack.org/554591 | |
| 15:43:10 | mriedem | welp, volume multiattach does'nt work with libvirt 4.0.0 in the queens UCA | |
| 15:44:41 | mnaser | mriedem: honest question is there multiattach tempeset jobs | |
| 15:45:07 | mriedem | hells yes | |
| 15:45:11 | mriedem | https://review.openstack.org/#/c/554317/ | |
| 15:45:40 | mriedem | looks like the shareable flag isn't getting set in the disk config xml for some reason, should be relatively easy to figure out why | |
| 15:45:55 | mnaser | mriedem: so does that mean that a certain company is releasing things without possibly running tempest jobs | |
| 15:45:56 | mriedem | i've just been getting distracted with the amount of bullshit warnings in the n-cpu logs | |
| 15:46:23 | mriedem | mnaser: libvirt is open source yeah? but even still, i wouldn't expect them to test openstack stuff against their code. | |
| 15:46:33 | mriedem | or qemu for that matter | |
| 15:46:44 | mnaser | well not libvirt but if uca ships libvirt 4.0.0 | |
| 15:46:49 | mnaser | i'd expect that they tested all of them together | |
| 15:47:19 | mriedem | i don't expect ubuntu / canonical to test all of the permutations of openstack features | |
| 15:47:31 | mriedem | since multiattach is optional too | |
| 15:47:44 | mriedem | maybe if it were part of the interop guidelines, but it's not | |
| 15:50:29 | openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Add --by-service to discover_hosts https://review.openstack.org/554600 | |
| 15:52:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add CPUWeigher https://review.openstack.org/379525 | |
| 15:53:33 | openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Add --by-service to discover_hosts https://review.openstack.org/554600 | |
| 15:54:50 | openstackgerrit | Dan Smith proposed openstack/nova stable/pike: Add --by-service to discover_hosts https://review.openstack.org/554603 | |
| 15:56:20 | openstackgerrit | Tyler Blakeslee proposed openstack/nova stable/queens: Add method repr() to NovaException https://review.openstack.org/554604 | |
| 16:03:54 | openstackgerrit | Tyler Blakeslee proposed openstack/nova master: Add method repr() to NovaException https://review.openstack.org/554607 | |
| 16:30:36 | openstackgerrit | Tyler Blakeslee proposed openstack/nova master: Add method repr() to NovaException https://review.openstack.org/554607 | |
| 16:36:46 | ameeda | Hi, I try to create stack using rest api. current api version is V1 . I POST request with auth key , I got this error message { "explanation": "The server could not comply with the request since it is either malformed or otherwise incorrect.", "code": 400, "error": { "message": "The server could not comply with the request since it is either malformed or otherwise incorrect.", "traceback": null, | |
| 16:41:53 | kashyap | Hmm, `git fetch origin` again failing for me, with 'origin' == https://git.openstack.org/openstack/nova.git | |
| 16:42:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Clarify log in RT._update_usage_from_migration https://review.openstack.org/554623 | |
| 16:44:13 | mriedem | we should log this more often i think: "Defaulting the value of the field 'projects' to None in FlavorPayload due to 'Cannot call _load_projects on orphaned Flavor object'" | |
| 16:44:14 | lyarwood | kashyap: https://git.openstack.org/openstack/nova without the .git as a remote WORKSFORME | |
| 16:44:19 | mriedem | 1K+ times isn't enough | |
| 16:45:00 | kashyap | lyarwood: Err, let me try that | |
| 16:45:30 | lyarwood | kashyap: as listed here - https://git.openstack.org/cgit/openstack/nova | |
| 16:47:52 | kashyap | lyarwood: No luck for me; very bizarre; yesterday it worked briefly, but not anymore | |
| 16:47:53 | dansmith | efried: around? | |
| 16:47:53 | efried | dansmith: yeaux | |
| 16:47:53 | efried | Am I reading backscroll or...? | |
| 16:47:53 | dansmith | efried: trying to write a functional test that talks to placement and do some aggregate stuff | |
| 16:47:53 | kashyap | lyarwood: Both (.git or otherwise) worked for me in the past. Not anymore. /me digs further | |
| 16:47:53 | dansmith | efried: and the reportclient I have is complaining that it doesn't know about a provider, which I think might be a local cache thing and I need to refresh its view or something? | |
| 16:47:53 | efried | dansmith: Which module are you writing your test in? | |
| 16:47:53 | dansmith | but the provider definitely exists | |
| 16:47:53 | efried | dansmith: Wanna post what you've got? | |
| 16:48:58 | dansmith | efried: see if this is enough: https://pastebin.com/ekYNZJWR | |
| 16:49:15 | dansmith | I did a raw get against placement and the provider uuid I'm using is definitely there | |
| 16:49:46 | efried | dansmith: Yeah, set_aggregates_for_provider does require that you've loaded up the provider previously. I think it says so in the docstring. Stand by... | |
| 16:50:08 | efried | oh, it says the provider must exist. Which isn't the same at all. | |
| 16:50:08 | dansmith | I don't think it does | |
| 16:50:10 | dansmith | yeah | |
| 16:50:31 | dansmith | presumably I need a .refresh() or some such? | |
| 16:50:36 | efried | dansmith: Well, the PUT ought to be working. | |
| 16:50:43 | dansmith | t'aint | |
| 16:50:43 | efried | cause that's definitely not relying on the cache. | |
| 16:51:14 | efried | yeah, 'tis. It's the cache update that ain't. | |
| 16:51:31 | efried | provider_tree.update_aggregates is what's complaining about the provider not being found. | |
| 16:51:58 | dansmith | you mean the aggregate association completed and it's just trying to refresh its view and failing? | |
| 16:52:03 | efried | Correct. | |
| 16:52:10 | dansmith | okay, what I meant is "this call is failing" | |
| 16:52:12 | dansmith | ;) | |
| 16:52:22 | efried | If you put an _ensure_resource_provider before your set_aggs, it'll fix it. | |
| 16:52:34 | dansmith | okay, but that's a bug yes? | |
| 16:52:51 | efried | Thinking... | |
| 16:53:05 | melwitt | bauzas: runways draft, please add feedback if you have any, want to kick off using it later this week https://etherpad.openstack.org/p/nova-runways-rocky | |
| 16:53:52 | dansmith | efried: I think the deal here is that this makes report client unable to be generally useful to manage things, as it seems opinionated about only knowing about one provider | |
| 16:53:53 | efried | dansmith: It's not unreasonable for you to expect to be able to use that method as you are. So yeah, I think it's a bug. But tbh I don't know what the right fix would be. | |
| 16:53:57 | dansmith | where it used to work well | |
| 16:54:07 | openstackgerrit | Mathieu Gagné proposed openstack/nova master: Fix rebuild of baremetal instance when vm_state is ERROR https://review.openstack.org/523559 | |
| 16:54:38 | dansmith | efried: I shall stick a #FIXME(efried) in my test | |
| 16:54:56 | efried | dansmith: wfm. Or even open a bug. | |
| 16:55:09 | dansmith | well, just this for the moment | |