| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-19 | |||
| 23:20:56 | melwitt | yeah :\ | |
| 23:22:33 | dansmith | mriedem: so I think maybe chatting with someone like dhellmann might be a good idea, but I kinda think we should be running with overwrite=True on those periodics' context | |
| 23:24:09 | dansmith | I'd also like someone to tell me why TLS isn't cleared when a new thread is spawned and/or would like to confirm that timers as we use them to start periodics in our services are actually running in their own threads and not as if they were signal handlers | |
| 23:26:38 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix message for unexpected external event https://review.openstack.org/554380 | |
| 23:27:18 | mriedem | ok, but not tonight | |
| 23:31:46 | openstackgerrit | melanie witt proposed openstack/nova master: Remove useless run_periodic_tasks call in ClientRouter https://review.openstack.org/554381 | |
| 23:34:02 | melwitt | dansmith, mriedem ^ I left the related overwrite=False regression test case alone thinking we would address that when we get answers about what we should be doing with overwrite + periodics later | |
| 23:35:22 | dansmith | melwitt: hmm, I'm not sure what that test is testing TBH | |
| 23:35:35 | dansmith | I'm pretty fried and well past punkin time, so I'll look tomorrow with a fresh head | |
| 23:35:57 | melwitt | it's testing that we don't overwrite=True during periodics because at the time we thought that was messing up things | |
| 23:36:03 | melwitt | okay, cool | |
| 23:42:15 | dansmith | I don't think it does though, because we just start the service and then assert our thing, | |
| 23:42:23 | dansmith | I don't think we know that the periodics have run yet | |
| 23:43:06 | dansmith | we don't run service.periodic_tasks() until the first time we fire the timer, which is delayed from startup, and that's where context gets generated for the periodic run | |
| #openstack-nova - 2018-03-20 | |||
| 00:04:14 | openstackgerrit | Merged openstack/nova master: Remove old flavor_extra_specs_delete db api method https://review.openstack.org/539702 | |
| 00:04:55 | openstackgerrit | Merged openstack/nova master: Report client: Remove version discovery comment https://review.openstack.org/554253 | |
| 00:05:08 | openstackgerrit | Merged openstack/nova master: Remove version/date from CLI documentation https://review.openstack.org/553903 | |
| 00:13:31 | pooja | Hi.. I am seeing an issue with NumInstancesFilter in nova scheduler (Newton release) when provisioning multiple instances in parallel (not in one batch api call) | |
| 00:14:09 | pooja | The scheduler's view of host isn't updated and so multiple instances get placed on a host, which exceeds the max_instances value set for that host. | |
| 00:14:31 | pooja | Is this a known issue and is there a solution for it in ocata/pike release? | |
| 00:15:11 | pooja | Appreciate any pointers or change links. Thanks! | |
| 00:16:17 | melwitt | pooja: are you running a single scheduler? there was a change in pike to do resource claims in the scheduler via placement. I'm not yet familiar with the "max_instances" value you mentioned though | |
| 00:16:51 | melwitt | okay, so it's a config option | |
| 00:21:03 | pooja | melwitt: Yes, I'm running a single instance of nova-scheduler | |
| 00:21:53 | pooja | This is the filter I'm referring to - https://github.com/openstack/nova/blob/master/nova/scheduler/filters/num_instances_filter.py#L28 | |
| 00:23:34 | melwitt | I found it too, currently looking through the code. it looks like the problem you described should be fixed as of pike with the claims in the scheduler. let me see if I can find a patch related to that specific area | |
| 00:24:08 | pooja | Great! thanks for your help looking into it, melwitt! | |
| 00:25:28 | Spaz-Home | Morning | |
| 00:30:39 | melwitt | pooja: to be honest, I'm not sure if the issue is fixed as of the new code. to be sure, it would be better to ask someone like bauzas or edleafe. here's a link to where I started tracing, if that might help in the meantime https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L283-L284 | |
| 00:33:50 | melwitt | and the consume_from_request is used in filter_scheduler.py, looking at it more in filter_scheduler.py, it does seem like it would not be resilient to the issue of parallel requests | |
| 00:35:34 | melwitt | it looks like the report of "num_instances" comes from a compute node stat report, which may not be updating in real-time | |
| 00:48:56 | pooja | melwitt: Sure, let me check with bauzas or edleafe too. | |
| 00:49:50 | pooja | Yes, the problem is that stats get updated asynchronously and num_instances value used by scheduler would be inaccurate based on that timing. | |
| 00:50:35 | melwitt | pooja: I see. I think I understand now, and based on that, it's probably still a problem in the current code now | |
| 00:51:04 | pooja | Oh okay.. should I file a bug for it? | |
| 00:51:27 | pooja | Do these filters work the same way with the new Placement API? | |
| 00:52:46 | melwitt | some do, some don't. the [Core|Ram|Disk]Filter became obsolete in the filter scheduler once we started calling placement. because we pre-filter based on answers from placement and the scheduler claims with placement along the way | |
| 00:54:09 | melwitt | but the rest of the filters run after the placement call, as they did before | |
| 00:56:17 | melwitt | again, bauzas, edleafe, and co are the people to chat with about that | |
| 00:56:47 | melwitt | if you want to open a bug, I can point them to it and ask them to comment on it. it's up to you, however you want to do it | |
| 01:09:48 | pooja | Sounds good! I will connect with them and see if I need to file a bug for this. Will let you know if I do that. Thanks again! | |
| 01:09:59 | melwitt | cool, thanks pooja | |
| 01:59:43 | openstackgerrit | Merged openstack/nova master: VMware: fix TypeError while get console log https://review.openstack.org/549182 | |
| 02:52:27 | alex_xu_ | jaypipes: what do you think about the preferred_traits, that resovled the cyborg weigher problem | |
| 04:28:50 | openstackgerrit | Merged openstack/nova master: Add placeholder migrations for Queens backports https://review.openstack.org/553831 | |
| 05:18:25 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | |
| 05:27:04 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | |
| 06:03:36 | openstackgerrit | Pranab proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612 | |
| 06:10:44 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | |
| 06:15:04 | openstackgerrit | Jianghua Wang proposed openstack/nova master: libvirt: Improve 'qemu-img convert' performance https://review.openstack.org/522067 | |
| 07:45:51 | openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242 | |
| 07:45:51 | openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605 | |
| 07:45:52 | openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | |
| 07:45:52 | openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | |
| 07:45:53 | openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | |
| 08:08:45 | openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | |
| 08:22:44 | openstackgerrit | sahid proposed openstack/nova master: Revert "[libvirt] Add _get_vcpu_realtime_scheduler()" https://review.openstack.org/554448 | |
| 08:22:55 | openstackgerrit | sahid proposed openstack/nova master: Revert "[libvirt] Add _get_numa_memnode()" https://review.openstack.org/554449 | |
| 08:30:42 | sahid | jaypipes: can you have a look at https://review.openstack.org/#/c/511188/ | |
| 08:30:58 | openstackgerrit | licanwei proposed openstack/nova master: Make nova-manage capable of syncing all cell databases https://review.openstack.org/519275 | |
| 08:31:31 | sahid | i mean it would be nice if you cn cut on it we can make some progress, basically you brought that idea and we never see you again :) | |
| 08:35:01 | kaisers1 | efried: ping | |
| 08:37:27 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver https://review.openstack.org/554195 | |
| 08:46:24 | openstackgerrit | jichenjc proposed openstack/nova master: Move placement test cases from db to placement https://review.openstack.org/553149 | |
| 08:51:42 | fanzhang | hi, nova team. Can I add some specified parameter to control boot --min-count instances within one request on different hosts? Like forcing instances launched on different hosts? | |
| 08:52:17 | fanzhang | I think there may be not functions like this, right? | |
| 08:54:10 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925 | |
| 08:58:29 | openstackgerrit | jichenjc proposed openstack/nova master: Avoid raise InstanceNotFound exception https://review.openstack.org/541152 | |
| 09:02:29 | bauzas | good morning folks | |
| 09:02:54 | Kevin_Zheng | fanzhang, maybe you should try anti-affinity filter | |
| 09:03:33 | fanzhang | Kevin_Zheng: thanks so much. Reading docs about anti-affinity filter now :) | |
| 09:05:16 | openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/554212 | |
| 09:13:52 | Kevin_Zheng | fanzhang yw | |
| 09:33:44 | jianghuaw_ | bauzas, good morning:-) | |
| 09:34:00 | bauzas | just catching up emails this morning | |
| 09:34:02 | jianghuaw_ | hope you enjoyed the time in the magic kingdom | |
| 09:34:25 | bauzas | well, my daughters did at least :) | |
| 09:34:59 | jianghuaw_ | good enough:-) | |
| 09:53:06 | openstackgerrit | Chris Dent proposed openstack/nova master: Provide framework for setting placement error codes https://review.openstack.org/546177 | |
| 10:02:46 | gibi | morning nova | |
| 10:29:20 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver https://review.openstack.org/554195 | |
| 10:41:00 | openstackgerrit | Pranab proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | |
| 10:41:50 | gibi | melwitt: I left a comment and a question in https://etherpad.openstack.org/p/nova-runways-rocky with '[gibi]' prefix. But overall I'm OK with the proposal. | |
| 10:42:30 | gibi | melwitt: I think we have to start doing it to gather real experience and then we can improve the process iteratively | |
| 11:03:12 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add disabled field to CellMapping object https://review.openstack.org/550090 | |
| 11:05:50 | Kevin_Zheng | gibi, Hi, I might need some suggestion on https://review.openstack.org/#/c/553288/ about tests | |
| 11:37:08 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add disabled field to CellMapping object https://review.openstack.org/550090 | |
| 11:46:00 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add CellMappingList.get_all_enabled() query method https://review.openstack.org/550188 | |
| 12:14:02 | gibi | Kevin_Zheng: I shortly checked your test, functionally it looks OK. Do you feel that adding the request_id everywhere in the test is too much? | |
| 12:16:07 | sean-k-mooney[m] | bauzas: o/ i believe you reviewed this last cycle would you mind taking a look at the re-proposal of the nic feature based scheduling spec when you have time. https://review.openstack.org/#/c/545951/ | |
| 12:16:08 | Kevin_Zheng | gibi, sort of, but I'm not be afraid to add them, just don't know whether we have a better way to do that, in the latest patchset, I did some nodification for test test_create_server_error, but somehow the req id is different, I will dig into it latter | |
| 12:17:03 | Kevin_Zheng | gibi for those tests that tested multiple actions in one test, it seems a little bit complicated, so I wonder we have a better way to do it. | |
| 12:17:29 | sean-k-mooney[m] | bauzas: i have 1 or two nits to adress in the corresponding code but should have the series rebased and uploaded by the end of the week. im hoping we can get this all merged before milestone 1 | |
| 12:19:27 | openstackgerrit | sahid proposed openstack/nova master: only increment disk address unit for scsi devices https://review.openstack.org/538310 | |
| 12:22:08 | sean-k-mooney[m] | dansmith: just saw your comment on https://review.openstack.org/#/c/449257/59 you last comment on this topic was before i took this over from rodolfo. ill try and adress this when i do the rebase later this week. | |
| 12:22:12 | openstackgerrit | Jan Zerebecki proposed openstack/os-vif stable/ocata: Check if interface belongs to a Linux Bridge before removing https://review.openstack.org/554523 | |
| 12:23:01 | sean-k-mooney[m] | dansmith: looking at your old comment you would like us to add a spec_object field in addtion to the spec field correct? | |
| 12:23:36 | gibi | Kevin_Zheng: thanks for describing your concerns, I have to think about a bit. I will reply in the review | |
| 12:23:58 | Kevin_Zheng | gibi thanks alot | |
| 12:24:10 | openstackgerrit | Jan Zerebecki proposed openstack/os-vif stable/ocata: Check if interface belongs to a Linux Bridge before removing https://review.openstack.org/554523 | |