| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-16 | |||
| 19:50:58 | superdan | entirely possible that early patches will be reviewed to oblivion making later patches irrelevant until substantially changed | |
| 19:51:05 | fried_rice | Yes, that also. | |
| 19:51:20 | superdan | well, the point of this is to maintain focus so we can chew through long series easier, | |
| 19:51:43 | superdan | so maybe it just needs to be "have approximately two weeks of stuff to review at the head of your series" | |
| 19:51:53 | superdan | nobody will ever be able to measure that of course | |
| 19:52:04 | fried_rice | No, but we'll get better at it with practice. | |
| 19:52:06 | superdan | and hopefully most blueprints will wholly fit into two weeks, but.. | |
| 19:52:10 | fried_rice | "Bottom N patches of bp X" | |
| 19:52:18 | fried_rice | kind of thing. | |
| 19:52:23 | mriedem | it's likely a discussion that happens when talking about the next thing to go into a slot, | |
| 19:52:27 | superdan | well, aim for whole blueprints, but for special problem children like you... | |
| 19:52:31 | mriedem | for single-patch small bp's, it's not an issue | |
| 19:52:56 | superdan | yeah | |
| 19:53:32 | mriedem | "is bp x ready for a slot? if so, are you going to be around for the next 2 weeks to respond to reviews? if so, i see that it's 20 patches already, what is the reasonable target?" | |
| 19:54:38 | mriedem | this shouldn't be all that process heavy | |
| 19:54:51 | mriedem | says the guy that loves process | |
| 19:54:55 | superdan | yeah for serious | |
| 19:55:11 | mriedem | hey, | |
| 19:55:13 | superdan | I expect we wing this for a cycle, and decide either to scrap it, or it becomes clear what some of the rules should be | |
| 19:55:16 | mriedem | when it's not *my* process i don't care as much | |
| 19:55:20 | superdan | heh | |
| 19:57:00 | jgwentworth | I'll ping gibi_ and bauzas next week to add their feedback to this too | |
| 19:58:17 | jgwentworth | since they're on PTO this week | |
| 19:58:38 | superdan | jgwentworth: might want to clean up the pad a bit and move discussion to the bottom or something | |
| 19:58:39 | jgwentworth | and it's friday late for them | |
| 19:58:42 | superdan | it's a fairly confusing read right now | |
| 19:59:09 | fried_rice | ++ | |
| 19:59:09 | fried_rice | I'm done mucking with it; have at r. | |
| 19:59:12 | superdan | a summary at the top or somethimg | |
| 19:59:27 | jgwentworth | yeah, I was debating whether to copy-paste the whole thing into a -discussion etherpad (should have done that first) and leave this as the trimmed down thing | |
| 19:59:48 | fried_rice | jgwentworth: I meant to mention, wouldn't mind if the definition was the first thing. | |
| 19:59:55 | fried_rice | ("What is a runway?") | |
| 20:00:01 | jgwentworth | oh, yeah, okay | |
| 20:15:20 | openstackgerrit | Merged openstack/nova master: Update contributor guide for Rocky https://review.openstack.org/550288 | |
| 20:15:30 | openstackgerrit | Merged openstack/nova master: Removed unnecessary parantheses in yield statements https://review.openstack.org/550379 | |
| 20:38:51 | mriedem | cfriesen: any idea if you can live migrate between compute hosts with different libvirt virt_types today? like qemu->kvm and back? | |
| 20:41:32 | mriedem | that pair might work, but i'm pretty sure something like kvm->xen wouldn't | |
| 20:52:40 | jgwentworth | superdan: this is a patch having to do with the hypervisor_type in the libvirt driver. it looked reasonable to me but I wasn't 100% sure whether filtering hypervisor_type by virt_type changes the semantics of hypervisor_type/capabilities. I'd appreciate your input about it https://review.openstack.org/#/c/531347/ | |
| 21:10:52 | oomichi | hi, I have a question about Date(2012-09-27), Version(2012.1) on OpenStack Doc like https://docs.openstack.org/nova/latest/cli/nova-api-metadata.html | |
| 21:11:34 | oomichi | They make me feel the doc seems super old, I am not sure we need to update or remove them | |
| 21:12:14 | mriedem | oomichi: those have always annoyed me too | |
| 21:12:38 | oomichi | mriedem: hehe, let me check the other projects too | |
| 21:12:46 | mriedem | i'm not sure if they are needed for man page builds | |
| 21:12:51 | mriedem | or were just originally informational | |
| 21:13:37 | mriedem | https://docs.openstack.org/cinder/latest/man/cinder-manage.html | |
| 21:13:45 | mriedem | cinder doesn't have the version or date in theirs | |
| 21:14:07 | oomichi | mriedem: cool, thanks for picking it up | |
| 21:14:32 | oomichi | it would be nice to send a mail to get answer from doc team | |
| 21:14:34 | cfriesen | mriedem: I've never tried live migration between different libvirt types...I'd expect it to fail. | |
| 21:14:37 | oomichi | will do that | |
| 21:15:02 | mriedem | apparently there is a whole spec http://man7.org/linux/man-pages/man7/man-pages.7.html | |
| 21:15:15 | mriedem | but i'm sure we don't follow the actual man page spec closely | |
| 21:15:24 | oomichi | btw cinder's "Manual group:cloud computing" seems a little odd | |
| 21:15:35 | mriedem | likely copied from nova | |
| 21:15:38 | mriedem | when cinder was split out | |
| 21:15:55 | mtreinish | oomichi, mriedem: it looks like it's just a table in the rst: https://git.openstack.org/cgit/openstack/nova/tree/doc/source/cli/nova-api.rst#n9 | |
| 21:15:57 | smcginnis | Any man page specific stuff probably hasn't been touched since then. | |
| 21:16:53 | mtreinish | the man pages are just sphinx rendering the rst: https://github.com/openstack/nova/blob/master/doc/source/conf.py#L137 with the manpage builder | |
| 21:17:17 | mtreinish | I just spent a bunch of time reformatting: https://stestr.readthedocs.io/en/latest/MANUAL.html to be a proper manpage when using that sphinx builder | |
| 21:17:32 | mtreinish | I can give you a hand with that if it's something you'd want to do | |
| 21:19:20 | oomichi | mtreinish: I might want to remove them (Date, Version) if we can | |
| 21:19:51 | mtreinish | yeah, I don't think that table adds anything. I think just push a patch to delete it, or change it to a comment so it doesn't render in the output | |
| 21:21:44 | oomichi | mtreinish: thanks, let me try | |
| 21:24:32 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | |
| 21:24:33 | openstackgerrit | Eric Fried proposed openstack/nova master: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | |
| 21:24:33 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | |
| 21:24:34 | openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | |
| 21:24:34 | openstackgerrit | Eric Fried proposed openstack/nova master: Make generation optional in ProviderTree https://review.openstack.org/539324 | |
| 21:24:35 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Add nested resources to server moving tests https://review.openstack.org/527728 | |
| 21:26:02 | oomichi | mriedem: mtreinish: cinder team has removes Date and Version on the same reason which we feel: https://review.openstack.org/#/c/325465/ | |
| 21:32:03 | openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Clean up man page and remove version/date https://review.openstack.org/553903 | |
| 21:33:03 | openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove version/date from CLI documantation https://review.openstack.org/553903 | |
| 21:33:32 | oomichi | mriedem: ^^^: done | |
| 21:40:02 | mriedem | +2 | |
| 21:40:17 | mriedem | POST_FAILURE on https://review.openstack.org/#/c/553794/ so it's going to have to get rechecked | |
| 21:57:47 | mriedem | cfriesen: found the code that won't allow it | |
| 21:58:09 | mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L210 | |
| 21:58:11 | mriedem | in the conductor task | |
| 21:58:18 | mriedem | also checks the version | |
| 22:00:38 | fried_rice | jgwentworth, superdan: Are we rolling out runways yet? I put one in the queue :) | |
| 22:01:46 | oomichi | thanks | |
| 22:01:50 | jgwentworth | fried_rice: heh, you're ready2rock. gonna ping gibi and bauzas on monday and see if they have anything to add/change before unleashing it to the dev ML | |
| 22:02:20 | fried_rice | cool cool. Meanwhile, same patches are in the rocky priorities etherpad, so I figger I'm covered :) | |
| 22:02:27 | jgwentworth | speaking of, while you're here oomichi if you have any feedback about our rough draft about runways for rocky https://etherpad.openstack.org/p/nova-runways-rocky | |
| 22:02:59 | jgwentworth | I'm sorry this hasn't been mentioned yet as I haven't written the PTG summary for the friday miscellaenous bag of topics yet | |
| 22:03:14 | jgwentworth | *miscellaneous | |
| 22:03:54 | jgwentworth | alex_xu_ ^ | |
| 22:04:01 | mriedem | jgwentworth: if you're going to attempt to summarize the friday misc stuff from the ptg, i'd recommend not trying to cover every single item, and only focus on highlights for any bigger or more contentious items | |
| 22:04:10 | mriedem | otherwise the summary will essentually be the etherpad itself | |
| 22:04:24 | jgwentworth | mriedem: yeah, I was wondering about that. thanks for the advice | |
| 22:04:32 | oomichi | jgwentworth: OK, let me check. (that is already huge btw :-) | |
| 22:04:34 | mriedem | i never tried to summarize all the misc stuff before | |
| 22:05:13 | jgwentworth | good to know | |
| 22:08:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | |
| 22:08:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add code to bind a port against a dest host during live migration https://review.openstack.org/523604 | |
| 22:08:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | |
| 22:08:41 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | |
| 22:08:41 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 22:08:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | |
| 22:08:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: compute: use port binding extended API during live migration https://review.openstack.org/551371 | |