| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-14 | |||
| 20:03:48 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553035 | |
| 20:04:14 | sean-k-mooney | mriedem: we have to be carful not to reintroduce https://bugs.launchpad.net/nova/+bug/1724573 by reverting https://review.openstack.org/#/c/400384 | |
| 20:04:15 | openstack | Launchpad bug 1724573 in OpenStack Compute (nova) "encrypted volumes are directly attached to instances after a compute host reboot" [Medium,Fix released] - Assigned to Matthew Booth (mbooth-9) | |
| 20:04:31 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553037 | |
| 20:04:58 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553038 | |
| 20:05:08 | mnaser | https://review.openstack.org/#/c/542767/ | |
| 20:05:11 | mnaser | can someone 'block' that from merging | |
| 20:05:17 | mnaser | dansmith: maybe remove your +W? | |
| 20:05:50 | dansmith | ack | |
| 20:05:52 | sean-k-mooney | mnaser: it has a zuul -2 because its in merge conflict | |
| 20:06:16 | mnaser | sean-k-mooney: figure just in case someone doesnt notice it :) | |
| 20:06:53 | mnaser | https://review.openstack.org/#/q/topic:bug/1744361+is:open+owner:%22Mohammed+Naser+%253Cmnaser%2540vexxhost.com%253E%22 | |
| 20:07:03 | mriedem | sean-k-mooney: yeah if we reverted all the way, we'd have to do a partial revert of https://review.openstack.org/#/c/400384 and only remove the changes for the vif plugging part | |
| 20:08:41 | sean-k-mooney | well looking at https://review.openstack.org/#/c/553035/ i think it solve the imidiate odl issue at least for now | |
| 20:09:07 | sean-k-mooney | that seams like the minimal change at the cost of never waiting | |
| 20:10:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Make nova-cells-v1 run with neutron https://review.openstack.org/549789 | |
| 20:14:17 | mriedem | if we wanted to go back to https://review.openstack.org/#/c/400384/, | |
| 20:14:28 | mriedem | we could pass destroy_vifs=False through self.destroy -> self.cleanup | |
| 20:14:39 | mriedem | because that was the change in behavior in that patch that caused a lot of the trouble | |
| 20:15:03 | mriedem | as i said, https://review.openstack.org/#/c/400384/ was meant to fix an encrypted volume issue and turned into "let's just fully destroy the damn thing and everything associated with it except disks" | |
| 20:21:03 | sean-k-mooney | im going to head off soon. FYI ill be online intermitely tommorw and then off until tuesday. | |
| 20:31:59 | efried | You don't like me anymore, jaypipes? | |
| 20:32:11 | dansmith | efried: we took a vote | |
| 20:32:17 | dansmith | sad to say, you're off the island | |
| 20:32:20 | efried | And edleafe won??? | |
| 20:32:23 | efried | Come ON! | |
| 20:32:27 | dansmith | hah | |
| 20:33:06 | efried | I mean, he does have seniority. | |
| 20:33:10 | efried | SERIOUS seniority. | |
| 20:33:41 | jaypipes | efried: your torch has been extinguished. | |
| 20:34:04 | dansmith | you must leave the tribal council area IMMEDIATELY | |
| 20:34:23 | jaypipes | dansmith: edleafe has won the microversion battle being currently waged. | |
| 20:34:34 | dansmith | ah heh | |
| 20:34:55 | efried | dansmith: It's not too late! You can saaaaave me! | |
| 20:35:05 | jaypipes | efried: that is correct. when a person is voted off the island in the survivor show, their torch is extinguished. | |
| 20:35:15 | dansmith | I wouldn't mind seeing a fire making challenge between the two of you | |
| 20:35:33 | jaypipes | efried: or at least, that's the way it was the last time I saw that show, which would have been around 2005. | |
| 20:35:45 | dansmith | efried: nah, you have to use flint and coconut husk | |
| 20:36:02 | efried | or my high-velocity eyeballs? | |
| 20:36:07 | jaypipes | dansmith: you can't make fried_rice without fire. | |
| 20:36:18 | dansmith | bah dum. | |
| 20:36:28 | openstackgerrit | Merged openstack/nova master: Revert "Make the InstanceMapping marker UUID-like" https://review.openstack.org/552937 | |
| 20:36:47 | jaypipes | hahaha | |
| 20:39:23 | dansmith | nice | |
| 20:41:19 | mriedem | i assume edleafe is an avid bachelor(ette) watcher | |
| 20:41:24 | mriedem | although it does come on pretty late... | |
| 20:41:42 | dansmith | um, aren't we all? | |
| 20:41:48 | edleafe | Nah, no cable in this house | |
| 20:41:52 | mriedem | it's not cable! | |
| 20:41:55 | dansmith | it's not on cable dude :) | |
| 20:41:56 | mriedem | rabbit ears | |
| 20:41:56 | dansmith | haha | |
| 20:42:21 | edleafe | guess I'll have to pick some up to see what all the fuss is about | |
| 20:42:21 | mriedem | or, your texas-sized satellite in the backyard should pick it up | |
| 20:42:37 | edleafe | maybe it's on hulu? | |
| 20:42:52 | mriedem | idk, but i wouldn't advice trying to find it | |
| 20:42:55 | dansmith | I bet it's on hulu, | |
| 20:43:03 | dansmith | but we're not serious about watching/liking it | |
| 20:43:27 | edleafe | oh sure | |
| 20:43:38 | edleafe | you're just probably embarrassed to admit it | |
| 20:43:47 | dansmith | heh | |
| 20:44:06 | edleafe | it *is* on hulu | |
| 20:44:15 | edleafe | wait - season 22?? | |
| 20:44:17 | dansmith | oh boy, edleafe is in for a treat tonight | |
| 20:44:24 | dansmith | oh yeah man, it's a major deal | |
| 20:44:42 | dansmith | that's why I figured it'd be on hulu.. they couldn't have a subscriber base without it | |
| 20:45:12 | edleafe | oh, they have all sorts of trashy TV: the voice, top model, the kardashians | |
| 20:45:29 | edleafe | I'm so culturally deprived | |
| 20:46:50 | efried | culturally depraved if you watch that crap. Take your pick | |
| 20:47:21 | edleafe | efried: good point | |
| 20:51:00 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: handle DiskNotFound during update_available_resource https://review.openstack.org/553067 | |
| 20:54:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: handle DiskNotFound during update_available_resource https://review.openstack.org/553067 | |
| 20:58:41 | cfriesen | got something wierd, looking for ideas. With libvirt, when you power off a node it calls _destroy() which will loop over the serial ports and call serial_console.release_port(). Then in power_on() we end up calling _destroy() again, which could end up releasing serial ports that are now in use by another instance. | |
| 21:00:11 | cfriesen | (I think these are basically TCP ports on the host.) | |
| 21:01:56 | mriedem | mnaser: left a comment in https://review.openstack.org/#/c/553035/ - how do you feel about working that into the commit message before we start a revert party | |
| 21:03:52 | mnaser | mriedem: are you okay with me copypasta-ing that comment and adding co-authored because you seem to have summarized it well | |
| 21:04:06 | mriedem | that's fine | |
| 21:04:12 | mriedem | don't really need the co-author | |
| 21:04:26 | mnaser | okay cool, let me see | |
| 21:07:08 | openstackgerrit | sean mooney proposed openstack/nova master: WIP add mtu to libvirt xml for ethernet and bridge types https://review.openstack.org/553072 | |
| 21:07:22 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553035 | |
| 21:07:36 | mnaser | mriedem: is that ok? if thats okay ill update the other ones | |
| 21:08:02 | mriedem | yeah lgtm | |
| 21:08:09 | sean-k-mooney | i have not tested the mtu ptach so ignore it for now. ill test it tomorrow and remove the WIP once i add unit test and check it actully works. | |
| 21:08:09 | mriedem | use the same change id in the stable branch ones too | |
| 21:08:10 | mriedem | please | |
| 21:08:17 | mnaser | will do | |
| 21:10:15 | arvindn05 | mriedem: jaypipes: updated the spec based on comments Patch set 9 should address the issues https://review.openstack.org/#/c/541507/9 | |
| 21:10:18 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553037 | |
| 21:10:29 | openstackgerrit | Eric Fried proposed openstack/nova master: Stop assuming initial provider generation is 0 https://review.openstack.org/548975 | |
| 21:10:39 | efried | cdent: jaypipes: That 'un is ready now too ^ | |
| 21:10:53 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553038 | |
| 21:10:54 | cdent | rad | |
| 21:11:43 | mnaser | mriedem: apparently changing the id in change-id: <foo> doesn't do it? | |
| 21:12:24 | mnaser | maybe i need to recommit or rebase (i did edited with the ui) | |
| 21:17:25 | mriedem | i figured you could use the ui | |
| 21:21:39 | sean-k-mooney | jaypipes: just on the nic feature based schduling spec https://review.openstack.org/#/c/545951/ | |
| 21:22:43 | sean-k-mooney | i just responed to you comments . i can resping if you want but many of the nits you raised are due to the fact that half of this feature merged in pike since it was feature complete since then | |
| 21:23:42 | sean-k-mooney | moving the nic feature to placement would be cool but they have been stored in the nova db for 2 release now so i would like to finish the use fo them first then port to placement | |
| 21:30:03 | jaypipes | sean-k-mooney: I'm already +2 on that. no need. | |