Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-03-14
14:31:39 mriedem https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/schemas/allocation.py#L85
14:31:46 efried It's ignored
14:32:00 efried generation (Optional)bodyintegerA consistent view marker that assists with the management of concurrent resource provider updates. The value is ignored; it is present to preserve symmetry between read and write representations.
14:32:01 mriedem oh gdi
14:32:24 mriedem ok, well, probably going to be important when both nova and neutron are changing allocatoins for the same consumer
14:32:53 Kevin_Zheng gibi, I saw that InstanceActionPayload is a parent object of alot other payload objects, and seems some of the child object also got version bump when the parent object got bumped?
14:33:08 efried mriedem: Yes. We talked about it in Dublin. On Wednesday IIRC. And agreed to add a generation field to the allocations table. jaypipes probably has more of it in his head. Not sure who's on the hook to do the spec/work.
14:33:18 mriedem Kevin_Zheng: yes that's not new
14:33:23 gibi Kevin_Zheng: if you add something to the parent then that will appeare in the children payloads therefore you need the bump
14:33:24 mriedem you'll have to update all of the children
14:33:37 Kevin_Zheng OMG
14:33:43 Kevin_Zheng so many children
14:33:52 mriedem c'mon
14:33:56 mriedem climb that mountain
14:34:12 gibi Kevin_Zheng: the parent-child relationship is not visible in the serialized payload, as it only contains the child class name
14:34:38 gibi Kevin_Zheng: therefore the version of the child should reflect the overall structure
14:35:06 Kevin_Zheng gibi ack
14:35:30 gibi Kevin_Zheng: dont worry I think the unit test will catch if you miss some of those children
14:35:53 Kevin_Zheng mriedem you got trainning too, I thought it was just for us LOL
14:36:38 gibi Kevin_Zheng: as the signature of the children classes will change if you add a field to the parent
14:37:09 Kevin_Zheng gibi, yeah thats true
14:37:38 openstackgerrit Ed Leafe proposed openstack/nova master: Add 'member_of' param to GET /allocation_candidates https://review.openstack.org/552098
14:37:40 edleafe alex_xu_: ^^ now you can ignore efried
14:38:09 stephenfin ShilpaSD: and that works as expected, for both noVNC 0.6 and 1.0?
14:38:55 ShilpaSD yes, if we manage at configuration level, no need to do changes at nova-compute
14:39:10 stephenfin mriedem: Thoughts on that? ^
14:39:23 mriedem stephenfin: huh?
14:39:49 stephenfin mriedem: This is for the breaking change in noVNC 1.0. Apparently we can set the config option to use 'vnc.html' with a parameter and this works with both noVNC 0.6 and 1.0
14:40:13 stephenfin 'vnc.html' instead of 'vnc_auto.html' for 0.6 and 'vnc_lite.html' for 1.0
14:40:32 mriedem oh
14:40:50 mriedem well that seems like the thing to do for the default then, but does that also work for 0.6?
14:41:07 mriedem if that doesn't work for 0.6, then you'd be regressing the default for anyone <1.0
14:41:07 stephenfin mriedem: According to ShilpaSD, it does, yes
14:41:23 stephenfin Yup, same as changing the default to 'vnc_lite.html'
14:41:48 mriedem sure seems fine then, accompanied with a release note that the default is changing probably
14:41:57 stephenfin Sweet
14:42:30 stephenfin ShilpaSD: If you fancy making that change to the default, we can see if DevStack is happy. That will ensure we're OK with 0.6
14:43:31 stephenfin ShilpaSD: I already have a DevStack change up to bump noVNC 1.0. I can make this change 'Depends-on' your one
14:48:53 ShilpaSD stephenfin: that will be great, but still one more query
14:49:01 stephenfin Shoot
14:49:03 ShilpaSD stephenfin: /opt/stack/nova/nova/tests/functional/api_sample_tests/api_samples/os-remote-consoles/get-vnc-console-post-resp.json.tpl....here also need to make that change? since functionaly TC using that
14:49:19 ShilpaSD /opt/stack/nova/doc/api_samples/os-remote-consoles/get-vnc-console-post-resp.json
14:49:38 stephenfin ShilpaSD: Already done https://review.openstack.org/#/c/550173/
14:50:00 stephenfin Well, those are wrong. You can take that patch and fix it up, if you like
14:50:21 stephenfin Or I'll rebase it onto whatever you do. You just need to modify nova/conf/pci.py and add a release note
14:51:35 stephenfin lyarwood: Regarding https://review.openstack.org/#/c/552874/, I think that's a bug in oslo_config.sphinxext. The rST is correct.
14:51:46 stephenfin If I were to guess, we're not doing a nested parse
14:53:41 ShilpaSD stephenfin: thnak you for clarification, will get back to you on what action i am taking aginst this
14:54:15 stephenfin (y)
14:54:31 sean-k-mooney mriedem: stephenfin just looking at https://review.openstack.org/#/c/548525/1 the few runs of kuryr-kubernetes-tempest-daemon-octavia i have see so far against os-vif seam a little flaky.
14:55:03 sean-k-mooney mriedem: stephenfin we may want to consider makeing it non voting if it contiues. ill keep an eye on it
14:56:05 cdent efried: re [t 1LbC] wasn't it to the consumer table?
14:56:05 purplerbot <efried> mriedem: Yes. We talked about it in Dublin. On Wednesday IIRC. And agreed to add a generation field to the allocations table. jaypipes probably has more of it in his head. Not sure who's on the hook to do the spec/work. [2018-03-14 14:33:08.634568] [n 1LbC]
14:56:39 efried cdent: Could be, sure. I'm not very familiar with the tables related to allocations.
14:56:53 efried and don't remember the conversation exactly
14:56:56 efried but I bet it's in the etherpad.
14:57:36 sean-k-mooney stephenfin: mriedem for example it failed https://review.openstack.org/#/c/476612/ becase the tempest regex elminated all tests http://logs.openstack.org/12/476612/30/check/kuryr-kubernetes-tempest-daemon-octavia/576bfad/job-output.txt.gz#_2018-03-13_07_42_00_900216 and it did not publish results on https://review.openstack.org/#/c/482226/20 at all.
14:58:02 stephenfin sean-k-mooney: Indeed. There was a thing on openstack-dev about it earlier in the week. Apparently some neutron (?) change has broken it
14:58:17 stephenfin sean-k-mooney: Agreed though. Let's keep an eye on it
14:59:08 sean-k-mooney stephenfin: well those two need other work to be mergable first but i would prefer to make it non voteing instead of blocking other changes to os-vif that may be need in the future.
15:00:32 sean-k-mooney stephenfin: its not blocking anything currently hence lets wait and see. legacy-tempest-dsvm-nova-os-vif on the other had we might want to make voteing or rework for zuul v3
15:06:24 Kevin_Zheng mriedem gibi thanks alot
15:24:28 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924
15:25:07 bauzas stephenfin: edleafe: jaypipes: dansmith: efried: you could be interested in https://review.openstack.org/552924 (NUMA topology with RPs)
15:25:29 bauzas I just have a shitty docs problem that I don't see why
15:26:18 efried bauzas: Added to review list.
15:26:30 efried bauzas: You're having trouble getting the doc to build?
15:26:37 bauzas yep
15:27:25 bauzas nvm, found the issue
15:27:27 bauzas PEBKAC
15:27:56 efried yep, indent that graphic
15:28:06 bauzas yeah, missed the code directive
15:28:19 efried ...and the next one.
15:28:23 efried Oh, or that.
15:28:58 efried and an extra newline around L138
15:29:14 efried and 150
15:29:28 efried and 178
15:29:41 efried bauzas: With those fixed, it builds for me.
15:30:08 efried bauzas: btw, not sure how you're building locally, but I use this to cut build time down to a sub-second:
15:30:18 efried specs ()
15:30:18 efried {
15:30:18 efried rele=${1:-rocky};
15:30:18 efried ( . .tox/docs/bin/activate || return;
15:30:18 efried set -x;
15:30:19 efried python setup.py build_sphinx -s doc/source/specs/$rele -c doc/source || return;
15:30:19 efried find doc/build/html -type f -name '*.html' | xargs realpath )
15:30:20 efried }
15:30:24 stephenfin bauzas: Also, single-backticks aren't really valid rST. They mean default role which just happens to be italics in current Sphinx. No reason that won't change going forward though (they do tend to break stuff often)
15:30:38 stephenfin But that's a big nit :) Also placed on my review queue
15:32:27 bauzas thanks both of you folks
15:32:54 openstackgerrit Chris Dent proposed openstack/nova-specs master: Spec for isolating configuration of placement database https://review.openstack.org/552927
15:32:58 bauzas stephenfin: so, for targeting links, you would recommend double-backticks ?
15:33:16 stephenfin bauzas: What do you mean?
15:33:24 bauzas (16:30:24) stephenfin: bauzas: Also, single-backticks aren't really valid rST. T
15:33:43 stephenfin Something like `xyz`_ or :role:`test` is valid. What's not valid is `xyz`
15:33:50 bauzas I used single backticks for explicit targeting
15:34:17 bauzas stephenfin: yeah, so I thought I did that everywhere, were have you seen a single-backtick without a link ?
15:35:12 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924
15:35:38 stephenfin bauzas: Line 131
15:35:57 stephenfin 257 too

Earlier   Later