| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-13 | |||
| 14:56:49 | dansmith | it can go in straight away | |
| 14:58:38 | edleafe | dansmith: sure, I can switch that | |
| 14:58:54 | tssurya | dansmith : mriedem gave his blessings on https://review.openstack.org/#/c/546684/ ; whenever you have the time could you please circle back for your re-approval ? | |
| 14:59:18 | dansmith | tssurya: I saw, it's in my queue | |
| 14:59:38 | tssurya | dansmith: thank you | |
| 15:00:15 | dansmith | edleafe: yeah that join is over my head for sure | |
| 15:03:08 | edleafe | dansmith: I was trying to follow the "join chain" logic in the rest of the code, but sqla doesn't like the "in" clause, it seems | |
| 15:03:40 | dansmith | edleafe: and member_of is a list of strings yeah? | |
| 15:04:11 | edleafe | dansmith: yep | |
| 15:04:40 | dansmith | edleafe: we should try query.summon(guru=jaypipes).execute() | |
| 15:05:08 | edleafe | dansmith: that reads like we're going to execute Jay | |
| 15:05:21 | dansmith | heh | |
| 15:10:45 | Spaz-Home | Man didn't deny it | |
| 15:16:18 | cdent | edleafe: you getting an error or bad results on that join chain? have you debugged to look at the generated table? is the join between the rp_tbl and rp_agg_tbl happening somewhere else already or do you need to hork that in there somewhere too? looks like that may be missing | |
| 15:17:14 | edleafe | cdent: getting an error from sqla on the join clause itself. | |
| 15:17:49 | cdent | it looks like it is an orphan | |
| 15:19:27 | edleafe | cdent: lemme paste the error | |
| 15:19:38 | cdent | ✔ | |
| 15:21:34 | edleafe | cd http://paste.openstack.org/show/699991/ | |
| 15:22:22 | edleafe | cdent: ^^ | |
| 15:25:29 | cdent | edleafe: the third argument to join is the onclause, and you've got a table | |
| 15:26:06 | cdent | so it trying to write a query but a table has no boolean characteristic | |
| 15:26:09 | cdent | http://docs.sqlalchemy.org/en/rel_1_1/core/selectable.html?highlight=sa%20join#sqlalchemy.sql.expression.join | |
| 15:28:30 | edleafe | cdent: ah, ok. I was trying to copy Jay's existing join chain logic | |
| 15:28:56 | edleafe | let me try breaking that up into two steps | |
| 15:29:44 | edleafe | ...after meetings are done, of course! | |
| 15:30:21 | cdent | edleafe: I think basically you need more than one join | |
| 15:31:48 | edmondsw | melwitt should I be doing anything to get eyes on the PowerVM virt driver spec for Rocky besides where I added to https://etherpad.openstack.org/p/rocky-nova-priorities-tracking? | |
| 15:34:37 | mriedem | sahid: let me know if you have any questions about my comments in https://review.openstack.org/#/c/485522/ | |
| 15:40:48 | jaypipes | edleafe: on a call with stephenfin and gibi. gimme about 15 mins? | |
| 15:43:28 | sahid | mriedem: ack, will have a look and let you know | |
| 15:44:47 | edleafe | jaypipes: cdent may have pointed me in the right direction. Wait until my next revision | |
| 15:47:26 | sahid | mriedem: in that meantime if i can ask you to have a look at this: https://review.openstack.org/#/c/539605/ i think we are all agree | |
| 15:48:46 | mriedem | hmm | |
| 15:50:27 | sahid | does that "hum" means you are not agree... :) | |
| 15:53:19 | jaypipes | stephenfin, gibi: https://etherpad.openstack.org/p/nfDwesfaMs | |
| 16:07:46 | openstackgerrit | Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/552384 | |
| 16:10:34 | openstackgerrit | Merged openstack/nova master: Transform live_migration.post.dest notifications https://review.openstack.org/469784 | |
| 16:11:19 | mriedem | sahid: comments inline | |
| 16:13:53 | mriedem | sahid: i won't claim to know much about virtio-net multiqueue | |
| 16:14:05 | mriedem | so my comments and questions are mostly about the big picture and for understanding | |
| 16:15:33 | dansmith | mriedem: do you care to scrutinize the os-vif and networky bits of this? https://review.openstack.org/#/c/489451/30 | |
| 16:16:13 | mriedem | it's not using os-vif is it? | |
| 16:16:26 | mriedem | also https://blueprints.launchpad.net/nova/+spec/live-migration-in-xapi-pool isn't approved | |
| 16:17:10 | mriedem | is this the thing to drop the aggregate up-call for xen live migration? | |
| 16:19:11 | Spaz-Home | Oh there's a blueprint for that | |
| 16:19:11 | Spaz-Home | ? | |
| 16:19:13 | Spaz-Home | that makes me happy if so | |
| 16:19:32 | dansmith | mriedem: yeah, we need to approve it specless I think, we discussed that at PTG | |
| 16:20:07 | Spaz-Home | I think i'd like to talk to Niachuan about that.. | |
| 16:20:59 | dansmith | mriedem: what I meant about os-vif is using your os-vif awareness to review all the networky bits of that | |
| 16:21:40 | mriedem | dansmith: comments inline | |
| 16:21:46 | mriedem | that patch doesn't remove the aggregate up-call at all | |
| 16:21:58 | mriedem | also, i don't have os-vif awareness :) | |
| 16:21:59 | dansmith | I know, see my comment | |
| 16:22:02 | mriedem | except to say i'm aware it exists | |
| 16:22:28 | dansmith | this patch allows live migration through a different pool mechanism, other than aggregates | |
| 16:22:33 | dansmith | which we discussed on friday at PTG, | |
| 16:22:39 | dansmith | is a precursor to removing the aggregate stuff | |
| 16:22:48 | Spaz-Home | I'd honestly like there to be a switch in there to allow for neither of those to be used. | |
| 16:23:02 | Spaz-Home | For example just using Cells and not HA pools | |
| 16:23:09 | dansmith | um | |
| 16:23:32 | dansmith | cells has nothing to do with this, but maybe you mean "just assume you can live migrate anywhere" ? | |
| 16:23:38 | openstackgerrit | Stephen Finucane proposed openstack/osc-placement master: Resolve nits from I552688b9ee32b719a576a7a9ed5e4d5aa31d7b3f https://review.openstack.org/537971 | |
| 16:23:56 | Spaz-Home | I mean that don't assume that it needs to be aggregated to live migrate. Cells does have to do with it when it can use Cells to know what to migrate to. | |
| 16:24:07 | Spaz-Home | or pooled as well really | |
| 16:24:29 | dansmith | this change has an "assume on the same network" flag, which I would assume is that? | |
| 16:24:37 | dansmith | but still, I don't see how "it can use cells to know" | |
| 16:25:00 | mriedem | so in other words, this is routed networks for xenapi live migration? | |
| 16:25:41 | dansmith | the xen driver has always had a mechanism to determine if two hosts can live migrate between each other (aggregates), | |
| 16:25:48 | dansmith | this is using a different mechanism for that now, | |
| 16:25:55 | Spaz-Home | It's also been pretty inconsistent. block-migration skips it completely | |
| 16:26:11 | dansmith | right | |
| 16:26:53 | Spaz-Home | But yeah I can agree.. so long as it's consistent | |
| 16:27:14 | openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/552363 | |
| 16:29:19 | dansmith | Spaz-Home: are you going to comment on that patch or what? I can't tell if you have feedback or concerns | |
| 16:29:22 | Spaz-Home | It may be worth saving that for a separate patch though to bring block-migration into proper parity as it is not the only issue that it is missing. | |
| 16:29:40 | Spaz-Home | Still just reading it and thinking, sir. | |
| 16:29:48 | melwitt | jichen: we're tracking them on the priorities etherpad at L95. I've added your patches there https://etherpad.openstack.org/p/rocky-nova-priorities-tracking | |
| 16:30:49 | Spaz-Home | Just figured i'd talk it out with people as I assume the nova development IRC room was for that.. | |
| 16:30:51 | Spaz-Home | But if not forgive me. | |
| 16:31:25 | mriedem | this room is only for kitten jokes | |
| 16:31:31 | dansmith | Spaz-Home: okay I'm just trying to make sure you comment on there if you have opinions one way or the other | |
| 16:32:04 | Spaz-Home | Right now I don't, just thinking about it.. but the more I think it's the same behavior it exhibits now just in a different way, and I cannot oppose that on concept alone | |
| 16:32:11 | mriedem | Spaz-Home: in other words, xenapi users / operators are actually pretty far and few between, so people that actually know how it works and can provide feedback on the review is very helpful | |
| 16:32:18 | Spaz-Home | I think maybe a follow-up commit to bring -block-migration into parity is a better method. | |
| 16:32:20 | mriedem | Spaz-Home: b/c i have no authority on xenapi virt driver knowledge | |
| 16:32:58 | Spaz-Home | And the cells thing is more my jenky environment running that i'm looking to preserve, so I will drop that argument for it :D | |
| 16:33:05 | jaypipes | sean-k-mooney: "deleting all the functional tests is not a solution to getting them running". <-- classic. | |
| 16:33:34 | melwitt | edmondsw: I think that should be sufficient. I'm going to be sending periodic reminders to the dev ML and mention in nova meetings to help people remember to look at the priorities etherpad | |
| 16:34:12 | Spaz-Home | I'll talk with the citrix folks on it tonight though and comment on it a bit later after some rest. | |
| 16:34:39 | dansmith | Spaz-Home: can you make sure someone shows up to the nova meeting to make sure the bp gets approved? | |
| 16:34:45 | dansmith | I'll add it to the agenda now before I forget | |
| 16:35:10 | Spaz-Home | Yeah i'll ping them all tonight to remind them. | |
| 16:35:19 | Spaz-Home | I work their hours so we see each other more than you guys do I Think | |
| 16:40:36 | Spaz-Home | melwitt, if you got my message while you were on vacation, I finished that script to pull metrics. If the numbers are something you're interested in let me know and i'll send them your way. | |
| 16:40:58 | Spaz-Home | Need to pull them for the previous 10 releases or so tonight, Will send you over a CSV. | |
| 16:42:33 | melwitt | Spaz-Home: not yet, sorry. I haven't yet gone through all the pings yet | |
| 16:44:23 | Spaz-Home | No worries at all, just figured i'd send a follow up for ya :) | |
| 16:44:33 | Spaz-Home | Absolutely bottom priority | |