| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-07 | |||
| 12:44:16 | lyarwood | ibmko: even that case has zero test coverage upstream | |
| 12:45:10 | lyarwood | ibmko: can't you hold off rebooting the compute nodes until the end of the upgrade assuming you're picking up new kernels, OVS, QEMU etc during the upgrade? | |
| 12:45:53 | ibmko | lyarwood, chmm good point - let me think about it | |
| 12:49:28 | ibmko | ibmko, chmm and when we do this, and then we upgrade QEMU and libvirt, now the question comes down to live migration compatibility among different versions of libvirt/qemu/kernel | |
| 12:50:43 | lyarwood | ibmko: that's fine, libvirt and QEMU support forward migrations from old to new. | |
| 12:53:52 | sticker | fwiw, live migrating an instance from an oldish version of QEMU to new had a bug that caused havoc for windows guests | |
| 12:54:21 | sticker | i think it was anything pre 1.5 to post 1.5 would fail due to a balloon driver bug | |
| 12:57:39 | gibi | jaypipes: done. I added it as point 16 in Agreements and decisions | |
| 12:58:13 | ibmko | lyarwood, thank you, I think we will try and go this direction | |
| 13:00:57 | jaypipes | gibi: ty sir | |
| 13:01:50 | mordred | anybody know - in https://developer.openstack.org/api-ref/compute/#id302 <-- hypervisor_hostname_pattern says "The hypervisor host name or a portion of it. The hypervisor hosts are selected with the host name matching this pattern." | |
| 13:02:04 | mordred | what kind of pattern is it? is it a regex? a glob? | |
| 13:12:56 | ameeda | hello. can you please check this patch for me https://review.openstack.org/#/c/526900/ | |
| 13:12:58 | ameeda | thanks | |
| 13:15:02 | edleafe | mordred: here's where it is used: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L677-L682 | |
| 13:15:14 | edleafe | mordred: so it's sorta-globbish | |
| 13:15:59 | mordred | edleafe: wow. so it's a passthrough to an SQL like syntax but wrapped in sql % wildcards? | |
| 13:17:38 | mordred | edleafe: meaning hypervisor_hostname_pattern of 'foo' would essentially be equiv to fnmatch.fnmatch('*foo*') - matching the string foo anywhere in the hostnames | |
| 13:17:42 | edleafe | mordred: yeah, pretty much | |
| 13:18:58 | mordred | edleafe: okie. that could stand a doc update - I never would have imagined that's what the input should look like from the words "matching this pattern" | |
| 13:19:33 | mordred | I totally would have tried '*foo*' and '.*foo.*' and been confused why I wasn't getting any results | |
| 13:19:42 | edleafe | mordred: it does seem to suggest regex | |
| 13:20:11 | mordred | yah. really it's not looking for a pattern at all -it's looking for a string that will be matched anywhere in the hostname | |
| 13:42:57 | openstackgerrit | Merged openstack/nova master: Return 400 when compute host is not found https://review.openstack.org/447355 | |
| 13:59:40 | Spazmotic | Morning folks. Let's see if I can fix up these unit tests before the end of my night and maybe finally put this thing to bed :D | |
| 14:07:51 | Spazmotic | I am honestly pretty grateful for this though.. it's giving me good, needed experience in Tox | |
| 14:07:55 | Spazmotic | well unittest | |
| 14:29:46 | openstackgerrit | Brooks Kaminski proposed openstack/nova master: XenAPI: XCP2.1+ Swallow VDI_NOT_IN_MAP Exception https://review.openstack.org/538415 | |
| 14:30:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | |
| 14:30:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/550488 | |
| 14:30:23 | Spazmotic | ^ jianghuaw_: "IF" you can find some time. Don't stress it though. | |
| 14:30:46 | Spazmotic | Also, thanks for the ideas.. I think the way I compare the result now is better using two variables. | |
| 14:31:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 14:31:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | |
| 14:38:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.openstack.org/512552 | |
| 14:38:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env https://review.openstack.org/512553 | |
| 14:38:33 | openstack | bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 14:38:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor https://review.openstack.org/512623 | |
| 14:44:38 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Save admin password to sysmeta in libvirt driver https://review.openstack.org/550489 | |
| 14:46:27 | mriedem | lyarwood: bauzas: we need to do a queens 17.0.1 release for a few fixes, can you review https://review.openstack.org/#/c/550259/ and https://review.openstack.org/#/c/550221/ (there is one below this too) | |
| 14:46:35 | bauzas | ack | |
| 14:47:46 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: cover migration cases with functional tests https://review.openstack.org/493865 | |
| 14:50:40 | bauzas | mriedem: booom | |
| 14:51:37 | mriedem | thanks | |
| 14:55:56 | openstackgerrit | Merged openstack/nova master: Add a nova-caching-scheduler job to the experimental queue https://review.openstack.org/539260 | |
| 14:56:48 | stephenfin | kashyap: Don't know if you got your answer, but theoretically Python 3 support is complete | |
| 14:56:54 | dansmith | jaypipes: fwiw, table.truncate() doesn't seem to work, at least in our functional tests | |
| 14:56:56 | openstackgerrit | Dan Smith proposed openstack/nova master: Run post-test archive against cell1 https://review.openstack.org/550194 | |
| 14:56:56 | openstackgerrit | Dan Smith proposed openstack/nova master: Add simple db purge command https://review.openstack.org/550171 | |
| 14:56:56 | openstackgerrit | Dan Smith proposed openstack/nova master: Add --purge helper flag to archive_deleted_rows https://review.openstack.org/550182 | |
| 14:57:13 | mriedem | stephenfin: ceph doesn't work on py3 if you're taking notes | |
| 14:57:20 | mriedem | well, librados doesn't | |
| 14:57:24 | kashyap | stephenfin: I see; "theoretically complete" means, in practise it is not? :D | |
| 14:57:37 | stephenfin | kashyap: All unit and functional tests are passing with Python 3. However, I doubt anyone is running a Python 3 deployment | |
| 14:57:38 | mriedem | kashyap: nova works on py3 | |
| 14:57:39 | kashyap | mriedem: How about eventlet? | |
| 14:57:41 | stephenfin | mriedem: It does now? | |
| 14:57:50 | stephenfin | I submitted patches saying as much a few months back | |
| 14:57:53 | mriedem | the dependent libraries, based on your configuration, might not work on py3 | |
| 14:58:12 | mriedem | last i checked the py3 ceph job wasn't working, melwitt was investigating that | |
| 14:58:14 | kashyap | mriedem: I see, is there a test job with PY3? | |
| 14:58:21 | stephenfin | mriedem: See commit 1e70cb8d4dace3c3372cd6e1bb13060becf25c6a | |
| 14:58:21 | mriedem | yes | |
| 14:58:46 | stephenfin | It does require ceph v11.1.0 though | |
| 14:58:56 | stephenfin | ...based on my notes from that | |
| 14:58:57 | mriedem | stephenfin: might be that we don't have a new enough version of ceph in the UCA | |
| 14:59:14 | mriedem | https://bugs.launchpad.net/glance-store/+bug/1706405 | |
| 14:59:15 | openstack | Launchpad bug 1706405 in glance_store "ceph jobs failing to upload images in pike due to "AttributeError: 'NoneType' object has no attribute 'Rados'" on py35" [Undecided,Confirmed] | |
| 14:59:15 | stephenfin | Without knowing anymore about it, That's probably it, aye | |
| 15:01:18 | mriedem | legacy-tempest-dsvm-py35-full-devstack-plugin-ceph is the job to look for | |
| 15:02:30 | jaypipes | dansmith: needs to be manually execute()d... :( | |
| 15:02:37 | dansmith | ah | |
| 15:02:47 | mriedem | http://logs.openstack.org/80/549880/1/experimental/legacy-tempest-dsvm-py35-full-devstack-plugin-ceph/7923b02/job-output.txt.gz#_2018-03-05_23_04_06_724259 | |
| 15:02:48 | jaypipes | but like I said, femto-optiomization | |
| 15:02:56 | mriedem | looks like the ceph job is busted on the tempest regex change | |
| 15:03:02 | mriedem | mtreinish: ^ is there a template for how to fix that? | |
| 15:03:08 | mriedem | tempest run: error: argument --regex/-r: expected one argument | |
| 15:03:10 | dansmith | jaypipes: yeah, but seems worth it.. i | |
| 15:03:16 | dansmith | jaypipes: I'll tack it on the end | |
| 15:05:40 | mtreinish | mriedem: hmm, that looks like a job not setting a regex and it was expecting one | |
| 15:06:04 | mtreinish | mriedem: I have no idea how/where any of the job definitions are setup now, maybe andreaf can help | |
| 15:06:05 | mriedem | mtreinish: so likely this http://logs.openstack.org/80/549880/1/experimental/legacy-tempest-dsvm-py35-full-devstack-plugin-ceph/7923b02/job-output.txt.gz#_2018-03-05_22_47_04_710732 | |
| 15:06:13 | mriedem | mtreinish: it's in openstack-zuul-jobs | |
| 15:06:37 | mriedem | https://github.com/openstack-infra/openstack-zuul-jobs/blob/master/playbooks/legacy/tempest-dsvm-py35-full-devstack-plugin-ceph/run.yaml#L61 | |
| 15:06:43 | mriedem | ^ doesn't exist in nova, | |
| 15:06:47 | mriedem | i think jbernard was working on adding it | |
| 15:07:05 | mtreinish | that probably is the cause then | |
| 15:07:25 | mtreinish | especially if that's being expected to set the regex things run with | |
| 15:07:26 | andreaf | mriedem I defined a new style job for ceph some time ago but the patch has been waiting for reviews for long time https://review.openstack.org/#/c/543048/ | |
| 15:07:29 | mriedem | heh https://review.openstack.org/#/c/459774/ | |
| 15:07:47 | mriedem | andreaf: is that py3? | |
| 15:07:55 | mriedem | andreaf: i can't read the new zuulv3 voodoo | |
| 15:07:56 | andreaf | mriedem both I think | |
| 15:08:08 | andreaf | yeah both | |
| 15:09:07 | andreaf | mriedem it defines the job and also a job template that runs py27 on check and py3 on experimental | |
| 15:09:27 | andreaf | the project stanzas are pretty much the same as before | |
| 15:10:11 | andreaf | mriedem mtreinish anyways my point was rather than fixing the legacy job perhaps we should run the new style one | |
| 15:11:19 | jaypipes | dansmith: coolio. | |
| 15:11:42 | mriedem | andreaf: yeah maybe - you should have the same regex in the py3 job in there | |
| 15:11:52 | mriedem | andreaf: given https://review.openstack.org/#/c/459774/4/tempest-conf.sh | |