| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-22 | |||
| 18:09:46 | mriedem | mdbooth: i don't really agree, | |
| 18:09:57 | mriedem | for a volume-backed instance, the disk is what matters (or doesn't) | |
| 18:10:31 | mriedem | if i have a 20gb flavor instance and snapshot it to get a 20gb image, then the image should say that you need a flavor of a minimum of 20gb to boot an instance with that image, right? | |
| 18:10:52 | mriedem | but that's not true with a volume, since the flavor.root_gb isn't used for the volume | |
| 18:14:08 | dansmith | mriedem: min_disk should be the size of the volume in that case when you snapshot I think | |
| 18:14:15 | dansmith | flavor.root_gb if ephemeral | |
| 18:14:30 | mriedem | dansmith: that's what i originally asked in the patch | |
| 18:14:36 | mriedem | rather than pop off min_disk, | |
| 18:14:40 | mriedem | why not just set it to root_bdm.size | |
| 18:15:21 | mriedem | good point though | |
| 18:15:37 | dansmith | I haven't been following the discussion or the patch really, but .. yeah | |
| 18:16:47 | mdbooth | dansmith: That's size | |
| 18:16:47 | mdbooth | size != min_disk | |
| 18:17:03 | mdbooth | Size can be expanded, min_disk is what it is | |
| 18:17:18 | mriedem | another good point, i was combining those image attrs in my head | |
| 18:18:40 | cfriesen | do I need to do something special for "nova get-serial-console" to support the socat console used by ironic? | |
| 18:19:13 | mriedem | check the ironic docs | |
| 18:19:28 | mriedem | https://docs.openstack.org/ironic/pike/admin/console.html | |
| 18:19:36 | mriedem | cfriesen: man that google search was hard... | |
| 18:22:03 | cfriesen | the "ironic node-get-console" command is working and gives a URL, but "nova get-serial-console" returns an error. | |
| 18:32:51 | melwitt | I'm off to the airport o/ seeya at the PTG | |
| 18:36:24 | mriedem | lyarwood: if you're around still, i'm going to be going through this pike backport series which is pretty important, starting at https://review.openstack.org/#/c/546218/ | |
| 18:47:20 | mriedem | mnaser: wondering about some missing compute api unit tests in this pike backport https://review.openstack.org/#/c/546221/4 | |
| 18:48:47 | efried | jaypipes: Do you want me to remove "in the Traits database" everywhere or just that one spot? | |
| 18:48:54 | efried | jaypipes: E.g. in the reno | |
| 18:49:25 | jaypipes | efried: everywhere. that's just implementation detail that isn't relevant. | |
| 18:49:27 | mriedem | heh, i can see ops freaking out now | |
| 18:49:34 | efried | ight | |
| 18:49:34 | mriedem | "nova added *another* database?!" | |
| 18:49:38 | jaypipes | right. | |
| 18:50:29 | mnaser | mriedem: thank you for reviewing the patches meticulously. i made sure to leave the conflicts because i don't trust my git conflict resolution stuff :< | |
| 18:50:35 | mnaser | ill update it now | |
| 18:51:51 | openstackgerrit | Eric Fried proposed openstack/nova master: rp: GET /resource_providers?required= |
|
| 18:51:52 | openstackgerrit | Eric Fried proposed openstack/nova master: Make _get_sharing_providers more efficient https://review.openstack.org/547008 | |
| 18:51:52 | efried | edleafe, jaypipes: All done ^ | |
| 18:54:37 | edleafe | efried: thx | |
| 18:54:49 | efried | My pleasure. | |
| 18:54:58 | efried | Except for the part where I had to delete that sqla block | |
| 18:55:02 | efried | That was pain | |
| 18:55:04 | efried | pure pain | |
| 18:57:11 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546221 | |
| 18:57:11 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional test for deleting BFV server with old attach flow https://review.openstack.org/546812 | |
| 18:57:12 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Ensure attachment_id always exists for block device mapping https://review.openstack.org/546275 | |
| 18:57:49 | mnaser | mriedem: fixed + rebased stuff on top | |
| 18:58:39 | mriedem | mnaser: i see you've mastered git review -R :) | |
| 18:58:55 | mnaser | mriedem: yes, got to keep my +2 with a rebase :p | |
| 18:59:46 | mnaser | cherry picking skills still need a bit more work though | |
| 19:00:45 | mriedem | mnaser: +2s up and down | |
| 19:01:07 | mnaser | mriedem: nice, bauzas mentioned he would have a look at backports when he's back on thursday :P | |
| 19:01:08 | mriedem | bauzas: if you're still around https://review.openstack.org/#/q/topic:bug/1750666+branch:stable/pike | |
| 19:01:16 | mnaser | 2 seconds apart, ha | |
| 19:02:23 | jaypipes | efried: +2 from me on both. nice work. | |
| 19:02:29 | efried | Thanks jaypipes | |
| 19:03:04 | jaypipes | lol | |
| 19:03:25 | jaypipes | efried: dansmith is somewhere over the Atlantic I think. | |
| 19:04:00 | jaypipes | hehe | |
| 19:04:26 | gryf | don't be afraid. just increase the frequency of the shots ;) | |
| 19:49:21 | mriedem | cfriesen: we don't support live migration with sriov ports attached right? | |
| 19:52:27 | mriedem | i guess i'm thinking about https://review.openstack.org/#/c/286744/ | |
| 19:57:37 | mriedem | jay-afk-2: this should be a simple spec re-approval https://review.openstack.org/#/c/543578/ | |
| 20:24:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | |
| 20:24:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add code to bind a port against a dest host during live migration https://review.openstack.org/523604 | |
| 20:34:45 | dansmith | mriedem: looking at the glance docs, I'm not sure I understand what you and mdbooth said earlier while I was landing.. min_disk should be the minimum size disk you can boot it on, which would be defined by the filesystem in the image | |
| 20:35:38 | mriedem | he left a comment in that patch if that helps | |
| 20:37:22 | dansmith | mriedem: the glance docs say --size is deprecated | |
| 20:37:32 | dansmith | https://docs.openstack.org/python-openstackclient/pike/cli/command-objects/image.html | |
| 20:37:39 | dansmith | "Image version 1 only." | |
| 20:38:17 | mriedem | ah | |
| 20:38:20 | mriedem | didn't realize that | |
| 20:38:32 | dansmith | what I don't understand from what he said, is that if you boot something that was min_disk=10 and even size=10, | |
| 20:38:41 | dansmith | then you inflate that into a 20gb flavor and snapshot it, | |
| 20:38:48 | dansmith | your min_disk is 20g now | |
| 20:38:56 | dansmith | unless there's some other meaning for that that I don't understand | |
| 20:38:58 | mriedem | wtf the glance v2 API says that size is in the response, and not deprecated https://developer.openstack.org/api-ref/image/v2/index.html#show-image-details | |
| 20:39:36 | dansmith | see, that says the size is the "size of the image data" | |
| 20:39:42 | dansmith | which may be smaller than the size of the disk you expect to have | |
| 20:39:47 | dansmith | if you have something like qcow2 | |
| 20:40:36 | mriedem | ok i'm asking rosmaita if size is a thing in v2 | |
| 20:40:37 | mriedem | or what | |
| 20:40:40 | dansmith | I mean, it's not overly verbose about it I guess, but.. | |
| 20:47:21 | openstackgerrit | Merged openstack/nova master: Extending delete_cell --force to delete instance_mappings https://review.openstack.org/540073 | |
| 20:47:43 | openstackgerrit | Merged openstack/nova master: Functional test: evacuate with no compute https://review.openstack.org/498482 | |
| 20:58:26 | openstackgerrit | Merged openstack/nova master: Clarify `resources` query param for /r_p and /a_c https://review.openstack.org/547065 | |
| 21:01:45 | dansmith | efried: what did you want to have a shootout over? | |
| 21:02:25 | efried | dansmith: Not a shootout. I was hearkening back to the chaps conversation. I was just looking for a review on placement API feature: https://review.openstack.org/#/c/546837/ | |
| 21:02:54 | dansmith | efried: jebus, don't you think you have had your fair share of core time today? | |
| 21:03:24 | efried | dansmith: Since you *just* approved the spec earlier, I figured you would want to get the code reviewed before it all falls out of your old, old brain. | |
| 21:03:39 | dansmith | efried: oh, I see, so you're really doing me a favor, I see | |
| 21:03:54 | efried | dansmith: Exactly. | |
| 21:04:02 | efried | You're welcome. | |
| 21:04:03 | dansmith | so really I should be thanking you | |
| 21:04:09 | efried | :) | |
| 21:05:21 | cfriesen | mriedem: correct, no live migration with sriov ports attached. | |
| 21:06:05 | cfriesen | are we wanting to go anywhere with cold migration support for LVM? | |
| 21:11:37 | mriedem | efried: i think you should have alex_xu review that | |
| 21:11:45 | mriedem | given he wrote the traits support in the allocation candidates API | |
| 21:11:51 | mriedem | he should be back to the work grind now | |
| 21:12:16 | efried | mriedem: Sure, sounds good. | |
| 21:12:17 | mriedem | cfriesen: doesn't matter to me | |
| 21:13:25 | dansmith | mriedem: looks fairly straightforward to me | |