| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-20 | |||
| 21:31:28 | mnaser | dansmith: yes, dont want to touch the changes below, but want to build on top of them | |
| 21:31:42 | dansmith | then yes, but I would use -R if you really want to avoid disturbing the one below | |
| 21:31:45 | zigo | The same passes in Py 2.7. | |
| 21:31:48 | mnaser | ok i'll do that, thank you dansmith | |
| 21:32:15 | dansmith | np | |
| 21:32:33 | zigo | It probably is an issue in blockdiag itself though... | |
| 21:34:45 | zigo | Everything else (ie: all Nova unit tests) pass in Py 3.6. | |
| 21:35:00 | zigo | Should I file a bug? | |
| 21:36:48 | melwitt | zigo: yeah, filing a bug would help. are you trying to run the tox 'docs' target or? | |
| 21:37:15 | zigo | melwitt: No, I'm building the Nova Debian package for Queens. | |
| 21:37:33 | zigo | No tox when doing packaging. | |
| 21:37:42 | melwitt | actually I see the 'docs' target is pinned to python 2.7, probably because of the bug you're hitting | |
| 21:37:55 | zigo | melwitt: PYTHONPATH=. python3 -m sphinx -b html doc/source $(CURDIR)/debian/nova-doc/usr/share/doc/nova-doc/html | |
| 21:37:58 | zigo | That's what I run. | |
| 21:38:22 | zigo | melwitt: Well, I do need the docs to also pass in Py3, since I'll be removing all traces of Py 2.7 in the Debian packages. | |
| 21:39:12 | zigo | Worst case, I'll remove the block dragram from the doc that is crashing sphinx. | |
| 21:39:33 | zigo | I'd of course prefer not to do that. | |
| 21:39:36 | melwitt | yeah ... based on the "basepython = python2.7" for docs in tox.ini, it's known not to build under py3 but I don't know why. I'd want to get stephenfin to look at it but he's out on PTO this week | |
| 21:42:00 | zigo | melwitt: No worries! :) | |
| 21:42:37 | zigo | https://bugs.launchpad.net/nova/+bug/1750672 | |
| 21:42:37 | openstack | Launchpad bug 1750672 in OpenStack Compute (nova) "failure to generate Nova's doc in Python 3.6" [Undecided,New] | |
| 21:47:28 | melwitt | thanks | |
| 21:51:27 | mriedem | cfriesen: don't know, it might assume you have to specify that, but you could open a bug and say if microversion >= x, don't require some option | |
| 21:51:49 | mriedem | cfriesen: melwitt: so there will definitely need to be some currency stuff like that in osc, like this https://review.openstack.org/#/c/546176/ | |
| 21:51:53 | mriedem | but it's pretty simple for most of it | |
| 21:52:04 | mriedem | oops wrong patch | |
| 21:52:15 | mriedem | https://review.openstack.org/#/c/545946/ | |
| 21:52:21 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Add functional test for deleting BFV server with old attach flow https://review.openstack.org/546315 | |
| 21:54:02 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Add functional test for deleting BFV server with old attach flow https://review.openstack.org/546315 | |
| 21:54:14 | mnaser | aaand thats a step 1 | |
| 21:54:26 | melwitt | mriedem: okay, that's cool. what about the auto-discover-latest behavior of the CLI? from what I understand, that's not something they wanted to allow in osc | |
| 21:56:40 | mriedem | melwitt: that doesn't exist in osc | |
| 21:56:44 | mriedem | or most CLIs besides nova's | |
| 21:56:48 | mriedem | i.e. cinder CLI doesn't do that either | |
| 21:57:27 | melwitt | I know | |
| 21:57:55 | melwitt | but I thought we would want to keep that, I've never understood how it's useful for a CLI to default to the lowest microversion | |
| 21:59:16 | melwitt | and I thought we discussed it in a forum session about osc last time, but I don't remember if we got any consensus or next steps about it | |
| 21:59:29 | zigo | melwitt: Here's the line that crashes everything: https://salsa.debian.org/openstack-team/services/nova/blob/debian/queens/debian/patches/remove-crashing-blockdiag-doc-line.patch | |
| 22:00:39 | melwitt | zigo: huh. interesting | |
| 22:00:51 | cfriesen | melwitt: yeah, I remember some discussion too. I pinged the OSC folks about microversion stuff but they basically said they had a plan and didn't seem to want any help with it. | |
| 22:01:20 | mriedem | melwitt: it was discussed in the user session in boston | |
| 22:01:35 | mriedem | and i think the consensus was "we should be consistent" but no decisive answer on which consistency is best | |
| 22:03:03 | mriedem | i can't remember which specific session now https://wiki.openstack.org/wiki/Forum/Boston2017 | |
| 22:03:06 | melwitt | okay. agreed on consistency. we'll need to re-sync with the osc team on that if we're going to get serious about deprecating the nova CLI | |
| 22:03:43 | jroll | melwitt: fwiw, the only explanation for defaulting CLIs to the lowest microversion that I've heard is so that new versions don't break bash scripts | |
| 22:03:50 | jroll | as if it's a bash sdk >.> | |
| 22:03:58 | mriedem | and we've asserted the CLI isn't an SDK | |
| 22:04:08 | mriedem | but the python API binding code is, so that's why that's opt-in | |
| 22:04:15 | melwitt | right | |
| 22:04:23 | jroll | for some definition of "we" :) | |
| 22:04:32 | mriedem | we == nova in this case | |
| 22:04:33 | melwitt | I don't think a bash sdk is a good idea for anyone | |
| 22:04:33 | mriedem | for our CLI | |
| 22:04:38 | jroll | right | |
| 22:04:46 | cfriesen | jroll: if you want that you can explicitly specify the API version in your bash script | |
| 22:05:08 | jroll | cfriesen: no I don't want that at all, just providing the anecdata that I have :)( | |
| 22:05:19 | cfriesen | "you" generally, not specifically | |
| 22:05:22 | cfriesen | :) | |
| 22:05:22 | jroll | right | |
| 22:06:15 | mriedem | well i can't find the etherpad, but i remember the discussion | |
| 22:06:20 | mriedem | i'm pretty sure it was boston | |
| 22:06:25 | mriedem | clarkb or mordred might remember | |
| 22:08:28 | melwitt | I had thought it got talked about more recently too, but maybe I'm thinking of boston and not realizing it | |
| 22:09:07 | mriedem | mordred: do you remember talking about standardizing CLIs at the forum in boston? | |
| 22:09:12 | mordred | dtantsur|afk has been working on a spec/document on the topic - I expect us to all sit down and alk about it some time next week | |
| 22:09:13 | mriedem | like the auto-discover microversion behavior | |
| 22:09:14 | mriedem | ? | |
| 22:10:24 | mordred | sorry - dtantsur has been working on aspec about sdks/libraries and microversions - not on cli things | |
| 22:11:30 | mordred | but I'd very much like for us to come to a shared understanding and consensus - and to make sure that whatever needs to be done to deprecate the nova cli is done - and will happily sign up to help work on that goal | |
| 22:13:16 | openstackgerrit | Hongbin Lu proposed openstack/nova master: [WIP] Skip placement on rebuild in same host https://review.openstack.org/546357 | |
| 22:17:55 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Add functional test for deleting BFV server with old attach flow https://review.openstack.org/546315 | |
| 22:17:55 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Check if attachment_id exists before deleting it https://review.openstack.org/546398 | |
| 22:18:25 | mnaser | mriedem: ^ that should fix it | |
| 22:18:41 | mnaser | (functional and unit tests passed locally, but didn't run the whole suite) | |
| 22:24:56 | mriedem | ok | |
| 22:31:45 | openstackgerrit | Matthew Edmonds proposed openstack/nova-specs master: PowerVM Virt Integration (Rocky) https://review.openstack.org/545111 | |
| 22:44:10 | openstackgerrit | Dan Smith proposed openstack/nova master: Avoid exploding if guest refuses to detach a volume https://review.openstack.org/546423 | |
| 22:54:48 | melwitt | dansmith: your review would be appreciated on the bug we looked at last week about saving the admin password in sysmeta for the libvirt driver https://review.openstack.org/#/c/543032 | |
| 22:55:02 | melwitt | I tested the patch with devstack and found it works | |
| 22:59:35 | melwitt | we don't have tempest coverage enabled of 'change password' in the gate because of the qemu guest agent requirement. I have a tempest patch up to add coverage for anyone who *can* run with [compute-feature-enabled]change_password = True but I haven't double-checked that it works in my devstack env yet https://review.openstack.org/#/c/543029/ | |
| 23:42:57 | mriedem | smcginnis: are you able to get this? https://drive.google.com/open?id=1jGiBLcaefpcAz66Camlcffeb4H9EkLtE | |
| 23:44:15 | mriedem | melwitt: dansmith: ^ ? audio is a bit quiet but otherwise it seems fine | |
| 23:46:32 | melwitt | what is that? | |
| 23:46:36 | mriedem | demo | |
| 23:46:41 | melwitt | ah, cool | |
| 23:48:13 | melwitt | yeah, I can see it. agree the audio is pretty quiet | |
| #openstack-nova - 2018-02-21 | |||
| 00:01:23 | smcginnis | Only let's me download. Doing that now. | |
| 00:01:27 | mriedem | https://www.youtube.com/watch?v=ykGe7GiF9yk | |
| 00:01:30 | mriedem | try that instead | |
| 00:03:57 | melwitt | it worked for me after I downloaded it | |
| 00:04:03 | melwitt | youtube gives me this error "This video is unavailable." | |
| 00:04:22 | mriedem | maybe b/c it's private? let me log out and try | |
| 00:04:39 | melwitt | yeah, I tried it in a non-logged-in window | |
| 00:04:47 | mriedem | ah yeah, sec | |
| 00:06:00 | melwitt | yep working now on youtube | |
| 00:06:12 | melwitt | *two thumbs up* | |
| 00:06:16 | mriedem | yeah i just made it public | |
| 00:06:55 | mriedem | audio chops a bit in places but it was kind of a pain in the ass so don't really care to re-record | |
| 00:11:52 | mriedem | eh it's pretty annoying | |
| 00:25:43 | tetsuro | jaypipes, cfriesen: I have updated the spec. Could you have a look on https://review.openstack.org/#/c/543805/, again ? | |