Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-20
15:42:47 mriedem but it's been broken since october
15:43:18 dansmith mriedem: I was taught not to punch people
15:43:26 mriedem wet willy some red hat infra people
15:43:29 dansmith mriedem: unless they were wrong or said something I didn't like
15:43:31 dansmith hah, eww
15:47:42 hrw https://marcin.juszkiewicz.com.pl/2018/02/19/hotplug-in-vm-easy-to-say/ - a story about https://review.openstack.org/#/c/545034/ patch (which waits for reviewers)
15:50:32 bauzas mriedem: okay, so I did set Wontfix for https://bugs.launchpad.net/nova/+bug/1740025 given my last comment
15:50:32 openstack Launchpad bug 1740025 in OpenStack Compute (nova) "LVM Sparse Volumes broken" [Undecided,Won't fix]
15:54:03 mriedem bauzas: if the fix is to deprecate the sparse_logical_volumes option, then it shouldn't really be 'wont fix'
15:54:15 mriedem unless you're just gonna related-bug that thing
15:55:01 bauzas mriedem: I'll deprecate the conf opt by passing a related-bug, yes
15:55:27 bauzas Wontfix is exactly for like "sorry, we know it doesn't work, but we don't plan to fix it"
15:55:51 bauzas and that bug is the exact reason why we should deprecate that option
15:56:06 mriedem bauzas: did you take a look at https://review.openstack.org/#/c/545132/ ?
15:56:16 mriedem you +W'ed the regression recreate test
15:56:42 mriedem mnaser: you should be able to start backports for that series
16:01:32 bauzas mriedem: not yet, because I need to think about it
16:02:14 bauzas ie. if the call is made in the right place
16:02:20 bauzas and if we're not missing anything
16:02:29 bauzas the change itself is easy to review
16:04:06 mnaser mriedem: i'll start doing that
16:05:16 bauzas mgoddard: saw your comment on https://bugs.launchpad.net/nova/+bug/1739735 looks like it's a new feature, right?
16:05:16 openstack Launchpad bug 1739735 in OpenStack Compute (nova) "boot baremetal server which has multi-interface will randomly choose baremetal server interface" [Undecided,New]
16:08:25 cfriesen mriedem: bauzas: I haven't used the LVM sparse stuff, we do use thinly-provisioned LVM internally.
16:08:48 bauzas heh
16:09:06 bauzas I'm pretty sure that if you used it, you'd discovered problems: p
16:09:36 bauzas it's a canary in a coal mine :p
16:10:17 bauzas artom: around ?
16:10:37 bauzas artom: do you think that https://bugs.launchpad.net/nova/+bug/1739735 is solvable by http://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/virt-device-tagged-attach-detach.html ?
16:10:38 openstack Launchpad bug 1739735 in OpenStack Compute (nova) "boot baremetal server which has multi-interface will randomly choose baremetal server interface" [Undecided,New]
16:10:45 bauzas artom: ie. using the ironic driver
16:10:47 mriedem dansmith: in https://review.openstack.org/#/c/543580/ - why do you remove defaults for kwargs in some methods but not others?
16:11:43 dansmith mriedem: because those are things that were added as optional just for compatibility when adding a new param that really should be passed all the time
16:11:44 cfriesen bauzas: we have internal patches to add support for thin lvm to nova. also to enable cold-migration and resize for LVM-backed instances
16:12:20 dansmith mriedem: if it was a thing we added in 4.x and expect to always pass, but made it optional so the tests would pass without having to touch it, I made it required here and fixed up the tests
16:12:31 dansmith mriedem: or at least, that was the intent
16:12:36 bauzas cfriesen: see https://bugs.launchpad.net/nova/+bug/1740025/comments/3
16:12:37 openstack Launchpad bug 1740025 in OpenStack Compute (nova) "LVM Sparse Volumes broken" [Undecided,Won't fix]
16:12:49 bauzas cfriesen: I seriously consider deprecating that possibility
16:12:56 bauzas at least the config option
16:13:04 mriedem dansmith: hmm, well not all are like that, like rebuild_instance shouldn't require host/node
16:13:23 dansmith mriedem: which line?
16:13:37 mriedem https://review.openstack.org/#/c/543580/1/nova/compute/rpcapi.py@721
16:14:20 bauzas jroll: trying to get Ironic's eyes for https://bugs.launchpad.net/nova/+bug/1739735
16:14:21 openstack Launchpad bug 1739735 in OpenStack Compute (nova) "boot baremetal server which has multi-interface will randomly choose baremetal server interface" [Undecided,New]
16:14:23 cfriesen bauzas: I'd be fine with that. :) One main reason we added support for thin volumes was that zeroing out the volumes was incredibly disk-intensive. By using thin we only zero out the blocks as they are allocated.
16:14:25 mriedem dansmith: nvm,
16:14:35 mriedem i was thinking of the conductor / compute task rpcapi
16:14:41 bauzas cfriesen: cool
16:14:43 mriedem conductor will always pass host/node to the compute rebuild_instance
16:14:43 jroll bauzas: will look / pass along
16:14:55 bauzas jroll: mgoddard provided a comment
16:15:08 mriedem even if it's just None
16:15:11 bauzas jroll: but I'm unclear if/how that makes that bug fixable
16:15:17 dansmith mriedem: it's just super hard to reason about a lot of these calls where everything is optional, except not really
16:15:26 jroll bauzas: will look / pass along, I'm in the middle of something
16:15:39 bauzas jroll: FWIW, we also have http://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/virt-device-tagged-attach-detach.html that helps setting network devices
16:15:41 dansmith mriedem: so later when you start depending on a parameter that has been required for three years, and some random unit test fails..
16:15:45 bauzas jroll: np, take your time
16:15:56 bauzas jroll: if you could just comment that bug, that'd be awesome
16:16:11 bauzas because I'm blind for triaging it :)
16:16:13 openstackgerrit Mohammed Naser proposed openstack/nova stable/queens: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546200
16:16:13 openstackgerrit Mohammed Naser proposed openstack/nova stable/queens: Store block device mappings in cell0 https://review.openstack.org/546201
16:16:14 openstackgerrit Mohammed Naser proposed openstack/nova stable/queens: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546202
16:16:14 openstackgerrit Mohammed Naser proposed openstack/nova stable/queens: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546203
16:16:15 openstackgerrit Mohammed Naser proposed openstack/nova stable/queens: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546204
16:22:59 openstackgerrit Mohammed Naser proposed openstack/nova stable/pike: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546218
16:23:00 jroll bauzas: commented - bug is "this is not deterministic", mgoddard's comment shows the tools to make it deterministic :)
16:23:15 bauzas jroll: ta
16:23:23 bauzas yeah, I understood the problem
16:23:29 bauzas it's not deterministic
16:23:39 bauzas but that's also why we have http://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/virt-device-tagged-attach-detach.html
16:24:52 jroll bauzas: I feel like I would need to read a lot of words to understand if that helps us :)
16:25:20 openstackgerrit Mohammed Naser proposed openstack/nova stable/pike: Store block device mappings in cell0 https://review.openstack.org/546219
16:25:31 cdent mriedem: if you want to restore https://review.openstack.org/#/c/418393/ I've got something to push there
16:25:40 bauzas jroll: anyway => Wontfix
16:25:54 mriedem cdent: done
16:26:02 cdent thanks
16:26:29 openstackgerrit Chris Dent proposed openstack/nova-specs master: Provide error codes for placement API https://review.openstack.org/418393
16:26:45 openstackgerrit Mohammed Naser proposed openstack/nova stable/pike: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546220
16:30:10 openstackgerrit Mohammed Naser proposed openstack/nova stable/pike: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546221
16:31:00 openstackgerrit Mohammed Naser proposed openstack/nova stable/pike: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546222
16:31:12 mnaser well, that was fun, now onto the one which will be the most fun, ocata.
16:31:20 zigo When building nova in Sid with Python 3.6, I get this unit test error: http://paste.openstack.org/show/678793/
16:31:25 zigo Has this been reported already?
16:33:43 openstackgerrit Mohammed Naser proposed openstack/nova stable/ocata: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546223
16:35:17 cdent zigo: yes, and fixed, one sec, I'll get you some links
16:35:36 cdent zigo: https://review.openstack.org/#/c/545798/ has links to bugs etc
16:36:18 artom bauzas, hey
16:36:38 bauzas artom: no worries, we closed the bug
16:36:59 artom bauzas, aha, I see
16:37:03 artom bauzas, byez
16:38:01 bauzas mriedem, melwitt, others : I won't be around tomorrow (PTO for skiing), so see you on Thursday for those that aren't yet flighting :)
16:38:12 bauzas flying* even
16:38:23 bauzas man, my English hurts
16:38:36 bauzas \o
16:38:44 openstackgerrit Mohammed Naser proposed openstack/nova stable/ocata: Store block device mappings in cell0 https://review.openstack.org/546226
16:39:11 bauzas mnaser: I'll review your stable changes once I'm back on Thursday
16:39:43 mnaser bauzas: no worries. i'll get them all in and make sure they pass CI.. i think some might need some test changes because some function signatures are different
16:40:08 mriedem dansmith: checking my understanding here https://review.openstack.org/#/c/543580/1/nova/compute/rpcapi.py@a1265 - we have some REST API handler code for compat exceptions raised from the compute rpcapi client; but we can't remove that handling in the api in queens because we could still have queens computes sending those errors?

Earlier   Later