| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-15 | |||
| 16:53:54 | bauzas | I'm poor at wording | |
| 16:54:08 | bauzas | but I'm afraid the word "filter" carries a lot of context | |
| 16:54:27 | bauzas | so I'd prefer to use a synonym for that mechanism | |
| 16:54:33 | bauzas | I know it's sneaky | |
| 16:54:50 | bauzas | so feel free to NACK me | |
| 16:54:52 | dansmith | bauzas: it's not exposed as a filter to the user or admin at all | |
| 16:55:06 | dansmith | bauzas: so we can change it either now or later if it becomes a problem | |
| 16:55:19 | bauzas | yeah it's just wording | |
| 16:55:26 | dansmith | but, IMHO, it's not a big enough deal to rename the things I have already :) | |
| 16:55:31 | bauzas | like we have nova aggs and placement aggs | |
| 16:55:41 | bauzas | dansmith: not requiring a respin of your spec | |
| 16:55:57 | bauzas | dansmith: but maybe we should consider that in your series :) | |
| 16:56:13 | dansmith | bauzas: well feel free to take exception to it in the code if you still feel that way yeah | |
| 16:56:16 | bauzas | scheduler filters and request filters seem very identical to me in terms | |
| 16:56:51 | bauzas | again, it's maybe me overreacting on some blueprints I could see in the future | |
| 16:57:07 | dansmith | what word do you like better? | |
| 16:57:10 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Allow to configure amount of PCIe slots in aarch64 instance https://review.openstack.org/545034 | |
| 16:57:28 | hrw | cna someone take a look at that patch? mriedem stephenfin bauzas? | |
| 16:57:40 | bauzas | dansmith: from a French folk, the Thesaurus tells me "strain" | |
| 16:57:54 | dansmith | lol | |
| 16:57:55 | bauzas | but anyway, I feel ashamed of nitpicking on that | |
| 16:58:06 | dansmith | that would make no sense to an english speaker | |
| 16:58:18 | bauzas | the history of nova told me that there are 3 NP problems | |
| 16:58:26 | bauzas | distibuted locks | |
| 16:58:36 | bauzas | NFV | |
| 16:58:41 | bauzas | or BFV even | |
| 16:58:44 | bauzas | and naming things | |
| 16:59:00 | bauzas | naming a new thing requires 3 cycles at least | |
| 16:59:21 | bauzas | in order to get consensus | |
| 16:59:37 | bauzas | so, anyway, let's just pretend I never asked for that | |
| 16:59:46 | dansmith | bauzas: as the only one who has (thus far) taken exception with the name, it's funny for you to be complaining about that :) | |
| 17:00:11 | bauzas | I know, hence my apologies | |
| 17:00:22 | bauzas | let's pretend that discussion never existed | |
| 17:00:35 | bauzas | (17:57:55) bauzas: but anyway, I feel ashamed of nitpicking on that | |
| 17:02:12 | mriedem | hrw: busy atm, can you mark that WIP if it's the initial version w/o tests? | |
| 17:02:19 | hrw | mriedem: ok | |
| 17:02:56 | hrw | W-1 | |
| 17:04:27 | openstackgerrit | Merged openstack/nova master: Don't JSON encode instance_info.traits for ironic https://review.openstack.org/543574 | |
| 17:04:44 | openstackgerrit | Merged openstack/nova master: Python 3 fix for sphinx doc https://review.openstack.org/544956 | |
| 17:05:51 | mriedem | ameeda: i think you're missing a unit test in https://review.openstack.org/#/c/528385/ | |
| 17:06:18 | mriedem | otherwise i think that's mostly ok, outside of the commit message cleanup | |
| 17:06:27 | openstackgerrit | Mark Goddard proposed openstack/nova stable/queens: Don't JSON encode instance_info.traits for ironic https://review.openstack.org/545037 | |
| 17:22:14 | mriedem | stephenfin: i don't know what people want in here https://review.openstack.org/#/c/544015/ | |
| 17:22:37 | bauzas | mriedem: dansmith: edleafe: cdent: I'm about to +W https://review.openstack.org/#/c/544585/ | |
| 17:22:46 | bauzas | if anyone has concerns, that's the moment | |
| 17:22:58 | bauzas | oops, jaypipes too ^ | |
| 17:23:57 | dansmith | my only concern would be the dependent specs, if people want those landed first | |
| 17:24:01 | dansmith | but I don't mind either way really | |
| 17:24:55 | stephenfin | mriedem: I think you identified what he was looking for, which was different to what I thought. Given that the caching scheduler is deprecated (I didn't know that), we don't need to worry about IMO | |
| 17:25:42 | mriedem | bauzas: it is certainly possible to know if we're doing a first schedule or a reschedule, | |
| 17:25:48 | mriedem | RequestSpec.retry has that information | |
| 17:26:00 | bauzas | mriedem: for a reschedule yes | |
| 17:26:05 | bauzas | mriedem: for a move operation, nope | |
| 17:26:08 | edleafe | bauzas: that's cool. At least there has been some discussion since my comment | |
| 17:26:11 | mriedem | bauzas: that's because https://review.openstack.org/#/c/505771/ | |
| 17:26:49 | mriedem | well, the issue in ^ confuses the fact that you're doing a reschedule or a move | |
| 17:26:57 | bauzas | shit | |
| 17:27:26 | bauzas | how many times will I regret to not have thought more on persisted fields for the RequestSpec object ? | |
| 17:27:47 | openstackgerrit | Claudiu Belu proposed openstack/nova master: compute: Cleans up allocations after failed resize https://review.openstack.org/543971 | |
| 17:27:57 | jaypipes | bauzas: hold please. | |
| 17:27:58 | cdent | bauzas: feel free to +w the spec if there's been enough feedback | |
| 17:28:00 | jaypipes | still reviewing | |
| 17:28:01 | mriedem | i thought that would be an easy fix but then second guessed myself, and need to write a functional test to be sure | |
| 17:28:07 | cdent | bauzas: except for jay :) | |
| 17:28:26 | bauzas | jaypipes: ack | |
| 17:29:52 | efried | Could rebase it on top of the other spec | |
| 17:31:29 | dansmith | or someone could slam it in: https://review.openstack.org/#/c/544694/ | |
| 17:31:42 | dansmith | it's really simple, has a lot of +1s from stakeholders and only needs a +W | |
| 17:31:50 | mriedem | looking | |
| 17:32:04 | mriedem | i will ram this down your throat like obamacare to the republicans | |
| 17:32:18 | mriedem | lemme call nancy quick | |
| 17:32:25 | dansmith | lolol | |
| 17:33:01 | openstackgerrit | Jay Pipes proposed openstack/nova-specs master: mirror nova host aggregates to placement API https://review.openstack.org/545057 | |
| 17:34:21 | dansmith | apparently by "lots" I meant "two" but.. you know | |
| 17:34:53 | mriedem | consider it rammed | |
| 17:35:03 | mriedem | thanks obama | |
| 17:35:19 | mriedem | the two that matter | |
| 17:38:51 | jaypipes | dansmith: cern doesn't use the cachingscheduler does it? | |
| 17:39:08 | mriedem | tssurya: ^ | |
| 17:39:24 | dansmith | jaypipes: presumably not because they're working through placement issues right now | |
| 17:39:34 | jaypipes | ak | |
| 17:40:50 | openstackgerrit | Merged openstack/nova-specs master: Support member_of param for allocation candidates https://review.openstack.org/544694 | |
| 17:42:05 | tssurya | mriedem, jaypipes, dansmith : no we don't | |
| 17:42:25 | mriedem | excellente | |
| 17:47:19 | gibi | dansmith: I also left some comments / questions on https://review.openstack.org/#/c/544585 just now | |
| 17:51:39 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Extending delete_cell --force to delete instance_mappings https://review.openstack.org/540073 | |
| 17:52:54 | bauzas | gibi: dansmith: I got the name. Let's call it "scheduler transformers" and name the first one "autobot" | |
| 17:53:07 | dansmith | gibi: replying | |
| 17:53:08 | mriedem | gibi: i cleaned up the commit message on this and added a simple unit test for detach failing, see if you still like it ^ | |
| 17:53:09 | mriedem | oops | |
| 17:53:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Detach volumes when VM creation fails https://review.openstack.org/528385 | |
| 17:53:15 | mriedem | gibi: ^ | |
| 17:53:28 | bauzas | please folks, don't tell me about Shia LaBeouf or anything stupid like the movies | |
| 17:53:39 | gibi | mriedem: looking | |
| 17:53:55 | bauzas | they killed my childhood | |
| 17:58:58 | mriedem | gibi: and left a comment | |
| 17:59:09 | mriedem | deleting the volume before we reschedule is kind of dumb | |
| 17:59:24 | mriedem | let's say i boot from volume with a pre-existing volume, | |
| 17:59:32 | gibi | mriedem: oops, +Wd it | |
| 17:59:36 | mriedem | spawn on the first host fails after i've attached the instance to the volume, | |