Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-15
08:43:36 ameeda gibi: thanks for reviews. what about this https://review.openstack.org/#/c/542378/ ? I am not sure why bug reporter asked to add this file, do you guess that I have to remove it ?
08:44:59 ameeda also regarding this https://review.openstack.org/#/c/543348/, I will ask openstack-requirements channel to get suitable answer
08:47:02 gibi ameeda: by reading the bug report I think dhellmann wants to move the doc only requirements to a separate file and _then_ change tox to use that requirement file for doc generation
08:48:19 gibi ameeda: I think you missed that second part
08:48:57 ameeda gibi: let me check. brb
08:55:31 ameeda gibi: thank for the update, I guess the edit of tox.ini will be here https://review.openstack.org/#/c/543348/1/tox.ini , so the old tox.ini was running correctly since the test-requirements have all requirements.
08:55:39 ameeda gibi: it make since ?
09:01:11 gmann_ gibi: your fix looks fine just comment for newton branch - https://review.openstack.org/#/c/538908/3
09:04:18 gibi ameeda: I don't get it. This patch https://review.openstack.org/#/c/543348/1/tox.ini still does not refer to the doc/requirements.txt you created in https://review.openstack.org/#/c/542378/
09:04:34 gibi ameeda: so something is missing
09:06:16 ameeda gibi: so I have to edit this https://review.openstack.org/#/c/543348/1/tox.ini to have -r{toxinidir}/doc/requirements.txt ? so my edit must be in this review https://review.openstack.org/#/c/543348/ to avoid merge conflict ?
09:09:18 gibi ameeda: I would keep your two change separate. I would change the tox.ini in https://review.openstack.org/#/c/542378/ to use the new doc/requirements.txt
09:09:58 gibi ameeda: for the testenv:docs and the testenv:releasenotes target
09:10:39 ameeda gibi: what should I write to use it ?
09:11:18 ameeda gibi: deps = -r{toxinidir}/doc/requirements.txt, right ?
09:11:22 gibi ameeda: I guess deps = -r{toxinidir}/doc/test-requirements.txt
09:11:28 gibi ameeda: yes
09:11:40 ameeda okay, Thanks for help ^_^
09:13:26 gibi gmann_: looking
09:13:39 ameeda gibi: is this correct https://pasteboard.co/H7JnfYu.png ?
09:14:25 gibi ameeda: at least that is what I would try :)
09:15:08 ameeda gibi: so I will upload new patch now ^_^
09:15:20 openstackgerrit Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378
09:26:39 openstackgerrit Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378
09:32:05 openstackgerrit Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378
09:40:12 bauzas morning Nova
09:41:07 ameeda bauzas: morning :)
09:43:51 gibi gmann_: I removed the newton branches from https://review.openstack.org/#/c/538908/
09:44:10 stephenfin bauzas: Oh hai. I'm going to be pushing up a reworked version of https://review.openstack.org/#/c/541290/ shortly and would love your thoughts :)
09:44:20 stephenfin Let me know if you want me to return the favour anywhere
09:45:43 bauzas stephenfin: sure thing
09:45:46 kashyap bauzas: Hey, when you get a sec, a question for you on #openstack-dev (on writing a new scheduler filter)
09:45:54 bauzas kashyap: ack
09:46:07 bauzas kashyap: why #openstack-dev btw. ? :)
09:46:14 bauzas since I very rarely scroll it
09:46:15 kashyap Heh
09:46:27 kashyap bauzas: It's not me, someone else asked the question
09:46:34 bauzas hah ok
09:46:36 bauzas np
09:46:37 kashyap I noticed the question and prompted you :-)
09:46:43 kashyap I _think_ he's left the channel :-(
09:47:00 kashyap I recognize the name of the developer from Kubernetes community
09:47:41 cdent stephenfin: it's funny how that works isn't it? so much stuff can stay under the radar, no matter how long you're around.
09:48:25 stephenfin cdent: For sure. You never stop learning new stuff
09:48:34 stephenfin Though I suppose if you did, it would probably be time to move on
09:49:07 cdent true
10:00:44 openstackgerrit Bence Romsics proposed openstack/nova master: Clarify 'capacity' in placement api-ref https://review.openstack.org/544347
10:08:40 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Move resource provider objects into placement hierarchy https://review.openstack.org/540049
10:08:41 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
10:08:41 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Isolate placement database config https://review.openstack.org/541435
10:08:42 openstackgerrit Chris Dent proposed openstack/nova master: Isolate config parse_args for placement https://review.openstack.org/543495
10:13:37 bauzas does anyone know if our nova documentation includes HTML rendered docstrings of our internal interfaces ?
10:13:40 bauzas stephenfin: ^
10:14:01 bauzas I'd like to point in a document some object structures
10:14:05 stephenfin bauzas: Nope
10:14:17 bauzas okay, then I'll say look at the code
10:14:22 stephenfin That would need Sphinx's 'apidoc' tool, which we don't use enable
10:14:29 stephenfin That'd be the best call, yeah
10:23:29 openstackgerrit Sylvain Bauza proposed openstack/nova master: doc: Clarify how to create your own filter https://review.openstack.org/544836
10:23:44 bauzas stephenfin: gibi: doc nits fix in https://review.openstack.org/544836
10:24:07 bauzas related to kashyap's proxying someone for clarifications about scheduler filters
10:24:28 kashyap bauzas: Thanks; will look at the review in a few
10:24:56 stephenfin bauzas: One newline missing and I'm +2
10:29:49 bauzas stephenfin: ack, thanks
10:37:18 openstackgerrit Sylvain Bauza proposed openstack/nova master: doc: Clarify how to create your own filter https://review.openstack.org/544836
10:38:35 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Add 'numa-aware-vswitches' spec https://review.openstack.org/541290
10:38:45 stephenfin bauzas: Boom ^
10:39:18 bauzas stephenfin: okay, I'll look at your spec once I'm done with jaypipes's one about aggregate ratios
10:42:42 openstackgerrit Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378
11:02:23 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Add 'numa-aware-vswitches' spec https://review.openstack.org/541290
11:12:57 openstackgerrit Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378
11:28:37 openstackgerrit Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378
11:31:56 openstackgerrit Merged openstack/nova master: doc: Clarify how to create your own filter https://review.openstack.org/544836
12:33:54 openstackgerrit Chris Dent proposed openstack/nova-specs master: VMware: add support for live migration https://review.openstack.org/299207
13:13:42 openstackgerrit Bence Romsics proposed openstack/nova master: Clarify 'capacity' in placement api-ref https://review.openstack.org/544347
13:26:52 openstackgerrit Thomas Goirand proposed openstack/nova master: Python 3 fix for sphinx doc https://review.openstack.org/544956
13:30:57 ameeda Hello, what do you think if I take this review and complete on it ? https://review.openstack.org/#/c/525253/
13:48:32 hrw ameeda: you mean "take it, update, send for review"?
13:48:57 hrw ameeda: if you feel that change is needed but abandoned by original author then why not
13:48:59 ameeda yes
13:49:48 hrw ameeda: my way from 'wth is kolla' to 'kolla core reviewer' started from taking over one patch
13:49:51 ameeda original author doesn't do any activity from awhile "5 weeks"
13:54:42 ameeda hrw: I am not sure if that is legal to take this patch, I want approval, what if I comment on the bug to ask current assignee if he still working on the bug. also I am not sure about the rank of this bug.
13:55:24 ameeda hrw: since I have patches need for review from awhile.
13:59:30 hrw ameeda: do what you think. nova is foss and mia maintainer can be overriden imho with new ver of patch
14:00:43 hrw ameeda: sometimes during review it is easier for reviewer to send new version than comment
14:02:16 ameeda hrw: so you guess me to mark current patch as abandoned then upload new patch
14:02:20 jroll ameeda: cfriesen is the author, he is active in this channel, might as well ask him
14:02:38 hrw ameeda: no.
14:02:44 ameeda cfriesen: are you around ?
14:03:15 hrw ameeda: git review 525253 -d; edit, git commit --amend, git review
14:03:42 ameeda hrw: thanks
14:04:10 mriedem heh, mnaser check out https://review.openstack.org/#/c/525253/ being discussed; look familiar?
14:05:50 ameeda mriedem: Hello :)
14:06:21 mnaser mriedem: lol, well now that I’ve learned a whole lot, I can tell that shouldn’t work for scenarios involving new flow :p
14:07:07 mnaser I don’t think it would be a fun time to replicate all the code used in the clean up section (but maybe it could be moved out to utils somewhere and reused)
14:07:31 mnaser But imho transactionally It feels more correct that bdms for failed instances aren’t disappearing
14:07:32 mriedem mnaser: yup, that's part of my -1
14:07:59 mnaser If the detach fails there should still be some sort of reference, right now there’s nothing
14:09:24 mnaser mriedem: as much as I’d hate to rebase the series again, should we add a release note for operators that “hey, if you have a lot of failed scheduled instances, your bdm table might get bigger because they’re saved now”

Earlier   Later