| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-14 | |||
| 20:07:59 | mnaser | so it should be volume['status'] = 'in-use' if has_attachment else 'available' | |
| 20:08:07 | mnaser | volume['attach_status'] = 'attached' if has_attachment else 'detached' | |
| 20:08:09 | mriedem | jogo: can you remove your -2 on this? https://review.openstack.org/#/c/159382/1 | |
| 20:08:29 | mnaser | my little functional test so far is failing because: HTTP exception thrown: Invalid volume: volume 'f8580fcb-b22d-4e50-b69a-d3d91f8f3a6b' status must be 'available'. Currently in 'detached' | |
| 20:08:33 | mriedem | mnaser: yes | |
| 20:08:51 | mnaser | ok, ill fix that first | |
| 20:08:53 | mriedem | mnaser: same problem here https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1574 | |
| 20:09:14 | melwitt | mnaser: is that what I proposed here? https://review.openstack.org/#/c/539758/ | |
| 20:09:28 | mnaser | melwitt: exactly that | |
| 20:09:38 | mnaser | ill rebasemy work on that, thank you | |
| 20:09:42 | mriedem | lemme look, we could rebase quick | |
| 20:09:50 | melwitt | I ran into the same problem recently working on func tests | |
| 20:09:58 | mnaser | melwitt: do we want to add in-use for volume status too? | |
| 20:10:22 | mnaser | but that might be a bit more work | |
| 20:10:36 | mnaser | because im not sure what the status is when using multiattach (in-use or available?) | |
| 20:10:51 | melwitt | mnaser: we might. I didn't try to go further with changing the fixture | |
| 20:10:59 | mriedem | i just left that comment | |
| 20:11:05 | mriedem | if there are attachments, the status should be at least 'in-use' | |
| 20:11:11 | melwitt | once it's attached, it should be 'in-use' from what I understand | |
| 20:11:18 | mriedem | it might not be technically correct, but it's more correct than saying 'available' | |
| 20:11:25 | mnaser | yeah, makes sense | |
| 20:11:47 | mriedem | with the new fixture, there can be 'empty' attachments, which puts the volume status in 'attaching' status, and the volume doesn't go to in-use until the attachment is 'completed' | |
| 20:11:59 | mriedem | in the old fixture, completed means calling os-attach | |
| 20:12:18 | mriedem | but we likely don't need to worry about those details in these fixtures | |
| 20:12:31 | melwitt | mnaser: you want to add 'in-use' and 'available' to that patch while you're rebasing? | |
| 20:12:39 | mnaser | melwitt: sure, i can do that | |
| 20:12:44 | melwitt | cool, thanks | |
| 20:13:15 | mriedem | actually, the loop above deals with this already | |
| 20:13:19 | mriedem | so likely don't need a change | |
| 20:14:19 | mriedem | i don't even know why we have this block of code now | |
| 20:14:24 | mriedem | the loop above handles both of those status values | |
| 20:16:01 | openstackgerrit | Peter Hamilton proposed openstack/nova-specs master: Add support for certificate validation https://review.openstack.org/540879 | |
| 20:20:30 | openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Account for host agg allocation ratio in placement https://review.openstack.org/544683 | |
| 20:25:46 | openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: Snapshot https://review.openstack.org/543023 | |
| 20:30:53 | cfriesen | mriedem: are you aware of any work going on as far as live migration monitoring? (related to the broken progress monitor) | |
| 20:31:12 | mnaser | sorry for the questions, is there a way to turn on debug logging for functional tests? | |
| 20:32:34 | mriedem | mnaser: run with OS_DEBUG=True | |
| 20:32:40 | mnaser | mriedem: thank you | |
| 20:32:41 | mriedem | cfriesen: nope | |
| 20:40:39 | mriedem | jaypipes: thanks for starting https://review.openstack.org/#/c/544683/ - a few thoughts inline | |
| 20:41:04 | mriedem | will definitely want to talk with dansmith about the new upcall | |
| 20:49:14 | mriedem | efried: i moved https://blueprints.launchpad.net/nova/+spec/nested-resource-providers back to queens and completed it | |
| 20:49:22 | mriedem | let us never speak of it again | |
| 20:49:29 | efried | ack | |
| 20:49:58 | efried | Someone still owes a NRP-in-alloc-cands spec for Rocky. | |
| 20:50:10 | efried | I think I'm still on the hook for that. | |
| 20:50:24 | mriedem | you just smelled it | |
| 20:52:39 | mriedem | melwitt: you gonna take the nova meeting baton tomorrow afternoon? | |
| 20:53:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_get_all db api method https://review.openstack.org/544688 | |
| 20:54:10 | dansmith | good gawd this aggregate de-compat is a mess | |
| 21:03:01 | jaypipes | mriedem: yup | |
| 21:05:39 | jogo | mriedem: done | |
| 21:08:24 | openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Support member_of param for allocation candidates https://review.openstack.org/544694 | |
| 21:15:18 | mriedem | jogo: thanks, and o/ | |
| 21:17:34 | jogo | mriedem: o/ glad gerrit lets you drop a -2 even if you can't -2 new things | |
| 21:20:04 | mriedem | jogo: you can always come back | |
| 21:20:44 | jaypipes | mriedem, dansmith, efried: don't forget about this other aggregate-related spec... https://review.openstack.org/#/c/529135/ | |
| 21:21:16 | jaypipes | dansmith: https://blueprints.launchpad.net/nova/+spec/placement-mirror-host-aggregates is ready for you to link to in your spec. | |
| 21:21:18 | efried | jaypipes: I can look again; maybe my opinion has changed. | |
| 21:21:34 | jaypipes | dansmith: working on the spec for that one now. | |
| 21:21:37 | efried | (the "opinion" that I don't understand most of it) | |
| 21:21:47 | dansmith | jaypipes: thanks | |
| 21:21:55 | jaypipes | efried: np. was just pointing out all my agg-related stuffs... | |
| 21:22:16 | efried | No need to get all aggro | |
| 21:22:30 | dansmith | jaypipes: the one I really need is the bp for adding aggregates to the allocation_candidates api | |
| 21:22:43 | efried | dansmith: https://review.openstack.org/#/c/544694/1 | |
| 21:23:09 | dansmith | ah cool | |
| 21:25:08 | jaypipes | dansmith: https://blueprints.launchpad.net/nova/+spec/alloc-candidates-member-of | |
| 21:25:16 | jaypipes | dansmith: yup, pushed it up about 20 minutes ago | |
| 21:25:19 | dansmith | jaypipes: yeah, found it thanks | |
| 21:25:35 | jaypipes | np | |
| 21:26:38 | dansmith | efried: yawna look at my replies before I push up this revision with the linkages? | |
| 21:26:46 | mriedem | god i see i need to read https://review.openstack.org/#/c/544585/ again | |
| 21:27:05 | efried | dansmith: You mean on ^ ? Looking... | |
| 21:27:14 | dansmith | yeah | |
| 21:29:02 | mnaser | functional tests done (and failing), crossing fingers that putting the change on top fixes things | |
| 21:29:09 | jogo | mriedem: :) | |
| 21:29:40 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove deprecated aggregate DB compatibility https://review.openstack.org/544698 | |
| 21:31:58 | jaypipes | aggregates are just the topic du jour I guess. | |
| 21:32:08 | efried | dansmith: Can you please clarify the traits thing for me? What I suggested in L119 was yes, "bulk adding traits to large swaths of compute nodes" - but instead of getting the trait to the API call by pulling it from the flavor, you get it from the RequestSpec (or whatever) and fold it into any traits provided from the flavor. | |
| 21:32:30 | efried | dansmith: Is that what you're suggesting could be a solution for boot-from-volume in the future? | |
| 21:32:31 | dansmith | efried: clarify how a trait in a flavor doesn't help? | |
| 21:32:38 | dansmith | efried: ha | |
| 21:32:40 | dansmith | *ah | |
| 21:32:58 | dansmith | efried: you could have flavors you allow BFV from but that aren't dedicated to bfv | |
| 21:32:59 | efried | dansmith: Getting the trait from not-flavor to avoid Skittles. | |
| 21:33:47 | dansmith | efried: so if you want to make sure that BFV requests using generic flavors don't get routed to any old host, you might want to slap a trait on those requests so that you can send them to the right place | |
| 21:33:59 | mriedem | my idea was that the pre-placement filter thing dan's spec is adding, would shove a trait into the flavor embedded in the reqspec b/c that's currently how we get the traits from the user to the scheduler to placement | |
| 21:34:28 | efried | Right, so we're merging traits-from-flavor with traits-from-elsewhere | |
| 21:34:32 | dansmith | we could do that too | |
| 21:34:41 | mriedem | so if we know we're doing bfv on a multiattach volume (or a tagged bdm), this code puts a CUSTOM_COMPUTE_SUPPORTS_MULTIATTACH on the flavor within the reqspec | |
| 21:34:47 | mriedem | efried: yeah | |
| 21:35:10 | efried | mriedem: Not on the flavor - on the allocation_candidates request | |
| 21:35:12 | mriedem | we could always do something else like the pre-placement filters add RequestSpec.system_traits (like system_metadata) or something | |
| 21:35:25 | mriedem | efried: but we have to get them to the allocation candidates request somehow | |
| 21:35:26 | dansmith | efried: on the flavor in the reqspec if we want it to be honored for a resize or migration kinda thing | |
| 21:36:25 | efried | Do we make other "modifications" to flavor data between when we pull it from the flavor db and when we attach it to the instance? | |
| 21:36:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_create db api method https://review.openstack.org/544703 | |
| 21:36:51 | dansmith | efried: we suggested doing this for zero-root-disk BFV things I think | |
| 21:37:12 | dansmith | efried: we also probably need traits to be stored in the reqspec proper for when the user asked for them right/ | |