| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-07 | |||
| 20:46:16 | mriedem | \O/ | |
| 20:47:35 | openstackgerrit | Merged openstack/python-novaclient master: Fix listing of instances above API max_limit https://review.openstack.org/534222 | |
| 20:48:10 | dansmith | mriedem: that would match "v2." right? | |
| 20:48:45 | dansmith | and it would also match "myapi-123.novav2.foo.com" | |
| 20:48:48 | mriedem | farq yes it will | |
| 20:49:05 | mriedem | i'm basically copying the existing glanceclient utility http://git.openstack.org/cgit/openstack/python-glanceclient/tree/glanceclient/common/utils.py#n383 | |
| 20:49:19 | mriedem | well, | |
| 20:49:30 | mriedem | you can always use CONF.glance.api_servers (like everyone has had to forever) if you don't like it | |
| 20:49:56 | dansmith | I guess we do this a lot, but re magic replacements on the url we don't control is playing with fire | |
| 20:50:26 | mriedem | i know | |
| 20:50:28 | mriedem | how about | |
| 20:50:28 | mriedem | >>> re.sub('/v\d+\.?\d*', '/', url) | |
| 20:50:28 | mriedem | 'http://23.253.94.203/image/' | |
| 20:50:42 | mriedem | since / is a special character, | |
| 20:50:49 | mriedem | i don't know if it's legit to have myapi-123.nova/v2.foo.com | |
| 20:50:59 | dansmith | it's not | |
| 20:51:11 | mriedem | so is that a smaller fire at least? | |
| 20:51:16 | mriedem | otherwise we have to release note this bug | |
| 20:51:19 | dansmith | so I would group the dot and the decimal and require them together or not at all | |
| 20:51:38 | dansmith | (\.\d+)? | |
| 20:51:51 | dansmith | and require / at the end immediately after the last digit | |
| 20:52:06 | dansmith | so "/v2.0oohhmy/" doesn't match | |
| 20:54:35 | dansmith | naw mean? | |
| 20:54:52 | mriedem | i don't regex well | |
| 20:55:17 | mriedem | >>> re.sub('/v\d+(\.\d+)?', '', 'http://23.253.94.203/image/v2.0') | |
| 20:55:18 | mriedem | 'http://23.253.94.203/image' | |
| 20:55:18 | mriedem | ? | |
| 20:56:01 | dansmith | re.sub('/\d+(\.\d+)?/', '/', url) | |
| 20:56:44 | mriedem | that doesn't work | |
| 20:56:58 | dansmith | hrm yeah | |
| 20:57:59 | openstackgerrit | Merged openstack/nova master: XenAPI: Provide support matrix and doc for VGPU https://review.openstack.org/540808 | |
| 20:58:48 | dansmith | because no trailing slash in your example | |
| 20:59:05 | dansmith | so I guess you can't do that | |
| 20:59:10 | mriedem | yar | |
| 20:59:16 | dansmith | does pinning to $ work because you know it'll be the end? | |
| 20:59:51 | dansmith | re.sub(r'/v\d+(\.\d+)?/?$', '/', 'http://thing.novav2.0oh.v2.foo/image/v2/') | |
| 21:00:02 | dansmith | allow one trailing slash, but otherwise the v2 has to be at the end | |
| 21:00:28 | dansmith | anyway, I'm probably being too OCD about it | |
| 21:00:57 | mriedem | yeah that works too | |
| 21:01:21 | mriedem | i might just add a known issue release note to the patch as well, | |
| 21:01:36 | mriedem | saying, we make a best attempt given the glanceclient bug, but if it doesn't work for you, use CONF.glance.api_servers | |
| 21:01:44 | dansmith | yeah | |
| 21:02:36 | melwitt | cells meeting | |
| 21:07:12 | cdent | dansmith: turns out I didn't have notifications turned on | |
| 21:07:18 | dansmith | cdent: dang :) | |
| 21:07:49 | cdent | so rabbit's a pig | |
| 21:08:09 | cdent | evidently it's a pig without realy doing anything | |
| 21:10:39 | mordred | mriedem: http://paste.openstack.org/show/665249 | |
| 21:11:58 | mriedem | cdent: are you sure? the default is both - did you explicitly configure it? | |
| 21:13:05 | cdent | mriedem: I may be confused. As I understand both is the default only if you have 'notify_on_state_change' set to something and the default for that is to not be set. | |
| 21:13:35 | mriedem | cdent: notify_on_state_change is only for instance updates | |
| 21:13:41 | mriedem | we notify the shit out of you for everything else | |
| 21:13:44 | mriedem | any action taken on an instance | |
| 21:13:53 | mriedem | plus steady state | |
| 21:14:01 | mriedem | "NOTIFY HI I AM STILL WORKING!" | |
| 21:14:11 | cdent | hmmm, the docs are not helping me much here, I will try harder | |
| 21:14:44 | mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#notifications | |
| 21:15:04 | mriedem | set notification_format=unversioned | |
| 21:15:13 | mriedem | i guess we don't have anything for just disabling notifications altogether :( | |
| 21:15:18 | cdent | right | |
| 21:15:21 | cdent | thus my confusion | |
| 21:15:49 | dansmith | mriedem: really? that's.. broken | |
| 21:16:06 | dansmith | maybe rabbit will throw them away if there is no consumer, but I thought not | |
| 21:17:26 | dansmith | anyway, biab | |
| 21:17:28 | openstackgerrit | Christian Berendt proposed openstack/nova stable/ocata: live-mig: keep disk device address same https://review.openstack.org/541904 | |
| 21:17:40 | cdent | so at the moment if I want to at least limit the volume of notifications I should change both to something else? I can at least do that | |
| 21:17:53 | cdent | Being able to turn them off fully seems like it might be a useful thing | |
| 21:18:25 | mriedem | https://docs.openstack.org/oslo.messaging/latest/configuration/opts.html#oslo_messaging_notifications.driver | |
| 21:18:31 | mriedem | you could set the notification driver to 'noop' | |
| 21:18:33 | mriedem | i guess | |
| 21:18:40 | mriedem | however, | |
| 21:18:52 | mriedem | nova is still generating rpc/db load just building the payloads to send them to dev/null | |
| 21:19:07 | mriedem | cdent: for now you'd set it the format to 'unversioned' | |
| 21:19:16 | mriedem | that's as minimal as it gets right now i think | |
| 21:19:33 | cdent | roger that | |
| 21:21:51 | bauzas | is it me or commenting on LP is not working ? | |
| 21:21:58 | bauzas | I got timeouts | |
| 21:23:02 | bauzas | mmmm, Launchpad seems to be in trouble | |
| 21:24:39 | bauzas | mriedem: saw https://bugs.launchpad.net/nova/+bug/1748004 | |
| 21:24:40 | openstack | Launchpad bug 1748004 in OpenStack Compute (nova) "test_evacuate_late_server_group_policy_check randomly fails with KeyError: 'fake-node'" [Undecided,New] | |
| 21:24:40 | bauzas | ouch | |
| 21:25:35 | cdent | bauzas: me too | |
| 21:26:00 | cdent | (on launchpad in trouble) | |
| 21:26:12 | bauzas | what's depressing is that it seems you can still open bugs, but not close them :p | |
| 21:28:28 | cdent | \o/ | |
| 21:28:44 | bauzas | yay it's back | |
| 21:38:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Workaround glanceclient bug when CONF.glance.api_servers not set https://review.openstack.org/541008 | |
| 21:40:30 | melwitt | mriedem: sorry I didn't mention this earlier but we have another regression but it's been regressed since ocata https://bugs.launchpad.net/nova/+bug/1729584 | |
| 21:40:32 | openstack | Launchpad bug 1729584 in OpenStack Compute (nova) "boot from volume + configdrive broken (regression)" [High,In progress] - Assigned to Jay Pipes (jaypipes) | |
| 21:41:32 | mriedem | then le meh | |
| 21:41:40 | melwitt | heh. okay | |
| 21:43:27 | ameeda_ | hello | |
| 21:45:11 | ameeda_ | I need +2w here https://review.openstack.org/#/c/528385/ please :$ | |
| 21:49:03 | mriedem | this is a db schema migration we likely want to get in since backporting db schema migrations isn't fun https://review.openstack.org/#/c/530429/ | |
| 21:49:12 | mriedem | it's a follow up to the API change to page instance actions and filter on changes-since | |
| 21:50:28 | ameeda_ | Hello mriedem :) | |
| 21:50:31 | mriedem | also need to get the queens GA release note prelude in https://review.openstack.org/#/c/541495/ | |
| 21:50:44 | mriedem | ameeda_: i don't have time to look at that right now | |
| 21:50:55 | mriedem | ameeda_: you don't need to ping people daily for reviews on your patch | |
| 21:51:00 | mriedem | someone will get to it | |